alamb merged PR #1885:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
github-actions[bot] closed pull request #14781: Reuse alias if possible
URL: https://github.com/apache/datafusion/pull/14781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] closed pull request #14954: feat: Fix multi-lines printing
issue for datafusion-cli and add the streaming printing feature back
URL: https://github.com/apache/datafusion/pull/14954
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
dependabot[bot] commented on PR #14807:
URL: https://github.com/apache/datafusion/pull/14807#issuecomment-2972121901
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version
github-actions[bot] commented on PR #12523:
URL: https://github.com/apache/datafusion/pull/12523#issuecomment-2972121947
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #14872:
URL: https://github.com/apache/datafusion/pull/14872#issuecomment-2972121717
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] closed pull request #15202: Draft: Parse literal to
different types
URL: https://github.com/apache/datafusion/pull/15202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
github-actions[bot] closed pull request #14989: Fix logo in rust API docs
URL: https://github.com/apache/datafusion/pull/14989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] closed pull request #14807: chore(deps): bump rand_distr
from 0.4.3 to 0.5.1
URL: https://github.com/apache/datafusion/pull/14807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] closed pull request #15106: WIP: User defined sorting
URL: https://github.com/apache/datafusion/pull/15106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mmooyyii opened a new issue, #16406:
URL: https://github.com/apache/datafusion/issues/16406
### Describe the bug
1. make test csv
```
import csv
import random
import decimal
random.seed(42)
def make_big_random_decimal():
n = random.randint(1, 1 << 5
xiedeyantu commented on issue #16302:
URL: https://github.com/apache/datafusion/issues/16302#issuecomment-2971964565
> Thanks [@xiedeyantu](https://github.com/xiedeyantu) -- I'll try and review
it shortly
Thanks a lot! @alamb
--
This is an automated message from the Apache Git Ser
codecov-commenter commented on PR #1880:
URL:
https://github.com/apache/datafusion-comet/pull/1880#issuecomment-2971927127
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1880?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
comphead merged PR #1886:
URL: https://github.com/apache/datafusion-comet/pull/1886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
comphead commented on PR #1886:
URL:
https://github.com/apache/datafusion-comet/pull/1886#issuecomment-2971915136
Thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
parthchandra commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2146243533
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -307,6 +307,18 @@ object CometConf extends ShimCometConf {
.booleanConf
.cr
parthchandra merged PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
parthchandra commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2146241641
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -533,13 +533,20 @@ private StructType getSparkSchemaByFieldId(
return
mbutrovich commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2146241932
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -307,6 +307,18 @@ object CometConf extends ShimCometConf {
.booleanConf
.crea
parthchandra commented on PR #1883:
URL:
https://github.com/apache/datafusion-comet/pull/1883#issuecomment-2971907817
Merged. Thanks for the reviews @andygrove @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
parthchandra commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2146236444
##
spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala:
##
@@ -120,29 +120,51 @@ class CometNativeShuffleSuite extends CometTestBase
adriangb commented on issue #15780:
URL: https://github.com/apache/datafusion/issues/15780#issuecomment-2971805394
@alamb I tried to put together an example of schema evolution where the file
had a Int32 column at the file schema level and the table has it as Int64, I
can see the extra conv
comphead commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2146172373
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -533,13 +533,20 @@ private StructType getSparkSchemaByFieldId(
return newS
parthchandra commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2146162601
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -533,13 +533,20 @@ private StructType getSparkSchemaByFieldId(
return
parthchandra commented on PR #1864:
URL:
https://github.com/apache/datafusion-comet/pull/1864#issuecomment-2971784129
Ci is failing because in (`iceberg_compat`)`initRecordBatchReader` we call
`planner.createExpr` for predicates that are pushed down and the expressions
are no longer there
comphead commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2146142132
##
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##
@@ -533,13 +533,20 @@ private StructType getSparkSchemaByFieldId(
return newS
codecov-commenter commented on PR #1886:
URL:
https://github.com/apache/datafusion-comet/pull/1886#issuecomment-2971750960
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1886?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
parthchandra commented on PR #1866:
URL:
https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2971722751
@andygrove perhaps we can merge this while we wait for the tests to be made
more accurate?
--
This is an automated message from the Apache Git Service.
To respond to the
jonathanc-n commented on PR #16391:
URL: https://github.com/apache/datafusion/pull/16391#issuecomment-2971722156
Fixed @alamb! Should be good now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
comphead opened a new pull request, #1886:
URL: https://github.com/apache/datafusion-comet/pull/1886
## Which issue does this PR close?
Closes #.
## Rationale for this change
Refactor planner read tests to improve readability and factor out reusable
code
#
parthchandra commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2146079262
##
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##
@@ -1745,6 +1746,77 @@ abstract class ParquetReadSuite extends CometTestBase {
adriangb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971653072
@alamb I opened https://github.com/pydantic/datafusion/pull/30 to explore
the idea of having two pushdown phases. It's not complete (some failing tests,
some TODOs) but I think it c
alamb commented on issue #1837:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/1837#issuecomment-2971597878
Ok, I have a PR up with the changelog and version bump:
https://github.com/apache/datafusion-sqlparser-rs/pull/1885
--
This is an automated message from the Apache G
alamb opened a new issue, #16405:
URL: https://github.com/apache/datafusion/issues/16405
### Is your feature request related to a problem or challenge?
_No response_
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
simonvandel opened a new pull request, #16404:
URL: https://github.com/apache/datafusion/pull/16404
## Which issue does this PR close?
- Closes #.
## Rationale for this change
Mostly drive-by changes. I don't think they have much impact on performance.
alamb merged PR #16403:
URL: https://github.com/apache/datafusion/pull/16403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
codecov-commenter commented on PR #1885:
URL:
https://github.com/apache/datafusion-comet/pull/1885#issuecomment-2971547836
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1885?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
alamb opened a new issue, #1886:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1886
Follow on to
- https://github.com/apache/datafusion-sqlparser-rs/issues/1837
This ticket tracks creating the next sqlparser release (mostly so others can
follow along)
**Targ
alamb opened a new pull request, #1885:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1885
- Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1837
Changes:
1. Generate CHANGELOG
2. Update version
--
This is an automated message from the Apache Gi
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971539472
> It could (and does currently) handle push down of dynamic filters, the
issue is that it cannot be run after EnforceSorting because EnforceSorting and
EnforceDistribution need to be r
adriangb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971532504
Okay then I'll file a ticket for the multi-column sort and the display. But
I do think we should hash out
https://github.com/apache/datafusion/pull/15770#issuecomment-2971441638 in
adriangb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971531318
> I don't understand why FilterPushdown can't also push down DynamicFlters
if it was run after EnforceSorting but I vaguely remember it being discussed
and rejected before
It
andygrove commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2146006687
##
dev/diffs/3.4.3.diff:
##
@@ -2404,7 +2411,31 @@ index 266bb343526..c3e3d155813 100644
checkAnswer(aggDF, df1.groupBy("j").agg(max("k")))
}
alamb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971519773
> Could it be that in that test we don't have file statistics
(`datafusion.execution.collect_statistics = false`) -> the pruning is happening
at the row group level?
```she
alamb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971520273
(basically I want to be able to see from statistics when the dynamic filters
are helping / not helping)
--
This is an automated message from the Apache Git Service.
To respond t
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971510953
> 1. Mutli-column order by not working. This seems like a bug / oversight.
Fundamentally I don't see any reason it shouldn't work, I'll have to
investigate why.
I suggest we fil
andygrove opened a new pull request, #1885:
URL: https://github.com/apache/datafusion-comet/pull/1885
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
alamb commented on code in PR #74:
URL: https://github.com/apache/datafusion-site/pull/74#discussion_r2145976359
##
content/blog/2025-06-15-optimizing-sql-dataframes-part-one.md:
##
@@ -0,0 +1,250 @@
+---
+layout: post
+title: Optimizing SQL (and DataFrames) in DataFusion, Part
adriangb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971481867
Could it be that in that test we don't have file statistics
(`datafusion.execution.collect_statistics = false`) -> the pruning is happening
at the row group level?
--
This i
alamb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971469382
> Hmm maybe we aren't including that statistic in the output?
I think everything that is non zero is included. I'll have to look into it
some more
--
This is an automated
andygrove merged PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
alamb commented on PR #16397:
URL: https://github.com/apache/datafusion/pull/16397#issuecomment-2971466770
> Relevant question to this text and the project is what the project's
stance is wrt API stability? Merging fast means you're likely to ship something
a little bit too quickly every no
andygrove commented on PR #1747:
URL:
https://github.com/apache/datafusion-comet/pull/1747#issuecomment-2971468514
Thanks for the review @parthchandra. I added the logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pepijnve commented on PR #16397:
URL: https://github.com/apache/datafusion/pull/16397#issuecomment-2971445102
Sorry to go a bit off topic for a sec, but there's some context I would like
to add. I worked on API design of a commercial software library with tons of
extension points for 10+ ye
adriangb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971441638
> We might be able to split the filter pushdown into two steps: static
(cannot make assumptions about reference links but can modify the plan tree,
e.g. for FitlerExec) and dynamic
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145924185
##
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##
@@ -114,6 +118,18 @@ fn pushdown_sorts_helper(
sort_push_down.data.fetch =
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145917211
##
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs:
##
@@ -346,6 +359,137 @@ fn test_node_handles_child_pushdown_result() {
);
}
+#[tokio:
adriangb opened a new pull request, #16403:
URL: https://github.com/apache/datafusion/pull/16403
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
adriangb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971392142
> > cover that?
>
> Yes 🤦
>
> For some reason it doesn't show up for me in the explain analyze I have:
[q25-analyze-topk-dynamic-filter.txt](https://github.com/use
alamb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971390765
> cover that?
Yes 🤦
For some reason it doesn't show up for me in the explain analyze I have:
[q25-analyze-topk-dynamic-filter.txt](https://github.com/user-attachment
alamb commented on PR #16397:
URL: https://github.com/apache/datafusion/pull/16397#issuecomment-2971392100
> This is really nice, thanks @alamb!
Thanks -- I was just channeling @ozankabak :)
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
adriangb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971391046
Thanks for the review @alamb!
I'll try to summarize the high level issues:
1. Mutli-column order by not working. This seems like a bug / oversight.
Fundamentally I don't se
alamb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145903411
##
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##
@@ -70,6 +71,8 @@ pub fn assign_initial_requirements(sort_push_down: &mut
SortPushDown) {
comphead opened a new issue, #1884:
URL: https://github.com/apache/datafusion-comet/issues/1884
### What is the problem the feature request solves?
Currently test cannot be run in native mode
```
test("test lookup map by a key") {
withSQLConf(
CometConf.COM
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145900061
##
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##
@@ -114,6 +118,18 @@ fn pushdown_sorts_helper(
sort_push_down.data.fetch =
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145895957
##
datafusion/sqllogictest/test_files/parquet_filter_pushdown.slt:
##
@@ -246,38 +246,3 @@ physical_plan
02)--FilterExec: val@0 != part@1
03)RepartitionExec
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145894014
##
datafusion/physical-optimizer/src/enforce_sorting/sort_pushdown.rs:
##
@@ -70,6 +71,8 @@ pub fn assign_initial_requirements(sort_push_down: &mut
SortPushDown)
codecov-commenter commented on PR #1883:
URL:
https://github.com/apache/datafusion-comet/pull/1883#issuecomment-2971338111
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
alamb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145790872
##
datafusion/core/tests/fuzz_cases/topk_filter_pushdown.rs:
##
@@ -0,0 +1,387 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
andygrove commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2145878327
##
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##
@@ -1745,6 +1746,77 @@ abstract class ParquetReadSuite extends CometTestBase {
adriangb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971321730
Doesn't
https://github.com/apache/datafusion/blob/4dd6923787084548c9ecc6d90c630c2c28ee9259/datafusion/datasource-parquet/src/metrics.rs#L30-L33
cover that?
--
This is an aut
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971297789
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubun
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971305067
🤖: Benchmark completed
Details
```
Comparing HEAD and topk-dynamic-filters
Benchmark sort_tpch.json
┏━━
simonvandel commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145802029
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
alamb opened a new issue, #16402:
URL: https://github.com/apache/datafusion/issues/16402
### Is your feature request related to a problem or challenge?
- This is a follow on to the feature added by @adriangb in
https://github.com/apache/datafusion/pull/16014
@adriangb added th
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971198838
I also filed a ticket to add a metric that we can use to see when file
pruning is working:
- https://github.com/apache/datafusion/issues/16402
--
This is an automated message from
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971173365
> > QQuery 25│ 380.03 ms │279.23 ms │ +1.36x faster
>
> ```sql
> SELECT SearchPhrase FROM hits WHERE SearchPhrase <> '' ORDER BY
SearchPhrase LIMIT 10;
>
parthchandra opened a new pull request, #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883
## Which issue does this PR close?
The mapping between Spark and Parquet for schemas with field ids did not
correctly handle the schemas with nested arrays of structs.
## R
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145547651
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec,
/// Cache holding plan properties l
timsaucer closed pull request #1110: WIP: scalar UDFs with metadata
URL: https://github.com/apache/datafusion-python/pull/1110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
timsaucer commented on PR #1110:
URL:
https://github.com/apache/datafusion-python/pull/1110#issuecomment-2971126021
Superseded by https://github.com/apache/datafusion-python/pull/1145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
andygrove commented on issue #1254:
URL:
https://github.com/apache/datafusion-comet/issues/1254#issuecomment-2971117509
I removed the following from the scope of this issue since they turned out
not to be bugs or correctness issues, but valid failures because Comet does not
support DPP nat
andygrove closed issue #1254: [EPIC] Spark SQL test failures when Comet JVM
shuffle is used
URL: https://github.com/apache/datafusion-comet/issues/1254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb closed issue #16336: SparkSha2 is not compliant with Spark and does not
support Int32 type
URL: https://github.com/apache/datafusion/issues/16336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb merged PR #16350:
URL: https://github.com/apache/datafusion/pull/16350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
dependabot[bot] commented on PR #16392:
URL: https://github.com/apache/datafusion/pull/16392#issuecomment-2971066993
This pull request was built based on a group rule. Closing it will not
ignore any of these versions in future pull requests.
To ignore these dependencies, configure [ig
alamb commented on issue #16323:
URL: https://github.com/apache/datafusion/issues/16323#issuecomment-2971079530
I think we are now done with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb closed issue #16323: Request to update crates.io ownership
URL: https://github.com/apache/datafusion/issues/16323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
alamb closed pull request #16392: chore(deps): bump prost-build from 0.13.5 to
0.14.0 in the proto group
URL: https://github.com/apache/datafusion/pull/16392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alamb commented on PR #16077:
URL: https://github.com/apache/datafusion/pull/16077#issuecomment-2971062970
Marking as draft as I think this PR is no longer waiting on feedback and I
am trying to make it easier to find PRs in need of review. Please mark it as
ready for review when it is read
alamb commented on PR #16392:
URL: https://github.com/apache/datafusion/pull/16392#issuecomment-2971066685
This needs to wait for an arrow-rs update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb commented on code in PR #16388:
URL: https://github.com/apache/datafusion/pull/16388#discussion_r2145600999
##
datafusion/core/src/execution/session_state.rs:
##
@@ -1675,6 +1675,13 @@ impl ContextProvider for SessionContextProvider<'_> {
.get(name)
alamb commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145582029
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
Dandandan commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971038192
I wonder if we see any improvements on the "sort tpch with limit" benchmark?
```cargo run --release --bin dfbench -- sort-tpch --iterations 5 --path
"${TPCH_DIR}" -o "${RESUL
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2971026040
> logical_select_all_from_1000 10.80 120.4±0.22ms
? ?/sec1.00 11.1±0.06ms? ?/sec
🚀
The other planning benchmarks look like prett
Dandandan commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145572928
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec,
/// Cache holding plan properties
epgif commented on PR #16401:
URL: https://github.com/apache/datafusion/pull/16401#issuecomment-2971013443
@alamb
> I wonder if there is some way we can write a test for it (mostly to
prevent it from being accidentally broken/changed in the future)
I looked around for some tes
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2971008063
val df = spark.sql("select hour('1969-12-31 16:00:00.0') AS folded_hour")
== Physical Plan ==
*(1) Project [16 AS folded_hour#0]
+- *(1) Scan OneRowRelation[]
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145548000
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec,
/// Cache holding plan properties l
Dandandan commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145545013
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec,
/// Cache holding plan properties
1 - 100 of 247 matches
Mail list logo
