Dandandan commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145545013
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec<PhysicalSortExpr>,
/// Cache holding plan properties like equivalences, output partitioning
etc.
cache: PlanProperties,
+ /// Filter matching the state of the sort for dynamic filter pushdown
+ filter: Option<Arc<DynamicFilterPhysicalExpr>>,
Review Comment:
What isn't really clear to me from this PR - will this create a filter here
regardless whether it can be pushed down or do we keep this as `None` if it
can't? As there might be a small overhead of evaluating this filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
