alamb commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145582029
##########
datafusion/sql/src/select.rs:
##########
@@ -374,6 +383,14 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result<LogicalPlan> {
match input {
+ LogicalPlan::Aggregate(ref agg)
+ if {
Review Comment:
what is the reason to add `{` here? It looked kind of strange to me -- i
would have expected something more like
```rust
LogicalPlan::Aggregate(ref agg) if
!&agg.group_expr.iter().any(has_unnest_expr_recursively) =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
