Dandandan commented on code in PR #15770: URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145572928
########## datafusion/physical-plan/src/sorts/sort.rs: ########## @@ -843,6 +846,8 @@ pub struct SortExec { common_sort_prefix: Vec<PhysicalSortExpr>, /// Cache holding plan properties like equivalences, output partitioning etc. cache: PlanProperties, + /// Filter matching the state of the sort for dynamic filter pushdown + filter: Option<Arc<DynamicFilterPhysicalExpr>>, Review Comment: That might make sense for now 🤔 I think once we do https://github.com/apache/datafusion/pull/15697 probably it's not needed to disable computing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org