parthchandra commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2146241641
##########
common/src/main/java/org/apache/comet/parquet/NativeBatchReader.java:
##########
@@ -533,13 +533,20 @@ private StructType getSparkSchemaByFieldId(
return newSchema;
}
+ private static boolean isPrimitiveCatalystType(DataType dataType) {
Review Comment:
It makes sense for this to be private. The definition of complex types may
change as support for types like `variant` and `geospatial` types is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
