Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread David
On Sun, 15 Sep 2019 at 07:24, Pratyush Yadav wrote: > On 15/09/19 01:57AM, David wrote: > > I can't say it strongly enough. Please do not change stage/unstage > > to require double-click. This would be most unwelcome here, unless it > > comes with a configuration option to preserve the old behavi

Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread David
On Sun, 15 Sep 2019 at 05:08, Pratyush Yadav wrote: > On 15/09/19 02:07AM, David wrote: > > On Sat, 14 Sep 2019 at 06:51, Bert Wesarg > > wrote: > > > I consider adding a second way as not not acceptable. I also consider > > > double-click on a file in a GUI an "open" action. > > > > Yes! > > >

[PATCH 3/3] list-objects-filter: give a more specific error sparse parsing error

2019-09-14 Thread Jeff King
From: Jon Simons The sparse:oid filter has two error modes: we might fail to resolve the name to an OID, or we might fail to parse the contents of that OID. In the latter case, let's give a less generic error message, and mention the OID we did find. While we're here, let's also mark both messag

[PATCH 2/3] list-objects-filter: delay parsing of sparse oid

2019-09-14 Thread Jeff King
The list-objects-filter code has two steps to its initialization: 1. parse_list_objects_filter() makes sure the spec is a filter we know about and is syntactically correct. This step is done by "rev-list" or "upload-pack" that is going to apply a filter, but also by "git clone" or

[PATCH 1/3] t5616: test cloning/fetching with sparse:oid= filter

2019-09-14 Thread Jeff King
From: Jon Simons We test in t5317 that "sparse:oid" filters work with rev-list, but there's no coverage at all confirming that they work with a fetch or clone (and in fact, there are several bugs). Let's do a basic test that a clone fetches the correct objects. [jk: extracted from Jon's earlier

[PATCH 0/3] clone --filter=sparse:oid bugs

2019-09-14 Thread Jeff King
On Mon, Sep 09, 2019 at 01:08:24PM -0400, Jeff King wrote: > I'll work up what I sent earlier into a real patch, and include some of > this discussion. Here it is. I pulled Jon's tests out into their own patch (mostly because it makes it easier to give credit). Then patch 2 is my fix, and patch 3

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Pratyush Yadav
On 15/09/19 02:45AM, Pratyush Yadav wrote: > On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote: > > Hi everyone, > > > > > > I personally prefer to have the changes I am about to commit visible > > in the diff view, while I write my commit message. So usually I do > > this: > > 1. Stage the file

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Johannes Sixt
Am 14.09.19 um 23:15 schrieb Pratyush Yadav: > On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote: >> When the user >> stages the last file in the "Unstaged Changes" widget, no file is >> selected and the diff view becomes blank. When this is the case, I >> would prefer that git-gui automatically s

Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread Pratyush Yadav
On 15/09/19 01:57AM, David wrote: > On Sat, 14 Sep 2019 at 08:07, Marc Branchaud wrote: > > On 2019-09-13 10:32 a.m., Pratyush Yadav wrote: > > > On 13/09/19 12:24PM, Allan Ford wrote: > > > >> Not a bug, but a suggestion consideration for “Git Gui” > > > >> Can a double click on the file name i

Re: git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Pratyush Yadav
On 14/09/19 02:24PM, Birger Skogeng Pedersen wrote: > Hi everyone, > > > I personally prefer to have the changes I am about to commit visible > in the diff view, while I write my commit message. So usually I do > this: > 1. Stage the file(s) I've been working on. > 2. Select a file I just staged,

[PATCH] doc: provide guidance on user.name format

2019-09-14 Thread brian m. carlson
It's a frequent misconception that the user.name variable controls authentication in some way, and as a result, beginning users frequently attempt to change it when they're having authentication troubles. Document that the convention is that this variable represents some form of a human's personal

Re: Git versioning policy - PatchMyPC compatibility on Windows

2019-09-14 Thread Philip Oakley
On 14/09/2019 20:38, brian m. carlson wrote: On 2019-09-14 at 12:49:40, Audric GUERIN wrote: Hi, I use PatchMyPC to keep all my applications up to date on Windows but there is one application that is never properly detected as up to date... and it is Git as you guessed. According to Justin Cha

[PATCH v3] Documentation: fix build with Asciidoctor 2

2019-09-14 Thread brian m. carlson
Our documentation toolchain has traditionally been built around DocBook 4.5. This version of DocBook is the last DTD-based version of DocBook. In 2009, DocBook 5 was introduced using namespaces and its syntax is expressed in RELAX NG, which is more expressive and allows a wider variety of syntax f

Re: [PATCH v2] Documentation: fix build with Asciidoctor 2

2019-09-14 Thread brian m. carlson
On 2019-09-14 at 07:53:01, SZEDER Gábor wrote: > Unfortunately, five out of five CI builds failed with the following: > > XMLTO git-revert.1 > I/O error : Attempt to load network entity > http://docbook.sourceforge.net/release/xsl-ns/current/manpages/docbook.xsl > warning: failed to loa

Re: Git versioning policy - PatchMyPC compatibility on Windows

2019-09-14 Thread brian m. carlson
On 2019-09-14 at 12:49:40, Audric GUERIN wrote: > Hi, > > I use PatchMyPC to keep all my applications up to date on Windows but there > is one application that is never properly detected as up to date... and it > is Git as you guessed. > > According to Justin Chalfant, Director of Engineering of

Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread Pratyush Yadav
On 15/09/19 02:07AM, David wrote: > On Sat, 14 Sep 2019 at 06:51, Bert Wesarg wrote: > > On Fri, Sep 13, 2019 at 4:32 PM Pratyush Yadav > > wrote: > > > On 13/09/19 12:24PM, Allan Ford wrote: > > > > I miss a general problem description: Whats wrong with the > > single-click on the icon to begin

Re: [PATCH v5] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-14 Thread Pratyush Yadav
You missed labelling the menu item of "Amend Last Commit" with the shortcut, like we do for other menu items bound to a hotkey like F5 for rescan, Ctrl-T for stage, etc. I added that locally. Thanks for the re-roll. Will queue. On 14/09/19 11:18AM, Birger Skogeng Pedersen wrote: > Selecting whe

Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread David
On Sat, 14 Sep 2019 at 06:51, Bert Wesarg wrote: > On Fri, Sep 13, 2019 at 4:32 PM Pratyush Yadav wrote: > > On 13/09/19 12:24PM, Allan Ford wrote: > > I miss a general problem description: Whats wrong with the > single-click on the icon to begin with? No problem here, but see my other message f

GIT_OBJECT_DIRECTORY ignored when cloning submodules

2019-09-14 Thread Robert Schmidt-Cisternas
Hi, In the pursuit of optimizing meta-repo workflows, I wanted to use GIT_OBJECT_DIRECTORY to specify a single objects directory used by all repos and submodules on a workstation. The idea being that many metarepos will contain similar sets of submodules, and objects can be reused, thus potential

Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread David
On Sat, 14 Sep 2019 at 08:07, Marc Branchaud wrote: > On 2019-09-13 10:32 a.m., Pratyush Yadav wrote: > > On 13/09/19 12:24PM, Allan Ford wrote: > >> Not a bug, but a suggestion consideration for “Git Gui” > >> Can a double click on the file name in the “unstaged” area move the > >> item to “sta

Re: [PATCH v2] gitk: Make web links clickable

2019-09-14 Thread Pratyush Yadav
On 14/09/19 09:33AM, Paul Mackerras wrote: > On Fri, Aug 30, 2019 at 12:02:07AM +0530, Pratyush Yadav wrote: > > On 29/08/19 11:27AM, Paul Mackerras wrote: > > > > I know I suggested searching till the first non-whitespace character, > > but thinking more about, there are some problematic cases.

Re: pd/fetch-jobs, was Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)

2019-09-14 Thread Palmer Dabbelt
On Thu, 12 Sep 2019 11:02:42 PDT (-0700), gits...@pobox.com wrote: Johannes Schindelin writes: * pd/fetch-jobs (2019-08-13) 5 commits . fetch: make --jobs control submodules and remotes . fetch: add the --submodule-fetch-jobs option . fetch: add the fetch.jobs config key . fetch: add the "

Git versioning policy - PatchMyPC compatibility on Windows

2019-09-14 Thread Audric GUERIN
Hi, I use PatchMyPC to keep all my applications up to date on Windows but there is one application that is never properly detected as up to date... and it is Git as you guessed. According to Justin Chalfant, Director of Engineering of PatchMyPC, Git version "number" / identifier is not "stan

git-gui: automatically move focus to staged file before typing commit message?

2019-09-14 Thread Birger Skogeng Pedersen
Hi everyone, I personally prefer to have the changes I am about to commit visible in the diff view, while I write my commit message. So usually I do this: 1. Stage the file(s) I've been working on. 2. Select a file I just staged, so I can see the changes in the diff widget. 3. Jump to the "Commit

[PATCH v5] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-14 Thread Birger Skogeng Pedersen
Selecting whether to "Amend Last Commit" or not does not have a hotkey. With this patch, the user may toggle between the two options with CTRL/CMD+e. Signed-off-by: Birger Skogeng Pedersen Rebased-by: Bert Wesarg --- git-gui.sh | 8 1 file changed, 8 insertions(+) diff --git a/git-gu

Re: [PATCH v4] git-gui: add hotkey to toggle "Amend Last Commit"

2019-09-14 Thread Birger Skogeng Pedersen
Thanks, I really appreciate you taking time to explain it thoroughly. On Sat, Sep 14, 2019 at 12:11 AM Pratyush Yadav wrote: > So while my advice above was to work on top of "master", that does not > apply in this case since your patch is dependent on someone's patch > which isn't in master yet.

Re: [PATCH v2] Documentation: fix build with Asciidoctor 2

2019-09-14 Thread SZEDER Gábor
On Fri, Sep 13, 2019 at 01:52:40AM +, brian m. carlson wrote: > We also need to teach xmlto how to use the namespaced DocBook XSLT > stylesheets instead of the non-namespaced ones it usually uses. > Normally these stylesheets are interchangeable, but the non-namespaced > ones have a bug that c

Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”

2019-09-14 Thread Johannes Sixt
Am 13.09.19 um 16:32 schrieb Pratyush Yadav: > Is partial single and partial double click behaviour acceptable? Or > should we make the entire row double click only? Or something else that > I missed? I don't mind adding the suggested double-click action, but removing the single-click action wou