[PATCH] testsuite: Disable colorization for ubsan test

2020-05-20 Thread Kito Cheng
- Run gcc testsuite with qemu will print out ascii color code for ubsan related testcase, however several testcase didn't consider that, so disable colorization prevent such problem and simplify the process when adding testcase in future. - Verified on native X86 and RISC-V qemu full sy

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Kito Cheng
Hi Richard: Tested and committed with fixes, thanks your review :) On Mon, May 18, 2020 at 6:22 PM Richard Biener wrote: > > On Mon, May 18, 2020 at 9:27 AM Kito Cheng wrote: > > > > ping > > > > On Tue, Apr 14, 2020 at 2:53 PM Kito Cheng wrote: > >> > >> - The alignment for local variable wa

Re: [PATCH][C] c/95141 - fix bogus integer overflow warning

2020-05-20 Thread Richard Biener
On Tue, 19 May 2020, Joseph Myers wrote: > On Tue, 19 May 2020, Richard Biener wrote: > > > This fixes an integer overflow warning that ultimatively happens because > > of TREE_OVERFLOW propagating through transforms and the existing guard > > against this, > > > > 375 if (TREE_OVERFLO

Re: [PATCH 2/2] rs6000: tune loop size for cunroll at O2

2020-05-20 Thread Jiufu Guo via Gcc-patches
"Kewen.Lin" writes: > Hi Jeff, > > on 2020/5/20 上午11:58, Jiufu Guo via Gcc-patches wrote: >> Hi, >> >> This patch check the size of a loop to be unrolled/peeled completely, >> and set the limits to a number (24). This prevents large loop from >> being unrolled, then avoid binary size increasing

Re: ChangeLog files - server and client scripts (git cherry-pick)

2020-05-20 Thread Martin Liška
On 5/14/20 2:42 PM, Martin Liška wrote: Hello. I'm sending patch candidate that adds 2 new git aliases: - gcc-backport - simple alias to 'git cherry-pick -x' - gcc-revert - it similarly appends '(this reverts commit 365e3cde4978c6a7dbfa50865720226254c016be)' to a reverted commit message The sc

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 5:56 AM Jiufu Guo via Gcc-patches wrote: > > Hi, > > In r10-4525, and r10-4161, loop unroller was enabled for simply loops at -O2. > At the same time, the GIMPLE cunroll is also enabled, while it is not only for > simple loops. This patch introduces a hook to check if a lo

Re: ChangeLog files - server and client scripts

2020-05-20 Thread Martin Liška
On 5/20/20 12:20 AM, Jonathan Wakely wrote: Or this one that actually adds the closing parenthesis Thank you, it's definitely an improvement. There's final version of the patch I've just applied. Martin >From a55c1018c9d7c53b643203e7f71b06953fae86a1 Mon Sep 17 00:00:00 2001 From: Jonathan Wak

Re: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-20 Thread Martin Liška
On 5/20/20 7:53 AM, Frederik Harwath wrote: Martin Liška writes: Hi Martin, On 5/19/20 11:45 AM, Frederik Harwath wrote: Thank you Frederick for the patch. Looking at what I grepped: https://github.com/marxin/gcc-changelog/issues/1#issuecomment-621910248 I get a 404 error when I try to acc

[PATCH][DOCS] Mention new git aliases.

2020-05-20 Thread Martin Liška
Hi. I would like to mention newly added git aliases. Martin --- htdocs/gitwrite.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index 791213a5..e3a1305b 100644 --- a/htdocs/gitwrite.html +++ b/htdocs/gitwrite.html @@ -433

RE: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-20 Thread Kyrylo Tkachov
> -Original Message- > From: Gcc-patches On Behalf Of Srinath > Parvathaneni > Sent: 15 May 2020 12:27 > To: Christophe Lyon > Cc: Richard Earnshaw ; gcc Patches patc...@gcc.gnu.org> > Subject: RE: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE > vector load/store intrinsic

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Wed, May 20, 2020 at 5:56 AM Jiufu Guo via Gcc-patches > wrote: >> >> Hi, >> >> In r10-4525, and r10-4161, loop unroller was enabled for simply loops at -O2. >> At the same time, the GIMPLE cunroll is also enabled, while it is not only >> for >> simple loops. This p

Re: [PATCH] Refactor `execute` from gcc.c

2020-05-20 Thread Richard Biener via Gcc-patches
On Tue, May 19, 2020 at 2:24 AM Giuliano Belinassi via Gcc-patches wrote: > > Hi, > > After having so much trouble working on the `execute' function inside > gcc.c, I decided to refactor it so that it could be more digestible. > Since I am using it on my branch, I am submitting this patch for > "b

[PATCH][PR92658] Add missing vector truncmn2 expanders for avx512f

2020-05-20 Thread Hongtao Liu via Gcc-patches
Hi: Bootstrap is ok, regression test on i386/x86-64 backend is ok. gcc/ChangeLog: PR target/92658 * config/i386/sse.md (trunc2, truncv32hiv32qi2, trunc2): New expander. gcc/testsuite/ChangeLog: * gcc.target/i386/pr92658-avx512f.c: New test. * gcc.

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 10:27 AM Jiufu Guo wrote: > > Richard Biener writes: > > > On Wed, May 20, 2020 at 5:56 AM Jiufu Guo via Gcc-patches > > wrote: > >> > >> Hi, > >> > >> In r10-4525, and r10-4161, loop unroller was enabled for simply loops at > >> -O2. > >> At the same time, the GIMPLE cu

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Wed, May 20, 2020 at 10:27 AM Jiufu Guo wrote: >> >> Richard Biener writes: >> >> > On Wed, May 20, 2020 at 5:56 AM Jiufu Guo via Gcc-patches >> > wrote: >> >> >> >> Hi, >> >> >> >> In r10-4525, and r10-4161, loop unroller was enabled for simply loops at >> >> -O2.

Re: [PATCH] contrib/gcc-changelog: Handle Reviewed-{by,on}

2020-05-20 Thread Martin Liška
On 5/20/20 7:53 AM, Frederik Harwath wrote: Yes, I will add it. Thank you for the patch. I'm adding test for that and also some format changes in order to make flake8 happy: flake8 contrib/gcc-changelog/ contrib/gcc-changelog/git_commit.py:158:59: E502 the backslash is redundant between brack

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Wed, May 20, 2020 at 5:56 AM Jiufu Guo via Gcc-patches > wrote: >> >> Hi, >> >> In r10-4525, and r10-4161, loop unroller was enabled for simply loops at -O2. >> At the same time, the GIMPLE cunroll is also enabled, while it is not only >> for >> simple loops. This p

Re: ChangeLog files - server and client scripts (git cherry-pick)

2020-05-20 Thread Thomas Koenig via Gcc-patches
Hm, one question: I find the r11-1234 type commit to be much more readable, in ChangeLog files and everywhere else. Would it be possible to have that format instead of "cherry picked from commit $HEX_SOUP" ?

Re: ChangeLog files - server and client scripts (git cherry-pick)

2020-05-20 Thread Martin Liška
On 5/20/20 11:19 AM, Thomas Koenig wrote: Hm, one question: I find the r11-1234 type commit to be much more readable, in ChangeLog files and everywhere else. Would it be possible to have that format instead of "cherry picked from commit $HEX_SOUP" ? I'm not aware of how to do it. Please let's

Re: ChangeLog files - server and client scripts (git cherry-pick)

2020-05-20 Thread Jakub Jelinek via Gcc-patches
On Wed, May 20, 2020 at 11:19:49AM +0200, Thomas Koenig wrote: > Hm, one question: I find the r11-1234 type commit to be much more > readable, in ChangeLog files and everywhere else. > > Would it be possible to have that format instead of > "cherry picked from commit $HEX_SOUP" ? I think if you g

Re: Avoid SCC hashing on unmergeable trees

2020-05-20 Thread Martin Liška
On 5/19/20 10:46 PM, Jan Hubicka wrote: Martin, the zstd compression breaks the compression statistics (it works when GCC is configured for zlib) Hello. Can you please be please more concrete? I can help with, but I don't know what's broken. Thanks, Martin

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-05-20 Thread Thomas Schwinge
Hi Julian! Moving this over, from the "Fix component mappings with derived types for OpenACC" thread, , where you propose to change this 'GOMP_MAP_STRUCT' handling code: On 2019-12-17T22:03:47-0800, Julian Brown wrote: > --- a/lib

[PATCH] Fill up {,un}compression stats for ZSTD in LTO.

2020-05-20 Thread Martin Liška
Hi. As Honza correctly noticed we're missing {,un}compression ratio for ZSTD compression. Before: gcc foo.o -flto-report 2>&1 | grep com [WPA] Compression: 1022 input bytes, 0 uncompressed bytes (ratio: 0.00) [WPA] Compression: 1368 input bytes, 0 uncompressed bytes (ratio: 0.00) After

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 11:08 AM Jiufu Guo wrote: > > Richard Biener writes: > > > On Wed, May 20, 2020 at 5:56 AM Jiufu Guo via Gcc-patches > > wrote: > >> > >> Hi, > >> > >> In r10-4525, and r10-4161, loop unroller was enabled for simply loops at > >> -O2. > >> At the same time, the GIMPLE cu

Re: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-20 Thread Martin Liška
Hi. You forgot to install testsuite/ChangeLog entries. Please do it so that comparison of future gcc-changelog won't miss these entries. Martin

Re: Avoid SCC hashing on unmergeable trees

2020-05-20 Thread Richard Biener
On Tue, 19 May 2020, Jan Hubicka wrote: > Hi, > this is new incarantion of patch to identify unmergeable tree at streaming out > time rather than streaming in and to avoid pickling them to sccs with with > hash > codes. > > Building cc1 plus this patch reduces: > > [WPA] read 4452927 SCCs of av

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-05-20 Thread Franz Sirl
Am 2020-05-19 um 21:05 schrieb Martin Liška: Hi. We make direct emission for asan_emit_stack_protection for smaller stacks. That's fine but we're missing the piece that marks the stack as released and we run out of pre-allocated stacks. I also included some stack-related constants that were used

Re: [PATCH] x86: Update VPCLMULQDQ check

2020-05-20 Thread H.J. Lu via Gcc-patches
On Tue, May 19, 2020 at 11:00 PM Uros Bizjak wrote: > > On Wed, May 20, 2020 at 3:57 AM H.J. Lu wrote: > > > > Update VPCLMULQDQ check to support processors with AVX version of > > VPCLMULQDQ. > > > > PR target/91695 > > * config/i386/cpuinfo.c (get_available_features): Fix VPCLMU

Re: [PATCH] x86: Update VPCLMULQDQ check

2020-05-20 Thread Uros Bizjak via Gcc-patches
On Wed, May 20, 2020 at 1:15 PM H.J. Lu wrote: > > On Tue, May 19, 2020 at 11:00 PM Uros Bizjak wrote: > > > > On Wed, May 20, 2020 at 3:57 AM H.J. Lu wrote: > > > > > > Update VPCLMULQDQ check to support processors with AVX version of > > > VPCLMULQDQ. > > > > > > PR target/91695 > > >

Re: V2 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386

2020-05-20 Thread H.J. Lu via Gcc-patches
On Tue, May 19, 2020 at 11:10 PM Uros Bizjak wrote: > > On Tue, May 19, 2020 at 11:40 PM H.J. Lu wrote: > > > > > > > > > > I will take a look to see if we share the same CPU detection > > > > > > > > > code between > > > > > > > > > libgcc and config/i386/driver-i386.c. > > > > > > > > > > > >

[PATCH] middle-end/95231 - revert parts of PR95171

2020-05-20 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. I mistook the opportunity to also "fix" the [VEC_]COND_EXPR case for PR95171 but I was wrong in that it doesn't need the fix and in the actual fix as well. The following just reverts that part. 2020-05-20 Richard Biener

Re: Avoid SCC hashing on unmergeable trees

2020-05-20 Thread Jan Hubicka
> On 5/19/20 10:46 PM, Jan Hubicka wrote: > > Martin, the zstd compression breaks the compression statistics (it works > > when > > GCC is configured for zlib) > > Hello. > > Can you please be please more concrete? I can help with, but I don't know > what's broken. Sure, the compression statisti

Re: Avoid SCC hashing on unmergeable trees

2020-05-20 Thread Jan Hubicka
Hi, > > The patch looks reasonable - the wins are not entirely clear to me > since you mix in LTO streaming format optimizations. You promised > to improve collisions on the SCC merging side but those are not > spectacular (if present at all) in the above data? Thanks for looking into that. Coll

Re: [PATCH] Fill up {,un}compression stats for ZSTD in LTO.

2020-05-20 Thread Jan Hubicka
> Hi. > > As Honza correctly noticed we're missing {,un}compression ratio for > ZSTD compression. > > Before: > > gcc foo.o -flto-report 2>&1 | grep com > [WPA] Compression: 1022 input bytes, 0 uncompressed bytes (ratio: 0.00) > [WPA] Compression: 1368 input bytes, 0 uncompressed bytes (rati

Re: Avoid SCC hashing on unmergeable trees

2020-05-20 Thread Richard Biener
On Wed, 20 May 2020, Jan Hubicka wrote: > Hi, > > > > The patch looks reasonable - the wins are not entirely clear to me > > since you mix in LTO streaming format optimizations. You promised > > to improve collisions on the SCC merging side but those are not > > spectacular (if present at all) i

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 9:20 AM Kito Cheng wrote: > > Hi Richard: > > Tested and committed with fixes, thanks your review :) And we're now hitting internal compiler error: in execute, at adjust-alignment.c:73 for FAIL: gcc.target/i386/pr69454-2.c (internal compiler error) FAIL: gcc.target/i386

[PATCH] tree-optimization/95219 - improve IV selection for induction

2020-05-20 Thread Richard Biener
This improves code generation with SSE2 for the testcase by making sure to only generate a single IV when the group size is a multiple of the vector size. It also adjusts the testcase which was passing before. Bootstrapped / tested on x86_64-unknown-linux-gnu, pushed. 2020-05-20 Richard Biene

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Kito Cheng
Ok, I will check. On Wed, May 20, 2020 at 8:04 PM Richard Biener wrote: > > On Wed, May 20, 2020 at 9:20 AM Kito Cheng wrote: > > > > Hi Richard: > > > > Tested and committed with fixes, thanks your review :) > > And we're now hitting > > internal compiler error: in execute, at adjust-alignment.

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Kito Cheng
There is an assertion checking to make sure LOCAL_DECL_ALIGNMENT never shrink alignment, But those two testcase did under x86_64 with -m32, I am not sure if the behavior is expected or not? It should be fixed on target if that behavior is not expected. On Wed, May 20, 2020 at 8:06 PM Kito Cheng

Re: Avoid SCC hashing on unmergeable trees

2020-05-20 Thread Martin Liška
On 5/20/20 1:49 PM, Jan Hubicka wrote: On related note, I remember us discussing that std compression has problem with bigger headers then zlib. Since we stream our header that says if section is compressed, I wonder if we could teach stream-out phase to skip compression if it is not benefical,

Re: [PATCH v4] Fix alignment for local variable [PR90811]

2020-05-20 Thread Richard Biener via Gcc-patches
On Wed, May 20, 2020 at 2:30 PM Kito Cheng wrote: > > There is an assertion checking to make sure LOCAL_DECL_ALIGNMENT never > shrink alignment, > > But those two testcase did under x86_64 with -m32, I am not sure if > the behavior is expected or not? > It should be fixed on target if that behavio

Re: [PATCH] c++: spec_hasher and TYPENAME_TYPE resolution [PR95223]

2020-05-20 Thread Nathan Sidwell
On 5/19/20 11:38 PM, Patrick Palka via Gcc-patches wrote: After enabling sanitization of the specialization tables, we are triggering one of the hash table sanity checks in the below testcase. The reason is that when looking up the specialization j in the type_specializations table, the sanity c

[preprocessor] Replace flags with an enum

2020-05-20 Thread Nathan Sidwell
_cpp_find_file has 3 bool arguments, at most one of which is ever set. Ripe for replacing with a 4-state enum. Also, this is C++, so 'typedef struct Foo Foo' is unnecessary. pushed to master. nathan -- Nathan Sidwell 2020-05-20 Nathan Sidwell * internal.h (typedef _cpp_file): Delete, unn

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-20 Thread Martin Liška
On 4/23/20 5:42 PM, Marco Elver via Gcc-patches wrote: Hello. Not being a maintainer of libsanitizer but I can provide a feedback: Add support to optionally emit different instrumentation for accesses to volatile variables. While the default TSAN runtime likely will never require this feature,

Re: [PATCH] TESTSUITE: Fix tests for 16-bit targets

2020-05-20 Thread Christophe Lyon via Gcc-patches
Hi, On Mon, 18 May 2020 at 14:42, Jozef Lawrynowicz wrote: > > On Fri, May 15, 2020 at 10:48:56PM +, Joseph Myers wrote: > > On Fri, 15 May 2020, Jozef Lawrynowicz wrote: > > > > > The attached patch fixes many GCC and G++ tests for 16-bit targets. These > > > targets can have the following

Re: [PATCH] Add -fuse-ld= to specify an arbitrary executable as the linker

2020-05-20 Thread Martin Liška
Hello. diff --git a/gcc/collect2.c b/gcc/collect2.c index f8a5ce45994..e04892cb91f 100644 --- a/gcc/collect2.c +++ b/gcc/collect2.c @@ -782,15 +782,16 @@ main (int argc, char **argv) USE_GOLD_LD, USE_BFD_LD, USE_LLD_LD, + USE_LD, I wouldn't add a new constant.

RE: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-20 Thread Srinath Parvathaneni
Hi Martin, > -Original Message- > From: Martin Liška > Sent: 20 May 2020 11:51 > To: Srinath Parvathaneni ; Christophe Lyon > > Cc: Richard Earnshaw ; gcc Patches patc...@gcc.gnu.org> > Subject: Re: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE > vector load/store intrinsic

Re: ChangeLog files - server and client scripts (git cherry-pick)

2020-05-20 Thread Richard Earnshaw
On 20/05/2020 10:27, Jakub Jelinek via Gcc wrote: > On Wed, May 20, 2020 at 11:19:49AM +0200, Thomas Koenig wrote: >> Hm, one question: I find the r11-1234 type commit to be much more >> readable, in ChangeLog files and everywhere else. >> >> Would it be possible to have that format instead of >> "

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-20 Thread Marco Elver via Gcc-patches
On Wed, 20 May 2020 at 15:30, Martin Liška wrote: > > On 4/23/20 5:42 PM, Marco Elver via Gcc-patches wrote: > > Hello. > > Not being a maintainer of libsanitizer but I can provide a feedback: Thank you for the review! Note, this is not touching libsanitizer or user-space TSAN runtime, only the

[PATCH] git_email.py: fix duplicate author_lines.

2020-05-20 Thread Martin Liška
Hi. A small de-duplication that I noticed for commit: eb069ae8819c3a84d7f78becc5501e21ee3a9554 I'm going to install the patch. Martin contrib/ChangeLog: 2020-05-20 Martin Liska * gcc-changelog/git_commit.py: Add author_tuple only if not present in author_lines. * gc

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-20 Thread Martin Liška
On 5/20/20 4:04 PM, Marco Elver wrote: On Wed, 20 May 2020 at 15:30, Martin Liška wrote: On 4/23/20 5:42 PM, Marco Elver via Gcc-patches wrote: Hello. Not being a maintainer of libsanitizer but I can provide a feedback: Thank you for the review! Note, this is not touching libsanitizer or

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-05-20 Thread Thomas Schwinge
Hi! On 2019-12-17T22:03:47-0800, Julian Brown wrote: > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > static int > -find_group_last (int pos, size_t mapnum, unsigned short *kinds) > +find_group_last (int pos, size_t mapnum, size_t *sizes, unsigned short > *kinds) > { >unsigned char

Re: [PATCH][PR92658] Add missing vector truncmn2 expanders for avx512f

2020-05-20 Thread Uros Bizjak via Gcc-patches
On Wed, May 20, 2020 at 10:35 AM Hongtao Liu wrote: > > Hi: > Bootstrap is ok, regression test on i386/x86-64 backend is ok. > > gcc/ChangeLog: > PR target/92658 > * config/i386/sse.md > (trunc2, truncv32hiv32qi2, > trunc2): New expander. > > gcc/testsuite/ChangeL

Re: [PATCH] c++: spec_hasher and TYPENAME_TYPE resolution [PR95223]

2020-05-20 Thread Jason Merrill via Gcc-patches
On 5/19/20 11:38 PM, Patrick Palka wrote: After enabling sanitization of the specialization tables, we are triggering one of the hash table sanity checks in the below testcase. The reason is that when looking up the specialization j in the type_specializations table, the sanity check finds that

Re: [PATCH] Tweak some powerpc tests for altivec_ok and vsx_ok

2020-05-20 Thread Segher Boessenkool
Hi~ On Tue, May 19, 2020 at 03:20:37PM -0700, Douglas B Rupp wrote: > On 5/19/20 3:03 PM, Segher Boessenkool wrote: > >This is a compile test, so it does not matter at all what the kernel is > >doing or not doing. And the -mcpu=power8 flag should enable altivec. > >Apparently it doesn't for you,

Re: [PATCH v2] c++: Implement DR 2289, Uniqueness of structured binding names [PR94553]

2020-05-20 Thread Jason Merrill via Gcc-patches
On 5/20/20 1:14 AM, Marek Polacek wrote: - If not, set INITIALIZED to zero, which will indirectly + If not, return error_mark_node, which will indirectly tell `cp_finish_decl' to ignore the initializer once it is parsed. */ Wow, that comment has been mismatched to the code since

[committed] i386: Fix *pushsi2_rex64 constraints [PR95238]

2020-05-20 Thread Uros Bizjak via Gcc-patches
2020-05-20 Uroš Bizjak gcc/ChangeLog: PR target/95238 * config/i386/i386.md (*pushsi2_rex64): Use "e" constraint instead of "i". Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Uros. diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index aa4f25b7065..

[committed]i386: Fix zero/sign extend expanders [PR95229]

2020-05-20 Thread Uros Bizjak via Gcc-patches
2020-05-20 Uroš Bizjak gcc/ChangeLog: PR target/95229 * config/i386/sse.md (v8qiv8hi2): Use simplify_gen_subreg instead of simplify_subreg. (v8qiv8si2): Ditto. (v4qiv4si2): Ditto. (v4hiv4si2): Ditto. (v8qiv8di2): Ditto. (v4qiv4di2): Ditto. (v2qiv2di2): Ditto.

Re: [PATCH 2/2] rs6000: tune loop size for cunroll at O2

2020-05-20 Thread Segher Boessenkool
Hi! Yes, you can just use estimate_num_loop_insns afaics. On Wed, May 20, 2020 at 11:58:20AM +0800, Jiufu Guo wrote: >if (unroll_only_small_loops && optimize == 2) > { >if (maxiter >= 4 > - && !(TREE_CODE (niter) == INTEGER_CST && single_exit (loop))) > + && !(TREE_CO

Re: [PATCH] Tweak some powerpc tests for altivec_ok and vsx_ok

2020-05-20 Thread Douglas B Rupp
On 5/20/20 9:46 AM, Segher Boessenkool wrote: So, which spec are those 4 lines above from? From -with-specs= in the configure command.  We use that capability extensively for VxWorks. We have as DRIVER_SELF_SPECS (see rs6000.h) #define DRIVER_SELF_SPECS \ "%{mdejagnu-cpu=*: %Interesting.

Re: [PATCH] c++: C++20 DR 2237, disallow simple-template-id in cdtor.

2020-05-20 Thread Marek Polacek via Gcc-patches
Ping. On Mon, May 11, 2020 at 04:23:17PM -0400, Marek Polacek via Gcc-patches wrote: > On Sun, Apr 05, 2020 at 09:46:09PM -0400, Jason Merrill wrote: > > On 4/4/20 7:30 PM, Marek Polacek wrote: > > > This patch implements DR 2237 which says that a simple-template-id is > > > no longer valid as the

Re: [PATCH] Tweak some powerpc tests for altivec_ok and vsx_ok

2020-05-20 Thread Douglas B Rupp
Backporting the DRIVER_SELF_SPECS change fixed all the mdejagnu-cpu related tests. Thanks for your help on this. Consider this patch request withdrawn.  I'll resubmit one for the remaining failing tests for discussion. --Doug

[preprocessor] a few cleanups in c-family

2020-05-20 Thread Nathan Sidwell
Here are some small cleanups. The one bug fix is try_to_locate_new_include_insertion_point was using pointer comparison to compare strings. This usually works, because the line table doesn't duplicate file names. Except when reading preprocessed input. In that case this was failing horribly

Re: [PATCH 07/13] OpenACC 2.6 deep copy: libgomp parts

2020-05-20 Thread Julian Brown
On Wed, 20 May 2020 16:52:02 +0200 Thomas Schwinge wrote: > Hi! > > On 2019-12-17T22:03:47-0800, Julian Brown > wrote: > > --- a/libgomp/oacc-mem.c > > +++ b/libgomp/oacc-mem.c > > > static int > > -find_group_last (int pos, size_t mapnum, unsigned short *kinds) > > +find_group_last (int po

zstd not found if installed in non-system prefix

2020-05-20 Thread Michael Kuhn
Hi, when specifying a non-system prefix with --with-zstd, the build fails because the header and library cannot be found (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95005). The attached patch fixes the problem and is what we use in Spack to make GCC build with zstd support. Best regards,

[PATCH] Tweak some powerpc tests for vsx

2020-05-20 Thread Douglas B Rupp
Greetings, Here are a few proposed fsf-testsuite test tweaks for powerpc. Since there's no mcpu to validate the vsx extensions, may I suggest it is reasonable to check to see if they are supported? Your critique and criticism is of course welcomed. Douglas Rupp, AdaCore diff --git gcc/tes

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Segher Boessenkool
On Wed, May 20, 2020 at 12:30:30PM +0200, Richard Biener wrote: > I think this is the wrong way to approach this. You're doing too many > things at once. Try to fix the powerpc regression with the extra > flag_rtl_unroll_loops, that could be backported. Then you can > independently see whether e

[PATCH] More c++ math reject macros

2020-05-20 Thread Douglas B Rupp
Greetings Alex, You added some math reject macros on 2020-01-23 in gcc-10.  Here are a few more. If approved, also request permission to backport to gcc-10 branch. --Douglas Rupp, AdaCore diff --git libstdc++-v3/configure libstdc++-v3/configure index 502f6602001..6b54078ad79 100755 --- libs

Re: [PATCH] c++: C++20 DR 2237, disallow simple-template-id in cdtor.

2020-05-20 Thread Jason Merrill via Gcc-patches
On 5/20/20 2:05 PM, Marek Polacek wrote: Ping. OK (with 2a->20, of course). Jason On Mon, May 11, 2020 at 04:23:17PM -0400, Marek Polacek via Gcc-patches wrote: On Sun, Apr 05, 2020 at 09:46:09PM -0400, Jason Merrill wrote: On 4/4/20 7:30 PM, Marek Polacek wrote: This patch implements DR

Re: [preprocessor] a few cleanups in c-family

2020-05-20 Thread Nathan Sidwell
On 5/20/20 2:22 PM, Nathan Sidwell wrote: Here are some small cleanups. The one bug fix is try_to_locate_new_include_insertion_point was using pointer comparison to compare strings.  This usually works, because the line table doesn't duplicate file names.  Except when reading preprocessed inp

Re: [PATCH] Tweak some powerpc tests for altivec_ok and vsx_ok

2020-05-20 Thread Segher Boessenkool
Hi! On Wed, May 20, 2020 at 10:56:21AM -0700, Douglas B Rupp wrote: > >So, which spec are those 4 lines above from? > From -with-specs= in the configure command.  We use that > capability extensively for VxWorks. static const char *const driver_self_specs[] = { "%{fdump-final-insns:-fdump-fina

Re: [PATCH] TESTSUITE: Fix tests for 16-bit targets

2020-05-20 Thread Jozef Lawrynowicz
On Wed, May 20, 2020 at 03:37:30PM +0200, Christophe Lyon via Gcc-patches wrote: > Hi, > > > > On Mon, 18 May 2020 at 14:42, Jozef Lawrynowicz > wrote: > > > > On Fri, May 15, 2020 at 10:48:56PM +, Joseph Myers wrote: > > > On Fri, 15 May 2020, Jozef Lawrynowicz wrote: > > > > > > > The att

Re: [PATCH] x86: Add -mavoid-libcall for -mgeneral-regs-only

2020-05-20 Thread Jeff Law via Gcc-patches
On Fri, 2020-05-15 at 08:11 +0200, Uros Bizjak via Gcc-patches wrote: > On Fri, May 15, 2020 at 1:13 AM H.J. Lu wrote: > > The -mgeneral-regs-only option generates code that uses only the > > general-purpose registers. It prevents the compiler from using vector > > registers. But GCC may still g

[PATCH] Suggest including or for [u]int[8|16|32|64]_t

2020-05-20 Thread Mark Wielaard
Plus [u]intptr_t and associated constants. Refactor the bool, true, false, code so it fits into the new table based design. gcc/c-family/ChangeLog: * known-headers.cc (get_stdlib_header_for_name): Add a new gcc/testsuite/ChangeLog: * gcc.dg/spellcheck-stdint.c: New test.

Re: [RFC] analyzer: Add exit, and _exit replacement, to sm-signal.

2020-05-20 Thread Mark Wielaard
Hi, On Mon, May 18, 2020 at 07:30:58PM -0400, Marek Polacek wrote: > > + /* Returns a replacement function as text if it exists. Currently > > + only "exit" has a signal-safe replacement "_exit", which does > > + slightly less, but can be used in a signal handler. */ > > + const char *

[PATCH v2] Add -fuse-ld= to specify an arbitrary executable as the linker

2020-05-20 Thread Fangrui Song via Gcc-patches
On 2020-05-20, Martin Liška wrote: Hello. Thanks for review. Sent PATCH v2. diff --git a/gcc/collect2.c b/gcc/collect2.c index f8a5ce45994..e04892cb91f 100644 --- a/gcc/collect2.c +++ b/gcc/collect2.c @@ -782,15 +782,16 @@ main (int argc, char **argv) USE_GOLD_LD, USE_BFD_LD,

[committed] i386: Do not use commutative operands with (use) RTX [PR95238]

2020-05-20 Thread Uros Bizjak via Gcc-patches
2020-05-21 Uroš Bizjak gcc/ChangeLog: PR target/95218 * config/i386/mmx.md (*mmx_v2sf): Do not mark operands 1 and 2 commutative. Manually swap operands. (*mmx_nabsv2sf2): Ditto. Partially revert: 2020-05-18 Uroš Bizjak * config/i386/i386.md (*tf2_1): Mark

[committed] libstdc++: Use 'using' for types in Networking TS headers

2020-05-20 Thread Jonathan Wakely via Gcc-patches
* include/experimental/buffer: Replace typedefs with alias-declarations. * include/experimental/executor: Likewise. * include/experimental/internet: Likewise. * include/experimental/socket: Likewise. * include/experimental/timer: Likewise. Tested pow

gcc-patches@gcc.gnu.org

2020-05-20 Thread Jonathan Wakely via Gcc-patches
Also add some missing member functions, nodiscard attributes, and noexcept-specifiers. * include/experimental/executor (use_future_t::use_future_t()): Fix incorrect noexcept-specifier. * include/experimental/internet (basic_resolver_results): Adjust whitespace.

[committed] libstdc++: Better requirements checking in Networking TS

2020-05-20 Thread Jonathan Wakely via Gcc-patches
Define concepts and traits for checking type requirements. * include/experimental/bits/net.h (__endpoint, __protocol) (__acceptable_protocol, __inet_protocol): New concepts. (__detail::__is_endpoint): Move trait from . (__is_protocol, __is_acceptable_protocol, __is_

gcc-patches@gcc.gnu.org

2020-05-20 Thread Jonathan Wakely via Gcc-patches
On 21/05/20 01:01 +0100, Jonathan Wakely wrote: Also add some missing member functions, nodiscard attributes, and noexcept-specifiers. * include/experimental/executor (use_future_t::use_future_t()): Fix incorrect noexcept-specifier. * include/experimental/internet (basic_

Re: [PATCH] c++: template instantiation during fold_for_warn [PR94038]

2020-05-20 Thread Patrick Palka via Gcc-patches
On Tue, 19 May 2020, Jason Merrill wrote: > On 5/8/20 11:42 AM, Patrick Palka wrote: > > On Wed, 6 May 2020, Patrick Palka wrote: > > > > > On Wed, 6 May 2020, Patrick Palka wrote: > > > > > > > On Tue, 5 May 2020, Patrick Palka wrote: > > > > > > > > > On Tue, 5 May 2020, Patrick Palka wrote:

Re: [PATCH] c++: template instantiation during fold_for_warn [PR94038]

2020-05-20 Thread Patrick Palka via Gcc-patches
On Wed, 20 May 2020, Patrick Palka wrote: > On Tue, 19 May 2020, Jason Merrill wrote: > > > On 5/8/20 11:42 AM, Patrick Palka wrote: > > > On Wed, 6 May 2020, Patrick Palka wrote: > > > > > > > On Wed, 6 May 2020, Patrick Palka wrote: > > > > > > > > > On Tue, 5 May 2020, Patrick Palka wrote: >

[PATCH] contrib/gen_autofdo_event.py: Allow for it to work if there are more than 3 hyphens in Family-model

2020-05-20 Thread Javad Karabi via Gcc-patches
Perfmon mapfile Family-model's can contain 4 hyphens, e.g. "GenuineIntel-6-55-[56789ABCDEF]" This simply slices the hyphen-split Family-model to the first 3 elements, so that the list unpack does not throw an exception saying that there are too many values to unpack. diff --git a/contrib/gen_auto

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-20 Thread Jiufu Guo via Gcc-patches
Segher Boessenkool writes: > On Wed, May 20, 2020 at 12:30:30PM +0200, Richard Biener wrote: >> I think this is the wrong way to approach this. You're doing too many >> things at once. Try to fix the powerpc regression with the extra >> flag_rtl_unroll_loops, that could be backported. Then you

Re: [PATCH][PR92658] Add missing vector truncmn2 expanders for avx512f

2020-05-20 Thread Hongtao Liu via Gcc-patches
On Wed, May 20, 2020 at 11:43 PM Uros Bizjak wrote: > > On Wed, May 20, 2020 at 10:35 AM Hongtao Liu wrote: > > > > Hi: > > Bootstrap is ok, regression test on i386/x86-64 backend is ok. > > > > gcc/ChangeLog: > > PR target/92658 > > * config/i386/sse.md > > (trunc2, tru

[PATCH] libgfortran: Use __builtin_cpu_is/__builtin_cpu_supports

2020-05-20 Thread H.J. Lu via Gcc-patches
* m4/matmul.m4: Don't include . Use __builtin_cpu_is/__builtin_cpu_supports * generated/matmul_c10.c: Regenerated. * generated/matmul_c16.c: Likewise. * generated/matmul_c4.c: Likewise. * generated/matmul_c8.c: Likewise. * generated/matmul_i1

[committed] libstdc++: Avoid constraint recursion with iterator_traits (PR 93983)

2020-05-20 Thread Jonathan Wakely via Gcc-patches
Checking whether a filesystem::path constructor argument is an iterator requires instantiating std::iterator_traits. In C++20 that checks for satisfaction of std::iterator_traits constraints, which checks if the type is copyable, which can end up recursing back to the path constructor. The fix in L