Hi,
On Mon, 18 May 2020 at 14:42, Jozef Lawrynowicz
<joze...@mittosystems.com> wrote:
>
> On Fri, May 15, 2020 at 10:48:56PM +0000, Joseph Myers wrote:
> > On Fri, 15 May 2020, Jozef Lawrynowicz wrote:
> >
> > > The attached patch fixes many GCC and G++ tests for 16-bit targets. These
> > > targets can have the following properties:
> > > - "int", "size_t", "ptrdiff_t", "void *" are 16-bit types
> > > - sizeof(int) == sizeof(short)
> >
> > Some of the tests are disabled by the patch for the case where pointers
> > are the same size as int. Were those tests all previously failing for
> > 32-bit targets where that's the case? If not, ptr_eq_int seems an
> > inappropriate condition for disabling them.
>
> Ah yes, regarding g++.dg/init/new44.C, it seems that i386-pc-linux-gnu
> does require an array size cookie even though ptr_eq_int (in fact,
> since the decision relates to size_t, a pointer size effective target
> shouldn't
> have been used anyway). I'll amend the condition so it is skipped for msp430
> only.
>
> The other test using ptr_eq_int (g++.dg/init/const7.C) is also passing
> on i386-pc-linux-gnu, so I'll amend that as well.
>
> I'll make sure to do a full regtest on i386-pc-linux-gnu before
> applying.
>
I've noticed regressions on aarch64 with -mabi=ilp32:
g++.dg/warn/Wconversion-null-2.C -std=gnu++14 (test for warnings, line 37)
g++.dg/warn/Wconversion-null-2.C -std=gnu++14 (test for warnings, line 60)
g++.dg/warn/Wconversion-null-2.C -std=gnu++17 (test for warnings, line 37)
g++.dg/warn/Wconversion-null-2.C -std=gnu++17 (test for warnings, line 60)
g++.dg/warn/Wconversion-null-2.C -std=gnu++2a (test for warnings, line 37)
g++.dg/warn/Wconversion-null-2.C -std=gnu++2a (test for warnings, line 60)
g++.dg/warn/Wconversion-null-2.C -std=gnu++98 (test for warnings, line 37)
g++.dg/warn/Wconversion-null-2.C -std=gnu++98 (test for warnings, line 60)
The logs say:
/gcc/testsuite/g++.dg/warn/Wconversion-null-2.C:37:9: error: call of
overloaded 'g(NULL)' is ambiguous
/gcc/testsuite/g++.dg/warn/Wconversion-null-2.C:60:11: error: call of
overloaded 'g(NULL)' is ambiguous
Can you check/fix?
Thanks
Christophe
> Thanks,
> Jozef
>
> >
> > --
> > Joseph S. Myers
> > jos...@codesourcery.com
