RE: [PATCH] Fix PR54733 Optimize endian independent load/store

> From: Christophe Lyon [mailto:christophe.l...@linaro.org] > On 29 May 2014 11:58, Thomas Preud'homme > wrote: > > > > Does the patch solve the problem you had? What about you Christophe? > > > > > > Hi Thomas, > > After a quick test, it looks OK to me. Great. What about you Andreas? Does it w

Re: [PATCH, Pointer Bounds Checker 21/x] Weakrefs output

On 06/02/14 09:22, Ilya Enkovich wrote: Hi, This patch prevents output of both instrumented and not instrumented weakref variants. Thanks, Ilya -- gcc/ 2014-06-02 Ilya Enkovich * cgraphunit.c (output_weakrefs): If there are both instrumented and original versions, output o

Re: [C PATCH] Better location for switch warnings (PR c/30020)

On 06/04/14 00:46, Marek Polacek wrote: It is trivial to pass the location from c_add_case_label down to check_case_bounds, so do that. With it, we instead of i.c:4:3: warning: case label value is less than minimum value for type switch (c) { case 42: case -1: return -1; }; ^ output i.c

Re: [PATCH, Pointer Bounds Checker 23/x] Function split

On 06/03/14 01:10, Ilya Enkovich wrote: Hi, This patch does not allow splitting in case bounds are returned until retutrned bounds are supported. It also propagates instrumentation marks for generated call and function. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-

Re: [C PATCH] Don't reject valid code with _Alignas (PR c/61053)

On 06/02/14 00:52, Marek Polacek wrote: Ping. On Sun, May 25, 2014 at 11:30:51AM +0200, Marek Polacek wrote: On Mon, May 05, 2014 at 10:27:03PM +0200, Marek Polacek wrote: In this PR the issue is that we reject (valid) code such as _Alignas (long long) long long foo; with -m32, because we trip

Re: [build, doc, testsuite] Centralise clearing hardware capabilities with Sun ld

On 05/27/14 02:04, Rainer Orth wrote: It's been a week since I've submitted the patch, so far having received approval for the testsuite parts only. While I don't need approval for the Solaris-only parts, it would be good if the doc and build changes could be checked by the respective maintaine

Re: [PATCH] Fix PR middle-end/61141

On 05/24/14 12:39, John David Anglin wrote: The insns are being deleted in "final" after the assembly output has being done. So, for example, pa_output_call is never called with a delayed branch sequence containing a NOTE_INSN_DELETED. OK. That's good to know. I scanned final and final_scan_i

Re: Fix a function decl in gfortran

Still untested patch, but I cannot resist pointing out stupid typos by myself. I intent to tests the build and test the patch - and then to commit it as obvious. If you see problems with this approach please scream now. On Wed, Jun 04, 2014 at 08:13:44AM +0200, Tobias Burnus wrote: > + To be u

Re: [PATCH, Pointer Bounds Checker 6/x] New static constructor types

On 04/16/14 06:33, Ilya Enkovich wrote: Hi, This patch add new static constructor types used by Pointer Bounds Checker. It was approved earlier for 4.9 and I'll assume patch is OK for trunk if no objections arise. Patch was bootstrapped and tested for linux-x86_64. Thanks, Ilya -- gcc/ 201

Re: PR61385: phiopt drops some PHIs

On Tue, 3 Jun 2014, Jeff Law wrote: On 06/03/14 08:08, Richard Biener wrote: All arguments get the same value (and the PHI in middle-bb is surely a singleton?), so it's way better to re-materialize the PHI as a gimple assignment at the start of the basic block. If they are singletons (which I

Re: [PATCH, Pointer Bounds Checker 5/x] Attributes

On 04/16/14 06:26, Ilya Enkovich wrote: Hi, This patch introduces attributes used by Pointer Bounds Checker. Comparing to what was approved for 4.9, this one has additional attribute 'bnd_instrument' to be used for selective instrumentation. Bootstrapped and tested on linux-x86_64. OK for t

Re: PR61385: phiopt drops some PHIs

On 06/04/14 01:46, Marc Glisse wrote: On Tue, 3 Jun 2014, Jeff Law wrote: On 06/03/14 08:08, Richard Biener wrote: All arguments get the same value (and the PHI in middle-bb is surely a singleton?), so it's way better to re-materialize the PHI as a gimple assignment at the start of the basic b

Re: [PATCH, Pointer Bounds Checker 13/x] Early versioning

2014-06-04 10:46 GMT+04:00 Jeff Law : > On 06/03/14 03:29, Richard Biener wrote: >> >> On Tue, Jun 3, 2014 at 7:55 AM, Ilya Enkovich >> wrote: >>> >>> 2014-06-02 21:27 GMT+04:00 Jeff Law : On 06/02/14 04:48, Ilya Enkovich wrote: >> >> >> Hmm, so if I understand things correct

Re: [build, doc, testsuite] Centralise clearing hardware capabilities with Sun ld

Jeff Law writes: > On 05/27/14 02:04, Rainer Orth wrote: >> >> It's been a week since I've submitted the patch, so far having received >> approval for the testsuite parts only. >> >> While I don't need approval for the Solaris-only parts, it would be good >> if the doc and build changes could be

Re: [patch, testsuite] Fix PR 49191 with test for STRICT_ALIGNMENT

On 06/08/11 22:51, Steve Ellcey wrote: On Wed, 2011-06-08 at 22:19 +0200, Jakub Jelinek wrote: On Wed, Jun 08, 2011 at 01:16:26PM -0700, Steve Ellcey wrote: On Wed, 2011-06-08 at 22:08 +0200, Jakub Jelinek wrote: On Wed, Jun 08, 2011 at 01:03:53PM -0700, Steve Ellcey wrote: 2011-06-08 Steve

Re: [build, driver] RFC: Support compressed debug sections

Mike Stump writes: > On Jun 3, 2014, at 3:40 AM, Rainer Orth wrote: >> It's been another week, and I still need approval for the build, doc, >> and Darwin changes: > > So, the darwin bits look trivial enough, if the entire scheme is what > people want to do. My question would be, why do we want

Re: [PATCH][AARCH64]Support full addressing modes for ldr/str in vectorization scenarios

On 4 June 2014 03:11, Bin.Cheng wrote: > Yes, If there is a PR, I can evaluate how this can help and ask > release maintainer for approval. I'll reduce the test case and create one shortly

Re: PR61385: phiopt drops some PHIs

On Tue, Jun 3, 2014 at 10:30 PM, Marc Glisse wrote: > On Tue, 3 Jun 2014, Richard Biener wrote: > >> On Tue, Jun 3, 2014 at 3:48 PM, Marc Glisse wrote: >>> >>> Hello, >>> >>> apparently it is possible to have a PHI in the middle basic block of >>> value_replacement, so I need to move it as well w

RE: [PATCH ARM] Improve ARM memset inlining

Ping^4. The original thread is https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00182.html, also there is some info at https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00182.html in the same thread. Thanks, bin > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > o

Re: Eliminate write-only variables

On Tue, Jun 3, 2014 at 6:19 PM, Jan Hubicka wrote: >> On Mon, Jun 2, 2014 at 8:59 PM, Jan Hubicka wrote: >> >> >> >> Yeah, I discussed this with martin today on irc. For aliasing we'd like >> >> to know whether a decl possibly has its address taken. Currently we only >> >> trust TREE_ADDRESSAB

[PATCH] Adding myself to Write After Approval in MAINTAINERS

Hi all, I forgot to add myself to the MAINTAINERS file when I got Write After Approval access. This patch does just this (already commited as specified on the website): diff --git a/ChangeLog b/ChangeLog index d35b315..80e9600 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2014-06-04 T

Re: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

On Wed, Jun 4, 2014 at 7:59 AM, Thomas Preud'homme wrote: > When bswap replace a bitwise expression involving a memory source by a load > possibly followed by a bswap, it is possible that the load has a size smaller > than that of the target expression where the bitwise expression was affected.

Re: [PATCH] Fix PR61320: disable bswap for unaligned access on SLOW_UNALIGNED_ACCESS targets

On Wed, Jun 4, 2014 at 8:07 AM, Thomas Preud'homme wrote: > Hi there, > > It seems from PR61320 that the bswap pass causes some problems when it > replaces > an OR expression by an unaligned access. Although it's not clear yet why the > unaligned load does not go through the extract_bit_field cod

Re: [PATCH, i386, Pointer Bounds Checker 10/x] Partitions

On Tue, Jun 3, 2014 at 11:24 PM, Jeff Law wrote: > On 06/02/14 05:41, Richard Biener wrote: >> >> >> this should be all moved to the symbol table level. (and IDENTIFIER_NODE >> shouldn't have to have tree_common.chain and thus become smaller). > > Which ought to be independent of the pointer chec

Re: [PATCH] Fix PR54733 Optimize endian independent load/store

On Wed, Jun 4, 2014 at 9:04 AM, Thomas Preud'homme wrote: >> From: Christophe Lyon [mailto:christophe.l...@linaro.org] >> On 29 May 2014 11:58, Thomas Preud'homme >> wrote: >> > >> > Does the patch solve the problem you had? What about you Christophe? >> > >> > >> >> Hi Thomas, >> >> After a quic

Re: [PATCH, Pointer Bounds Checker 6/x] New static constructor types

On Wed, Apr 16, 2014 at 2:33 PM, Ilya Enkovich wrote: > Hi, > > This patch add new static constructor types used by Pointer Bounds Checker. > It was approved earlier for 4.9 and I'll assume patch is OK for trunk if no > objections arise. > > Patch was bootstrapped and tested for linux-x86_64. >

Re: [PATCH, Pointer Bounds Checker 13/x] Early versioning

On Wed, Jun 4, 2014 at 8:46 AM, Jeff Law wrote: > On 06/03/14 03:29, Richard Biener wrote: >> >> On Tue, Jun 3, 2014 at 7:55 AM, Ilya Enkovich >> wrote: >>> >>> 2014-06-02 21:27 GMT+04:00 Jeff Law : On 06/02/14 04:48, Ilya Enkovich wrote: >> >> >> Hmm, so if I understand thi

Re: PR61385: phiopt drops some PHIs

On Wed, Jun 4, 2014 at 9:59 AM, Jeff Law wrote: > On 06/04/14 01:46, Marc Glisse wrote: >> >> On Tue, 3 Jun 2014, Jeff Law wrote: >> >>> On 06/03/14 08:08, Richard Biener wrote: All arguments get the same value (and the PHI in middle-bb is surely a singleton?), so it's way better to

[PATCH][1/2] Improve DSE

This first patch improves DSE by improving the handling of references with non-invariant addresses such as a->b[i].c in stmt_kills_ref_p_1. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2014-06-04 Richard Biener * tree-ssa-alias.c (stmt_may_clobber_ref_p):

RE: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

> From: Richard Biener [mailto:richard.guent...@gmail.com] > > I'd rather change the comparisons > > - if (n->size < (int)sizeof (int64_t)) > -n->n &= ((uint64_t)1 << (n->size * BITS_PER_UNIT)) - 1; > + if (bitsize / BITS_PER_UNIT < (int)sizeof (int64_t)) > +n->n &= ((uint64_t)1 << bits

[PATCH][2/2] Improve DSE

This improves DSE by not stopping to look for a killing stmt at the first may-alias but instead continue looking for a kill (well, until we hit a may-use or run into limitations of the walker). This fixes some embarrassing missing dead store eliminations (it's also more expensive, but the walking

Re: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

On Wed, Jun 4, 2014 at 12:42 PM, Thomas Preud'homme wrote: >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> >> I'd rather change the comparisons >> >> - if (n->size < (int)sizeof (int64_t)) >> -n->n &= ((uint64_t)1 << (n->size * BITS_PER_UNIT)) - 1; >> + if (bitsize / BITS_PER_

Re: [build, driver] RFC: Support compressed debug sections

On Jun 4, 2014, at 1:54 AM, Rainer Orth wrote: > Mike Stump writes: >> On Jun 3, 2014, at 3:40 AM, Rainer Orth >> wrote: >>> It's been another week, and I still need approval for the build, doc, >>> and Darwin changes: >> >> So, the darwin bits look trivial enough, if the entire scheme is what

RE: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

> From: Richard Biener [mailto:richard.guent...@gmail.com] > > Err, but if you zero-extend directly to the target type you have the > correct result, too. Yep but in some case we need sign extend (32 bit bitwise OR stored into 64 bit result). As I said, the logic could be simplified by sign exten

RE: [Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

Ping. I have changed the subject line accordingly. Regards, Rohit > -Original Message- > From: David Edelsohn [mailto:dje@gmail.com] > Sent: Thursday, May 08, 2014 9:28 PM > To: Dharmakan Rohit-B30502; Jakub Jelinek; Richard Biener > Cc: Alan Modra; gcc-patches@gcc.gnu.org; Wienskoski

Re: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

On Wed, Jun 4, 2014 at 1:15 PM, Thomas Preud'homme wrote: >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> >> Err, but if you zero-extend directly to the target type you have the >> correct result, too. > > Yep but in some case we need sign extend (32 bit bitwise OR stored > into 64

Re: [PATCH][AARCH64]Support full addressing modes for ldr/str in vectorization scenarios

On 4 June 2014 10:06, Charles Baylis wrote: > On 4 June 2014 03:11, Bin.Cheng wrote: > >> Yes, If there is a PR, I can evaluate how this can help and ask >> release maintainer for approval. > > I'll reduce the test case and create one shortly I have created PR61411 with a reduced test case.

Re: PR61385: phiopt drops some PHIs

On Wed, 4 Jun 2014, Richard Biener wrote: So I'd say we should instead simply bail out if the middle-bb has a PHI node. Sounds good to me, so I am testing the mini-patch I had originally posted to bugzilla: 2014-06-04 Marc Glisse PR tree-optimization/61385 gcc/ * tree-ss

Re: PR61385: phiopt drops some PHIs

On Wed, Jun 4, 2014 at 1:20 PM, Marc Glisse wrote: > On Wed, 4 Jun 2014, Richard Biener wrote: > >> So I'd say we should instead simply bail out if the middle-bb has a PHI >> node. > > > Sounds good to me, so I am testing the mini-patch I had originally posted to > bugzilla: Ok. Thanks, Richard.

Re: Fix a function decl in gfortran

On 06/04/2014 09:40 AM, Tobias Burnus wrote: Still untested patch, but I cannot resist pointing out stupid typos by myself. I intent to tests the build and test the patch - and then to commit it as obvious. If you see problems with this approach please scream now. I have no idea about the appr

Re: [C++ Patch] PR 43453

Hi, On 05/26/2014 05:41 PM, Paolo Carlini wrote: ... the below should be better, handles correctly cv-qualifiers. Pinging this... Thanks! Paolo.

[PATCH][match-and-simplify] Restore bootstrap somewhat

The following patche is necessary to get to stage2 target library building. Bootstrapped until that point, applied. Richard. 2014-06-04 Richard Biener * genmatch.c (error_cb, fatal_at): Annotate with printf format attribute to silence warning. * gimple-match-head.c (

[PATCH][match-and-simplify] Fix cut&paste error

Committed. Hopefully that restores bootstrap ... Richard. 2014-06-04 Richard Biener * gimple-match-head.c (gimple_match_and_simplify): Fix cut&paste error. Index: gcc/gimple-match-head.c === --- gcc/gimple-matc

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

On Tue, 3 Jun 2014, Richard Sandiford wrote: > Sandra Loosemore writes: > > Catherine included an earlier version of this patch with the microMIPS > > submission a couple years ago: > > > > https://gcc.gnu.org/ml/gcc-patches/2012-07/msg00972.html > > > > Richard's response was: > > > >> Looks li

Re: [patch i386]: Fix PR/46219 Generate indirect jump instruction

So after SIBLING_CALL_P flags gets now preserved in peep2_attempt, the patch simplifies. Regression tested for x86_64-unknown-linux-gnu, and i686-pc-cygwin. Ok for apply (with ChangeLog plus testcase adjustment as done by initial patch)? Index: config/i386/i386.md

[PATCH] Spurious .s with -fdump-ada-spec

Hello, Currently, GCC outputs ".s" assembly files when running on C/C++ header files with -fdump-ada-spec. This is unexpected, since -fdump-ada-spec is used only to output an Ada binding. This patch fixes the spec-strings for C/C++ header files in order to pass a "-o %g.s" flag to cc1/cc1plu

Re: [PATCH, Pointer Bounds Checker 6/x] New static constructor types

2014-06-04 13:58 GMT+04:00 Richard Biener : > On Wed, Apr 16, 2014 at 2:33 PM, Ilya Enkovich wrote: >> Hi, >> >> This patch add new static constructor types used by Pointer Bounds Checker. >> It was approved earlier for 4.9 and I'll assume patch is OK for trunk if no >> objections arise. >> >>

Re: patch to fix PR61325

On 4 June 2014 00:02, James Greenhalgh wrote: > On Thu, May 29, 2014 at 06:38:22PM +0100, Vladimir Makarov wrote: >> The following patch PR61325. The details can be found on >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61325 >> >> The patch was bootstrapped and tested on x86/x86-64. >>

Re: [PATCH] Fix logic for detection of zero initializer (PR c/53119)

On Mon, Jun 02, 2014 at 12:58:53AM -0400, S. Gilles wrote: Thanks for tackling this. > @@ -6858,6 +6858,9 @@ > /* 1 if this constructor is erroneous so far. */ > static int constructor_erroneous; > > +/* 1 if this constructor is the universal zero initializer { 0 } */ ". */" at the end of

[PATCH, PR 61391]

Hi All, Here is a simple fix for 61391 - missed a check that statement basic block is inside loop. With this fix test-case from bug is compiled successfully. Bootstrap and regression testing did not show any new failures. Is it OK for trunk? ChangeLog: 2014-06-04 Yuri Rumyantsev PR tree-op

Re: [PATCH, Pointer Bounds Checker 6/x] New static constructor types

On Wed, Jun 4, 2014 at 3:13 PM, Ilya Enkovich wrote: > 2014-06-04 13:58 GMT+04:00 Richard Biener : >> On Wed, Apr 16, 2014 at 2:33 PM, Ilya Enkovich >> wrote: >>> Hi, >>> >>> This patch add new static constructor types used by Pointer Bounds Checker. >>> It was approved earlier for 4.9 and I'l

Re: [PATCH, PR 61391]

On Wed, Jun 4, 2014 at 3:17 PM, Yuri Rumyantsev wrote: > Hi All, > > Here is a simple fix for 61391 - missed a check that statement basic > block is inside loop. With this fix test-case from bug is compiled > successfully. > > Bootstrap and regression testing did not show any new failures. > > Is

Re: [PATCH, PR 61391]

On Wed, Jun 4, 2014 at 3:37 PM, Richard Biener wrote: > On Wed, Jun 4, 2014 at 3:17 PM, Yuri Rumyantsev wrote: >> Hi All, >> >> Here is a simple fix for 61391 - missed a check that statement basic >> block is inside loop. With this fix test-case from bug is compiled >> successfully. >> >> Bootstr

[PATCH][match-and-simplify] Remove remaining stmt expression uses

This removes the code-generation ones by simply passing the destination to the generators. It also fixes the last remaining warning (just introduced) and removes the -Wno-error -fpermissive flags from building gimple-match.o. Bootstrapped on x86_64-unknown-linux-gnu, applied. Richard. 2014-06-

[PATCH] Trust TREE_ADDRESSABLE

This makes may_be_aliased trust TREE_ADDRESSABLE setting for exported decls. This should make it possible for LTO to compute more optimistic aliasing and removes the pessimization with respective to aliasing that currently LTO brought global (but hidden visibility) statics cause. Bootstrapped an

Re: [patch][gomp4] openacc loops

Hi Cesar! This patch, which is derived from Ilmir Usmanov's work posted here , implements the loop directive in openacc. The original patch is mostly intact, Thank you! I looked through the patch and found that you also added middle-end

[Patch,testsuite] Fix bind_pic_locally

Hello, This is to follow up the patch I had posted to fix bind_pic_locally some time ago (sorry, this went in to my back log for a while). To summarize, multilib_flags when it contains -fpic or -fPIC, overrides -fpie or -fPIE that is added by bind_pic_locally. The fix that was finally agreed on

[Patch,testsuite] Fix tests that fail due to symbol visibility when -fPIC

Hello, The following test cases fail when -fPIC is passed as dejagnu multilib flag since -fPIC causes the 'availability' of the functions to be overwritable. I have fixed this by adding bind_pic_locally to these cases. gcc.dg/fail_always_inline.c gcc.dg/inline-22.c gcc.dg/inline_4.c

Re: [C++ Patch] PR 43453

On 05/26/2014 11:41 AM, Paolo Carlini wrote: + /* C++11 8.5/17: "If the destination type is an array of characters, +an array of char16_t, an array of char32_t, or an array of wchar_t, +and the initializer is a string literal...". */ + else if (TREE_CODE (newrhs) == STR

[PATCH] Fix non-register vector temporaries created from SAVE_EXPRs

This removes an odd restriction in lookup_tmp_vars helper create_tmp_from_val. That conditionalizes whether vector and complex variables get to have a register based on whether the tmp var is a formal one or not. But that can't matter for correctness, either all temporaries can get a register or

Re: [PATCH, Pointer Bounds Checker 19/x] Support bounds in expand

Hi, On Mon, 2 Jun 2014, Ilya Enkovich wrote: > > There is exactly one place (except for the self-recursive ones) where > > you call the new store_expr with a non-null argument for bounds > > target, and it seems to be only necessary for when some sub-expression > > of the RHS is a call. Can y

Re: [PATCH, PR 61391]

Richard. Here is update patch with test-case and new ChangeLog. gcc/ChangeLog 2014-06-04 Yuri Rumyantsev PR tree-optimization/61319 * tree-if-conv.c (is_cond_scalar_reduction): Add missed check that stmt belongs to loop. gcc/testsuite/ChangeLog * gcc.dg/torture/pr61319.c: New test. 2014-06

Re: [PATCH, PR 61391]

On Wed, Jun 04, 2014 at 07:11:26PM +0400, Yuri Rumyantsev wrote: > Here is update patch with test-case and new ChangeLog. If approved, please avoid the DOS style line endings in the testcase. Jakub

Re: [PATCH, PR 61391]

Yuri Rumyantsev writes: > Property changes on: testsuite/gcc.dg/torture/pr61391.c > ___ > Added: svn:executable Don't make the file executable. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8

Re: [PATCH, PR 61391]

I converted test-case to Unix format and new patch is attached. 2014-06-04 19:14 GMT+04:00 Jakub Jelinek : > On Wed, Jun 04, 2014 at 07:11:26PM +0400, Yuri Rumyantsev wrote: >> Here is update patch with test-case and new ChangeLog. > > If approved, please avoid the DOS style line endings in the te

Re: [PATCH, PR 61391]

Sorry, I sent you 'bad' patch, resend it. 2014-06-04 19:19 GMT+04:00 Yuri Rumyantsev : > I converted test-case to Unix format and new patch is attached. > > 2014-06-04 19:14 GMT+04:00 Jakub Jelinek : >> On Wed, Jun 04, 2014 at 07:11:26PM +0400, Yuri Rumyantsev wrote: >>> Here is update patch with

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

On 06/04/2014 06:20 AM, Richard Biener wrote: On Tue, 3 Jun 2014, Richard Sandiford wrote: Richi suggested just changing the alignment at output time. I assume that would be a case of replacing the DECL_ALIGN in: /* Tell assembler to move to target machine's alignment for functions. */

C++ PATCH for c++/61382 (init-list evaluation order)

My patch for 51253 didn't handle all cases of this; I was forgetting that when we direct-initialize a variable, we never build an AGGR_INIT_EXPR. So let's handle this in cp_gimplify_expr. Tested x86_64-pc-linux-gnu, applying to trunk. commit 2cddc650aac580698d4ff47c31670f168aa3ce31 Author: Jas

[PATCH] Don't call init_caller_save if LRA enabled

LRA generate caller-save register store/restore during split register, not generate by caller-save.c:save_call_clobbered_regs, so initialize this module by init_caller_save is meaningless if LRA enabled 2014-06-05 Kito Cheng * ira.c (ira): Don't call init_caller_save if LRA enabled since LRA

Re: [PATCH] Fix logic for detection of zero initializer (PR c/53119)

On Wed, Jun 04, 2014 at 03:15:02PM +0200, Marek Polacek wrote: > On Mon, Jun 02, 2014 at 12:58:53AM -0400, S. Gilles wrote: > > Thanks for tackling this. > > > @@ -6858,6 +6858,9 @@ > > /* 1 if this constructor is erroneous so far. */ > > static int constructor_erroneous; > > > > +/* 1 if th

Re: emit __float128 typeinfo

How about, in emit_support_tinfos, using type_for_mode to check for a TF-mode floating point type different from long_double_type_node? Jason

Re: [PATCH 2/2, x86] Add palignr support for AVX2.

Is it ok to use the following pattern? patch passed bootstrap and make check, but one test failed: gcc/testsuite/gcc.target/i386/vect-rebuild.c It failed on /* { dg-final { scan-assembler-times "\tv?permilpd\[ \t\]" 1 } } */ which is now palignr. However, both palignr and permilpd costs 1 tick and

[gomp4] Missing -fopenacc handling (was: Dumping gimple for offload.)

Hi! On Tue, 19 Nov 2013 13:58:29 +0400, Ilya Tocar wrote: > * cgraph.h (symtab_node): Add need_dump. > * cgraphunit.c (ipa_passes): Run ipa_write_summaries for omp. > (compile): Intialize streamer for omp. > * ipa-inline-analysis.c (inline_generate_summary): Add flag_open

Re: Fix a function decl in gfortran

On 06/04/2014 09:40 AM, Tobias Burnus wrote: Still untested patch, but I cannot resist pointing out stupid typos by myself. I intent to tests the build and test the patch - and then to commit it as obvious. If you see problems with this approach please scream now. Even with this applied, I'm s

Re: [PATCH 3/5] Make recog_op_alt consumers check the enabled attribute

Thanks for the reviews, now committed Jeff Law writes: > On 05/31/14 03:15, Richard Sandiford wrote: >> As described in the covering note, it seems better to put the onus of >> checking the enabled attribute on the passes that are walking each >> alternative, like LRA does for its internal subpas

Re: [PATCH 0/5] Cache recog_op_alt by insn code, take 2

Jeff Law writes: > On 05/31/14 03:02, Richard Sandiford wrote: >> A second difference was that preprocess_constraints skips disabled >> alternatives while LRA's setup_operand_alternative doesn't; LRA just >> checks for disabled alternatives when walking the array instead. >> That should make no di

Re: RFA: Make LRA temporarily eliminate addresses before testing constraints

Vladimir Makarov writes: > On 06/02/2014 03:36 PM, Richard Sandiford wrote: >> Ping. Imagination's copyright assignment has now gone through and so >> in principle we're ready for the MIPS LRA switch to go in. We need >> this LRA patch as a prequisite though. >> >> Robert: you also had an LRA ch

Re: [build, driver] RFC: Support compressed debug sections

>> If it is just to reach compatibility with the debugger, then I’d rather >> either just mandate a certain debugger or autoconf for what the current >> debugger supports. As of late people seem to just break the debugging >> experience with non-updated gdbs and assume that a newer gdb is used. >

Re: [C++ Patch] PR 43453

Hi, On 06/04/2014 04:16 PM, Jason Merrill wrote: if (TREE_CODE (init) == TREE_LIST - && TREE_CODE (TREE_TYPE (decl)) == ARRAY_TYPE) + && TREE_CODE (type) == ARRAY_TYPE + /* C++11 8.5/17: "If the destination type is an array of characters, + an array of char16_t, an

Re: [patch] Shorten Windows path

Hi, On 04/01/2014 05:17 AM, Joey Ye wrote: > diff --git a/libcpp/files.c b/libcpp/files.c > index 7e88778..ad68682 100644 > --- a/libcpp/files.c > +++ b/libcpp/files.c > @@ -387,8 +387,14 @@ find_file_in_dir (cpp_reader *pfile, _cpp_file *file, > bool *invalid_pch) >char *copy; >

Re: patch to fix PR61325

On 2014-06-03, 6:02 PM, James Greenhalgh wrote: On Thu, May 29, 2014 at 06:38:22PM +0100, Vladimir Makarov wrote: The following patch PR61325. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61325 The patch was bootstrapped and tested on x86/x86-64. Committe

Re: patch to fix PR61325

On 2014-06-03, 6:02 PM, James Greenhalgh wrote: On Thu, May 29, 2014 at 06:38:22PM +0100, Vladimir Makarov wrote: The following patch PR61325. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61325 The patch was bootstrapped and tested on x86/x86-64. Committe

Re: [PATCH 2/2, x86] Add palignr support for AVX2.

On 06/04/2014 10:06 AM, Evgeny Stupachenko wrote: > Is it ok to use the following pattern? > > patch passed bootstrap and make check, but one test failed: > gcc/testsuite/gcc.target/i386/vect-rebuild.c > It failed on /* { dg-final { scan-assembler-times "\tv?permilpd\[ \t\]" 1 } } > */ > which is

Re: [C++ Patch] PR 43453

On 06/04/2014 02:08 PM, Paolo Carlini wrote: /* An array of character type can be initialized from a -brace-enclosed string constant. - -FIXME: this code is duplicated from reshape_init. Probably -we should just call reshape_init here? */ It strikes me as odd th

Re: emit __float128 typeinfo

On Wed, 4 Jun 2014, Jason Merrill wrote: How about, in emit_support_tinfos, using type_for_mode to check for a TF-mode floating point type different from long_double_type_node? What should I pass as the mode argument? I can't just write TFmode, that will fail to compile on platforms that don'

[Patch] PR55189 enable -Wreturn-type by default

Hello, Finally, I have been able to update all tests with -Wreturn-type enabled by default. AFAIK, under GNU/Linux Debian Jessie 64 bits, there is no PASS->FAIL tests. Now, I would like to know if I can commit that into the repository. Who can review that? As attachment, you will find the actual

Re: [patch][gomp4] openacc loops

Hi Cesar! On Tue, 3 Jun 2014 16:00:30 -0700, Cesar Philippidis wrote: > in order to make > the patch yield more interesting results, I've also enabled the private > clause. Is this patch ok for the gomp-4_0-branch? > gcc/ > * c/c-parser.c (c_parser_oacc_all_clauses): Update handling

Re: [patch i386]: Fix PR/46219 Generate indirect jump instruction

On 06/04/2014 05:37 AM, Kai Tietz wrote: > +(define_peephole2 > + [(set (match_operand:DI 0 "register_operand") > +(match_operand:DI 1 "memory_operand")) > + (call (mem:QI (match_operand:DI 2 "register_operand")) > + (match_operand 3))] > + "TARGET_64BIT && REG_P (operands[0])

Fix address space computation in expand_debug_expr

For the AVR target, assertions in convert_debug_memory_address cause a couple of ICEs (see PR 52472). Jakub suggested returning a NULL rtx, which works, but on debugging further, I found that expand_debug_expr appears to incorrectly compute the address space for ADDR_EXPR and MEM_REFs. For ADDR_EX

Re: [C++ Patch] PR 43453

Hi, On 06/04/2014 09:32 PM, Jason Merrill wrote: On 06/04/2014 02:08 PM, Paolo Carlini wrote: /* An array of character type can be initialized from a - brace-enclosed string constant. - - FIXME: this code is duplicated from reshape_init. Probably - we should just call reshap

Re: [C++ Patch] PR 43453

... sorry attached a wrong diff. Paolo. / Index: cp/decl.c === --- cp/decl.c (revision 211242) +++ cp/decl.c (working copy) @@ -5758,6 +5758,13 @@ check_initializer (tree decl, tree init, int flags

[s390, Committed] Use INTVAL only on CONST_INT in addptrdi3 and addptrsi3

Andreas, This patch ensures that INTVAL is only used on a CONST_INT in define_expands addptrdi3 and addptrsi3. I ran into this issue when building gcc for target s390 with --enable-checking=yes,rtl. Finished s390 build with patch, and committed as trivial. Thanks, - Tom 2014-06-04 Tom de Vr

Re: Fix a function decl in gfortran

Hi Bernd, Bernd Schmidt wrote: On 06/04/2014 09:40 AM, Tobias Burnus wrote: I intent to tests the build and test the patch - and then to commit it as obvious. If you see problems with this approach please scream now. Even with this applied, I'm still seeing similar failures. I didn't claim

Re: [PATCH 4/5] add gcc/gdb interface files

> "Jakub" == Jakub Jelinek writes: >> +GCC_METHOD7 (gcc_decl, build_decl, >> + const char */* name */, >> + enum gcc_c_symbol_kind /* sym_kind */, >> + gcc_type /* sym_type */, >> + const char */* substitution_name */, >> + gcc_address /* address */, >>

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

On Mon, Jun 02, 2014 at 01:50:53PM -0400, Jason Merrill wrote: > On 06/02/2014 01:04 PM, Marek Polacek wrote: > >>>#ifdef __cplusplus > >>>template bool f(T t, U u) { return (!t == u); } > >>>#endif > >>> > >>>I think !t should have null TREE_TYPE in this case. > > > >Hmm, I see no crash; the type

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

On Wed, Jun 04, 2014 at 10:56:43PM +0200, Marek Polacek wrote: > +/* Warn about logical not used on the left hand side operand of a comparison. > + This function assumes that the LHS is inside of TRUTH_NOT_EXPR. > + Do not warn if the LHS or RHS is of a boolean or a vector type. */ > + > +voi

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

On Wed, Jun 04, 2014 at 11:02:10PM +0200, Jakub Jelinek wrote: > On Wed, Jun 04, 2014 at 10:56:43PM +0200, Marek Polacek wrote: > > > +/* Warn about logical not used on the left hand side operand of a > > comparison. > > + This function assumes that the LHS is inside of TRUTH_NOT_EXPR. > > +

Re: [PATCH 2/2, x86] Add palignr support for AVX2.

Thanks. Moving pattern down helps. Now make check for the following patch passed: diff --git a/gcc/config/i386/predicates.md b/gcc/config/i386/predicates.md index 2ef1384..8266f3e 100644 --- a/gcc/config/i386/predicates.md +++ b/gcc/config/i386/predicates.md @@ -1417,6 +1417,22 @@ return true;

[4.8, PR 61393] Disable IPA-CP of transactional memory clones

Hi, PR 61393 shows that trans-mem does not play along with IPA-CP (or anything cloning cgraph_nodes for that matter). It is entirely possible that simply properly copying tm_clone flag of a node when cloning it is enough to make it work, but that is something a trans-mem person has to confirm and

[4.9, PR 61393] Disable IPA-CP of transactional memory clones

Hi, this patch does the same thing (disables IPA-CP for nodes marked as tm_clone) for the same reason as described in the previous mail but for the 4.9 branch. I've confirmed it fixes the PR failure and passes bootstrap and testing on x86_64-linux. OK for 4.9? Thanks, Martin 2014-06-04 Mart

  1   2   >