> On 23 Aug 2024, at 06:21, Andrew Pinski wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Aug 22, 2024 at 11:28 AM Andrew Pinski wrote:
>>
>> On Thu, Aug 22, 2024 at 4:12 AM Richard Biener wrote:
>>>
>>> On Thu, 22 Aug 2024, Jennifer Schmitz wrote:
>>>
>>
Apparently due to slightly different optimization levels
not always both subroutines have multiple subranges,
but having at least one such, and no lexical blocks
is sufficient to prove that the fix worked. Q.E.D.
So reduce the test expectations to only at least one
inlined subroutine with multiple
On Thu, Aug 22, 2024 at 11:28 AM Andrew Pinski wrote:
>
> On Thu, Aug 22, 2024 at 4:12 AM Richard Biener wrote:
> >
> > On Thu, 22 Aug 2024, Jennifer Schmitz wrote:
> >
> > > On 19 Aug 2024, at 21:02, Richard Sandiford
> > > wrote:
> > > >
> > > > External email: Use caution opening links or at
The testcase cc.dg/vect/vect-mod-var.c has an division by 0
which is undefined. On some targets (aarch64), the scalar and
the vectorized version, the result of division by 0 is the same.
While on other targets (x86), we get a SIGFAULT. On other targets (powerpc),
the results are different.
The fix
On Fri, Aug 23, 2024 at 11:03 AM HAO CHEN GUI wrote:
>
> Hi Hongtao,
>
> 在 2024/8/23 9:47, Hongtao Liu 写道:
> > On Thu, Aug 22, 2024 at 4:06 PM HAO CHEN GUI wrote:
> >>
> >> Hi Hongtao,
> >>
> >> 在 2024/8/21 11:21, Hongtao Liu 写道:
> >>> r15-3058-gbb42c551905024 support const0 operand for movv16qi,
Hi Hongtao,
在 2024/8/23 9:47, Hongtao Liu 写道:
> On Thu, Aug 22, 2024 at 4:06 PM HAO CHEN GUI wrote:
>>
>> Hi Hongtao,
>>
>> 在 2024/8/21 11:21, Hongtao Liu 写道:
>>> r15-3058-gbb42c551905024 support const0 operand for movv16qi, please
>>> rebase your patch and see if there's still the regressions.
>
On Mon, May 13, 2024 at 2:21 PM Fangrui Song wrote:
>
> On Mon, Mar 4, 2024 at 12:13 AM Fangrui Song wrote:
> >
> > From: Fangrui Song
> >
> > -fno-pic -mfdpic generated code is like regular -fno-pic, not suitable
> > for FDPIC (absolute addressing for symbol references and no function
> > descr
On 8/22/24 4:39 AM, Kewen.Lin wrote:
> on 2024/8/21 21:14, Peter Bergner wrote:
>> - if (ALTIVEC_OR_VSX_VECTOR_MODE (mode) || mode == TImode)
>> + if (ALTIVEC_OR_VSX_VECTOR_MODE (mode) || mode == TImode
>> + || mode == PTImode)
>
> Maybe we can introduce a macro to t
On Thu, Aug 22, 2024 at 4:06 PM HAO CHEN GUI wrote:
>
> Hi Hongtao,
>
> 在 2024/8/21 11:21, Hongtao Liu 写道:
> > r15-3058-gbb42c551905024 support const0 operand for movv16qi, please
> > rebase your patch and see if there's still the regressions.
>
> There's still regressions. The patch enables V16QI
>> I'm not sure if it's profitable to replace a lmul8 load with 127
>> vslide1down.vx
>> ops but we're being honest with the middle end when returning the # of insns
>> we'll be emitting when costing...
I think it's issue of dynamic LMUL cost model which only care about program
SSA-based registe
Nice Clean up! It's very reasonable to have a dedicated riscv-v.h
juzhe.zh...@rivai.ai
From: Patrick O'Neill
Date: 2024-08-23 03:46
To: gcc-patches
CC: rdapp.gcc; juzhe.zhong; kito.cheng; jeffreyalaw; gnu-toolchain; Patrick
O'Neill
Subject: [PATCH 6/9] RISC-V: Emit costs for bool and stepped
On Thu, Aug 22, 2024 at 02:20:14PM -0400, Patrick Palka wrote:
> On Mon, 12 Aug 2024, Nathaniel Shead wrote:
>
> > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
> >
> > I tried to implement a remapping of the slots for TARGET_EXPRs for the
> > FIXME but I wasn't able to work ou
On 8/22/24 3:53 PM, Andrew Pinski wrote:
This is an obvious fix to the gcc.dg/torture/pr116420.c testcase which simplier
changes from plain `char` to `signed char` so it works on targets where plain
char defaults
to unsigned.
Pushed as obvious after a quick test for aarch64-linux-gnu to make
> On 22 Aug 2024, at 21:27, Jason Merrill wrote:
>
> On 8/22/24 3:43 PM, Iain Sandoe wrote:
>>> On 22 Aug 2024, at 17:47, Jason Merrill wrote:
>>> On 8/22/24 12:35 PM, Iain Sandoe wrote:
>
>> +build_coroutine_frame_delete_expr (tree coro_fp, tree orig, tree
>> frame_size,
>> +
This is an obvious fix to the gcc.dg/torture/pr116420.c testcase which simplier
changes from plain `char` to `signed char` so it works on targets where plain
char defaults
to unsigned.
Pushed as obvious after a quick test for aarch64-linux-gnu to make sure the
testcase
passes now.
PR te
Bootstrapping and using --disable-libstdcxx will cause a build failure deep in
compiling
stage2 so instead error out early in the toplevel configure so it is more user
friendly.
Bootstrapped and tested on x86_64-linux-gnu.
Also made sure --disable-libstdcxx without --disable-bootstrap failed.
> -Original Message-
> From: Richard Biener
> Sent: Wednesday, August 21, 2024 12:12 PM
> To: Tamar Christina
> Cc: GCC Patches
> Subject: Re: [RFC] Support single lane SLP early break
>
> On Tue, 20 Aug 2024, Tamar Christina wrote:
>
> > Hi,
> >
> > I've been working on a prototype of
On 8/22/24 12:46, Patrick O'Neill wrote:
These cases are handled in the expander
(riscv-v.cc:expand_const_vector). We need the vector builder to detect
these cases so extract that out into a new riscv-v.h header file.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (class rvv_builder): Move
With newer ld, the default search library path does not include /usr/lib nor
/lib
but the driver decides to not pass -L down to the link for these and then in
some/most
cases libc is not found.
This code dates from at least 1992 and it is done in a way which is not safe and
does not make sense. S
On Thu, Aug 22, 2024 at 9:42 AM Richard Sandiford
wrote:
>
> "H.J. Lu" writes:
> > As PR target/116174 shown, we may need to verify the directive order.
> > Extend check-function-bodies to cover directives.
> >
> > * gcc.target/i386/pr116174.c: Use check-function-bodies.
> > * lib/sca
As PR target/116174 shown, we may need to verify labels and the directive
order. Extend check-function-bodies to support matched output lines to
allow label and directives.
gcc/
* doc/sourcebuild.texi (check-function-bodies): Add an optional
argument for matched output lines.
gc
> + /* Constants in range -16 ~ 15 integer or 0.0 floating-point
> +can be emitted using vmv.v.i. */
> + if (satisfies_constraint_vi (x) || satisfies_constraint_Wc0 (x))
> return 1;
Just a nit but while you're at it, don't you want to split
Before looking at the rest (tomorrow) - this is OK.
--
Regards
Robin
On 8/22/24 3:43 PM, Iain Sandoe wrote:
On 22 Aug 2024, at 17:47, Jason Merrill wrote:
On 8/22/24 12:35 PM, Iain Sandoe wrote:
+build_coroutine_frame_delete_expr (tree coro_fp, tree orig, tree frame_size,
+ tree promise_type, location_t loc)
+{
Here it seems
These subroutines will be used in expand_const_vector in a future patch.
Relocate so expand_const_vector can use them.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (expand_vector_init_insert_elems): Relocate.
(expand_vector_init_trailing_same_elem): Ditto.
Signed-off-by: Patrick O'Ne
Currently we assert when encountering a non-duplicate boolean vector.
This patch allows non-duplicate vectors to fall through to the
gcc_unreachable and assert there.
This will be useful when adding a catch-all pattern to emit costs and
handle arbitary vectors.
gcc/ChangeLog:
* config/ri
Applies after the recent 9 patch series:
"RISC-V: Improve const vector costing and expansion"
https://inbox.sourceware.org/gcc-patches/20240822194705.2789364-1-patr...@rivosinc.com/T/#t
This isn't functional due to RTX hash collisions. It was incredibly useful and
helped me catch a few tricky bugs
These cases are handled in the expander
(riscv-v.cc:expand_const_vector). We need the vector builder to detect
these cases so extract that out into a new riscv-v.h header file.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (class rvv_builder): Move to riscv-v.h.
* config/riscv/riscv.cc
This manifests in RTL that is optimized away which causes runtime failures
in the testsuite. Update all patterns to use a temp result register if required.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (expand_const_vector): Use tmp register if
needed.
Signed-off-by: Patrick O'Neill
The corresponding expander (riscv-v.cc:expand_const_vector) matches
const_vec_duplicate_p before const_vec_series_p. Reorder to match this
behavior when calculating costs.
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_const_insns): Relocate.
Signed-off-by: Patrick O'Neill
---
gcc/confi
repeating_sequence_p operates directly on the encoded pattern and does
not derive elements using the .elt() accessor. Passing in the length of
the unencoded vector can cause an out-of-bounds read of the encoded
pattern.
gcc/ChangeLog:
* config/riscv/riscv-v.cc
(rvv_builder::can_duplicate
Also explicitly disallow CONST_VECTOR_DUPLICATE_P for now.
CONST_VECTOR_DUPLICATE_P was previously disallowed implicitly.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (expand_vec_series): Update comment.
(expand_vector_init_insert_elems): Ditto.
(expand_const_vector): Add catc
The comment previously here stated that the Wc0/Wc1 cases are handled by
the vi constraint but that is not true for the 0.0 Wc0 case.
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_const_insns): Handle 0.0 floating-point
case.
Signed-off-by: Patrick O'Neill
---
gcc/config/riscv/
Prior to this patch the expander would emit vectors like:
{ 0, 0, 5, 5, 10, 10, ...}
as:
{ 0, 0, 2, 2, 4, 4, ...}
This patch sets the step size to the requested value.
gcc/ChangeLog:
* config/riscv/riscv-v.cc (expand_const_vector): Fix STEP size in
expander.
Signed-off-by: Pat
Constant vectors are currently spilled/loaded from memory often. This series
increases the number of costed patterns via a catch-all pattern and fixes a
variety of bugs I found along the way.
Patrick O'Neill (9):
RISC-V: Use encoded nelts when calling repeating_sequence_p
RISC-V: Fix vid const
Hi Jason
> On 22 Aug 2024, at 17:47, Jason Merrill wrote:
>
> On 8/22/24 12:35 PM, Iain Sandoe wrote:
>> Hi Jason,
>> Firstly, Arsen has WIP to revise the allocation / deallocation to deal with
>> coroutine frames that are more aligned than 2 * sizeof (pointer). We will
>> also
>> be consideri
The DF framework provides us a way to run dataflow problems on
sub-graphs. Naturally a bitmap of interesting blocks is passed into
those routines. At a confluence point, the DF framework will not mark
a block for re-processing if it's not in that set of interesting blocks.
When ext-dce sets
On Thu, Aug 22, 2024 at 4:12 AM Richard Biener wrote:
>
> On Thu, 22 Aug 2024, Jennifer Schmitz wrote:
>
> > On 19 Aug 2024, at 21:02, Richard Sandiford
> > wrote:
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Jennifer Schmitz writes:
> > >> Thanks for t
This patch adds OpenMP's interop support to the libgomp plugins (nvptx:
cuda, cuda_driver, hip; gcn: hip, hsa).*
[The idea is that the user can ask OpenMP to return a foreign-runtime
handle (CUdevice, hipCtx_t, …) for to a specified OpenMP device number –
and to create a stream (CUstream, hipS
The recently introduced search_line_fast_ssse3 raised padding
requirement from 16 to 64, which was adjusted in read_file_guts,
but the corresponding ' + 16' in _cpp_convert_input was overlooked.
libcpp/ChangeLog:
PR preprocessor/116458
* charset.cc (_cpp_convert_input): Bump paddi
On Mon, 12 Aug 2024, Nathaniel Shead wrote:
> Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
>
> I tried to implement a remapping of the slots for TARGET_EXPRs for the
> FIXME but I wasn't able to work out how to do so effectively. Given
> that I doubt this will be a common iss
> -Original Message-
> From: Torbjorn SVENSSON
> Sent: Wednesday, August 21, 2024 2:23 PM
> To: Tamar Christina ; Richard Biener
>
> Cc: Jeff Law ; gcc-patches@gcc.gnu.org; Richard
> Earnshaw ; quic_apin...@quicinc.com;
> yvan.r...@foss.st.com
> Subject: Re: [PATCH] testsuite: Add -fwrapv
On 8/22/24 12:51 PM, Simon Martin wrote:
We currently ICE upon the following invalid code, because we don't check the
number of template parameters in member class template specializations. This
patch fixes the PR by adding such a check.
=== cut here ===
template struct x {
template struct
Ping.
I think the review for patch 2/2 (fixing the ICE) deferred review of
this patch.
Since this patch includes the testcase and everything needed for
reproducing the ICE it should make it easier to debug [1].
This patch still applies so I've re-triggered precommit.
Patrick
[1]:
https://in
We currently ICE upon the following invalid code, because we don't check the
number of template parameters in member class template specializations. This
patch fixes the PR by adding such a check.
=== cut here ===
template struct x {
template struct y {
typedef T result2;
};
};
template<
On 8/22/24 12:35 PM, Iain Sandoe wrote:
Hi Jason,
Firstly, Arsen has WIP to revise the allocation / deallocation to deal with
coroutine frames that are more aligned than 2 * sizeof (pointer). We will also
be considering Lewis' P2014 (use of the aligned allocator). So this patch is
very much a
"H.J. Lu" writes:
> As PR target/116174 shown, we may need to verify the directive order.
> Extend check-function-bodies to cover directives.
>
> * gcc.target/i386/pr116174.c: Use check-function-bodies.
> * lib/scanasm.exp (configure_check-function-bodies): Add an
> argument for
On 8/22/24 12:19 PM, Iain Sandoe wrote:
Maybe use iloc_sentinel? It's a bit awkward because it won't set
UNKNOWN_LOCATION, but avoids needing to restore it at the end of the function.
I've used this - with the function start location - but I don't think that
really solves the problem; it needs
Michael Matz writes:
> when experimenting with m68k plus LRA one of the
> changes in the backend is to accept ASHIFTs (not only
> MULT) as scale code for address indices. When then not
> turning on LRA but using reload those addresses are
> presented to it which chokes on them. While reload is
>
Hi Jason,
Firstly, Arsen has WIP to revise the allocation / deallocation to deal with
coroutine frames that are more aligned than 2 * sizeof (pointer). We will also
be considering Lewis' P2014 (use of the aligned allocator). So this patch is
very much a staging point.
>> operator new for
LGTM
Robin Dapp 於 2024年8月23日 週五 00:04 寫道：
> Hi,
>
> standard abs synthesis during expand is max (a, -a). This
> expansion has the advantage of avoiding masking and is thus potentially
> faster than the a < 0 ? -a : a synthesis.
>
> Regtested on rv64gcv_zvfh_zvbb.
>
> Regards
> Robin
>
> gcc/Ch
>>>Maybe use iloc_sentinel? It's a bit awkward because it won't set
>>>UNKNOWN_LOCATION, but avoids needing to restore it at the end of the
>>>function.
>>I've used this - with the function start location - but I don't think that
>>really solves the problem; it needs to be UNKNOWN_LOCATION to st
On 8/22/24 4:38 AM, Iain Sandoe wrote:
Hi Jason,
+ if (!glvalue_p (o) && !xvalue_p (o))
+o = build_target_expr_with_type (o, TREE_TYPE (o), tf_warning_or_error);
Maybe get_target_expr instead?
done.
+ o = cp_build_init_expr (loc, e_proxy, convert_from_reference (o));
Why con
On 8/21/24 3:10 PM, Iain Sandoe wrote:
In the case that the initial awaiter returns an object, the initial await
can be a target expression and we need to look at its initializer to cast
the await_resume() to void and to wrap in a compoun expression that sets
the initial_await_resume_called flag.
Hi,
standard abs synthesis during expand is max (a, -a). This
expansion has the advantage of avoiding masking and is thus potentially
faster than the a < 0 ? -a : a synthesis.
Regtested on rv64gcv_zvfh_zvbb.
Regards
Robin
gcc/ChangeLog:
* config/riscv/autovec.md (abs2): Expand via ma
On 8/21/24 3:10 PM, Iain Sandoe wrote:
In the fix for PR95822 (r11-7402) we set throwing_cleanup false in the top
level of the coroutine transform code. However, as the current PR shows,
that is not sufficient.
Any use of cxx_maybe_build_cleanup() can reset the flag, which causes the
check_retu
On 8/21/24 3:10 PM, Iain Sandoe wrote:
[dcl.fct.def.coroutine]/7 says:
The expression promise.get_return_object() is used to initialize the returned
reference or prvalue result object of a call to a coroutine. The call to
get_return_object is sequenced before the call to initial_suspend and is
in
On 8/22/24 11:42 AM, Jason Merrill wrote:
On 8/21/24 3:10 PM, Iain Sandoe wrote:
Require that the value returned by get_return_object is convertible to
the ramp return. This means that the only time we allow a void
get_return_object, is when the ramp is also a void function.
We diagnose this e
when experimenting with m68k plus LRA one of the
changes in the backend is to accept ASHIFTs (not only
MULT) as scale code for address indices. When then not
turning on LRA but using reload those addresses are
presented to it which chokes on them. While reload is
going away the change to make the
This is part of making m68k work with LRA. See PR116429.
In short: setup_sp_offset is internally inconsistent. It wants to
setup the sp_offset for newly generated instructions. sp_offset for
an instruction is always the state of the sp-offset right before that
instruction. For that it starts at
this is part of making m68k work with LRA. See PR116374.
m68k has the property that sometimes the elimation offset
between %sp and %argptr is zero. During setting up elimination
infrastructure it's changes between sp_offset and previous_offset
that feed into insns_with_changed_offsets that ultima
On 8/21/24 3:10 PM, Iain Sandoe wrote:
We have been requiring the get_return_on_allocation_fail() call to have the
same type as the ramp. This is not intended by the standard, so relax that
to allow anything convertible to the ramp return.
OK.
PR c++/109682
gcc/cp/ChangeLog:
On 8/21/24 3:10 PM, Iain Sandoe wrote:
Require that the value returned by get_return_object is convertible to
the ramp return. This means that the only time we allow a void
get_return_object, is when the ramp is also a void function.
We diagnose this early to allow us to exit the ramp build if
Gcc maintainers:
Version 3, fixed a few typos per Kewen's review. Fixed the expected
number of scan-assembler-times for xvtlsbb and setbc. Retested on Power
10 LE.
Version 2, based on discussion additional overloaded instances of the
vec_test_lsbb_all_ones and, vec_test_lsbb_all_zeros buil
> Why's the include needed? .ccs ought to include coretypes.h directly
> (and get machmode.h that way, since coretypes.h include machmode.h).
Ugh, that was not intentional, sometimes my auto-complete inserts
such includes for no reason. I really need to disable that, thanks for
pointing that out
On 8/22/24 04:44, Richard Sandiford wrote:
The sequence of events in this PR is that:
- the function has many addresses in which only a single hard base
register is acceptable. Let's call the hard register H.
- IRA allocates that register to one of the pseudo base registers.
Let's call
Kewen:
On 8/20/24 12:56 AM, Kewen.Lin wrote:
Hi Carl,
on 2024/8/9 23:57, Carl Love wrote:
Gcc maintainers:
Version 2, based on discussion additional overloaded instances of the
vec_test_lsbb_all_ones and, vec_test_lsbb_all_zeros built-ins has been added.
The additional instances are for
> "Richard" == Richard Biener writes:
>> While working on a patch to the Ada compiler, I found a spot in
>> dwarf2out.cc that calls add_name_attribute where a call to
>> add_name_and_src_coords_attributes would be better, because the latter
>> respects DECL_NAMELESS.
Richard> If the point is
> On Aug 21, 2024, at 18:08, Bill Wendling wrote:
>
>>>
>>> to test.
>>
>> For the unary operator __counted_by(PTR), “PTR” must have a counted_by
>> attribute, if not, there will be a compilation time error.
>>
>> Then the user could write the following code:
>>
>> If __builtin_has_att
On 8/21/24 3:10 PM, Iain Sandoe wrote:
The responsibility for destroying part of the frame content (promise,
arg copies and the frame itself) transitions from the ramp to the
body of the coroutine once we reach the await_resume () for the
initial suspend.
We added the variable that flags the tra
Prathamesh Kulkarni writes:
>> -Original Message-
>> From: Richard Biener
>> Sent: Wednesday, August 21, 2024 5:09 PM
>> To: Prathamesh Kulkarni
>> Cc: Richard Sandiford ; Thomas Schwinge
>> ; gcc-patches@gcc.gnu.org
>> Subject: RE: Re-compute TYPE_MODE and DECL_MODE while streaming in f
"Robin Dapp" writes:
> diff --git a/gcc/machmode.h b/gcc/machmode.h
> index c31ec2f2ebc..b3307ad9342 100644
> --- a/gcc/machmode.h
> +++ b/gcc/machmode.h
> @@ -20,6 +20,7 @@ along with GCC; see the file COPYING3. If not see
> #ifndef HAVE_MACHINE_MODES
> #define HAVE_MACHINE_MODES
>
> +#inclu
> On Aug 21, 2024, at 17:54, Bill Wendling wrote:
>
>> if (__builtin_get_counted_by(p->array)) {
>>size_t max_value =
>> type_max(typeof(*__builtin_get_counted_by(p->array)));
>>if (count > type_max)
>>...fail cleanly...
>>*__builtin_get_counted_by(p->ar
Hi, Bill,
Thank you for the info.
> On Aug 21, 2024, at 17:36, Bill Wendling wrote:
>
>>
>> Bill, could you please provide a little bit more info on the possibility of
>> a new builtin __builtin_has_attribute() in CLANG?
>>
> From what I gathered, it would require some moderate surgery to
> -Original Message-
> From: Richard Biener
> Sent: Wednesday, August 21, 2024 5:09 PM
> To: Prathamesh Kulkarni
> Cc: Richard Sandiford ; Thomas Schwinge
> ; gcc-patches@gcc.gnu.org
> Subject: RE: Re-compute TYPE_MODE and DECL_MODE while streaming in for
> accelerator
>
> External email
On 8/22/24 9:30 AM, Iain Sandoe wrote:
Hi Jason,
+ tree stmt = begin_function_body ();
As in the last patch, "stmt" seems an obscure name for the result of
begin_function_body.
done.
+ /* Avoid the code here attaching a location that makes the debugger jump. */
+ location_t save_inpu
> Indeed though that might be a larger change.
I have tested the attached now, aarch64 is still running but
x86 and power10 are bootstrapped and regtested, riscv regtested.
Hope I didn't miss any target-specific code that I haven't tested.
As the issue is only latent I verified by calling
get_b
On 8/22/24 7:29 AM, Iain Sandoe wrote:
+ tree fn_return_type = TREE_TYPE (TREE_TYPE (orig));
/* Ramp: */
+ tree stmt = begin_function_body ();
The name "stmt" doesn't suggest to me that it's holding the result of begin_function_body. Maybe
"ramp_fnbody"? Of course, then there's some
On Thu, 22 Aug 2024 at 14:31, Patrick Palka wrote:
>
> Tested on x86_64-pc-linux-gnu, does this look OK for trunk and
> perhaps 14?
OK for trunk and gcc-14.
We didn't backport the fix to move ranges::iota to , so the
iota.cc test will need adjustment on the branch.
>
> -- >8 --
>
> libstdc++-v
Tested on x86_64-pc-linux-gnu, does this look OK for trunk and
perhaps 14?
-- >8 --
libstdc++-v3/ChangeLog:
* testsuite/25_algorithms/contains/1.cc: Verify value of
__cpp_lib_ranges_contains.
* testsuite/25_algorithms/find_last/1.cc: Verify value of
__cpp_lib_rang
Hi Jason,
>>+ tree stmt = begin_function_body ();
>As in the last patch, "stmt" seems an obscure name for the result of
>begin_function_body.
done.
>>+ /* Avoid the code here attaching a location that makes the debugger jump.
>>*/
>>+ location_t save_input_loc = input_location;
>>+ locati
On Wed, 21 Aug 2024, Artemiy Volkov wrote:
> Hi,
>
> sending a v2 of
> https://gcc.gnu.org/pipermail/gcc-patches/2024-August/659851.html after
> changing variable types in all new testcases from standard to fixed-width.
>
> Could anyone please assist with reviewing and/or pushing to trunk/14 sin
On Fri, Aug 16, 2024 at 4:24 PM Konstantinos Eleftheriou
wrote:
>
> From: kelefth
>
> In expressions like (a != b || ((a ^ b) & CST0) == CST1) and
> (a != b || (a ^ b) == CST), (a ^ b) is folded to false.
> In the equivalent expressions (((a ^ b) & CST0) == CST1 || a != b) and
> ((a ^ b) == CST,
On 8/21/24 3:11 PM, Raphael Moreira Zinsly wrote:
The stack-clash code is generating wrong cfi directives in
riscv_v_adjust_scalable_frame because REG_CFA_DEF_CFA has a different
encoding than REG_FRAME_RELATED_EXPR, this patch fixes the offset sign
in prologue and starts using REG_CFA_DEF_CFA
On 8/22/24 2:46 AM, Richard Sandiford wrote:
This patch fixes gcc.c-torture/compile/opout.c for m68k with LRA
enabled. The test has:
...
z (a, b)
{
return (int) &a + (int) &b + (int) x + (int) z;
}
so it adds the address of two incoming arguments. This ends up
being treated as an LEA in
On Thu, Aug 22, 2024 at 1:03 AM Edwin Lu wrote:
>
> Hi,
>
> Just wanted to ping this for more guidance.
It's difficult for me as long as I cannot investigate this with a testcase. Can
we go ahead with the other parts so the testcase can be added and the
issue reproduced?
Richard.
> Edwin
>
> O
On Wed, Aug 21, 2024 at 12:08 PM Kugan Vivekanandarajah
wrote:
>
> Hi Richard,
>
> > On 20 Aug 2024, at 6:09 pm, Richard Biener
> > wrote:
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On Fri, Aug 9, 2024 at 2:39 AM Kugan Vivekanandarajah
> > wrote:
> >>
> >> Than
On 8/22/24 5:04 AM, Manolis Tsamis wrote:
Similar to not allowing jump instructions in the generated code, we also
shouldn't allow call instructions in noce_convert_multiple_sets.
In the case of PR116358 a libcall was generated from force_operand.
PR middle-end/116358
gcc/ChangeLog:
This is a revised version of a patch Giovanni submitted some years ago,
which has been unreviewed until recently.
Tested x86_64-linux. I would like to push this to trunk.
-- >8 --
When RAND_MAX is small and the number of elements being shuffled is
close to it, we get very uneven distributions in
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
-- >8 --
After importing a header unit we learn about and setup any header
modules that we transitively depend on. However, this causes
'set_filename' to fail an assertion if we then come across this header
as an #include and attem
On Thu, Aug 22, 2024 at 1:47 PM Andrew Pinski wrote:
>
> The problem here was a missing save_expr around arg0 since
> it is used twice, once in REALPART_EXPR and once in IMAGPART_EXPR.
> Thia adds the save_expr and reformats the code slightly so it is a
> little easier to understand. It excludes
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
-- >8 --
Currently the handling of include translation is confusing to read,
using a tri-state integer without much clarity on what different states
mean. This patch cleans this up to use explicit enumerators indicating
the differe
On Thu, Aug 22, 2024 at 1:35 PM John Paul Adrian Glaubitz
wrote:
>
> On Thu, 2024-08-22 at 13:05 +0200, Richard Biener wrote:
> > > I'm not sure that bisecting works here as I suspect the issue is a result
> > > of the LRA switch.
> >
> > For sure. Still debugging/fixing the testsuite issue will
The problem here was a missing save_expr around arg0 since
it is used twice, once in REALPART_EXPR and once in IMAGPART_EXPR.
Thia adds the save_expr and reformats the code slightly so it is a
little easier to understand. It excludes the case when arg0 is
a COMPLEX_EXPR since in that case we'll en
Single argument static_assert is C++17 only.
libcpp/ChangeLog:
* lex.cc(search_line_ssse3): fix static_assert to use 2 arguments.
---
Pushed to master as obvious.
Fixed the CL + added a reason in the assert.
Thanks!
libcpp/lex.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On Thu, 2024-08-22 at 13:05 +0200, Richard Biener wrote:
> > I'm not sure that bisecting works here as I suspect the issue is a result
> > of the LRA switch.
>
> For sure. Still debugging/fixing the testsuite issue will be much easier.
>
> Does a int main(){} also segfault?
I can run the LRA-en
>>+ tree fn_return_type = TREE_TYPE (TREE_TYPE (orig));
>> /* Ramp: */
>>+ tree stmt = begin_function_body ();
>The name "stmt" doesn't suggest to me that it's holding the result of
>begin_function_body. Maybe "ramp_fnbody"? Of course, then there's some
>confusion with "ramp_body". Shou
On Thu, 22 Aug 2024, Marc Poulhiès wrote:
> Single argument static_assert is C++17 only.
>
> libcpp/ChangeLog:
>
> * lex.cc: fix static_assert to use 2 arguments.
When pushing, please fix the entry to mention the function name if that's
not too much trouble:
* lex.cc (search_line
On Thu, 22 Aug 2024, Jennifer Schmitz wrote:
> On 19 Aug 2024, at 21:02, Richard Sandiford wrote:
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Jennifer Schmitz writes:
> >> Thanks for the comments. I updated the patch accordingly and bootstrapped
> >> and test
On Thu, Aug 22, 2024 at 12:54 PM John Paul Adrian Glaubitz
wrote:
>
> Hi Richard,
>
> On Thu, 2024-08-22 at 12:49 +0200, Richard Biener wrote:
> > If this is stage2 or stage3 it hints at a miscompile of the stage2/3
> > compiler. I'd concentrate on other
> > issues first and suggest to use --disa
1 - 100 of 130 matches
Mail list logo
