> Why's the include needed? .ccs ought to include coretypes.h directly > (and get machmode.h that way, since coretypes.h include machmode.h).
Ugh, that was not intentional, sometimes my auto-complete inserts such includes for no reason. I really need to disable that, thanks for pointing that out. > > /* Find the narrowest integer mode that contains at least SIZE bits. > > Such a mode must exist. */ > > The comment is no longer true. Maybe: > > /* Find the narrowest integer mode that contains at least SIZE bits, > if such a mode exists. */ > > Similarly for smallest_mode_for_size. > > Otherwise it looks good. Thanks for doing this. Ok, I'm going to remove the include, adjust the comments and push once all tests come out green. > When I had a quick look before sending my previous message, it seemed like > quite a few callers do have natural error paths for the case where no mode > exists. But I agree it makes sense to do that separately. I can follow > up with a patch for that. Thanks, I also noticed a few when adjusting the callers but didn't want to complicate the patch further. -- Regards Robin
