On Thu, Aug 22, 2024 at 9:42 AM Richard Sandiford <richard.sandif...@arm.com> wrote: > > "H.J. Lu" <hjl.to...@gmail.com> writes: > > As PR target/116174 shown, we may need to verify the directive order. > > Extend check-function-bodies to cover directives. > > > > * gcc.target/i386/pr116174.c: Use check-function-bodies. > > * lib/scanasm.exp (configure_check-function-bodies): Add an > > argument for fluff. Set up_config(fluff) to $fluff if not > > empty. > > (check-function-bodies): Add an optional argument for fluff and > > pass it to configure_check-function-bodies. > > Looks like a useful feature, but how about instead making the extra > argument specify things that *should* be matched, rather than things > that shouldn't? That argument would then take precedence over the > current fluff regexp. > > That might be easier to maintain, since it wouldn't need to repeat the > knowledge currently in configure_check-function-bodies. And it should > cope more easily with multiple assembly dialects.
Fixed in v2. > The documentation in doc/sourcebuild.texi would need to be updated as well. Fixed in v2: https://gcc.gnu.org/pipermail/gcc-patches/2024-August/661226.html Thanks. H.J.
