New French PO file for 'gcc' (version 14.2.0)

2024-08-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the French team of translators. The file is available at: https://translationproject.org/latest/gcc/fr.po (This file, 'gcc-14.2.0.fr.po', has jus

Re: [PATCH] IRA: Ignore debug insns for uses in split_live_ranges_for_shrink_wrap. [PR116179]

2024-08-02 Thread Sam James
Andrew Pinski writes: > Late_combine exposed this latent bug in split_live_ranges_for_shrink_wrap. > What it did was copy-prop regno 151 from regno 119 from: > ``` > (insn 2 264 3 2 (set (reg/f:DI 119 [ thisD.3697 ]) > (reg:DI 151)) "/app/example.cpp":19:13 70 {*movdi_aarch64} > (exp

[PATCH] IRA: Ignore debug insns for uses in split_live_ranges_for_shrink_wrap. [PR116179]

2024-08-02 Thread Andrew Pinski
Late_combine exposed this latent bug in split_live_ranges_for_shrink_wrap. What it did was copy-prop regno 151 from regno 119 from: ``` (insn 2 264 3 2 (set (reg/f:DI 119 [ thisD.3697 ]) (reg:DI 151)) "/app/example.cpp":19:13 70 {*movdi_aarch64} (expr_list:REG_DEAD (reg:DI 151)

Re: [PATCH 1/2] gdbhooks: Make dot viewer configurable

2024-08-02 Thread David Malcolm
On Thu, 2024-08-01 at 10:14 +0100, Alex Coplan wrote: > Hi, > > This adds a new GDB parameter 'gcc-dot-cmd' which allows the user to > configure the command used to render the CFG within dot-fn. > > E.g. with this patch the user can change their dot viewer like so: > > (gdb) show gcc-dot-cmd > T

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 23:49, Giuseppe D'Angelo wrote: > > Hello, > > as usual thank you for the review. V2 is attached. > > On 02/08/2024 14:38, Jonathan Wakely wrote: > > On Fri, 2 Aug 2024 at 13:17, Jonathan Wakely wrote: > >> > >> On Fri, 2 Aug 2024 at 11:45, Giuseppe D'Angelo wrote: > >>> > >

Re: [PATCH] libstdc++: Do not use deduced return type for std::forward_like

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 23:43, Patrick Palka wrote: > > On Fri, 2 Aug 2024, Patrick Palka wrote: > > > On Fri, 2 Aug 2024, Jonathan Wakely wrote: > > > > > This isn't properly tested so I'm not pushing it, but I'm sharing it now > > > for comment. > > > > > > -- >8 -- > > > > > > Inspired by https:/

Re: [PATCH v2] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Giuseppe D'Angelo
Hello, as usual thank you for the review. V2 is attached. On 02/08/2024 14:38, Jonathan Wakely wrote: On Fri, 2 Aug 2024 at 13:17, Jonathan Wakely wrote: On Fri, 2 Aug 2024 at 11:45, Giuseppe D'Angelo wrote: Hello, The attached patch adds support for P2248R8 + P3217R0 (Enabling list-initi

Re: [PATCH] libstdc++: Do not use deduced return type for std::forward_like

2024-08-02 Thread Patrick Palka
On Fri, 2 Aug 2024, Patrick Palka wrote: > On Fri, 2 Aug 2024, Jonathan Wakely wrote: > > > This isn't properly tested so I'm not pushing it, but I'm sharing it now > > for comment. > > > > -- >8 -- > > > > Inspired by https://github.com/llvm/llvm-project/issues/101614 this > > replaces the ded

Re: [PATCH] libstdc++: Do not use deduced return type for std::forward_like

2024-08-02 Thread Patrick Palka
On Fri, 2 Aug 2024, Jonathan Wakely wrote: > This isn't properly tested so I'm not pushing it, but I'm sharing it now > for comment. > > -- >8 -- > > Inspired by https://github.com/llvm/llvm-project/issues/101614 this > replaces the deduced return type of std::forward_like with a type trait > to

Re: [PATCH] rs6000, document built-ins vec_test_lsbb_all_ones and, vec_test_lsbb_all_zeros

2024-08-02 Thread Peter Bergner
On 7/31/24 10:21 PM, Kewen.Lin wrote: > on 2024/8/1 01:52, Carl Love wrote: >> Yes, I noticed that the built-ins were defined as overloaded but only had >> one definition. Did seem odd to me. >> >>> either is with "vector unsigned char" as argument type, but the >>> corresponding instance >>> p

[PATCH] warn-access: ignore template parameters when matching operator new/delete [PR109224]

2024-08-02 Thread Arsen Arsenović
I'm not 100% clear on what the semantics of the matching here are meant to be - AFAICT, an operator new/delete pair matches (after falling through the other cases) if all their components (besides the actual operator name, of course) match, and the pair of actual operator names matches if one is a

Re: [PATCH] PR116080: Fix test suite checks for musttail

2024-08-02 Thread Andi Kleen
Andi Kleen writes: > From: Andi Kleen > > This is a new attempt to fix PR116080. The previous try was reverted > because it just broke a bunch of tests, hiding the problem. The previous version still had one failure on powerpc because of a template call that needs a dg-error check for external_

[PATCH] libstdc++: Do not use deduced return type for std::forward_like

2024-08-02 Thread Jonathan Wakely
This isn't properly tested so I'm not pushing it, but I'm sharing it now for comment. -- >8 -- Inspired by https://github.com/llvm/llvm-project/issues/101614 this replaces the deduced return type of std::forward_like with a type trait to compute that type. libstdc++-v3/ChangeLog: * incl

Re: [PATCH] Make may_trap_p_1 return false for constant pool references [PR116145]

2024-08-02 Thread Andrew Pinski
On Wed, Jul 31, 2024 at 9:41 AM Richard Sandiford wrote: > > The testcase contains the constant: > > arr2 = svreinterpret_u8(svdup_u32(0x0a0d5c3f)); > > which was initially hoisted by hand, but which gimple optimisers later > propagated to each use (as expected). The constant was then expanded

Re: [PATCH] c++: permit errors inside uninstantiated templates [PR116064]

2024-08-02 Thread Patrick Palka
On Fri, 2 Aug 2024, Patrick Palka wrote: > On Fri, 2 Aug 2024, Jason Merrill wrote: > > > On 8/1/24 2:52 PM, Patrick Palka wrote: > > > In recent versions of GCC we've been diagnosing more and more kinds of > > > errors inside a template ahead of time. This is a largely good thing > > > because

[PATCH v2] c++: fix -Wdangling-reference false positive [PR115987]

2024-08-02 Thread Marek Polacek
On Thu, Aug 01, 2024 at 05:20:43PM -0400, Jason Merrill wrote: > On 8/1/24 4:19 PM, Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > -- >8 -- > > This fixes another false positive. When a function is taking a > > temporary of scalar type that couldn't

Re: [PATCH] c++: Move -Wdangling-reference to -Wextra

2024-08-02 Thread Patrick Palka
On Fri, 2 Aug 2024, Marek Polacek wrote: > On Thu, Aug 01, 2024 at 05:18:35PM -0400, Jason Merrill wrote: > > On 8/1/24 4:20 PM, Marek Polacek wrote: > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > > > -- >8 -- > > > Despite a number of mitigations (don't warn for std::

Re: [PATCH 0/1] Initial support for AVX10.2

2024-08-02 Thread Andi Kleen
> > INT8 is actually char per my understanding. > > For FP8, currently there is no basic calculation insts yet. So we have no > support for them in AVX10.2 currently, and treat them just as a piece > of char. > > Also there might be other issues for FP8 to discuss, like ABI issues, so > we put t

Re: [PATCH] c++: permit errors inside uninstantiated templates [PR116064]

2024-08-02 Thread Patrick Palka
On Fri, 2 Aug 2024, Jason Merrill wrote: > On 8/1/24 2:52 PM, Patrick Palka wrote: > > In recent versions of GCC we've been diagnosing more and more kinds of > > errors inside a template ahead of time. This is a largely good thing > > because it catches bugs, typos, dead code etc sooner. > > > >

Re: [PATCH] c++: Move -Wdangling-reference to -Wextra

2024-08-02 Thread Marek Polacek
On Thu, Aug 01, 2024 at 05:18:35PM -0400, Jason Merrill wrote: > On 8/1/24 4:20 PM, Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > -- >8 -- > > Despite a number of mitigations (don't warn for std::span-like classes, > > lambdas, adding [[gnu::no_dangl

[PATCH] c++: remove function/var concepts code

2024-08-02 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu. Comments? -- >8 -- This patch removes vestigial Concepts TS code as discussed in . In particular, it removes code related to function/variable concepts. That includes variable_concept_

[Patch, Fortran] PR104626 ICE in gfc_format_decoder, at fortran/error.cc:1071

2024-08-02 Thread Jerry D
Hi all, Doing some catchup here. I plan to commit the following shortly. This is one of Steve's patches posted on bugzilla. I have created a new test case. Regression tested on linux x86-64. git show: commit 4d4549937b789afe4037c2f8f80dfc2285504a1e (HEAD -> master) Author: Steve Kargl Date

Re: [PATCH] c++: Add unsequenced C++ testcase

2024-08-02 Thread Jason Merrill
On 8/1/24 2:43 PM, Jakub Jelinek wrote: Hi! This is the testcase I wrote originally and which on top of the https://gcc.gnu.org/pipermail/gcc-patches/2024-August/659154.html patch didn't behave the way I wanted (no warning and no optimizations of [[unsequenced]] function templates which don't ha

[RFC][PATCH] SVE intrinsics: Fold svdiv (svptrue, x, x) to ones

2024-08-02 Thread Jennifer Schmitz
This patch folds the SVE intrinsic svdiv into a vector of 1's in case 1) the predicate is svptrue and 2) dividend and divisor are equal. This is implemented in the gimple_folder for signed and unsigned integers. Corresponding test cases were added to the existing test suites. The patch was bootstr

Re: [PATCH v2] c++/coroutines: check for members we use in handle_types [PR105475]

2024-08-02 Thread Jason Merrill
On 8/2/24 10:50 AM, Arsen Arsenović wrote: Jason Merrill writes: I don't think these names need to mention "baselink", but I'm not strongly against it. It doesn't fit with the rest of the codebase either, so I'll rename them. A few other tweaks below: @@ -90,6 +90,7 @@ struct GTY((for_us

Re: [PATCH v1] aarch64: Add fp8 scalar types

2024-08-02 Thread Claudio Bantaloukas
On 02/08/2024 12:17, Richard Sandiford wrote: > Claudio Bantaloukas writes: >> The ACLE defines a new scalar type, __mfp8. This is an opaque 8bit types that >> can only be used by fp8 intrinsics. Additionally, the mfloat8_t type is made >> available in arm_neon.h and arm_sve.h as an alias of the

Re: [PATCH] c++: permit errors inside uninstantiated templates [PR116064]

2024-08-02 Thread Jason Merrill
On 8/1/24 2:52 PM, Patrick Palka wrote: In recent versions of GCC we've been diagnosing more and more kinds of errors inside a template ahead of time. This is a largely good thing because it catches bugs, typos, dead code etc sooner. But if the template never gets instantiated then such errors

Re: [PATCH 03/15] arm: [MVE intrinsics] Cleanup arm-mve-builtins-functions.h

2024-08-02 Thread Christophe Lyon
On Fri, 2 Aug 2024 at 18:14, Andre Vieira (lists) wrote: > > Hi, > > This looks great to me, only one small suggestion, but take it or leave > it I think it's a matter of preference. > > On 11/07/2024 22:42, Christophe Lyon wrote: > > > + /* No predicate, no suffix. */ > > if (e

Re: [PATCH 01/15] arm: [MVE intrinsics] improve comment for orrq shape

2024-08-02 Thread Christophe Lyon
On Fri, 2 Aug 2024 at 17:46, Andre Vieira (lists) wrote: > > Hi Christophe, > > Maybe this patch was based on an older source, but the comment now reads: > > /* _t vfoo[t0](_t, _t) > _t vfoo[_n_t0](_t, _t) > > Where the _n form only supports s16/s32/u16/u32 types as for vorrq. > > Exam

New Croatian PO file for 'gcc' (version 14.2.0)

2024-08-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Croatian team of translators. The file is available at: https://translationproject.org/latest/gcc/hr.po (This file, 'gcc-14.2.0.hr.po', has j

Re: [PATCH] forwprop: Don't add uses to dce list if debug statement [PR116156]

2024-08-02 Thread Andrew Pinski
On Thu, Aug 1, 2024 at 11:55 PM Richard Biener wrote: > > On Thu, Aug 1, 2024 at 10:40 PM Andrew Pinski > wrote: > > > > The problem here is that when forwprop does a copy prop, into a statement, > > we mark the uses of that statement as possibly need to be removed. But it > > just > > happened

Re: [PATCH] fortran: Fix a pasto in gfc_check_dependency

2024-08-02 Thread Mikael Morin
Le 02/08/2024 à 17:05, Jakub Jelinek a écrit : On Fri, Aug 02, 2024 at 04:58:09PM +0200, Mikael Morin wrote: But the function actually returns 0 rather than 1 that PR45019 meant. So I bet in addition to fixing the pasto we should move that conditional from where it is right now to the return 0;

New Chinese (simplified) PO file for 'gcc' (version 14.2.0)

2024-08-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Chinese (simplified) team of translators. The file is available at: https://translationproject.org/latest/gcc/zh_CN.po (This file, 'gcc-14.2.

[RFC/RFA] [PATCH v2 11/12] Replace the original CRC loops with a faster CRC calculation.

2024-08-02 Thread Mariam Arutunian
After the loop exit an internal function call (CRC, CRC_REV) is added, and its result is assigned to the output CRC variable (the variable where the calculated CRC is stored after the loop execution). The removal of the loop is left to CFG cleanup and DCE. gcc/ * gimple-crc-optimization.cc

Re: [PATCH 03/15] arm: [MVE intrinsics] Cleanup arm-mve-builtins-functions.h

2024-08-02 Thread Andre Vieira (lists)
Hi, This looks great to me, only one small suggestion, but take it or leave it I think it's a matter of preference. On 11/07/2024 22:42, Christophe Lyon wrote: + /* No predicate, no suffix. */ if (e.type_suffix (0).integer_p) if (e.type_suffix (0).unsigne

[Committed] RISC-V: Improve length attributes for atomic insn sequences

2024-08-02 Thread Patrick O'Neill
On 8/2/24 07:10, Jeff Law wrote: On 8/1/24 10:25 PM, Patrick O'Neill wrote: gcc/ChangeLog: * config/riscv/sync-rvwmo.md: Add conditional length attributes. * config/riscv/sync-ztso.md: Ditto. * config/riscv/sync.md: Fix incorrect insn length attributes and reformat existing co

Re: [PATCH 01/15] arm: [MVE intrinsics] improve comment for orrq shape

2024-08-02 Thread Andre Vieira (lists)
Hi Christophe, Maybe this patch was based on an older source, but the comment now reads: /* _t vfoo[t0](_t, _t) _t vfoo[_n_t0](_t, _t) Where the _n form only supports s16/s32/u16/u32 types as for vorrq. Example: vorrq. int16x8_t [__arm_]vorrq[_s16](int16x8_t a, int16x8_t b) int1

Re: [PATCH] arm: Fix testism with mve/ivopts-3.c testcase

2024-08-02 Thread Andre Vieira (lists)
Yeah true... committed. On 01/08/2024 13:54, Christophe Lyon wrote: On 8/1/24 12:02, Andre Vieira (lists) wrote: On 01/08/2024 10:09, Christophe Lyon wrote: It seems your attachment contains only the commit message but lacks the actual patch? I blame lack of coffee... Thanks. The

Re: [RFC] RISC-V: Add support for Profiles RVA/B23.

2024-08-02 Thread Jiawei
在 2024/8/1 21:54, Christoph Müllner 写道: On Mon, Jul 29, 2024 at 5:26 AM Jiawei wrote: This patch adds support for RISC-V RVA23 and RVB23 Profiles[1], which depend on the base RISC-V Profiles support[2]. [1] https://github.com/riscv/riscv-profiles/releases/tag/rva23-v0.4-rvb23-v0.1-internal-

[PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-02 Thread Jiawei
https://github.com/riscv/riscv-isa-manual/blob/main/src/zimop.adoc gcc/ChangeLog: * common/config/riscv/riscv-common.cc: New extension. * config/riscv/riscv.opt: New mask. gcc/testsuite/ChangeLog: * gcc.target/riscv/arch-42.c: New test. * gcc.target/riscv/arch-43

Re: [PATCH] fortran: Fix a pasto in gfc_check_dependency

2024-08-02 Thread Jakub Jelinek
On Fri, Aug 02, 2024 at 04:58:09PM +0200, Mikael Morin wrote: > > But the function actually returns 0 rather than 1 that PR45019 meant. > > So I bet in addition to fixing the pasto we should move that conditional > > from where it is right now to the return 0; location after > > check_data_pointer_

Re: [PATCH] aarch64: Fuse CMP+CSEL and CMP+CSET for -mcpu=neoverse-v2

2024-08-02 Thread Richard Sandiford
Jennifer Schmitz writes: > Dear Richard, > Thanks for the feedback! I made the changes as suggested. Here is the updated > patch, bootstrapped and tested again. > Best, > Jennifer LGTM, thanks. Pushed to trunk with some minor reindentation: if ((prev_type == TYPE_ALUS_SREG || prev_type =

Re: [PATCH] fortran: Fix a pasto in gfc_check_dependency

2024-08-02 Thread Mikael Morin
Le 02/08/2024 à 10:12, Jakub Jelinek a écrit : On Thu, Aug 01, 2024 at 09:03:39PM +0200, Mikael Morin wrote: Le 01/08/2024 à 12:00, Jakub Jelinek a écrit : Hi! A static analyzer found what seems like a pasto in the PR45019 changes, the second branch of || only accesses sym2 while the first one

[PATCH v2] c++/coroutines: check for members we use in handle_types [PR105475]

2024-08-02 Thread Arsen Arsenović
Jason Merrill writes: > I don't think these names need to mention "baselink", but I'm not strongly > against it. It doesn't fit with the rest of the codebase either, so I'll rename them. > A few other tweaks below: > >> @@ -90,6 +90,7 @@ struct GTY((for_user)) coroutine_info >> tree self_h_

Re: [PATCH v2] RISC-V: Add --with-cmodel configure option

2024-08-02 Thread Jeff Law
On 8/1/24 11:11 PM, Hau Hsu wrote: Sometimes we want to use default cmodel other than medlow. Add a GCC configure option for that. gcc/ChangeLog: * config.gcc (riscv*-*-*): Add support for --with-cmodel configure option. * config/riscv/riscv.h (TARGET_RISCV_DEFAULT_CMODEL): Define

Re: [PATCH] lra: emit caller-save register spills before call insn [PR116028]

2024-08-02 Thread Jeff Law
On 8/1/24 4:12 AM, Surya Kumari Jangala wrote: lra: emit caller-save register spills before call insn [PR116028] LRA emits insns to save caller-save registers in the inheritance/splitting pass. In this pass, LRA builds EBBs (Extended Basic Block) and traverses the insns in the EBBs in reverse

Re: [PATCH] c++, coroutines: Simplify separation of the user function body and ramp.

2024-08-02 Thread Jason Merrill
On 8/2/24 6:50 AM, Iain Sandoe wrote: This fixes a (so far unreported) bug where we would handle noexcept ramps correctly, but omit exception specs - take this opportunity to simplify. Tested on x86_64-darwin, OK for trunk? thanks Iain --- 8< --- We need to separate the original user-authored f

Re: [PATCH] genemit: Fix handling of explicit parallels for clobbers [PR116058]

2024-08-02 Thread Jeff Law
On 8/1/24 7:51 PM, Andrew Pinski wrote: In a define_insn, you could use either an explicit parallel for the insns or genrecog/genemit will add one for you. The problem when genemit is processing the pattern for clobbers (to create the function add_clobbers), genemit hadn't add the implicit par

Re: [PATCH] RISC-V: Improve length attributes for atomic insn sequences

2024-08-02 Thread Jeff Law
On 8/1/24 10:25 PM, Patrick O'Neill wrote: gcc/ChangeLog: * config/riscv/sync-rvwmo.md: Add conditional length attributes. * config/riscv/sync-ztso.md: Ditto. * config/riscv/sync.md: Fix incorrect insn length attributes and reformat existing conditional checks.

Re: [PATCH] fortran: Support optional dummy as BACK argument of MINLOC/MAXLOC.

2024-08-02 Thread Mikael Morin
Le 01/08/2024 à 21:02, Thomas Koenig a écrit : Hi Mikael, +  gcc_assert (backexpr->expr_type == EXPR_VARIABLE); drop it, downgrade to checking, or is it worth? Whether it is worth it, I don't know; it's protecting the access to backexpr->symtree a few lines down, idependently of the imp

[PATCH] middle-end/111821 - compile-time/memory-hog with large copy

2024-08-02 Thread Richard Biener
The following fixes a compile-time/memory-hog when performing a large aggregate copy to a small object allocated to a register. While store_bit_field_1 called by store_integral_bit_field will do nothign for accesses outside of the target the loop over the source in store_integral_bit_field will sti

[PATCH] vect: Multistep float->int conversion only with no trapping math

2024-08-02 Thread Juergen Christ
Do not convert floats to ints in multiple step if trapping math is enabled. This might hide some inexact signals. Also use correct sign (the sign of the target integer type) for the intermediate steps. This only affects undefined behaviour (casting floats to unsigned datatype where the float is

Re: [PATCH] arm: Fix testism with mve/ivopts-3.c testcase

2024-08-02 Thread Christophe Lyon
On 8/1/24 14:54, Christophe Lyon wrote: On 8/1/24 12:02, Andre Vieira (lists) wrote: On 01/08/2024 10:09, Christophe Lyon wrote: It seems your attachment contains only the commit message but lacks the actual patch? I blame lack of coffee... Thanks. The patch LGTM.  It seems patc

Re: [PATCH] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 13:17, Jonathan Wakely wrote: > > On Fri, 2 Aug 2024 at 11:45, Giuseppe D'Angelo wrote: > > > > Hello, > > > > The attached patch adds support for P2248R8 + P3217R0 (Enabling > > list-initialization for algorithms, C++26). The big question is whether > > this keeps the code r

Re: [PATCH] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 11:45, Giuseppe D'Angelo wrote: > > Hello, > > The attached patch adds support for P2248R8 + P3217R0 (Enabling > list-initialization for algorithms, C++26). The big question is whether > this keeps the code readable enough without introducing too much > #ifdef-ery, so any feed

Re: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-02 Thread Jakub Jelinek
On Fri, Aug 02, 2024 at 11:58:19AM +, Prathamesh Kulkarni wrote: > diff --git a/gcc/data-streamer-in.cc b/gcc/data-streamer-in.cc > index 7dce2928ef0..7b9d8cc0129 100644 > --- a/gcc/data-streamer-in.cc > +++ b/gcc/data-streamer-in.cc > @@ -182,10 +182,8 @@ streamer_read_hwi (class lto_input_blo

RE: Support streaming of poly_int for offloading when it's degree <= accel's NUM_POLY_INT_COEFFS

2024-08-02 Thread Prathamesh Kulkarni
> -Original Message- > From: Jakub Jelinek > Sent: Wednesday, July 31, 2024 8:46 PM > To: Prathamesh Kulkarni > Cc: Richard Biener ; Richard Sandiford > ; gcc-patches@gcc.gnu.org > Subject: Re: Support streaming of poly_int for offloading when it's > degree <= accel's NUM_POLY_INT_COEFF

Re: [PATCH 8/8]AArch64: take gather/scatter decode overhead into account

2024-08-02 Thread Richard Sandiford
Tamar Christina writes: >> -Original Message- >> From: Tamar Christina >> Sent: Thursday, August 1, 2024 9:51 AM >> To: Richard Sandiford >> Cc: Kyrylo Tkachov ; gcc-patches@gcc.gnu.org; nd >> ; Richard Earnshaw ; Marcus >> Shawcroft ; ktkac...@gcc.gnu.org >> Subject: RE: [PATCH 8/8]AArc

Re: [PATCH v1] aarch64: Add fp8 scalar types

2024-08-02 Thread Richard Sandiford
Claudio Bantaloukas writes: > The ACLE defines a new scalar type, __mfp8. This is an opaque 8bit types that > can only be used by fp8 intrinsics. Additionally, the mfloat8_t type is made > available in arm_neon.h and arm_sve.h as an alias of the same. > > This implementation uses an INTEGER_TYPE,

[PATCH] c++, coroutines: Simplify separation of the user function body and ramp.

2024-08-02 Thread Iain Sandoe
This fixes a (so far unreported) bug where we would handle noexcept ramps correctly, but omit exception specs - take this opportunity to simplify. Tested on x86_64-darwin, OK for trunk? thanks Iain --- 8< --- We need to separate the original user-authored function body from the definition of th

[pushed] c++, coroutines: Provide a CTOR for a callback object [NFC].

2024-08-02 Thread Iain Sandoe
Tested on x86_64-darwin, pushed to trunk as obvious, thanks Iain --- 8< --- This provides and uses a CTOR to initialize the object used in tree walks to track local variable uses. This makes the idiom used consistent. gcc/cp/ChangeLog: * coroutines.cc (struct local_vars_frame_data): Ad

[PATCH] libstdc++: add default template parameters to algorithms

2024-08-02 Thread Giuseppe D'Angelo
Hello, The attached patch adds support for P2248R8 + P3217R0 (Enabling list-initialization for algorithms, C++26). The big question is whether this keeps the code readable enough without introducing too much #ifdef-ery, so any feedback is appreciated. Thanks, -- Giuseppe D'Angelo From 9f1a8

[pushed] c++, coroutines: Remove unused suspend point state [NFC].

2024-08-02 Thread Iain Sandoe
Tested on x86_64-darwin, pushed to trunk as obvious, thanks Iain --- 8< --- We maintain state on the progress of await analysis in an object that is passed to the various tree walks used. Some of the state had become stale (i.e. unused members). Remove those and provide a CTOR so that updates a

[pushed] c++, coroutines: Fix a typo in checking for void expression types.

2024-08-02 Thread Iain Sandoe
tested on x86_64-darwin and linux, pushed to trunk as obvious, thanks, Iain --- 8< --- The current code fails to check for void expression types because it does not lookup the type. Fixed thus. gcc/cp/ChangeLog: * coroutines.cc (replace_continue): Look up expression type. Signed-off-b

Re: [PATCH] MATCH: add abs support for half float

2024-08-02 Thread Richard Biener
On Fri, Aug 2, 2024 at 11:20 AM Kugan Vivekanandarajah wrote: > > > > > On 1 Aug 2024, at 10:46 pm, Richard Biener > > wrote: > > > > External email: Use caution opening links or attachments > > > > > > On Thu, Aug 1, 2024 at 5:31 AM Kugan Vivekanandarajah > > wrote: > >> > >> > >> On Mon, Jul

[PATCH, v2] libstdc++: Preserve signbit of nan when converting float to double [PR113578]

2024-08-02 Thread Jonathan Wakely
Rivos CI found a problem in the v1 patch (see the PR comments). This should solve it, by using 'constexpr' not _GLIBCXX17_CONSTEXPR. That requires diagnostic pragmas to suppress -Wc++17-extensions and isn't possible at all in C++98 mode, so just use the slightly less efficient __builtin_signbit(__f

Re: [RFC/RFA] [PATCH v2 09/12] Add symbolic execution support.

2024-08-02 Thread Richard Biener
On Wed, Jul 31, 2024 at 12:42 PM Mariam Arutunian wrote: > > Gives an opportunity to execute the code on bit level, >assigning symbolic values to the variables which don't have initial values. >Supports only CRC specific operations. > >Example: > >uint8_t crc; >uint8_t pol

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-08-02 Thread Richard Biener
On Wed, Jul 31, 2024 at 10:15 AM Mariam Arutunian wrote: > > This patch adds a new compiler pass aimed at identifying naive CRC > implementations, > characterized by the presence of a loop calculating a CRC (polynomial long > division). > Upon detection of a potential CRC, the pass prints an i

Re: [PATCH 2/2 v3] libstdc++: add std::is_virtual_base_of

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 10:35, Giuseppe D'Angelo wrote: > > Hello, > > On 31/07/2024 00:55, Jonathan Wakely wrote: > > If __cpp_lib_is_virtual_base_of depends on __has_builtin, then that > > will do the right thing for #ifdef __cpp_lib_is_virtual_base_of in > > . > > Third time's the charm, I hope; c

Re: [PATCH 2/2 v3] libstdc++: add std::is_virtual_base_of

2024-08-02 Thread Giuseppe D'Angelo
Hello, On 31/07/2024 00:55, Jonathan Wakely wrote: If __cpp_lib_is_virtual_base_of depends on __has_builtin, then that will do the right thing for #ifdef __cpp_lib_is_virtual_base_of in . Third time's the charm, I hope; clang trunk seems to like this. Thank you, -- Giuseppe D'Angelo From 7e81

Re: [PATCH] MATCH: add abs support for half float

2024-08-02 Thread Kugan Vivekanandarajah
> On 1 Aug 2024, at 10:46 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Thu, Aug 1, 2024 at 5:31 AM Kugan Vivekanandarajah > wrote: >> >> >> On Mon, Jul 29, 2024 at 10:11 AM Andrew Pinski wrote: >>> >>> On Mon, Jul 29, 2024 at 12:57 AM Ku

[PATCH v1] aarch64: Add fp8 scalar types

2024-08-02 Thread Claudio Bantaloukas
The ACLE defines a new scalar type, __mfp8. This is an opaque 8bit types that can only be used by fp8 intrinsics. Additionally, the mfloat8_t type is made available in arm_neon.h and arm_sve.h as an alias of the same. This implementation uses an INTEGER_TYPE, with precision 8 to represent __mfp8.

Re: [PATCH] aarch64: Fuse CMP+CSEL and CMP+CSET for -mcpu=neoverse-v2

2024-08-02 Thread Jennifer Schmitz
Dear Richard, Thanks for the feedback! I made the changes as suggested. Here is the updated patch, bootstrapped and tested again. Best, Jennifer 0001-AArch64-Fuse-CMP-CSEL-and-CMP-CSET-for-mcpu-neoverse.patch Description: Binary data > On 31 Jul 2024, at 21:21, Richard Sandiford wrote: > > Ex

Re: [RFC] RISC-V: Add support for Profiles RVA/B23.

2024-08-02 Thread Jiawei
在 2024/8/1 21:54, Christoph Müllner 写道: On Mon, Jul 29, 2024 at 5:26 AM Jiawei wrote: This patch adds support for RISC-V RVA23 and RVB23 Profiles[1], which depend on the base RISC-V Profiles support[2]. [1] https://github.com/riscv/riscv-profiles/releases/tag/rva23-v0.4-rvb23-v0.1-internal-

Re: [PATCH] fortran: Fix a pasto in gfc_check_dependency

2024-08-02 Thread Tobias Burnus
[static analyzer] Jakub Jelinek wrote: […] it is some proprietary static analyzer I want to point out that a under utilized static analyzer keeps scanning GCC: Coverity Scan. If someone has the time, I think it would be worthwhile to have a look at the reports. There are a bunch of persons

Re: [PATCH] fortran: Fix a pasto in gfc_check_dependency

2024-08-02 Thread Jakub Jelinek
On Thu, Aug 01, 2024 at 09:03:39PM +0200, Mikael Morin wrote: > Le 01/08/2024 à 12:00, Jakub Jelinek a écrit : > > Hi! > > > > A static analyzer found what seems like a pasto in the PR45019 changes, > > the second branch of || only accesses sym2 while the first one sym1 except > > for this one spo

Re: [PATCH] aarch64: Add support for AdvSIMD faminmax

2024-08-02 Thread Kyrylo Tkachov
Hi Saurabh, > On 1 Aug 2024, at 11:14, Saurabh Jha wrote: > > External email: Use caution opening links or attachments > > > The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and > mandatory from Armv9.5-a. It introduces instructions for computing the > floating point absolute maxi

RE: [PATCH] i386: Fix comment/naming for APX NDD constraints

2024-08-02 Thread Liu, Hongtao
> -Original Message- > From: Kong, Lingling > Sent: Friday, August 2, 2024 2:43 PM > To: gcc-patches@gcc.gnu.org > Cc: Liu, Hongtao ; H. J. Lu > Subject: [PATCH] i386: Fix comment/naming for APX NDD constraints > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for tru

Re: [committed] libstdc++: Remove unnecessary uses of

2024-08-02 Thread Jonathan Wakely
On Fri, 2 Aug 2024 at 02:29, Andrew Pinski wrote: > > On Thu, Aug 1, 2024 at 2:14 PM Jonathan Wakely wrote: > > > > This will probably need a gcc-15/porting_to.html entry at some point. > > Every time we remove transitive includes of it breaks > > somebody! > > Yes including testcases, libstdc++

[COMMITTED 26/26] ada: Fix handling of SPARK_Mode on standalone child subprogram

2024-08-02 Thread Marc Poulhiès
From: Yannick Moy SPARK_Mode aspect was not properly propagated to the body of a standalone child subprogram from the generated spec for that subprogram, leading GNATprove to not analyze this body. Now fixed. gcc/ada/ * aspects.adb (Find_Aspect): Take into account the case of a node

[COMMITTED 24/26] ada: Remove unused null branch

2024-08-02 Thread Marc Poulhiès
From: Piotr Trojanek Code cleanup; semantics is unaffected. gcc/ada/ * exp_util.adb (Insert_Actions): Remove null ELSE branch. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_util.adb | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/ada/exp_util.adb b/gcc

[COMMITTED 22/26] ada: Refactor negated conjuncts

2024-08-02 Thread Marc Poulhiès
From: Piotr Trojanek Code cleanup; semantics is unaffected. gcc/ada/ * exp_util.adb (Insert_Actions): Move negation in front of complex conjunctions. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_util.adb | 13 +++-- 1 file changed, 7 insertions(

[COMMITTED 17/26] ada: Add contracts to Ada.Strings.Unbounded and adapt implementation

2024-08-02 Thread Marc Poulhiès
From: Yannick Moy Add complete functional contracts to all subprograms in Ada.Strings.Unbounded, except Count, following the specification from Ada RM A.4.5. These contracts are similar to the contracts found in Ada.Strings.Fixed and Ada.Strings.Bounded. A difference is that type Unbounded_Strin

[COMMITTED 20/26] ada: Errors on legal container aggregates with iterated_element_associations

2024-08-02 Thread Marc Poulhiès
From: Gary Dismukes The compiler rejects various cases of container aggregates with iterated_element_associations that include a loop_parameter_subtype_indication or that include the "reverse" keyword. The fixes are in the parser, for naccepting the syntax for these cases, as well as for properly

[COMMITTED 15/26] ada: Remove unreferenced procedure

2024-08-02 Thread Marc Poulhiès
From: Richard Kenner gcc/ada/ * exp_ch4.adb (Generate_Temporary): Remove unused procedure. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_ch4.adb | 43 --- 1 file changed, 43 deletions(-) diff --git a/gcc/ada/exp_ch4.adb b/

[COMMITTED 25/26] ada: Fix handling of iterated component associations with sub-aggregates

2024-08-02 Thread Marc Poulhiès
From: Piotr Trojanek Fix a number of problems in handling of actions generated for a 2-dimensional array aggregate where the outer aggregate has iterated component association and the inner aggregate involves run-time checks. gcc/ada/ * exp_aggr.adb (Add_Loop_Actions): Actions are now a

[COMMITTED 11/26] ada: Reject ambiguous function calls in interpolated string expressions

2024-08-02 Thread Marc Poulhiès
From: Javier Miranda This patch enhances support for this language feature by rejecting more ambiguous function calls. In terms of name resolution, the analysis of interpolated expressions is now treated as an expression of any type, as required by the documentation. Additionally, support for nes

[COMMITTED 21/26] ada: Simplify code by reusing Choice_List

2024-08-02 Thread Marc Poulhiès
From: Piotr Trojanek Code cleanup; semantics is unaffected. gcc/ada/ * exp_aggr.adb (Gen_Assign): Fix layout. * sem_aggr.adb (Empty_Range): Reuse Choice_List. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_aggr.adb | 8 gcc/ada/sem_aggr.adb | 8 +

[COMMITTED 23/26] ada: Simplify manipulation of the list with loop actions

2024-08-02 Thread Marc Poulhiès
From: Piotr Trojanek Code cleanup; behavior is unaffected. gcc/ada/ * exp_aggr.adb (Add_Loop_Actions): Change manipulation of list to avoid unnecessary calls to Parent and Loop_Actions. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_aggr.adb | 2 +- 1 fil

[COMMITTED 10/26] ada: Compiler accepts illegal assignment to reference type target.

2024-08-02 Thread Marc Poulhiès
From: Steve Baird An assignment statement whose LHS is of a reference type is never legal. If no other legality rule is violated, then it is ambiguous. In some cases this ambiguity was not correctly detected. gcc/ada/ * sem_ch5.adb (Analyze_Assignment): Delete code that was inco

[COMMITTED 18/26] ada: Tweak container aggregate expansion code

2024-08-02 Thread Marc Poulhiès
From: Ronan Desplanques This patch makes a minor modification to Expand_Container_Aggregate in order to silence a GNAT SAS false positive. gcc/ada/ * exp_aggr.adb (Expand_Container_Aggregate): Remove variables. (To_Int): New function. (Add_Range_Size): Use newly introduc

[COMMITTED 13/26] ada: Add leap second support to conversion of Unix_Time

2024-08-02 Thread Marc Poulhiès
From: Tonu Naks Unix timestamp jumps one second back when a leap second is applied and doesn't count cumulative leap seconds. This was not taken into account in conversions between Unix time and Ada time. Now fixed. gcc/ada/ * libgnat/a-calend.adb: Modify unix time handling. Tested on

[COMMITTED 16/26] ada: Ensure variable is initialized before use

2024-08-02 Thread Marc Poulhiès
From: Ronan Desplanques This patch is motivated by a GNAT SAS report. gcc/ada/ * scng.adb (Slit): Initialize object in uncommon path. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/scng.adb | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/ada/scng.adb b/gcc/ad

[COMMITTED 09/26] ada: Finish up support for relaxed finalization

2024-08-02 Thread Marc Poulhiès
From: Eric Botcazou This adds a variant of the System.Finalization_Primitives unit that supports only controlled types with relaxed finalization, and adds the description of its implementation to Exp_Ch7. gcc/ada/ * exp_ch7.adb (Relaxed Finalization): New paragraph in head comme

[COMMITTED 19/26] ada: Plug loophole in handling of No_Raise pragma

2024-08-02 Thread Marc Poulhiès
From: Eric Botcazou Unlike the aspect, the pragma needs to be propagated explicitly from a generic subprogram to its instances. gcc/ada/ * sem_ch12.adb (Analyze_Subprogram_Instantiation): Propagate the No_Raise flag like the No_Return flag. Tested on x86_64-pc-linux-gnu, commit

[COMMITTED 08/26] ada: Fix handling reference warnings with slices

2024-08-02 Thread Marc Poulhiès
From: Viljar Indus gcc/ada/ * sem_util.adb (Set_Referenced_Modified): Set referenced as LHS for the prefixes of array slices. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_util.adb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/g

[COMMITTED 12/26] ada: Update doc of Style_Checks pragma

2024-08-02 Thread Marc Poulhiès
From: Tonu Naks gcc/ada/ * doc/gnat_rm/implementation_defined_pragmas.rst: Add examples. * gnat_rm.texi: Regenerate. * gnat_ugn.texi: Regenerate. Tested on x86_64-pc-linux-gnu, committed on master. --- .../implementation_defined_pragmas.rst| 79

[COMMITTED 07/26] ada: Reject illegal uses of type/subtype current instance

2024-08-02 Thread Marc Poulhiès
From: Steve Baird The current instance of a type or subtype (see RM 8.6) is an object or value, not a type or subtype. So a name denoting such a current instance is illegal in any context that requires a name denoting a type or subtype. In some cases this error was not detected. gcc/ada/

[COMMITTED 06/26] ada: Type conversion in instance incorrectly rejected.

2024-08-02 Thread Marc Poulhiès
From: Steve Baird In some cases, a legal type conversion in a generic package is correctly accepted but the corresponding type conversion in an instance of the generic is incorrectly rejected. gcc/ada/ * sem_res.adb (Valid_Conversion): Test In_Instance instead of In_Instance_Bod

[COMMITTED 14/26] ada: Clean up handling of inlining of finalizer procedures

2024-08-02 Thread Marc Poulhiès
From: Richard Kenner Change Is_Finalizer from synthesized attribute into flag. Remove duplicate Is_Finalizer_Proc. Add new Try_Inline_Always for backend usage. gcc/ada/ * einfo-utils.ads (Is_Finalizer): Delete. * einfo-utils.adb (Is_Finalizer): Delete. * einfo.ads: Adjus

  1   2   >