On 8/1/24 7:51 PM, Andrew Pinski wrote:
In a define_insn, you could use either an explicit parallel for the insns or genrecog/genemit will add one for you. The problem when genemit is processing the pattern for clobbers (to create the function add_clobbers), genemit hadn't add the implicit parallel yet but at the same time forgot to ignore that there could be an explicit parallel there. This means in some cases (like in the sh backend), add_clobbers and recog had a different idea if there was clobbers on the insn. This fixes the problem by looking through the explicit parallel for the instruction in genemit. Bootstrapped and tested on x86_64-linux-gnu. PR middle-end/116058 gcc/ChangeLog: * genemit.cc (struct clobber_pat): Change pattern to be rtvec. Add code field. (gen_insn): Look through an explicit parallel if there was one. Update store to new clobber_pat. (output_add_clobbers): Update call to gen_exp for the changed clobber_pat.
Richard S. effectively ack'd in the BZ. So Ok for the trunk. jeff