Re: [patch] Guard aarch64/aapcs64 tests using abitest.S by check_weak_available

> On 16 Dec 2019, at 14:54, Richard Sandiford wrote: >> We have local patches adding >> >> dg-require-effective-target fpic >> >> directives to these. >> >> Is that the correct thing to do ? > > Yeah. Adding that to tests that use -fpic or -fPIC is OK/preapproved. > > Personally, I don't

[patch, fortran] Fix PR 91541, ICE on valid for INDEX

Hello world, the attached patch fixes an ICE on valid for INDEX (see test case). The problem was that the KIND argument was still present during scalarization, which caused the ICE. The fix is to remove the KIND argument, and the best place to do this is in resolution. I did try to do this in g

Re: gccgo branch updated

I've updated the gccgo branch to revision 279561 of trunk. Ian

Re: [PATCH] Handle aggregate pass-through for self-recursive call (PR ipa/92794)

>> +static bool >> +self_recursive_agg_pass_through_p (cgraph_edge *cs, ipa_agg_jf_item *jfunc, >> +int i) >> +{ >> + if (cs->caller == cs->callee->function_symbol () > I don't know if self-recursive calls can be interposed at all, if yes > you need to add the av

Re: [PATCH 12/49] Add diagnostic paths

On Sat, 2019-12-07 at 07:45 -0700, Jeff Law wrote: > On Fri, 2019-11-15 at 20:22 -0500, David Malcolm wrote: > > This patch adds support for associating a "diagnostic_path" with a > > diagnostic: a sequence of events predicted by the compiler that > > leads > > to > > the problem occurring, with th

Re: [PATCH] [RFC] ipa: duplicate ipa_size_summary for cloned nodes

On 2019/12/18 23:48, Jan Hubicka wrote: >> The size_info of ipa_size_summary are created by r277424. It should be >> duplicated for cloned nodes, otherwise self_size and >> estimated_self_stack_size >> would be 0, causing param large-function-insns and large-function-growth >> working >> inaccur

[C++ PATCH] PR c++/91165 follow-on tweak

I talked in the PR about possibly stripping the location from the args in the hash table, since if we use the cache the locations would be wrong, but didn't actually do anything about that. Then I noticed that there's already unshare_expr_without_location... Tested x86_64-pc-linux-gnu, applying t

[committed] Add diagnostic_metadata and CWE support

This patch adds support for associating a diagnostic message with an optional diagnostic_metadata object, so that plugins can add extra data to their diagnostics (e.g. mapping a diagnostic to a taxonomy or coding standard such as from CERT or MISRA). Currently this only supports associating a CWE

[C++ PATCH] Fix -Wunused-but-set-* false positives in arg passing to ... (PR c++/92666)

Hi! convert_arg_to_ellipsis used to call decay_conversion for all types (which calls mark_rvalue_use), but it doesn't anymore in GCC 10, and while for INTEGRAL_OR_ENUMERATION_TYPE_P args it calls cp_perform_integral_promotions which does that too and for aggregate args keeps calling decay_conversi

[C++ PATCH] Don't ignore side-effects on decltype(nullptr) typed args passed to ... (PR c++/92992)

Hi! While looking at PR92666, I've spotted a wrong-code issue where we ignore any side-effects on arguments passed to ellipsis if they have decltype(nullptr) type. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and release branches? 2019-12-19 Jakub Jelinek

[committed] Avoid some Fortran FE opts in OpenMP atomics (PR fortran/92977)

Hi! Similarly to EXEC_OMP_WORKSHARE, EXEC_OMP_ATOMIC has also very tight rules what can and can't appear in the block, enforced through parsing and resolving, so e.g. inserting EXEC_BLOCK there leads to ICEs. In theory, one could add such a BLOCK around the atomic rather than inside of it, but th

[PATCH] Partially fix libgomp/testsuite/libgomp.c/pr86416-*.c

Hi! As mentioned in the PR, I believe we should use long double float suffixes in the test testing long double and Q suffixes in the test that tests __float128, both because PowerPC doesn't allow mixing them and because only the latter test is guarded on float128 support. Bootstrapped/regtested o

Re: [PATCH 10/13] OpenACC 2.6 deep copy: Fortran front-end parts

On 12/18/19 7:04 AM, Julian Brown wrote: This part contains the Fortran front-end support for parsing the new attach and detach clauses, as well as derived-type members on other data-movement clauses (copyin, copyout, etc.). I browsed the patch and it looks mostly fine to me. However, I do have

[PATCH] PowerPC, Rename SIGNED_BIT_OFFSET_P to SIGNED_INTEGER_BIT_P

In the patch: https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01201.html Segher Boessenkool asked me to submit a patch to rename the macros used to see if a number is a valid signed 16 or 34-bit value: > Please follow up with a patch to not call random numbers "OFFSET". This patch does this, renam

Re: [PATCH] V10 patch #5, Fix codegen bug with vector extracts using a variable offset & PC-relative address

On Tue, Dec 17, 2019 at 12:02:46PM -0600, Segher Boessenkool wrote: > > ;; Variable V2DI/V2DF extract > > (define_insn_and_split "vsx_extract__var" > > - [(set (match_operand: 0 "gpc_reg_operand" "=v,wa,r") > > - (unspec: [(match_operand:VSX_D 1 "input_operand" "v,m,m") > > -

Re: [Patch] Add OpenACC 2.6's no_create

Hi Tobias! On 2019-12-18T13:36:29+0100, Tobias Burnus wrote: > libgomp/target.c's gomp_map_vars_internal: it now uses the normal code > path in the upper loop, except that one directly bails out when the > 'key' has not been found (skipping the adjacent MAP_POINTER as well). > The 'case' in th

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

On Wed, Dec 18, 2019 at 08:47:31AM +, Mark Eggleston wrote: > > It is a bit confusing that the Fortran FE source files have the .c > extension implying C when they are C++ and are compiled using C++. It is not puzzling at all. gfortran was added to GCC some 15 years ago. gfortran was origin

[RFC][C++ PATCH] Don't mangle attributes that have a space in their name

The SVE port needs to maintain a different type identity for GNU vectors and "SVE vectors" even during LTO, since the types use different ABIs. The easiest way of doing that seemed to be to use type attributes. However, these type attributes shouldn't be user-facing; they're just a convenient way

Re: [PATCH 00/13] OpenACC 2.6 manual deep copy support

Hi! On 2019-12-17T22:02:25-0800, Julian Brown wrote: > This patch series provides support for OpenACC 2.6's manual deep copy > (attach/detach) feature. Thanks. There is high pressure to get this functionality into GCC 10, but remaining time is short, given upcoming winter holidays, and GCC dev

[committed] Drop unused member from cpp_string_location_reader (PR preprocessor/92982)

Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Committed to trunk as r279541. libcpp/ChangeLog: PR preprocessor/92982 * charset.c (cpp_string_location_reader::cpp_string_location_reader): Delete initialization of m_line_table. * include/cppli

Re: [PATCH] OpenACC reference count overhaul

Hi! On 2019-12-11T18:22:00+0100, I wrote: > On 2019-10-29T12:15:01+, Julian Brown wrote: >> I've removed the special-case handling >> of pointers in the enter/exit data code, and combined the >> gomp_acc_remove_pointer code (which now iterated over mappings >> one-at-a-time anyway) with the l

Re: [PATCH][ARM][GCC][1/x]: MVE ACLE intrinsics framework patch.

On 11/14/19 7:12 PM, Srinath Parvathaneni wrote: Hello, This patch creates the required framework for MVE ACLE intrinsics. The following changes are done in this patch to support MVE ACLE intrinsics. Header file arm_mve.h is added to source code, which contains the definitions of MVE ACLE

Re: [RFC] Offloading Support in libgomp

Hi! On 2019-12-07T15:22:33+0100, I wrote: > [...] propose the attached patch > adding a safeguard [...] See attached "Assert in 'libgomp/target.c:gomp_unmap_vars_internal' that we're not unmapping 'tgt' while it's still in use"; committed to trunk in r279534. Grüße Thomas From 7c82035afd9b01

Re: [RFC PATCH] Coalesce host to device transfers in libgomp

Hi! On 2017-10-25T13:38:50+0200, Jakub Jelinek wrote: > --- libgomp/target.c.jj 2017-10-24 12:07:03.763759657 +0200 > +++ libgomp/target.c 2017-10-25 13:17:31.608975390 +0200 > +/* Return true for mapping kinds which need to copy data from the > + host to device for regions that weren't

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

Hi! On 2018-05-25T13:01:58-0700, Cesar Philippidis wrote: > This patch updates GCC's to support OpenACC 2.5's data clause semantics. Per "OpenACC 2.5: 'acc_delete' etc. on non-present data is a no-op", which this patch didn't address. I wanted to delay fixing this

Re: [OpenACC] Elaborate/simplify 'exit data' 'finalize' handling (was: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior)

Hi! On 2019-12-13T23:34:15+, Julian Brown wrote: > On Fri, 13 Dec 2019 15:13:53 +0100 > Thomas Schwinge wrote: >> Julian, Tobias, regarding the following OpenACC 'exit data' 'finalize' >> handling: >> >> On 2018-05-25T13:01:58-0700, Cesar Philippidis >> wrote: >> > [...] >> >> ... does th

[PR92848] [OpenACC] Use 'GOMP_MAP_VARS_ENTER_DATA' for dynamic data lifetimes

Hi! I haven't researched when this broke, but to fix PR92848 "[OpenACC] Memory leak for simple 'acc_create', 'acc_delete' sequence", see attached "[PR92848] [OpenACC] Use 'GOMP_MAP_VARS_ENTER_DATA' for dynamic data lifetimes"; committed to trunk in r279530. Grüße Thomas From 4b1057f6d9f6b4dbc

Re: [PATCH, OpenACC, libgomp, v6, stage1] Async-rework update

Hi! On 2019-05-13T21:33:20+0800, Chung-Lin Tang wrote: > committed (... in r271128.) As obvious, see attached "Make 'libgomp/target.c:gomp_unmap_tgt' 'static' again"; committed to trunk in r279529. Grüße Thomas From 60272bbbd67100b5fd864bfa8a9495b249778a66 Mon Sep 17 00:00:00 2001 From: ts

Re: [PATCH][GCC][arm] Add CLI and multilib support for Armv8.1-M Mainline MVE extensions

On 12/18/19 5:00 PM, Mihail Ionescu wrote: Hi Kyrill, On 12/18/2019 02:13 PM, Kyrill Tkachov wrote: > Hi Mihail, > > On 11/8/19 4:52 PM, Mihail Ionescu wrote: >> Hi, >> >> This patch adds CLI and multilib support for Armv8.1-M MVE to the Arm >> backend. >> Two new option added for v8.1-m.main:

Re: [PATCH][GCC][arm] Add CLI and multilib support for Armv8.1-M Mainline MVE extensions

Hi Kyrill, On 12/18/2019 02:13 PM, Kyrill Tkachov wrote: Hi Mihail, On 11/8/19 4:52 PM, Mihail Ionescu wrote: Hi, This patch adds CLI and multilib support for Armv8.1-M MVE to the Arm backend. Two new option added for v8.1-m.main: "+mve" for integer MVE instructions only and "+mve.fp" for

Re: [PATCH, GCC/ARM, 9/10] Call nscall function with blxns

On 12/18/19 1:38 PM, Mihail Ionescu wrote: Hi, On 11/12/2019 10:23 AM, Kyrill Tkachov wrote: On 10/23/19 10:26 AM, Mihail Ionescu wrote: [PATCH, GCC/ARM, 9/10] Call nscall function with blxns Hi, === Context === This patch is part of a patch series to add support for Armv8.1-M Mainline S

Re: [GCC][testsuite][ARM][AArch64] Add ARM v8.6 effective target checks to target-supports.exp

Stam Markianos-Wright writes: > On 12/13/19 11:15 AM, Richard Sandiford wrote: >> Stam Markianos-Wright writes: >>> Hi all, >>> >>> This small patch adds support for the ARM v8.6 extensions +bf16 and >>> +i8mm to the testsuite. This will be tested through other upcoming >>> patches, which is why

Re: [LTO] PR 86416 – improve lto1 diagnostic if a mode does not exist (esp. for offloading targets)

On Wed, Dec 18, 2019 at 05:39:51PM +0100, Tobias Burnus wrote: > Hence, one can write a much cleaner patch which is about as long as the hack > but not hackish :-) > > Bootstrapped + regtested on x86-64-gnu-linux w/o offloading and with nvptx > offloading. > OK? LGTM. > 2019-12-18 Tobias Burnus

Re: [Patch, fortran] PR70853 - ICE on pointing to null, in gfc_add_block_to_block, at fortran/trans.c:1599

On 12/18/19 17:17, Tobias Burnus wrote: > LGTM. Thanks for the patch! Thanks, committed as r279527. > Tobias > > PS: I assume, your patch also fixes the following test case, which also > ICEs in gfc_trans_pointer_assignment: > integer, pointer, contiguous :: x(:) > nullify(x(1:1)) > end Well, th

Re: [LTO] PR 86416 – improve lto1 diagnostic if a mode does not exist (esp. for offloading targets)

Hi Jakub, thanks for the pointers; I was also not happy about part (B). The mode gets written at lto-streamer-out.c's lto_write_mode_table, which is already called with 'if (lto_stream_offload_p)'. — Looking at places where the name gets constructed, I realized that required information is al

[GCC][PATCH][Aarch64] Add Bfloat16_t scalar type, vector types and machine modes to Aarch64 back-end [2/2]

Hi all, This patch is part 2 of Bfloat16_t enablement in the Aarch64 back-end. This new type is constrained using target hooks TARGET_INVALID_CONVERSION, TARGET_INVALID_UNARY_OP, TARGET_INVALID_BINARY_OP so that it may only be used through ACLE intrinsics (will be provided in later patches). R

[GCC][PATCH][Aarch64] Add Bfloat16_t scalar type, vector types and machine modes to Aarch64 back-end [1/2]

Hi all, This patch adds Bfloat type support to the ARM back-end. It also adds a new machine_mode (BFmode) for this type and accompanying Vector modes V4BFmode and V8BFmode. The second patch in this series uses existing target hooks to restrict type use. Regression testing on aarch64-none-elf pa

Re: [Patch, fortran] PR70853 - ICE on pointing to null, in gfc_add_block_to_block, at fortran/trans.c:1599

LGTM. Thanks for the patch! Tobias PS: I assume, your patch also fixes the following test case, which also ICEs in gfc_trans_pointer_assignment: integer, pointer, contiguous :: x(:) nullify(x(1:1)) end On 12/18/19 5:07 PM, Harald Anlauf wrote: The patch is self-explaining and practically obv

[Patch, fortran] PR70853 - ICE on pointing to null, in gfc_add_block_to_block, at fortran/trans.c:1599

The patch is self-explaining and practically obvious: pointer bounds remapping to NULL is not allowed, thus we shall reject it. I hope the error message is fine. If somebody prefers a formulation as in the standard ("data target", also used by the Intel compiler), please speak now. Regtested on

Re: [PATCH] Handle aggregate pass-through for self-recursive call (PR ipa/92794)

> Hi, > > On Tue, Dec 17 2019, Feng Xue OS wrote: > > If argument for a self-recursive call is a simple pass-through, the call > > edge is also considered as source of any value originated from > > non-recursive call to the function. Scalar pass-through and full aggregate > > pass-through due to p

Re: [PATCH 05/49] vec.h: add auto_delete_vec

On Wed, 2019-12-04 at 09:29 -0700, Martin Sebor wrote: > On 11/15/19 6:22 PM, David Malcolm wrote: > > This patch adds a class auto_delete_vec, a subclass of auto_vec > > > > that deletes all of its elements on destruction; it's used in many > > places later in the kit. > > > > This is a crude wa

Re: [PATCH] Handle aggregate pass-through for self-recursive call (PR ipa/92794)

Hi, On Tue, Dec 17 2019, Feng Xue OS wrote: > If argument for a self-recursive call is a simple pass-through, the call > edge is also considered as source of any value originated from > non-recursive call to the function. Scalar pass-through and full aggregate > pass-through due to pointer pass-th

Re: [PATCH] [RFC] ipa: duplicate ipa_size_summary for cloned nodes

> The size_info of ipa_size_summary are created by r277424. It should be > duplicated for cloned nodes, otherwise self_size and estimated_self_stack_size > would be 0, causing param large-function-insns and large-function-growth > working > inaccurate when ipa-inline. > > gcc/ChangeLog: > >

[patch][avr] New option -nodevicespecs to omit -specs=... in self specs.

Hi, currently device support in avr-gcc is accomplished by injecting a specs file my means of -specs=... in dirver self specs. This patch adds a new avr driver option to omit the addition of respective -specs option so give the user more freedom. Ok to apply? Johann * config/avr/avr

[patch][avr] PR92606: Disable -fipa-icf-variables because it generates wrong code.

Hi, this patch turns off -fipa-icf-variables because it generates wrong code like for PR92606. As there is no target hook that could decide whether such optimizations are obsolete, disable such optimizations alltogether until PR92932 (target hook to disable such optimizations depending on obje

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

On 12/18/19 8:15 AM, Segher Boessenkool wrote: >> +/* { dg-do compile { target { powerpc*-*-* } } } */ >> +/* { dg-options "-w -O2 -mdejagnu-cpu=power9" } */ > > You don't need that target clause in gcc.target/powerpc (and dg-do compile > is the default, but having it explicit is also fine of cour

Re: [PATCH] [RFC] ipa: duplicate ipa_size_summary for cloned nodes

> The size_info of ipa_size_summary are created by r277424. It should be > duplicated for cloned nodes, otherwise self_size and estimated_self_stack_size > would be 0, causing param large-function-insns and large-function-growth > working > inaccurate when ipa-inline. > > gcc/ChangeLog: > >

Re: [PATCH] IPA-CP: Remove bogus static keyword (PR 92971)

> > the leak is indeed a problem, thanks for spotting it. But apart from > that, I really wanted to pass vNULL to intersect_aggregates_with_edge, > and the patch below does it explicitely to make it clear, because while > the function can do also intersecting its actual task here is to carry > ov

Re: [PATCH] analyzer: remove __analyzer builtins

On Wed, Dec 18, 2019 at 09:36:55AM -0500, David Malcolm wrote: > This patch eliminates the builtins in favor of a header file in the > DejaGnu testsuite. > > Jakub: do you prefer this approach? (eliminating the builtins in favor of > "magic" function names for use just using analyzer DejaGnu tests

[PATCH] analyzer: remove __analyzer builtins

On Fri, 2019-12-13 at 13:31 -0500, David Malcolm wrote: > On Fri, 2019-12-13 at 19:27 +0100, Jakub Jelinek wrote: > > On Fri, Dec 13, 2019 at 01:11:05PM -0500, David Malcolm wrote: > > > gcc/ChangeLog: > > > * builtins.def (BUILT_IN_ANALYZER_BREAK): New builtin. > > > (BUILT_IN_ANALYZER_DUMP):

Re: [PATCH] Fix symver attribute with LTO

On 2019-12-18 14:19 +0100, Jan Hubicka wrote: > The problem here is that we lie to the compiler (by pretending that > foo_v2 is exported from DSO while it is not) and force user to do the > same. > > We support two ways to hide symbol - either at compile time via > attribute((visibility("hidden"))

Re: [PATCH] Fix symver attribute with LTO

On 2019-12-18 14:19 +0100, Jan Hubicka wrote: > > ICE here. > > > > lto1: internal compiler error: tree check: expected identifier_node, have > > function_decl in ultimate_transparent_alias_target, at varasm.c:1308 > > 0x6f9cfe tree_check_failed(tree_node const*, char const*, int, char const*, > >

Re: [PATCH] rs6000: Fix 2 for PR92661, Do not define builtins that overload disabled builtins

(Whoops, I missed replying t this one. Sorry.) On Tue, Dec 10, 2019 at 12:27:11PM -0600, Peter Bergner wrote: > On 12/4/19 5:03 PM, Segher Boessenkool wrote: > > On Wed, Dec 04, 2019 at 03:53:30PM -0600, Peter Bergner wrote: > >> Right. I'll come up with a patch and hopefully Iain and David can

Re: [PATCH][GCC][arm] Add CLI and multilib support for Armv8.1-M Mainline MVE extensions

Hi Mihail, On 11/8/19 4:52 PM, Mihail Ionescu wrote: Hi, This patch adds CLI and multilib support for Armv8.1-M MVE to the Arm backend. Two new option added for v8.1-m.main: "+mve" for integer MVE instructions only and "+mve.fp" for both integer and single-precision/half-precision floating-p

Re: [PATCH] IPA-CP: Remove bogus static keyword (PR 92971)

Hi, On Tue, Dec 17 2019, Jakub Jelinek wrote: > On Tue, Dec 17, 2019 at 01:50:32PM +0100, Martin Jambor wrote: >> Hi, >> >> as reported in PR 92971, IPA-CP's >> cgraph_edge_brings_all_agg_vals_for_node defines one local variable with >> the static keyword which is a clear mistake, probabley a cut

Re: [patch] Use simple LRA algorithm at -O0

On 2019-12-17 1:02 p.m., Eric Botcazou wrote: Hi, LRA is getting measurably slower since GCC 8, at least on x86, and things are worsening since GCC 9. While this might be legitimate when optimization is enabled, it's a pure waste of cycles at -O0 so the attached patch switches LRA over to usi

Re: [PATCH] V10 patch #4, Add new prefixed/non-prefixed memory constraints

Hi! On Tue, Dec 17, 2019 at 07:38:51PM -0500, Michael Meissner wrote: > On Tue, Dec 17, 2019 at 05:35:24PM -0600, Segher Boessenkool wrote: > > And what is with the INSN_FORM_PCREL_EXTERNAL? > > INSN_FORM_PCREL_EXTERNAL says that the operand is a reference to an external > symbol. It cannot appe

Re: 'find_group_last' (was: [PATCH] OpenACC reference count overhaul)

On Wed, 18 Dec 2019 10:18:14 +0100 Thomas Schwinge wrote: > Hi Julian! > > Thanks for walking me through this. > > On 2019-12-14T00:19:04+, Julian Brown > wrote: > > On Fri, 13 Dec 2019 16:25:25 +0100 > > Thomas Schwinge wrote: > >> On 2019-10-29T12:15:01+, Julian Brown > >> wrote:

Re: [PATCH, GCC/ARM, 9/10] Call nscall function with blxns

Hi, On 11/12/2019 10:23 AM, Kyrill Tkachov wrote: On 10/23/19 10:26 AM, Mihail Ionescu wrote: [PATCH, GCC/ARM, 9/10] Call nscall function with blxns Hi, === Context === This patch is part of a patch series to add support for Armv8.1-M Mainline Security Extensions architecture. Its purpose i

Re: [PATCH, GCC/ARM, 8/10] Do lazy store & load inline when calling nscall function

Hi Kyrill, On 11/12/2019 10:22 AM, Kyrill Tkachov wrote: Hi Mihail, On 10/23/19 3:24 PM, Mihail Ionescu wrote: [PATCH, GCC/ARM, 8/10] Do lazy store & load inline when calling nscall function Hi, === Context === This patch is part of a patch series to add support for Armv8.1-M Mainline Secu

Re: [PATCH, GCC/ARM, 4/10] Clear GPR with CLRM

Hi Kyrill, On 12/17/2019 10:26 AM, Kyrill Tkachov wrote: Hi Mihail, On 12/16/19 6:29 PM, Mihail Ionescu wrote: Hi Kyrill, On 11/12/2019 09:55 AM, Kyrill Tkachov wrote: Hi Mihail, On 10/23/19 10:26 AM, Mihail Ionescu wrote: [PATCH, GCC/ARM, 4/10] Clear GPR with CLRM Hi, === Context === T

[Ping][GCC][PATCH][ARM]Add ACLE intrinsics for dot product (vusdot - vector, vdot - by element) for AArch32 AdvSIMD ARMv8.6 Extension

On 12/13/19 10:22 AM, Stam Markianos-Wright wrote: > Hi all, > > This patch adds the ARMv8.6 Extension ACLE intrinsics for dot product > operations (vector/by element) to the ARM back-end. > > These are: > usdot (vector), dot (by element). > > The functions are optional from ARMv8.2-a as -marc

Re: [PATCH, GCC/ARM, 1/2] Add support for ASRL(reg) and LSLL(reg) instructions for Armv8.1-M Mainline

Hi Kyrill, On 12/11/2019 05:50 PM, Kyrill Tkachov wrote: Hi Mihail, On 11/14/19 1:54 PM, Mihail Ionescu wrote: Hi, This patch adds the new scalar shift instructions for Armv8.1-M Mainline to the arm backend. This patch is adding the following instructions: ASRL (reg) LSLL (reg) Sorry fo

Re: [PATCH] Fix symver attribute with LTO

> ICE here. > > lto1: internal compiler error: tree check: expected identifier_node, have > function_decl in ultimate_transparent_alias_target, at varasm.c:1308 > 0x6f9cfe tree_check_failed(tree_node const*, char const*, int, char const*, > ...) > ../../gcc/gcc/tree.c:9685 > 0x714541 tree_c

Re: [C++ Patch] Improve throw, sizeof, and alignof locations & more

On 12/16/19 6:06 PM, Paolo Carlini wrote: Hi, another batch of work. Primarily, more of the idea of moving up the construction of the compound location thus passing it to the cxx_sizeof_or_alignof* and build_throw functions to obtain better locations for all the diagnostics issued by the latt

[C++ PATCH] PR c++/12333 - X::~X() with implicit this->.

this->X::~X() is handled by finish_class_member_access_expr and its lookup_destructor subroutine; let's use it in cp_parser_lookup_name for the case where this-> is implicit. I tried replacing the other destructor code here with just the call to lookup_destructor, but that regressed handling of na

Re: [LTO] PR 86416 – improve lto1 diagnostic if a mode does not exist (esp. for offloading targets)

On Fri, Dec 13, 2019 at 03:34:56PM +0100, Tobias Burnus wrote: > --- a/gcc/lto-streamer-in.c > +++ b/gcc/lto-streamer-in.c > @@ -1700,7 +1700,19 @@ lto_input_mode_table (struct lto_file_decl_data > *file_data) > } > /* FALLTHRU */ > default: > - fatal_

Re: [Patch] Add OpenACC 2.6's no_create

Hi Thomas, @Thomas (and, possibly, Julian & Jakub): Please glance quickly the gomp_map_vars_internal change. libgomp/target.c's gomp_map_vars_internal: it now uses the normal code path in the upper loop, except that one directly bails out when the 'key' has not been found (skipping the adjac

[committed, amdgcn] Fix vect/pr65947-8.c testcase for amdgcn

This patch fixes a test failure caused by GCN's ability to vectorize mixed-mode operations not typically available on other platforms. Basically, the testcase attempts to compare a vector of char against a scalar int. GCN can do this just fine, so the loop vectorizes, but the pass conditions e

*ping* / Re: [LTO] PR 86416 – improve lto1 diagnostic if a mode does not exist (esp. for offloading targets)

*ping* On 12/13/19 3:34 PM, Tobias Burnus wrote: As long as one compiles for a single target, the message is unlikely to appear. However, when compiling for offloading, the modes supported on the target 'host' and on the target 'device' can be different. In particular, 'long double' (when larg

Re: [PATCH][AArch64] Fixup core tunings

Hi Wilco, On 12/17/19 4:03 PM, Wilco Dijkstra wrote: Hi Richard, > This changelog entry is inadequate.  It's also not in the correct style. > > It should say what has changed, not just that it has changed. Sure, but there is often no useful space for that. We should auto generate changelogs if

Re: [PATCH 3/4] Also propagate SRA accesses from LHS to RHS (PR 92706)

On December 17, 2019 1:43:15 PM GMT+01:00, Martin Jambor wrote: >Hi, > >the previous patch unfortunately does not fix the first testcase in PR >92706 and since I am afraid it might be the important one, I also >focused on that. The issue here is again total scalarization accesses >clashing with

Re: [PATCH 2/2] libada: Respect `--enable-version-specific-runtime-libs'

On Wed, 18 Dec 2019, Eric Botcazou wrote: > > gcc/ada/ > > * gcc-interface/Makefile.in (ADA_RTL_DSO_DIR): New variable. > > (install-gnatlib): Use it in place of ADA_RTL_OBJ_DIR for shared > > library installation. > > > > libada/ > > * Makefile.in (toolexecdir, toolexecli

Re: [PATCH 2/2] libada: Respect `--enable-version-specific-runtime-libs'

> gcc/ada/ > * gcc-interface/Makefile.in (ADA_RTL_DSO_DIR): New variable. > (install-gnatlib): Use it in place of ADA_RTL_OBJ_DIR for shared > library installation. > > libada/ > * Makefile.in (toolexecdir, toolexeclibdir): New variables. > (LIBADA_FLAGS_T

Re: [PATCH 1/4] Add verification of SRA accesses

On December 17, 2019 1:40:47 PM GMT+01:00, Martin Jambor wrote: >Hi, > >because the follow-up patches perform some non-trivial operations on >SRA patches, I wrote myself a verifier. And sure enough, it has >spotted two issues, one of which is fixed in this patch too - we did >not correctly set t

Re: [modulo-sched][PATCH] Fix PR92591

On December 17, 2019 8:40:59 PM GMT+01:00, Roman Zhuykov wrote: >Hello. > >> As pointed out in the PR >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92591#c1, the test can >be >> fixed by DFA-checking more adjacent row sequences in the partial >> schedule. >> I've found that on powerpc64 gcc.c-t

Re: [PATCH] Avoid suspicious -Wduplicate-branches warning in lto-wrapper.c (PR lto/92972)

On December 17, 2019 9:43:26 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >big ? "-fno-pie" : "-fno-pie" doesn't make much sense, either we want >to >use big ? "-fno-PIE" : "-fno-pie", but as both mean the same thing, I >think >just using "-fno-pie" is good enough. + a few formatting nits and one >

Pass ipa-bit-cp info to tree-ssa-ccp

Hi, while hunting the streaming bug of ipa-bit-cp which exchanged value and mark while streaming to ltrans I noticed that this bug had almost no effect because we almost always throw away the relevant info. This patch makes tree-ssa-ccp to use results of ipa-bit-cp so the value is actually used.

Re: [PATCH] Fix redundant load missed by fre [tree-optimization 92980]

On Wed, Dec 18, 2019 at 1:18 AM Hongtao Liu wrote: > > On Wed, Dec 18, 2019 at 4:26 PM Segher Boessenkool > wrote: > > > > On Wed, Dec 18, 2019 at 10:37:11AM +0800, Hongtao Liu wrote: > > > Hi: > > > This patch is to simplify A * C + (-D) -> (A - D/C) * C when C is a > > > power of 2 and D mod

Re: [PATCH] Fix symver attribute with LTO

On 2019-12-18 10:26 +0100, Jan Hubicka wrote: > Hi, > sorry I forgot to include cgraph and varpool changes in the patch. > > Index: varpool.c > === > --- varpool.c (revision 279467) > +++ varpool.c (working copy) > @@ -539,8 +539,7 @@

[Ada] Small tweak to pragma Warnings (On)

This changes pragma Warnings (On) from reenabling all the warnings previously silenced to reenabling only those warnings which were enabled when the latest pragma Warnings (Off) was processed (excluding the front-end warnings which are handled separately by the front-end). Tested on x86_64-suse

Re: [PATCH] Fix symver attribute with LTO

Hi, sorry I forgot to include cgraph and varpool changes in the patch. Index: varpool.c === --- varpool.c (revision 279467) +++ varpool.c (working copy) @@ -539,8 +539,7 @@ varpool_node::assemble_aliases (void) { varpo

Re: [PATCH] Fix redundant load missed by fre [tree-optimization 92980]

On Wed, Dec 18, 2019 at 4:26 PM Segher Boessenkool wrote: > > On Wed, Dec 18, 2019 at 10:37:11AM +0800, Hongtao Liu wrote: > > Hi: > > This patch is to simplify A * C + (-D) -> (A - D/C) * C when C is a > > power of 2 and D mod C == 0. > > bootstrap and make check is ok. > > Why would this be

Re: 'find_group_last' (was: [PATCH] OpenACC reference count overhaul)

Hi Julian! Thanks for walking me through this. On 2019-12-14T00:19:04+, Julian Brown wrote: > On Fri, 13 Dec 2019 16:25:25 +0100 > Thomas Schwinge wrote: >> On 2019-10-29T12:15:01+, Julian Brown >> wrote: >> > static int >> > -find_pointer (int pos, size_t mapnum, unsigned short *kind

Re: [PATCH] Some compute_objsize/gimple_call_alloc_size/maybe_warn_overflow cleanups (PR tree-optimization/92868)

On Tue, Dec 17, 2019 at 09:53:43AM -0700, Martin Sebor wrote: > I appreciate a cleanup but I don't have the impression this patch > does clean anything up. Because of all the formatting changes and > no tests the effect of the changes isn't as clear as it should be. > (I wish you would resist the

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

On 17/12/2019 18:04, Janne Blomqvist wrote: On Tue, Dec 17, 2019 at 7:47 PM Steve Kargl wrote: On Tue, Dec 17, 2019 at 05:28:05PM +, Mark Eggleston wrote: On 17/12/2019 17:06, Steve Kargl wrote: On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: gcc/fortran/ChangeLog

Re: [PATCH] Fix symver attribute with LTO

On 2019-12-17 18:47 +0100, Jan Hubicka wrote: > > Would it be equivalent to: > > 1) output foo_v2 local > > 2) producing static alias with local name (.L1) > > 3) do .symver .L1,foo@@@VERS_2 > > That is somewhat more systematic and would not lead to false > > visibilities. > > I spent some time pl

Re: [Patch, Fortran] PR92896 [10 Regression] Fix - Prevent character conversion in array constructor

On 17/12/2019 17:47, Steve Kargl wrote: On Tue, Dec 17, 2019 at 05:28:05PM +, Mark Eggleston wrote: On 17/12/2019 17:06, Steve Kargl wrote: On Tue, Dec 17, 2019 at 03:41:41PM +, Mark Eggleston wrote: gcc/fortran/ChangeLog     Mark Eggleston      PR fortran/92896     * arr

Re: [PATCH] Fix redundant load missed by fre [tree-optimization 92980]

On Wed, Dec 18, 2019 at 10:37:11AM +0800, Hongtao Liu wrote: > Hi: > This patch is to simplify A * C + (-D) -> (A - D/C) * C when C is a > power of 2 and D mod C == 0. > bootstrap and make check is ok. Why would this be a good idea? It is not reducing the number of operators or similar? Seg