On 12/18/19 8:15 AM, Segher Boessenkool wrote:
>> +/* { dg-do compile { target { powerpc*-*-* } } } */
>> +/* { dg-options "-w -O2 -mdejagnu-cpu=power9" } */
>
> You don't need that target clause in gcc.target/powerpc (and dg-do compile
> is the default, but having it explicit is also fine of course).
I think leaving the bare dg-do compile (ie, no target) is nice,
for newbies who don't know that dg-do compile is the default.
>> --- gcc/testsuite/gcc.target/powerpc/dfp-dd.c (revision 278980)
>> +++ gcc/testsuite/gcc.target/powerpc/dfp-dd.c (working copy)
>> @@ -1,6 +1,7 @@
>> /* Test generation of DFP instructions for POWER6. */
>> /* Origin: Janis Johnson <janis...@us.ibm.com> */
>> -/* { dg-do compile { target { powerpc*-*-linux* && powerpc_fprs } } } */
>> +/* { dg-do compile { target { powerpc*-*-linux* } } } */
>> +/* { dg-require-effective-target dfp_hw } */
>
> You can remove powerpc_fprs now because it became redundant? Cool.
Right, hard dfp support requires we have hard float support.
> But dfp_hw is the wrong conditions for a dg-do compile test.
Ok, yes. Looking closer, that dfp_hw is a runtime test and not
what we want. I'll change this to using "hard_dfp" which is a
compile time test.
> Nice cleanups! Please fix that dfp_hw thing, and then, okay for trunk,
> Thanks!
Will do, thanks. I'll commit this after making these changes and
rerunning the updated test cases.
Peter
