Hi! On Tue, Dec 17, 2019 at 07:38:51PM -0500, Michael Meissner wrote: > On Tue, Dec 17, 2019 at 05:35:24PM -0600, Segher Boessenkool wrote: > > And what is with the INSN_FORM_PCREL_EXTERNAL? > > INSN_FORM_PCREL_EXTERNAL says that the operand is a reference to an external > symbol. It cannot appear in an actual memory insns in normal usage, but it > needs to be handled several places:
Sure. Both prefixed_memory and non_prefixed_memory should test something like memory_operand, not just whether it is a MEM. But *both* of them, that's the point, and using some more generic hook. Segher