(Whoops, I missed replying t this one. Sorry.)
On Tue, Dec 10, 2019 at 12:27:11PM -0600, Peter Bergner wrote:
> On 12/4/19 5:03 PM, Segher Boessenkool wrote:
> > On Wed, Dec 04, 2019 at 03:53:30PM -0600, Peter Bergner wrote:
> >> Right. I'll come up with a patch and hopefully Iain and David can test
> >> on Darwin and AIX and I can test on Linux with --enable-decimal-float
> >> and --disable-decimal-float. That should cover the major subtargets and
> >> if it works there, I'd expect it to work on the minor subtargets too.
>
> Ok, how about the patch below? If Iain and David could test this on Darwin
> and AIX respectively, that would be great. I'm currently testing this on
> powerpc64le-linux, with and without --disable-decimal-float.
>
> The pr92661.c test case is the DFP test case you wanted added to make sure
> we do not ICE, even when DFP is disabled. The dfp-[dt]d*.c changes are
> due to me seeing them being run (and FAILing) on my --disable-decimal-float
> runs. Clearly, they shouldn't be run when DFP is disabled.
>
> All of the powerpc/dfp/* tests had powerpc*-*-* target tests, but that is
> covered by the dfp.exp target tests, so I removed them along with the
> now unneeded dg-skip-if AIX tests. If dg-do compile is the default, do
> we want to just remove that whole line?
>
> How is this looking?
> --- gcc/testsuite/gcc.target/powerpc/pr92661.c (nonexistent)
> +++ gcc/testsuite/gcc.target/powerpc/pr92661.c (working copy)
> @@ -0,0 +1,19 @@
> +/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-options "-w -O2 -mdejagnu-cpu=power9" } */
You don't need that target clause in gcc.target/powerpc (and dg-do compile
is the default, but having it explicit is also fine of course).
> --- gcc/testsuite/gcc.target/powerpc/dfp-dd.c (revision 278980)
> +++ gcc/testsuite/gcc.target/powerpc/dfp-dd.c (working copy)
> @@ -1,6 +1,7 @@
> /* Test generation of DFP instructions for POWER6. */
> /* Origin: Janis Johnson <janis...@us.ibm.com> */
> -/* { dg-do compile { target { powerpc*-*-linux* && powerpc_fprs } } } */
> +/* { dg-do compile { target { powerpc*-*-linux* } } } */
> +/* { dg-require-effective-target dfp_hw } */
You can remove powerpc_fprs now because it became redundant? Cool.
But dfp_hw is the wrong conditions for a dg-do compile test.
Nice cleanups! Please fix that dfp_hw thing, and then, okay for trunk,
Thanks!
Segher
