Re: [102/nnn] poly_int: vect_permute_load/store_chain

2017-11-20 Thread Jeff Law
On 10/23/2017 11:41 AM, Richard Sandiford wrote: > The GET_MODE_NUNITS patch made vect_grouped_store_supported and > vect_grouped_load_supported check for a constant number of elements, > so vect_permute_store_chain and vect_permute_load_chain can assert > for that. This patch adds commentary to t

Re: [099/nnn] poly_int: struct_value_size

2017-11-20 Thread Jeff Law
On 10/23/2017 11:40 AM, Richard Sandiford wrote: > This patch makes calls.c treat struct_value_size (one of the > operands to a call pattern) as polynomial. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * calls.c (emit_call_1, expa

Re: [105/nnn] poly_int: expand_assignment

2017-11-20 Thread Jeff Law
On 10/23/2017 11:42 AM, Richard Sandiford wrote: > This patch makes the CONCAT handing in expand_assignment cope with > polynomial mode sizes. The mode of the CONCAT must be complex, > so we can base the tests on the sizes of the real and imaginary > components. > > > 2017-10-23 Richard Sandifo

Re: [106/nnn] poly_int: GET_MODE_BITSIZE

2017-11-20 Thread Jeff Law
On 10/23/2017 11:43 AM, Richard Sandiford wrote: > This patch changes GET_MODE_BITSIZE from an unsigned short > to a poly_uint16. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * machmode.h (mode_to_bits): Return a poly_uint16 rathe

Re: [107/nnn] poly_int: GET_MODE_SIZE

2017-11-20 Thread Jeff Law
On 10/23/2017 11:43 AM, Richard Sandiford wrote: > This patch changes GET_MODE_SIZE from unsigned short to poly_uint16. > The non-mechanical parts were handled by previous patches. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * ma

Re: [patch] remove cilk-plus

2017-11-20 Thread Jeff Law
On 11/16/2017 10:02 AM, Koval, Julia wrote: > Thanks for your comments, fixed it. > > 2017-11-16 Julia Koval > Sebastian Peryt > > * Makefile.def (target_modules): Remove libcilkrts. > * Makefile.in: Ditto. > * configure: Ditto. > * configure.ac: Ditto.

[PING] Plugin support on Windows/MinGW

2017-11-20 Thread Boris Kolpackov
Hi, I would like to ping this patch: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01040.html The changes are fairly conservative: they do not touch much of the existing module implementation and plugin support on MinGW is disabled by default (there are also fixes for a couple of bugs as a bonus

libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-20 Thread Ian Lance Taylor
This patch by Than McIntosh fixes a small bug in the libgo Makefile recipe that constructs the directory from which to pick up libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was missing the flags, which meant that for -m32 builds we'd see the 64-bit libgcc dir. Bootstrapped and ran

Go patch committed: report error for ++/-- applied to a non-numeric type

2017-11-20 Thread Ian Lance Taylor
This patch to the Go frontend reports an error when ++ or -- is used with a non-numeric type. This avoids a later compiler crash. This fixes GCC PR 83071. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-20 Thread Jeff Law
On 11/20/2017 08:04 AM, Alan Hayward wrote: >>> >>> Yes, that was an early alternative option for the patch. >>> >>> With that it would effect every operation that uses SVE registers. A simple >>> add of two registers now has 4 inputs and two outputs. It would get in the >>> way when debugging any

Re: [PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-20 Thread Jeff Law
On 11/20/2017 02:07 PM, Jakub Jelinek wrote: > Hi! > > Apparently ARM can do the widening SImode multiply only using a libcall, > so the recently changed expand_mul_overflow ignores it at first, then > sees possibility to use the HImode code, but uses expand_simple_binop > with OPTAB_DIRECT which

Re: [PATCH] Fix ICE with __RTL and -g (PR debug/82933)

2017-11-20 Thread Jeff Law
On 11/20/2017 02:10 PM, Jakub Jelinek wrote: > Hi! > > The dwarf2out.c code relies on the assembly_start debug hook being > invoked before any RTL is processed from final.c (and needs it to be > done just once). Normally it is called from cgraphunit.c, but when > __RTL is seen with a starting pas

Re: Patch ping

2017-11-20 Thread Jim Wilson
On 11/20/2017 02:58 PM, Jim Wilson wrote: The dwarf2out.c patch looks good to me, though the testcase does not fail on unpatched mainline anymore.  I had to go back to the 2017-10-22 snapshot to see the failure.  There was a followup from Mark Wielaard mentioning that elfutils still fails on ma

Re: [PING][patch] PR81794: have "would be stringified in traditional C" warning in libcpp/macro.c be controlled by -Wtraditional

2017-11-20 Thread David Malcolm
On Wed, 2017-10-25 at 14:45 -0400, Eric Gallager wrote: > On Sat, Sep 30, 2017 at 8:05 PM, Eric Gallager > wrote: > > On Fri, Sep 29, 2017 at 11:15 AM, David Malcolm > m> wrote: > > > On Sun, 2017-09-17 at 20:00 -0400, Eric Gallager wrote: > > > > Attached is a version of > > > > https://gcc.gnu.

Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-20 Thread Jeff Law
On 11/19/2017 03:26 PM, Martin Sebor wrote: >>> I have seen it in the early IL but this late I couldn't come >>> up with a test case where such a loop would be necessary. >>> The COMPONENT_REF always refers to the member array.  If you >>> can show me an example to test with I'll add the handling i

Re: [PATCH] Don't split call from its call arg location

2017-11-20 Thread Jeff Law
On 11/20/2017 04:04 AM, Claudiu Zissulescu wrote: > When a port is using hardware loops (like ARC) makes use of > reorg_loops to find and analyze loops that end in loop_end > instructions. The very same function can be set to reorder the cfg > such that the loop end occurs after the loop start. Thi

Re: [014/nnn] poly_int: indirect_refs_may_alias_p

2017-11-20 Thread Jeff Law
On 11/20/2017 06:00 AM, Richard Sandiford wrote: > Jeff Law writes: >> On 10/23/2017 11:05 AM, Richard Sandiford wrote: >>> This patch makes indirect_refs_may_alias_p use ranges_may_overlap_p >>> rather than ranges_overlap_p. Unlike the former, the latter can handle >>> negative offsets, so the f

[Patch][aarch64][committed] Fix test broken by patch for PR target/81356

2017-11-20 Thread Steve Ellcey
My patch for PR target/81356 caused the test gfortran.dg/pr45636.f90 to generate an XPASS instead of an XFAIL.  This change seems correct since we no longer define TARGET_USE_BY_PIECES_INFRASTRUCTURE_P so I am going to check this patch in as obvious in order to make the test a PASS instead of XPASS

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-11-20 Thread Steve Ellcey
On Mon, 2017-11-20 at 15:24 +0100, Christophe Lyon wrote: >  > As a result of this patch, we now have: > XPASS: gfortran.dg/pr45636.f90   -O   scan-tree-dump-times forwprop2 > "memset" 0 > instead of: > XFAIL: gfortran.dg/pr45636.f90   -O   scan-tree-dump-times forwprop2 > "memset" 0 (found 2 times

Re: Patch ping

2017-11-20 Thread Jim Wilson
On 11/19/2017 11:55 PM, Jakub Jelinek wrote: I'd like to ping the following patches: http://gcc.gnu.org/ml/gcc-patches/2017-10/msg01895.html PR debug/82718 Fix DWARF5 .debug_loclist handling with hot/cold partitioning I already responded to this one. https://gcc.gnu.org/ml/gcc-patches

Small C++ PATCH to avoid duplicate visibility warning

2017-11-20 Thread Jason Merrill
We've been warning about a base with different visibility while walking the fields list as well as the base list. Tested x86_64-pc-linux-gnu, applying to trunk. commit de7f9f640df9dc1e181284009ba48ac281bef825 Author: Jason Merrill Date: Fri Nov 17 17:13:40 2017 -0500 Avoid duplicate visibi

[PATCH, rs6000] (v2) testcase updates for fold-vec-abs-* for power9 codegen

2017-11-20 Thread Will Schmidt
Hi, Add additional scan-assembler entries for those tests with simple variations in codegen. (for power9, versus power8, etc). 2017-11-20 Will Schmidt [testsuite] * fold-vec-abs-char-fwrapv.c: Add xxspltib insn to expected output. * fold-vec-abs-c

[PATCH, rs6000] (v2) fold-vec-ld* testcase updates for power9

2017-11-20 Thread Will Schmidt
Hi, Update the scan-assembler stanza to include those instructions generated for a power9 target. 2017-11-20 Will Schmidt [testsuite] * fold-vec-ld-char.c: Add lxv insn to expected output. * fold-vec-ld-double.c: Add lxv insn to expected output.

[PATCH, rs6000] (v2) fold-vec-splat* testcase updates for power9

2017-11-20 Thread Will Schmidt
Hi, Update the scan-assembler stanza to include those instructions generated for a power9 target. 2017-11-20 Will Schmidt [testsuite] * fold-vec-splat-8.c : Add vspltisb to expected output. * fold-vec-splats-int.c : Add mtvsrws to expected output.

Re: [RFC][PATCH] Change default to -fcommon

2017-11-20 Thread Michael Matz
Hi, On Mon, 20 Nov 2017, Richard Biener wrote: > Also we cannot raise alignment of commons and thus vectorization is > pessimized (all vectorizer testcases use - fno-common). That would be a simple oversight then. That's one of the nice things with common symbols, they contain their own align

Re: [RFC][PATCH] Change default to -fcommon

2017-11-20 Thread Michael Matz
Hi, On Mon, 20 Nov 2017, Sandra Loosemore wrote: > > I have a hard time imaging that, so can you give details? FWIW I've > > personally always considered using common symbols nicer. > > The optimization case I'm familiar with is for targets that support -G > and GP-relative addressing modes t

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-20 Thread Jakub Jelinek
On Mon, Nov 20, 2017 at 02:25:35PM -0700, Martin Sebor wrote: > On 11/20/2017 02:14 PM, Jakub Jelinek wrote: > > Hi! > > > > All the hash_maps in tree-ssa-strlen.c except for the newly added one > > were pointers to hash maps, which were constructed either lazily or during > > the pass. But strle

Re: [PATCH] avoid assuming strncat/strncpy don't change length of source string (PR 83075)

2017-11-20 Thread Jakub Jelinek
On Mon, Nov 20, 2017 at 02:38:10PM -0700, Martin Sebor wrote: > > I think it is better to have a dg-do run testcase and not scan for abort. > > We can be able to optimize at some point n0 to 3 and n1 to 6 and optimize > > away the abort. In the testcase I've added to the PR there was a separate >

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-20 Thread Jonathan Wakely
On 20/11/17 21:07 +, Jonathan Wakely wrote: On 20/11/17 21:01 +, Jonathan Wakely wrote: On 20/11/17 21:43 +0100, Christophe Lyon wrote: On 20 November 2017 at 17:02, David Edelsohn wrote: This patch has introduced new regressions on at least PowerPC and AArch64. FAIL: ext/special_fun

Re: [PATCH] avoid assuming strncat/strncpy don't change length of source string (PR 83075)

2017-11-20 Thread Martin Sebor
On 11/20/2017 12:39 PM, Jakub Jelinek wrote: On Mon, Nov 20, 2017 at 12:15:09PM -0700, Martin Sebor wrote: PR tree-optimization/83075 * tree-ssa-strlen.c (handle_builtin_stxncpy): Avoid assuming strncat/strncpy don't change length of source string. gcc/testsuite/ChangeLo

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-20 Thread Martin Sebor
On 11/20/2017 02:14 PM, Jakub Jelinek wrote: Hi! All the hash_maps in tree-ssa-strlen.c except for the newly added one were pointers to hash maps, which were constructed either lazily or during the pass. But strlen_to_stridx is now constructed at the compiler start, which is something I'd prefe

[PATCH] Avoid static initialization in the strlen pass

2017-11-20 Thread Jakub Jelinek
Hi! All the hash_maps in tree-ssa-strlen.c except for the newly added one were pointers to hash maps, which were constructed either lazily or during the pass. But strlen_to_stridx is now constructed at the compiler start, which is something I'd prefer to avoid, it affects even -O0 that way and em

Re: [C/C++ PATCH] Fix ICE in get_atomic_generic_size (PR c++/83059)

2017-11-20 Thread Nathan Sidwell
On 11/20/2017 04:03 PM, Jakub Jelinek wrote: Hi! Not all INTEGER_CSTs satisfy tree_fits_uhwi_p, and those that don't ICE in tree_to_uhwi. But, what the memmodel_base function actually does is mask only the 16 low bits, the upper bits are reserved for target dependent flags and -Winvalid-memory-

[PATCH] Fix ICE with __RTL and -g (PR debug/82933)

2017-11-20 Thread Jakub Jelinek
Hi! The dwarf2out.c code relies on the assembly_start debug hook being invoked before any RTL is processed from final.c (and needs it to be done just once). Normally it is called from cgraphunit.c, but when __RTL is seen with a starting pass, run_rtl_passes is called already from the FE. While i

Re: [PATCH 1/3] [ARM] Add bus_width_bits to tune_params

2017-11-20 Thread Charles Baylis
On 15 September 2017 at 18:01, Kyrill Tkachov wrote: > From what I can tell Ramana and Richard preferred to encode this attribute > as > a tuning struct property rather than an inline conditional based on > arm_arch7. > I agree that if we want to use that information, it should be encoded this >

Re: [PATCH 2/3] [ARM] Refactor costs calculation for MEM.

2017-11-20 Thread Charles Baylis
On 15 September 2017 at 18:01, Kyrill Tkachov wrote: > > On 15/09/17 16:38, Charles Baylis wrote: >> >> On 13 September 2017 at 10:02, Kyrill Tkachov >> wrote: >>> >>> Hi Charles, >>> >>> On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis This patch mo

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-20 Thread Jonathan Wakely
On 20/11/17 21:01 +, Jonathan Wakely wrote: On 20/11/17 21:43 +0100, Christophe Lyon wrote: On 20 November 2017 at 17:02, David Edelsohn wrote: This patch has introduced new regressions on at least PowerPC and AArch64. FAIL: ext/special_functions/hyperg/check_value.cc execution test FAIL:

[PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-20 Thread Jakub Jelinek
Hi! Apparently ARM can do the widening SImode multiply only using a libcall, so the recently changed expand_mul_overflow ignores it at first, then sees possibility to use the HImode code, but uses expand_simple_binop with OPTAB_DIRECT which requires actual HImode optabs, which ARM doesn't have, it

[committed] i386.c diagnostics fix

2017-11-20 Thread Jakub Jelinek
Hi! While working on the just posted patch, I've noticed another spot in i386.c that uses incorrect capitalization in diagnostics. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2017-11-20 Jakub Jelinek * config/i386/i386.c (parse_

[C/C++ PATCH] Fix ICE in get_atomic_generic_size (PR c++/83059)

2017-11-20 Thread Jakub Jelinek
Hi! Not all INTEGER_CSTs satisfy tree_fits_uhwi_p, and those that don't ICE in tree_to_uhwi. But, what the memmodel_base function actually does is mask only the 16 low bits, the upper bits are reserved for target dependent flags and -Winvalid-memory-model already warns about those during expansio

Re: [14/nn] Add helpers for shift count modes

2017-11-20 Thread Richard Sandiford
Richard Biener writes: > On Thu, Oct 26, 2017 at 2:06 PM, Richard Biener > wrote: >> On Mon, Oct 23, 2017 at 1:25 PM, Richard Sandiford >> wrote: >>> This patch adds a stub helper routine to provide the mode >>> of a scalar shift amount, given the mode of the values >>> being shifted. >>> >>> On

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-20 Thread Jonathan Wakely
On 20/11/17 21:43 +0100, Christophe Lyon wrote: On 20 November 2017 at 17:02, David Edelsohn wrote: This patch has introduced new regressions on at least PowerPC and AArch64. FAIL: ext/special_functions/hyperg/check_value.cc execution test FAIL: tr1/5_numerical_facilities/special_functions/17_

[PATCH] Fix load_gsi computation in store-merging (PR tree-optimization/83047)

2017-11-20 Thread Jakub Jelinek
Hi! This is something the bswap pass has been already doing, but not the new load handling code in store-merging. If all the loads have the same vuse, it still doesn't mean they are necessarily in the same basic block. If they are in multiple bbs, previously we've chosen randomly (well, from the

Re: [RFC][PATCH] Change default to -fcommon

2017-11-20 Thread Richard Biener
On November 20, 2017 9:02:55 PM GMT+01:00, Sandra Loosemore wrote: >On 11/20/2017 10:34 AM, Michael Matz wrote: >> What's your rationale for changing this? In your initial mail you >said: >> >> "On many targets this means global variable accesses having an >unnecessary >> codesize and performan

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-20 Thread Christophe Lyon
On 20 November 2017 at 17:02, David Edelsohn wrote: > This patch has introduced new regressions on at least PowerPC and AArch64. > > FAIL: ext/special_functions/hyperg/check_value.cc execution test > FAIL: tr1/5_numerical_facilities/special_functions/17_hyperg/check_value.cc > execution test > > T

Re: Increase precision of static profiles

2017-11-20 Thread Christophe Lyon
On 19 November 2017 at 11:01, Tom de Vries wrote: > On 11/17/2017 08:53 PM, Jan Hubicka wrote: >> >> Hi, >> this patch makes static profile to be in range 0...2^30 rather than >> 0...1. This is safe now as profile-counts are taking care of >> possible overflow when the profile ends up cummula

Re: [patch] Add support for #pragma GCC unroll

2017-11-20 Thread Bernhard Reutner-Fischer
On 20 November 2017 at 15:45, Steve Kargl wrote: > On Mon, Nov 20, 2017 at 12:57:47PM +0100, Bernhard Reutner-Fischer wrote: >> On 20 November 2017 at 12:26, Eric Botcazou wrote: >> >> If anybody finds the time to push the corresponding Fortran changes then >> >> I'd >> >> be grateful. I won't h

Re: [PATCH, rs6000] Testcase updates for power9 codegen

2017-11-20 Thread Will Schmidt
On Mon, 2017-11-20 at 11:23 -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Nov 17, 2017 at 11:30:27AM -0600, Will Schmidt wrote: > > [testsuite] > > * fold-vec-neg-int.c: Specify -mcpu=power8 > > Dot at end of sentence (quite a few times), please. > > > -/* { dg-final { scan-assembler-ti

Re: [PATCH] rs6000: Don't touch below the stack pointer (PR77687)

2017-11-20 Thread Segher Boessenkool
On Tue, Sep 19, 2017 at 09:21:50PM +, Segher Boessenkool wrote: > With the 32-bit SVR4 ABI we don't have a red zone, so we have to restore > the callee-saved registers before we restore the stack pointer. > > The previous fix for this PR failed in two ways, for huge frames: first, > we use a n

[PATCH] PR 53796 Improve INQUIRE(RECL=...) handling

2017-11-20 Thread Janne Blomqvist
The current F2018 draft (N2137) specifies behavior of the RECL= specifier in the INQUIRE statement, where it previously was left as undefined. Namely: - If the unit is not connected, RECL= should be given the value -1. - If the unit is connected with stream access, RECL= should be given the valu

Re: [RFC][PATCH] Change default to -fcommon

2017-11-20 Thread Sandra Loosemore
On 11/20/2017 10:34 AM, Michael Matz wrote: What's your rationale for changing this? In your initial mail you said: "On many targets this means global variable accesses having an unnecessary codesize and performance penalty in C code (the same source generates better code when built as C++)."

Re: [PATCH, i386]: Add bswaphi2 insn pattern

2017-11-20 Thread Uros Bizjak
Hello! Attached patch introduces bswaphi2 named insn pattern that results in movbe instruction. Without the patch, the following testcase: void baz (char *buf, unsigned int data) { buf[0] = data >> 8; buf[1] = data; } compiles to (-O2 -march=haswell): rolw$8, %si movw

[PATCH, i386]: Add bswaphi2 insn pattern

2017-11-20 Thread Uros Bizjak
Hello! Attached patch introduces bswaphi2 named insn pattern that results in movbe instruction. Without the patch, the following testcase:

Re: [patch] Add support for #pragma GCC unroll

2017-11-20 Thread Sandra Loosemore
On 11/17/2017 03:23 AM, Eric Botcazou wrote: Index: doc/extend.texi === --- doc/extend.texi (revision 254797) +++ doc/extend.texi (working copy) @@ -22376,6 +22376,18 @@ void ignore_vec_dep (int *a, int k, int @} @end smal

Re: [PATCH] avoid assuming strncat/strncpy don't change length of source string (PR 83075)

2017-11-20 Thread Jakub Jelinek
On Mon, Nov 20, 2017 at 12:15:09PM -0700, Martin Sebor wrote: > PR tree-optimization/83075 > * tree-ssa-strlen.c (handle_builtin_stxncpy): Avoid assuming > strncat/strncpy don't change length of source string. > > gcc/testsuite/ChangeLog: > > PR tree-optimization/83075 >

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-11-20 Thread Steve Ellcey
On Mon, 2017-11-20 at 18:27 +, James Greenhalgh wrote: > > If you have the time, would you mind giving me a quick run-down of what > design decisions went in to this patch, and why they are the right thing > to do? Sorry to offload that, but it will be the most efficient route > to a review.

[PATCH] avoid assuming strncat/strncpy don't change length of source string (PR 83075)

2017-11-20 Thread Martin Sebor
Unlike strcat and strcpy, it is valid for strncat and strncpy to result in modifying the source string by overwriting its terminating nul. The attached patch removes an assumption to the contrary introduced with the -Wstringop-truncation enhancement. Martin PR tree-optimization/83075 - Invalid s

Re: [patches] Re: [PATCH] RISC-V: Implement __umulsidi3, umul_ppmm and __muluw3

2017-11-20 Thread Palmer Dabbelt
On Sun, 19 Nov 2017 23:31:56 PST (-0800), ja...@redhat.com wrote: On Sun, Nov 19, 2017 at 08:53:00PM -0800, Jim Wilson wrote: > 2017-11-24 Kito Cheng > > * longlong.h [__riscv] (__umulsidi3): Define. > [__riscv] (umul_ppmm) Likewise. > [__riscv] (__muluw3) Likewise.

Re: [committed][PATCH] Fix bogus propagation in DOM

2017-11-20 Thread Jeff Law
On 11/20/2017 03:25 AM, Richard Biener wrote: > On Sun, Nov 19, 2017 at 9:16 PM, Jeff Law wrote: >> On my local branch gcc.dg/torture/pr56349.c fails by sending GCC into an >> infinite loop trying to simplify a self-referring statement. ie >> something like >> >> x_1 = x_1 + 10; >> >> That, of cou

Re: Patch ping

2017-11-20 Thread Nathan Sidwell
On 11/20/2017 02:55 AM, Jakub Jelinek wrote: http://gcc.gnu.org/ml/gcc-patches/2017-11/msg00851.html C++2A P0428R2 - familiar template syntax for generic lambdas Are there existing testcases checking this is permitted w/o warning under the appropriate circumstances? That seems to be th

Re: [patch, fortran] Implement maxloc and minloc for character

2017-11-20 Thread Thomas Koenig
Am 20.11.2017 um 09:30 schrieb Janne Blomqvist: On Sun, Nov 19, 2017 at 11:11 PM, Thomas Koenig wrote: There is one question regarding the ABI. Apparently, the string length is passed as an int even on a 64-bit system. I verified that this is indeed the case by doing the actual work on a powerp

Re: Patch ping

2017-11-20 Thread Nathan Sidwell
On 11/20/2017 02:55 AM, Jakub Jelinek wrote: Hi! http://gcc.gnu.org/ml/gcc-patches/2017-11/msg01026.html C++2A P0329R4: Designated Initialization OK, thanks -- Nathan Sidwell

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-11-20 Thread James Greenhalgh
On Mon, Nov 20, 2017 at 05:39:25PM +, Steve Ellcey wrote: > Re-ping with a CC to the Aarch64 maintainers. If I'm completely honest with myself, I don't know enough about this area to review the patch. Szabolcs' OK holds a lot of weight with me, but I'd like to understand more of the top-level

Re: [PATCH] Add _Float/_FloatX rounding built-ins & improve gimple optimization of _Float/_FloatX built-in functions

2017-11-20 Thread Michael Meissner
On Mon, Nov 20, 2017 at 11:32:08AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Nov 17, 2017 at 07:35:05PM -0500, Michael Meissner wrote: > > Here is the fixed patch. It fixes the btrunc2 insn to use the correct > > XSRPQI variant for truncf128. I added the float128-hw11.c test as a runtim

Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64

2017-11-20 Thread Steve Ellcey
Re-ping with a CC to the Aarch64 maintainers. Steve Ellcey sell...@cavium.com On Tue, 2017-10-24 at 11:11 -0700, Steve Ellcey wrote: > Ping. > > Steve Ellcey > sell...@cavium.com > > On Tue, 2017-10-03 at 11:57 -0700, Steve Ellcey wrote: > > > > On Mon, 2017-10-02 at 15:38 +0100, Szabolcs Nagy

Re: [RFC][PATCH] Change default to -fcommon

2017-11-20 Thread Michael Matz
Hi, On Mon, 20 Nov 2017, Wilco Dijkstra wrote: > > Note you have to make sure GFortran still works! So I think the patch > > should be changed to make the default behavior be frontend dependent > > or have a fortran/ adjustment that fixes things up for the fortran > > dialects that need it. >

Re: [PATCH] Add _Float/_FloatX rounding built-ins & improve gimple optimization of _Float/_FloatX built-in functions

2017-11-20 Thread Segher Boessenkool
Hi! On Fri, Nov 17, 2017 at 07:35:05PM -0500, Michael Meissner wrote: > Here is the fixed patch. It fixes the btrunc2 insn to use the correct > XSRPQI variant for truncf128. I added the float128-hw11.c test as a runtime > test to make sure round, trunc, ceil, and floor return the correct values.

Re: [PATCH, rs6000] Testcase updates for power9 codegen

2017-11-20 Thread Segher Boessenkool
Hi! On Fri, Nov 17, 2017 at 11:30:27AM -0600, Will Schmidt wrote: > [testsuite] > * fold-vec-neg-int.c: Specify -mcpu=power8 Dot at end of sentence (quite a few times), please. > -/* { dg-final { scan-assembler-times "vspltisw|vxor" 1 } } */ > +//# Power9 added xxspltib instruction. > +/*

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-20 Thread Richard Biener
On November 20, 2017 4:51:04 PM GMT+01:00, Marek Polacek wrote: >On Thu, Nov 16, 2017 at 02:20:59PM -0500, Jason Merrill wrote: >> On Thu, Nov 16, 2017 at 12:41 PM, Marek Polacek >wrote: >> > On Tue, Nov 14, 2017 at 07:34:54AM +0100, Richard Biener wrote: >> >> On November 14, 2017 6:21:41 AM GM

Re: [RFA][PATCH] 8/n Pull evrp range analyzer into its own file

2017-11-20 Thread Richard Biener
On November 20, 2017 4:46:08 PM GMT+01:00, Jeff Law wrote: >On 11/20/2017 03:05 AM, Richard Biener wrote: >> On Sat, Nov 18, 2017 at 9:00 AM, Jeff Law wrote: >>> >>> >>> >>> This is just a straight cut-n-paste pulling the evrp_range_analyzer >>> methods out of gimple-ssa-evrp.c into gimple-ssa-ev

Re: std::advance istreambuf_iterator overload

2017-11-20 Thread Jonathan Wakely
On 20/11/17 07:40 +0100, François Dumont wrote: Here is the latest version I plan to commit after validation. I like the simplified logic for the while-loop. I'd like to keep the change to the money_get/get/[char/wchar_t]/9.cc tests. At the moment those tests passes only because there is no

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-20 Thread Jonathan Wakely
On 18/11/17 11:49 -0500, Ed Smith-Rowland wrote: On 11/17/2017 03:54 PM, Jonathan Wakely wrote: Hmm, you're probably right. I'd be tempted to though. I had an idea.  What about a macro _GLIBCXX_ELLINT_3_POS_NU or something that: 1. would allow users to detect which convention is on by defau

Re: [libstdc++] Expose Airy functions.

2017-11-20 Thread Jonathan Wakely
On 18/11/17 20:33 -0500, Ed Smith-Rowland wrote: Here is the final patch fir libstdc++ Airy functions... OK for trunk, thanks.

Re: [RFC][PATCH 12/n Embed range analysis in DOM

2017-11-20 Thread Jeff Law
On 11/20/2017 03:13 AM, Richard Biener wrote: > On Sat, Nov 18, 2017 at 10:31 AM, Jeff Law wrote: >> And a WIP. I can justify continuing work on this during stage3 for >> pr78496. But I thought it was worth giving folks a looksie. >> >> The goal here is to make tree-vrp's threading obsolete and

RFC: SAFE_MACRO_STMT

2017-11-20 Thread Tom de Vries
Hi, when writing macros that are intended to be used as if they were single statements, there are a couple of common problems: 1. Ending in semicolon ... #define foo stmt; ... This works fine if we use it like: ... void bar (void) { foo; } ... but we get an "else without a previous if" err

Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values

2017-11-20 Thread David Edelsohn
This patch has introduced new regressions on at least PowerPC and AArch64. FAIL: ext/special_functions/hyperg/check_value.cc execution test FAIL: tr1/5_numerical_facilities/special_functions/17_hyperg/check_value.cc execution test Thanks, David

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-20 Thread Marek Polacek
On Thu, Nov 16, 2017 at 02:20:59PM -0500, Jason Merrill wrote: > On Thu, Nov 16, 2017 at 12:41 PM, Marek Polacek wrote: > > On Tue, Nov 14, 2017 at 07:34:54AM +0100, Richard Biener wrote: > >> On November 14, 2017 6:21:41 AM GMT+01:00, Jason Merrill > >> wrote: > >> >On Mon, Nov 13, 2017 at 1:02

Re: [RFA][PATCH] 8/n Pull evrp range analyzer into its own file

2017-11-20 Thread Jeff Law
On 11/20/2017 03:05 AM, Richard Biener wrote: > On Sat, Nov 18, 2017 at 9:00 AM, Jeff Law wrote: >> >> >> >> This is just a straight cut-n-paste pulling the evrp_range_analyzer >> methods out of gimple-ssa-evrp.c into gimple-ssa-evrp-analyze.[ch]. >> >> Bootstrapped and regression tested on x86_64

Re: [RFC][PATCH] Change default to -fcommon

2017-11-20 Thread Wilco Dijkstra
Richard Biener wrote: > A target specific default might be a good idea if we decide to revert. > > Note I proposed this change a few times already, but the fear was always > we'll break too much legacy code. It will definitely break some code, but new warnings with -Werror might too... > Note y

RE: [RFC, vectorizer] Allow half_type for left shift in vect_operation_fits_smaller_type?

2017-11-20 Thread Jon Beniston
Hi Richard, >Not digged long into this "interesting" function but this case is only valid if type == >final type and if the result is not shifted back. vect_recog_over_widening_pattern >works on a whole sequence of stmts after all, thus > > b = (T_PROMOTED) a; > c = b << 2; > d = b >> 2; > e

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-20 Thread Alan Hayward
> On 17 Nov 2017, at 19:31, Jeff Law wrote: > > On 11/16/2017 11:50 AM, Alan Hayward wrote: >> >>> On 16 Nov 2017, at 18:24, Richard Biener wrote: >>> >>> On November 16, 2017 7:05:30 PM GMT+01:00, Jeff Law wrote: On 11/16/2017 05:34 AM, Alan Hayward wrote: > This is a set of patche

Re: VRP: x+1 and -x cannot be INT_MIN

2017-11-20 Thread Richard Biener
On Mon, Nov 20, 2017 at 3:10 PM, Marc Glisse wrote: > On Mon, 20 Nov 2017, Richard Biener wrote: > >>> I had to adapt one testcase where for VR_VARYING | [1, 1] we used to >>> produce >>> ~[0, 0] and now produce [-INT_MAX, INT_MAX]. I am surprised at how late >>> the >>> transformation now happens

Re: Fix gcc-7 and gcc-8 build of GO for Hurd and not kFreeBSD in debian/rules.defs

2017-11-20 Thread Aurelien Jarno
On 2017-11-20 14:31, Svante Signell wrote: > On Mon, 2017-11-20 at 14:04 +0100, Aurelien Jarno wrote: > > On 2017-11-20 13:20, Svante Signell wrote: > > > On Thu, 2017-11-16 at 20:39 +0100, Svante Signell wrote: > > > > > > Seeing the recent update of debian/rules.defs in gcc-7 a mistake was > > >

Re: [PATCH GCC]A simple implementation of loop interchange

2017-11-20 Thread Richard Biener
On Thu, Nov 16, 2017 at 4:18 PM, Bin.Cheng wrote: > On Tue, Oct 24, 2017 at 3:30 PM, Michael Matz wrote: >> Hello, >> >> On Fri, 22 Sep 2017, Bin.Cheng wrote: >> >>> This is updated patch for loop interchange with review suggestions >>> resolved. Changes are: >>> 1) It does more light weight c

Re: [patch] Add support for #pragma GCC unroll

2017-11-20 Thread Steve Kargl
On Mon, Nov 20, 2017 at 12:57:47PM +0100, Bernhard Reutner-Fischer wrote: > On 20 November 2017 at 12:26, Eric Botcazou wrote: > >> If anybody finds the time to push the corresponding Fortran changes then > >> I'd > >> be grateful. I won't have time for this until end of stage 1... > >> > >> http

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-11-20 Thread Christophe Lyon
On 17 November 2017 at 22:41, James Greenhalgh wrote: > On Fri, Sep 15, 2017 at 07:22:39PM +0100, Steve Ellcey wrote: >> PR 81356 points out that doing a __builtin_strcpy of an empty string on >> aarch64 does a copy from memory instead of just writing out a zero byte. >> In looking at this I found

Re: [PATCH][ARM] Fix test armv8_2-fp16-move-1.c

2017-11-20 Thread Kyrill Tkachov
On 20/11/17 14:14, Christophe Lyon wrote: Hi, On 17 November 2017 at 12:12, Kyrill Tkachov wrote: On 17/11/17 10:45, Sudi Das wrote: Hi Kyrill Thanks I have made the change. Thanks Sudi, I've committed this on your behalf with r254863. Kyrill Sudi From: Kyrill Tkachov Sent: Thurs

Re: [PATCH] RTEMS: Enable some libstdc++ features

2017-11-20 Thread Jonathan Wakely
On 20/11/17 09:03 +0100, Sebastian Huber wrote: libstdc++/ * acinclude.m4 (GLIBCXX_ENABLE_LIBSTDCXX_TIME): Add rtems*. (GLIBCXX_ENABLE_FILESYSTEM_TS): Likewise. * configure: Regenerate. OK, thanks.

Re: [v3 PATCH] Implement LWG 2353

2017-11-20 Thread Jonathan Wakely
On 19/11/17 02:40 +0200, Ville Voutilainen wrote: --- /dev/null +++ b/libstdc++-v3/testsuite/24_iterators/operations/lwg2353.cc @@ -0,0 +1,26 @@ +// { dg-options "-D_GLIBCXX_CONCEPT_CHECKS" } +// { dg-do run { target c++11 } } + +#include +#include +#include +#include +#include + +template +

Re: [PATCH][ARM] Fix test armv8_2-fp16-move-1.c

2017-11-20 Thread Christophe Lyon
Hi, On 17 November 2017 at 12:12, Kyrill Tkachov wrote: > > On 17/11/17 10:45, Sudi Das wrote: >> >> Hi Kyrill >> >> Thanks I have made the change. > > > Thanks Sudi, I've committed this on your behalf with r254863. > > Kyrill > > >> Sudi >> >> >> >> From: Kyrill Tkachov >> Sent: Thursday, Nove

Re: VRP: x+1 and -x cannot be INT_MIN

2017-11-20 Thread Marc Glisse
On Mon, 20 Nov 2017, Richard Biener wrote: I had to adapt one testcase where for VR_VARYING | [1, 1] we used to produce ~[0, 0] and now produce [-INT_MAX, INT_MAX]. I am surprised at how late the transformation now happens (only after removing __builtin_unreachable, in forwprop3, while trunk cur

Re: [PATCH] Fix test-suite fallout of default -Wreturn-type.

2017-11-20 Thread Jason Merrill
On Sun, Nov 19, 2017 at 7:56 AM, Thomas Schwinge wrote: > OK to fix the first four issues as follows? If approving this, please > respond with "Reviewed-by: NAME " so that your effort will be > recorded. See . OK. Reviewed-by: Jason Merrill

Re: [RFTesting] New POINTER_DIFF_EXPR

2017-11-20 Thread Jason Merrill
On Sun, Nov 19, 2017 at 6:54 PM, Marc Glisse wrote: > new version, regtested on powerpc64le-unknown-linux-gnu. The front-end parts > are up for review. The C++ changes are OK. Jason

[PATCH] Fix Werror=stringop-overflow in target.c

2017-11-20 Thread Martin Liška
Hello. This is fix of compilation error I see with --enable-offload-targets=nvptx-none=. It's explained in very detail way here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83007#c1 Ready for trunk? Martin libgomp/ChangeLog: 2017-11-20 Martin Liska * target.c (gomp_target_init): U

Re: [PATCH] make canonicalize_condition keep its promise

2017-11-20 Thread Aaron Sawdey
On Sun, 2017-11-19 at 16:44 -0700, Jeff Law wrote: > On 11/15/2017 08:40 AM, Aaron Sawdey wrote: > > So, the story of this very small patch starts with me adding > > patterns > > for ppc instructions bdz[tf] and bdnz[tf] such as this: > > > >   [(set (pc) > > (if_then_else > >   (and > >

Re: [PATCH] Fix test-suite fallout of default -Wreturn-type.

2017-11-20 Thread Martin Liška
On 11/19/2017 01:56 PM, Thomas Schwinge wrote: > Hi! > > On Wed, 18 Oct 2017 14:48:13 +0200, Martin Liška wrote: >> This is second patch that addresses test-suite fallout. All these tests fail >> because -Wreturn-type is >> now on by default. >> >> Patch can bootstrap on ppc64le-redhat-linux and

Re: Fix gcc-7 and gcc-8 build of GO for Hurd and not kFreeBSD in debian/rules.defs

2017-11-20 Thread Svante Signell
On Mon, 2017-11-20 at 14:04 +0100, Aurelien Jarno wrote: > On 2017-11-20 13:20, Svante Signell wrote: > > On Thu, 2017-11-16 at 20:39 +0100, Svante Signell wrote: > > > > Seeing the recent update of debian/rules.defs in gcc-7 a mistake was > > revealed in the patch debian_rules.defs for both gcc-7

Re: Fix gcc-7 and gcc-8 build of GO for Hurd and not kFreeBSD in debian/rules.defs

2017-11-20 Thread Aurelien Jarno
On 2017-11-20 13:20, Svante Signell wrote: > On Thu, 2017-11-16 at 20:39 +0100, Svante Signell wrote: > > Seeing the recent update of debian/rules.defs in gcc-7 a mistake was revealed > in > the patch debian_rules.defs for both gcc-7 and gcc-8. The correct patch is > inlined below: > > --- a/deb

Re: [014/nnn] poly_int: indirect_refs_may_alias_p

2017-11-20 Thread Richard Sandiford
Jeff Law writes: > On 10/23/2017 11:05 AM, Richard Sandiford wrote: >> This patch makes indirect_refs_may_alias_p use ranges_may_overlap_p >> rather than ranges_overlap_p. Unlike the former, the latter can handle >> negative offsets, so the fix for PR44852 should no longer be necessary. >> It can

Re: [PATCH][AArch64] Restrict POST_INC operand in aarch64_simd_mem_operand_p to register

2017-11-20 Thread Dominik Inführ
Thanks for the review! Could you also please commit this patch for me? I don’t have commit rights. Thanks, Dominik > On 17 Nov 2017, at 23:18, James Greenhalgh wrote: > > On Tue, Oct 31, 2017 at 02:47:29PM +0100, Dominik Inführ wrote: >> Hi, >> >> I have a custom optimization pass, that moves

  1   2   >