On November 20, 2017 4:46:08 PM GMT+01:00, Jeff Law <l...@redhat.com> wrote: >On 11/20/2017 03:05 AM, Richard Biener wrote: >> On Sat, Nov 18, 2017 at 9:00 AM, Jeff Law <l...@redhat.com> wrote: >>> >>> >>> >>> This is just a straight cut-n-paste pulling the evrp_range_analyzer >>> methods out of gimple-ssa-evrp.c into gimple-ssa-evrp-analyze.[ch]. >>> >>> Bootstrapped and regression tested on x86_64. >>> >>> >>> OK for the trunk? >> >> Hum. That makes things harder to follow - what's the advantage to >> making two files of EVRP?It's just separation of the analysis engine >from the clients. ie, >gimple-ssa-evrp.c is just a one client of the engine >gimple-ssa-evrp-analyze.c > >Other clients (DOM, sprintf, array bounds checking, _b_o_s, whatever) >wouldn't ever need to look at to look a gimple-ssa-evrp.c. > >Then again, I don't expect the clients to have to look deeply at >gimple-ssa-evrp-analyze.c either. THe idea is to make range >information >available in a dead simple way :-) > >It's probably the least important piece. If you'd prefer to keep them >together it's not a big deal -- and if at some later date we want to >pull them apart again, it shouldn't be hard. > >Your call.
I don't have a strong opinion here, so just go ahead with what is less work for you. Richard. > >jeff
