Hi,
Is the following patch okay for trunk?
SK
- Original Message -
From: "Shakthi Kannan"
To: gcc-patches@gcc.gnu.org
Sent: Friday, May 10, 2013 12:25:07 PM
Subject: [PATCH, PR preprocessor/42014] Added LAST_SOURCE_COLUMN in while loop
Hi,
The attached patch adds LAST_SOURCE_COLUMN to
Steve Ellcey writes:
>> It might be worth having a new "generic" scheduler that's supposed to be
>> a good compromise for modern cores though. Or, more simply, we could just
>> change:
>>
>> MIPS_CPU ("mips32", PROCESSOR_4KC, 32, PTF_AVOID_BRANCHLIKELY)
>> MIPS_CPU ("mips32r2", PROCESSOR_M4K, 33
Hi,
Is the following patch okay for trunk?
SK
- Original Message -
From: "Shakthi Kannan"
To: "Joseph S. Myers"
Cc: gcc-patches@gcc.gnu.org
Sent: Monday, May 6, 2013 4:00:06 PM
Subject: Re: [PATCH, wwwdocs] Fix PR 50642
Hi,
I am re-submitting the patch to use html.css from the update
On Tue, May 21, 2013 at 07:57:10PM -0700, Richard Henderson wrote:
> >+ /* This will create the if statement label. */
> >+ if_stmt_label[ii] = build_decl (location, LABEL_DECL, NULL_TREE,
> >+ void_type_node);
> >+ DECL_CONTEXT (if_stmt_label[ii]
On Mon, May 20, 2013 at 3:42 PM, Steven Bosscher wrote:
> On Mon, May 20, 2013 at 4:55 AM, Teresa Johnson wrote:
>
>> * ifcvt.c (find_if_case_1): Replace BB_COPY_PARTITION with assert
>> as this is now done by redirect_edge_and_branch_force.
>> * function.c (thread_prologue
On Mon, May 20, 2013 at 7:13 PM, Michael Meissner
wrote:
> This patch adds the builtins for the new ISA 2.07 crypto instructions. It
> bootstraps and causes no regressions, is it ok to install after patch #1 has
> been applied?
>
> [gcc]
> 2013-05-20 Michael Meissner
>
> * doc/extend.t
On Mon, May 20, 2013 at 5:34 PM, Michael Meissner
wrote:
> After submitting the patch, I realized I had submitted a previous version of
> the patch, that had the wq constraint that was initially for the quad memory
> operations, and also had the changes for ChangeLog.ibm, that I keep on the
> bran
OK.
Jason
On Tue, May 21, 2013 at 10:16 PM, Bill Schmidt
wrote:
> I can take a look at this tomorrow. I think I should probably commit
> the other pending patch I have first. There was some discussion on my
> patch whether it was the right approach, but given the behavior of
> existing allocators I think
Let me start by saying that I think the patch is generally ok, especially
considering the advice that's already been given. That said...
+++ b/gcc/c/c-array-notation.c
@@ -0,0 +1,3121 @@
So, like, are we going to need to replicate 3000 lines to add array notation to
c++ too? How much of th
On Tue, 2013-05-21 at 21:57 -0400, David Edelsohn wrote:
> On Tue, May 21, 2013 at 7:13 PM, Sandra Loosemore
> wrote:
> > On 05/21/2013 04:04 PM, David Edelsohn wrote:
> >>
> >>
> >> There are three issues here:
> >>
> >> 1) Someone in the LTC toolchain team needs to benchmark this patch on
> >> P
On Tue, May 21, 2013 at 7:13 PM, Sandra Loosemore
wrote:
> On 05/21/2013 04:04 PM, David Edelsohn wrote:
>>
>>
>> There are three issues here:
>>
>> 1) Someone in the LTC toolchain team needs to benchmark this patch on
>> POWER7.
>
>
> That would be great if somebody else could help with that.
>
>
Hi,
I think submitters have a point that it doesn't make much sense to warn
about unused parameters of defaulted functions: evidently those exist
only for documentation purposes. The actual warning is produced by
do_warn_unused_parameter, which belongs to gcc/function.c, thus the
simplest sol
This patch provides the tests for the new vector instructions added in patches
3 and 4. In addition, it provides the target support for power8 systems.
Is this patch acceptable to be checked in once the previous 4 patches have been
applied?
2013-05-21 Michael Meissner
* gcc.target/po
On 05/21/2013 04:04 PM, David Edelsohn wrote:
There are three issues here:
1) Someone in the LTC toolchain team needs to benchmark this patch on POWER7.
That would be great if somebody else could help with that.
2) We need to clarify how the patch affects the ABI because it cannot
break the
This patch is to be used with customized coverage reduction.
The functionalities are under two parameter options:
--param=COVERAGE-CALLBACK={0|1}
when enabled with 1, it injects a callback function for
each arc counter. Default off.
--param=COVERAGE-CALLONCE={0|1}
when enabled with 1, it stops inc
On Tue, May 21, 2013 at 5:49 PM, Sandra Loosemore
wrote:
> On 05/20/2013 03:20 PM, David Edelsohn wrote:
>>
>> This seems like a reasonable change and *should* improve performance,
>> but what is the actual effect on performance, especially recent POWER
>> processors? We have had some recent case
On 05/20/2013 03:20 PM, David Edelsohn wrote:
This seems like a reasonable change and *should* improve performance,
but what is the actual effect on performance, especially recent POWER
processors? We have had some recent cases where increased alignment
hurt performance because of secondary effe
On Tue, 2013-05-21 at 19:55 +0100, Richard Sandiford wrote:
> Hmm, but generic.md is very much legacy and shouldn't be used for
> vaguely modern cores. Even something like -mips32 is supposed to avoid
> the generic scheduler; it should use the 4k scheduler instead.
> What options were you using t
On 2013-05-20 09:15 , Evgeniy Stepanov wrote:
Is it OK for google/gcc-4_8 and google/main (or google/integration?) ?
OK for google branches.
Thanks. Diego.
On 05/21/2013 12:28 PM, Diego Novillo wrote:
> This is OK for google branches. I'm tempted to say it's fine for trunk, but I
> would like to know what maintainers think. Richard?
Looks plausible.
Irritating that we need another config file, rather than simply an environment
variable passed down
On 2013-05-21 15:00 , Simon Baldwin wrote:
Ping. Also, any thoughts on suitability of this (or otherwise) for trunk?
On 1 May 2013 16:04, Simon Baldwin wrote:
Fix libatomic testsuite for when GCC_UNDER_TEST is not plain xgcc.
Libatomic tests fail if GCC_UNDER_TEST is set to something other
Ping. Also, any thoughts on suitability of this (or otherwise) for trunk?
On 1 May 2013 16:04, Simon Baldwin wrote:
> Fix libatomic testsuite for when GCC_UNDER_TEST is not plain xgcc.
>
> Libatomic tests fail if GCC_UNDER_TEST is set to something other than a plain
> xgcc invocation (for examp
"Steve Ellcey " writes:
> While looking at some matrix code I noticed that the generic mips scheduler
> was putting out a bunch of integer madd instructions in a row and that
> I got better performance (on 74kc and proAptiv) when they were spread out.
>
> I was wondering what folks thought of this
On Tue, May 21, 2013 at 9:52 AM, Alexander Monakov wrote:
>
> 1. The documentation does not say whether reusing "state" objects is allowed.
> For instance, I'm using backtrace_simple, and then in the callback I'm
> invoking dladdr and backtrace_pcinfo to gather file-line info if available.
> Looks
Graham Stott writes:
> When micromips was added scanasm.exe wasn't updated this was causing a few
> tests
> which scanned the assembler output to start failing such as
> dg.c++/debiug/dwarf2/lineno-simple1.C.
>
> Fixed with the ollowing patch
Thanks. I think we should only conditionally match
That's a follow-up the just committed patch - which came too late in
some cases.
Build and regtested on x86-64-gnu-linux.
OK for the trunk?
Tobias
2013-05-21 Tobias Burnus
PR fortran/57338
* intrinsic.c (do_check): Move some checks to ...
(do_ts29113_check): ... this new function.
(chec
I just realized that this patch wasn't committed - I did it now: Rev.
199158.
Tobias
PS: Committed version attached, which honors the review comments.
On April 26, 2013 00:13, Mikael Morin wrote:
Hello,
Le 23/04/2013 09:58, Tobias Burnus a écrit :
The constraint checks for assumed-type and
Hello!
This patch avoids movdqu/movdqa when SSE2 is disabled. Although
-mno-sse2 is bordering on ABI violation for 64bit targets, the patch
is simple enough to fix movti_internal_rex64 pattern.
2013-05-21 Uros Bizjak
PR target/57356
* config/i386/i386.md (*movti_internal_rex64): Emit
On Mon, 20 May 2013, Ian Lance Taylor wrote:
> To be clear: are you withdrawing your earlier patch?
Yes; at this point I don't think it improves anything sufficiently to spend
more time on it.
Forgive me a digression, but having now actually used libbacktrace, I have
the following questions.
1.
> Fixed the problem, and retested. New patch attached.
OK for the google/gcc-4_8 branch. Thanks!
-cary
I have merged the trunk into the branch: Rev. 199152
Tobias
Hi Jakub, I actually committed this patch to mainline earlier today, as it is
trivial, enables my own plugin (dragonegg) to compile against gcc-4.8, and
according to the PR makes some other plugins work with gcc-4.8 too. I will
backport it to the gcc-4.8 branch if no-one objects. But maybe you a
Hi,
this adds the register save/restore routines to libgcc for a couple of cross
platforms that we use (powerpc-elf and powerpc-wrs-vxworks). OK for mainline?
2013-05-20 Eric Botcazou
libgcc/
* config.host (powerpc-*-elf*): Add rs6000/t-savresfgpr to tmake_file.
(powerpc-wr
Hi Richard,
> On 05/20/2013 09:55 AM, Kyrylo Tkachov wrote:
> > For example, a setup like:
> >
> > (define_attr "predicated" "yes,no" (const_string "no"))
> >
> > (define_attr "control_attr" "yes,no" (const_string "yes"))
> >
> >
> > (define_attr "enabled" "no,yes"
> > (cond [(and (eq_attr "cont
Hello Aldy et al.,
Attached, please find a patch on top of gomp4 branch that implements
Cilk's <#pragma simd> for C++. This is done in the same fashion as Aldy did in:
http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00678.html (It creates OMP_SIMD
trees and let omp-low do the rest).
On 04/26/2013 05:17 PM, Michael Zolotukhin wrote:
> gcc/ChangeLog
> 2013-04-26 Michael Zolotukhin
>
> * read-rtl.c (copy_rtx_for_iterators): Continue applying iterators
> while it has any effect.
Ok.
Bernd
On Tue, May 21, 2013 at 05:09:14PM +0200, Jakub Jelinek wrote:
> On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote:
> > This patch readd TARGET_H that was removed with revision 188166
> > IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
> > did have TARGET_H befo
On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote:
> This patch readd TARGET_H that was removed with revision 188166
> IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that
> did have TARGET_H before it was removed and it was not added to IPA_PROP_H or
> PLUGIN_HEADE
On 05/21/2013 09:03 AM, Jakub Jelinek wrote:
Hi!
int_fits_type_p ICEs if the second argument is pointer type (those don't
have TYPE_MIN_VALUE/TYPE_MAX_VALUE). Fixed thusly, bootstrapped/regtested
on x86_64-linux and i686-linux, ok for trunk?
2013-05-21 Jakub Jelinek
PR tree-optimiz
Hi!
int_fits_type_p ICEs if the second argument is pointer type (those don't
have TYPE_MIN_VALUE/TYPE_MAX_VALUE). Fixed thusly, bootstrapped/regtested
on x86_64-linux and i686-linux, ok for trunk?
2013-05-21 Jakub Jelinek
PR tree-optimization/57331
* tree-vrp.c (simplify_cond
On Tue, 2013-05-21 at 09:41 -0400, Diego Novillo wrote:
> On 2013-05-20 16:03 , David Malcolm wrote:
[...]
> >> BTW, I don't have commit rights to GCC (am reattaching the patch for
> >> convenience)
> > (I have svn rights now)
> Oh, that was it. Sorry, it slipped my mind. You can certainly commit
On Tue, May 21, 2013 at 10:57 AM, Eric Botcazou wrote:
>> This patch allows targets to keep the CFG around until after final, by
>> skipping pass_free_cfg and CFG-destructive passes like dbr_schedule,
>> and by making insn splitting before 'final' use split_all_insns
>> instead of split_all_insns_n
On 2013-05-20 16:03 , David Malcolm wrote:
Ping: OK if I commit this to trunk?
Absolutely. I remembering approving this a while back.
BTW, I don't have commit rights to GCC (am reattaching the patch for
convenience)
(I have svn rights now)
Oh, that was it. Sorry, it slipped my mind.
On 05/21/2013 06:13 AM, Paolo Carlini wrote:
@@ -2141,7 +2141,8 @@ rationalize_conditional_expr (enum tree_code code,
gcc_assert (!TREE_SIDE_EFFECTS (op0)
&& !TREE_SIDE_EFFECTS (op1));
return
- build_conditional_expr (build_x_binary_op (input_location,
+
On 21/05/13 11:26, Richard Sandiford wrote:
> Andreas Krebbel writes:
>> On 21/05/13 10:39, Richard Sandiford wrote:
>>> Andreas Krebbel writes:
On 30/04/13 16:56, Richard Sandiford wrote:
> This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out
> in the wide-int revi
All,
When micromips was added scanasm.exe wasn't updated this was causing a few tests
which scanned the assembler output to start failing such as
dg.c++/debiug/dwarf2/lineno-simple1.C.
Fixed with the ollowing patch
Graham
testuite/ChangeLog:
21-05-2013 * graham stott graham.st...@btin
> -Original Message-
> From: Aldy Hernandez [mailto:al...@redhat.com]
> Sent: Tuesday, May 21, 2013 8:14 AM
> To: Iyer, Balaji V
> Cc: gcc-patches; Jakub Jelinek
> Subject: Re: [gomp4/cilkplus] C parsing for Cilk Plus <#pragma simd>
>
> On 05/20/13 14:34, Iyer, Balaji V wrote:
> > Hello
On Fri, May 17, 2013 at 5:48 PM, Dehao Chen wrote:
> On Fri, May 17, 2013 at 1:22 AM, Richard Biener
> wrote:
>> On Wed, May 15, 2013 at 6:50 PM, Cary Coutant wrote:
gcc/ChangeLog:
* tree-cfg.c (locus_descrim_hasher::hash): Only hash lineno.
(locus_descrim_hasher::equal): Lik
On Tue, May 21, 2013 at 1:24 PM, Martin Jambor wrote:
> Hi,
>
> PR 57289 is an LTO streaming issue. We should process the bitpack
> before moving on to read other stuff in ipa_read_node_info because
> bp_unpack_value might read from the stream if there are many bits to
> read. Fixed by the follo
On 05/20/13 14:34, Iyer, Balaji V wrote:
Hello Aldy, I have moved a couple prototypes from c-tree.h to
c-family/c-common.h. This way I can use the same function for the C++
implementation. Here is a patch.
OK for branch.
On Tue, May 21, 2013 at 01:58:54PM +0200, Richard Biener wrote:
>
> The following fixes PR57318 where we estimate volatile loads to
> be eliminated.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
>
> Ok for the branch?
Yes.
Jakub
The following fixes PR57318 where we estimate volatile loads to
be eliminated.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
Ok for the branch?
Thanks,
Richard.
2013-05-21 Richard Biener
PR tree-optimization/57318
* tree-ssa-loop-ivcanon.c (tree_est
On Tue, May 21, 2013 at 01:55:34PM +0200, Richard Biener wrote:
>
> The following makes sure to preserve the call function type when
> redirecting edges.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
>
> Ok for the branch?
Yes, we'll need to do rc2 most likely anywa
The following makes sure to preserve the call function type when
redirecting edges.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
Ok for the branch?
Thanks,
Richard.
2013-05-21 Richard Biener
PR tree-optimization/57330
* cgraph.c (cgraph_redirect_ed
Hi,
PR 57289 is an LTO streaming issue. We should process the bitpack
before moving on to read other stuff in ipa_read_node_info because
bp_unpack_value might read from the stream if there are many bits to
read. Fixed by the following patch which makes 454.calculix build
with -flto again and als
Hi,
a little more work on locations. Yesterday, when I patched
build_new_op_1 to propagate the incoming location to cp_build_binary_op
I noticed that the locations for the conditional expressions in
Wdouble-promotion.C where inaccurate, essentially always pointing to the
end. We can improve t
Andreas Krebbel writes:
> On 21/05/13 10:39, Richard Sandiford wrote:
>> Andreas Krebbel writes:
>>> On 30/04/13 16:56, Richard Sandiford wrote:
This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out
in the wide-int review. It also passes "mode" rather than "VOIDmode"
>
On 21/05/13 10:39, Richard Sandiford wrote:
> Andreas Krebbel writes:
>> On 30/04/13 16:56, Richard Sandiford wrote:
>>> This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out
>>> in the wide-int review. It also passes "mode" rather than "VOIDmode"
>>> to immed_double_int_const.
> This patch allows targets to keep the CFG around until after final, by
> skipping pass_free_cfg and CFG-destructive passes like dbr_schedule,
> and by making insn splitting before 'final' use split_all_insns
> instead of split_all_insns_noflow if pass_free_cfg was skipped.
Well, you currently ca
Andreas Krebbel writes:
> On 30/04/13 16:56, Richard Sandiford wrote:
>> This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out
>> in the wide-int review. It also passes "mode" rather than "VOIDmode"
>> to immed_double_int_const. (As discussed in that thread, the latter
>> change
On 21 May 2013 09:24, Daniel Krügler wrote:
> 2013/5/21 Jonathan Wakely :
>> This broke due to some front end changes that disallow forming
>> function types that return abstract types. std::reference_wrapper
>> always passes an lvalue reference to __invoke so it's correct to use
>> an lvalue refe
On Mon, May 20, 2013 at 4:04 PM, Steven Bosscher wrote:
> On Mon, May 20, 2013 at 4:00 PM, Easwaran Raman wrote:
>> If your suggestion is to use that
>> instead of 1 when BB == NULL, that would work (even though setting it
>> to 1 is sufficient.)
>
> That's what I suggest, yes. I understand that 1
Hi Steven,
> > This would allow us to, for example, disable the predicable variant
> of an
> > insn
> > based on a non-constant variable.
>
> Is there a reason why you can't use attribute "enabled" for this?
The problem stems from the fact that the "predicable" attribute cannot have
a dynamic v
Am 19.05.2013 11:40, schrieb Paolo Carlini:
> On 05/19/2013 11:35 AM, Andreas Schwab wrote:
>> Tests that now fail, but worked before:
> Thanks Andreas. Matthias, please revert ASAP, thanks.
you already did that.
Looks like ext/random includes opt_random.h, which is not on any include dir, so
mak
2013/5/21 Jonathan Wakely :
> This broke due to some front end changes that disallow forming
> function types that return abstract types. std::reference_wrapper
> always passes an lvalue reference to __invoke so it's correct to use
> an lvalue reference as the result_of's template argument.
I agr
On Fri, May 17, 2013 at 5:51 PM, Jeff Law wrote:
> As I believe I pointed out in a follow-up message, 254.gap is depending on
> signed overflow semantics.
>
> This patch avoids eliminating a cast feeding a conditional when the
> SSA_NAME's range has overflowed unless -fstrict-overflow is in effect
On Tue, May 21, 2013 at 09:18:15AM +0100, Jonathan Wakely wrote:
> This broke due to some front end changes that disallow forming
> function types that return abstract types. std::reference_wrapper
> always passes an lvalue reference to __invoke so it's correct to use
> an lvalue reference as the
This broke due to some front end changes that disallow forming
function types that return abstract types. std::reference_wrapper
always passes an lvalue reference to __invoke so it's correct to use
an lvalue reference as the result_of's template argument.
PR libstdc++/57336
* incl
The following patch fixes store sinking to properly account for
self-assignments in the same way DSE does (which means this patch
also enhances store-sinking).
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
Richard.
2013-05-21 Richard Biener
PR tree-optimizat
Hi!
This PR has been fixed recently by PR56988 fix, but adding the testcase
IMHO doesn't hurt. Committed to trunk/4.8.
2013-05-21 Jakub Jelinek
PR tree-optimization/57321
* gcc.c-torture/execute/pr57321.c: New test.
--- gcc/testsuite/gcc.c-torture/execute/pr57321.c.jj201
Yes, this looks good. OK for trunk, but please add a note about those
additional changes you made to the ChangeLog entry. Thanks!
Thanks, done with this entry:
2013-05-21 Christian Bruel
* dwarf2out.c (multiple_reg_loc_descriptor): Use dbx_reg_number for
spanning register
On Sun, 19 May 2013, Chung-Ju Wu wrote:
> 2013/5/19 Ian Lance Taylor :
> > On Fri, May 17, 2013 at 7:29 PM, Chung-Ju Wu wrote:
> >> Ping: http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00429.html
> >>
> >> The patch is to fix dependency issue of libgcc Makefile.in
> >> by adding 'rm libgcc_tm.stamp
On 30/04/13 16:56, Richard Sandiford wrote:
> This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out
> in the wide-int review. It also passes "mode" rather than "VOIDmode"
> to immed_double_int_const. (As discussed in that thread, the latter
> change shouldn't make any difference
74 matches
Mail list logo
