On Mon, May 20, 2013 at 4:04 PM, Steven Bosscher <stevenb....@gmail.com> wrote:
> On Mon, May 20, 2013 at 4:00 PM, Easwaran Raman wrote:
>> If your suggestion is to use that
>> instead of 1 when BB == NULL, that would work (even though setting it
>> to 1 is sufficient.)
>
> That's what I suggest, yes. I understand that 1 is sufficient for now,
> but you never know if/when someone will use these uids for something
> else within the pass and expect them to be more-or-less unique (only
> non-unique for consecutive insns).
>
> But I have no strong preference either way, 1 or max+1.

It has to be 1 for correctness reason.

The patch is ok with the testcase included.

Thanks,
Richard.

> Ciao!
> Steven

Reply via email to