On 05/21/2013 04:04 PM, David Edelsohn wrote:
There are three issues here: 1) Someone in the LTC toolchain team needs to benchmark this patch on POWER7.
That would be great if somebody else could help with that.
2) We need to clarify how the patch affects the ABI because it cannot break the ABI.
I understand this.
3) Please stop saying that you cannot justify trying to get the patch in mainline. Other developers have pointed out how the patch may be incorrect. Do you want to deliver a broken compiler to CodeSourcery's customers? The comment sets a bad tone for engaging with the GCC community.
I think you've misunderstood my position, here. Delivering a broken compiler is just what I want to avoid! We've had the original local-arrays-only patch in our local tree for a couple of years now, but we no longer have a customer for it. I thought the comments from the previous review would be straightforward to address and it would be worth making one more attempt to revise and resubmit the patch, but if the feedback we get from the community is that this is still broken in other ways and is going to need a lot more work before it's acceptable, we're going to give up on it and revert the previous version of the patch locally too. We have a lot of higher-priority patches in our local tree that we'd like to get on mainline, and limited resources for working on it, so we need to pick our battles. That's all. :-)
-Sandra
