Re: [FFmpeg-devel] [PATCH] Remove the ffserver program and the ffm muxer/demuxer

2016-10-30 Thread Lukasz Marek
On 27.10.2016 20:26, Michael Niedermayer wrote: On Thu, Oct 27, 2016 at 11:03:07AM -0700, Reynaldo H. Verdejo Pinochet wrote: I agree with moving the apps to a seperate repo hosted within the same infra and keeping ffserver. I will help with ffserver as my time & todo list permits I don't follo

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-01 Thread Lukasz Marek
On 28.11.2016 19:53, Lou Logan wrote: On Mon, Nov 28, 2016, at 09:15 AM, Nicolas George wrote: ffserver has users I don't know of any. Do you have an estimation of how many users there may be? How much feedback has there been from these alleged users regarding the removal plans? I don't hav

Re: [FFmpeg-devel] [PATCH v3 3/3] lavd: deprecate opengl outdev

2016-09-15 Thread Lukasz Marek
On 14.09.2016 19:53, Nicolas George wrote: Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : This device depends on SDL which is deprecated. Signed-off-by: Josh de Kock If I understand correctly, SDL is only used in this device to set up a window and a context in a cross-platform wa

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Lukasz Marek
On 15.09.2016 23:19, Moritz Barsnick wrote: On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean? Has SDL1 gotten rotten? Or more precisely: - Has technology evolved, and the library

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Lukasz Marek
On 15.09.2016 23:36, Josh de Kock wrote: On 15/09/2016 22:28, Lukasz Marek wrote: On 15.09.2016 23:19, Moritz Barsnick wrote: On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean

Re: [FFmpeg-devel] Resurrection of ffserver

2016-09-17 Thread Lukasz Marek
On 17.09.2016 22:27, Rostislav Pehlivanov wrote: On 17 September 2016 at 20:58, Michael Fritscher < michael.fritsc...@telematik-zentrum.de> wrote: Good day, I read the sad news about ffservers a few days ago and have already written some mails to ffmpeg-user. I would like to step in to make f

Re: [FFmpeg-devel] Resurrection of ffserver

2016-09-17 Thread Lukasz Marek
On 17.09.2016 23:10, Rostislav Pehlivanov wrote: On 17 September 2016 at 22:04, Lukasz Marek wrote: Yeah, no. You can hardly say ffserver is a perfect program right now, so really moving it to another repo is hardly much of a change in terms of functionality. Bisection won't matter if hal

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-17 Thread Lukasz Marek
On 18 September 2016 at 00:30, Josh de Kock wrote: > I did this in about 5 minutes, and only tested it with one sample (on > OSX using the cocoa opengl renderer). Seems to work, but probably > won't for all cases. Would like some feedback where it doesnt work etc > > Signed-off-by: Josh de Kock

[FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-17 Thread Lukasz Marek
W dniu niedziela, 18 września 2016 Lou Logan > napisał(a): > On Sat, Sep 17, 2016, at 05:21 PM, Lukasz Marek wrote: > > On 18 September 2016 at 00:30, Josh de Kock wrote: > [...] > >> Would like some feedback where it doesnt work etc > [...] > > I said I will

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-18 Thread Lukasz Marek
On 18.09.2016 10:04, Josh de Kock wrote: On 18/09/2016 05:51, Lukasz Marek wrote: W dniu niedziela, 18 września 2016 Lou Logan > napisał(a): On Sat, Sep 17, 2016, at 05:21 PM, Lukasz Marek wrote: On 18 September 2016 at 00:30, Josh de Kock wrote: [...] Would like some feedback where

Re: [FFmpeg-devel] [PATCH] lavd/opengl: use SDL2

2016-09-18 Thread Lukasz Marek
On 18.09.2016 10:04, Josh de Kock wrote: On 18/09/2016 05:51, Lukasz Marek wrote: W dniu niedziela, 18 września 2016 Lou Logan > napisał(a): On Sat, Sep 17, 2016, at 05:21 PM, Lukasz Marek wrote: On 18 September 2016 at 00:30, Josh de Kock wrote: [...] Would like some feedback where

Re: [FFmpeg-devel] [PATCH 1/4] lavd: Add SDL2 output device

2016-09-18 Thread Lukasz Marek
On 15.09.2016 00:27, Josh de Kock wrote: Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- configure| 28 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 377 +++ 4 files

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-19 Thread Lukasz Marek
On Sep 18, 2016 04:57, "Ronald S. Bultje" wrote: > > Hi, > > On Sat, Sep 17, 2016 at 4:26 PM, Marton Balint wrote: > > > I think we should wait until Lukasz does the port of the opengl device to > > SDL2, and do the switch after that. > > > When do we think that'll be finished? I missed this, I

Re: [FFmpeg-devel] [PATCH 0/5] Add SDL2 support & drop SDL1 support

2016-09-24 Thread Lukasz Marek
been reviewed before, so there >> shouldn't be too much (or anything to change). >> >> Josh de Kock (3): >> lavd: Add SDL2 output device >> MAINTAINERS: update my entries >> lavd: drop SDL1 device & drop SDL1 support in general >> >>

[FFmpeg-devel] [PATCH] ffplay: remove redundant silence buffer

2016-03-20 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffplay.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/ffplay.c b/ffplay.c index 2cfdf26..731ae25 100644 --- a/ffplay.c +++ b/ffplay.c @@ -243,7 +243,6 @@ typedef struct VideoState { AVStream *audio_st; PacketQueue

Re: [FFmpeg-devel] [PATCH] ffplay: remove redundant silence buffer

2016-03-21 Thread Lukasz Marek
On 19.03.2016 19:16, Marton Balint wrote: > > On Thu, 17 Mar 2016, Lukasz Marek wrote: > >> Signed-off-by: Lukasz Marek >> --- >> ffplay.c | 13 ++--- >> 1 file changed, 6 insertions(+), 7 deletions(-) &g

Re: [FFmpeg-devel] GSoC again

2016-03-23 Thread Lukasz Marek
On 23.03.2016 17:09, Gerion Entrup wrote: > 3. Implement adaptive switching. > > A note to the 3rd point. I'm absolutely not sure, what amount of work this is > (maybe you could comment it) and what the best place would be to implement > this (including whether this whole feature is meaningful).

Re: [FFmpeg-devel] [PATCH] ffplay: fix silence insertion on error or pause

2016-04-04 Thread Lukasz Marek
On 03.04.2016 21:37, Marton Balint wrote: > Insertion of silence was a bit broken since > df34b700981de606ca4847e1ed0bfdf9ac3e9104 because the info whether or not the > source buffer supposed to be silence must be kept between callbacks. Failing > to > do so causes rogue samples from the last buff

Re: [FFmpeg-devel] Remove Derek Buitenhuis from MAINTAINERS

2016-05-19 Thread Lukasz Marek
On 19 May 2016 at 15:18, Derek Buitenhuis wrote: > On 5/19/2016 2:12 PM, Michael Niedermayer wrote: > > if derek still wants to leave in 2 weeks then so be it, its his choice > > but i really hope things can be resolved in a way that everyone > > stays and works together and is happy > > I will w

Re: [FFmpeg-devel] [PATCH] FTP graceful close data connection to avoid server abort

2016-06-08 Thread Lukasz Marek
On 09.06.2016 00:25, Michael Niedermayer wrote: > On Thu, Jun 02, 2016 at 02:29:47PM +0200, Camille Gonnet wrote: >> When writing files to FTP, if the data connection is closed before the >> control connection, the server may handle it as an aborted file transfer >> and create and leave the file em

Re: [FFmpeg-devel] [PATCH] FTP graceful close data connection to avoid server abort

2016-06-13 Thread Lukasz Marek
On 02.06.2016 14:29, Camille Gonnet wrote: When writing files to FTP, if the data connection is closed before the control connection, the server may handle it as an aborted file transfer and create and leave the file empty. --- libavformat/ftp.c | 14 ++ 1 file changed, 10 inserti

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

2014-08-02 Thread Lukasz Marek
+static av_always_inline int sad_wxh(const uint8_t *src1, ptrdiff_t stride1, +const uint8_t *src2, ptrdiff_t stride2, +int w, int h) +{ +int x, y, sum = 0; + +for (y = 0; y < h; y++) { +for (x = 0; x < w; x++)

[FFmpeg-devel] [PATCH 1/3] lavd/pulse_audio_dec: use default source when no input provided

2014-08-06 Thread Lukasz Marek
PulseAudio expilitly requires name of the source. This patch makes it use default source when not provided. It simplifies programistic use. Signed-off-by: Lukasz Marek --- libavdevice/pulse_audio_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice

[FFmpeg-devel] [PATCH 2/3] lavu/log: add device category macros

2014-08-06 Thread Lukasz Marek
--- libavutil/log.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavutil/log.h b/libavutil/log.h index a6a07e0..e1ff09b 100644 --- a/libavutil/log.h +++ b/libavutil/log.h @@ -46,6 +46,16 @@ typedef enum { AV_CLASS_CATEGORY_NB, ///< not part of ABI/API }AVClassCategory;

[FFmpeg-devel] [PATCH 3/3] opts: add list device sources/sinks options

2014-08-06 Thread Lukasz Marek
Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek --- cmdutils.c | 89 ++ cmdutils.h | 12 +++ cmdutils_common_opts.h | 6 3 files changed, 107 insertions

Re: [FFmpeg-devel] [PATCH 1/3] lavd/pulse_audio_dec: use default source when no input provided

2014-08-18 Thread Lukasz Marek
On 07.08.2014 15:36, Michael Niedermayer wrote: On Thu, Aug 07, 2014 at 01:58:55AM +0200, Lukasz Marek wrote: PulseAudio expilitly requires name of the source. This patch makes it use default source when not provided. It simplifies programistic use. Signed-off-by: Lukasz Marek

[FFmpeg-devel] [PATCH] lavd/fbdev_dec: use default device when not provided

2014-10-18 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavdevice/fbdev_dec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavdevice/fbdev_dec.c b/libavdevice/fbdev_dec.c index 1593b10..7b13a85 100644 --- a/libavdevice/fbdev_dec.c +++ b/libavdevice/fbdev_dec.c @@ -68,6 +68,7

Re: [FFmpeg-devel] [PATCH 3/3] opts: add list device sources/sinks options

2014-10-18 Thread Lukasz Marek
On 13.08.2014 16:00, Michael Niedermayer wrote: On Thu, Aug 07, 2014 at 01:58:57AM +0200, Lukasz Marek wrote: Allows to list sources/sinks of the devices that implement that functionality. [...] +int show_sinks(void *optctx, const char *opt, const char *arg) +{ +#if CONFIG_AVDEVICE

[FFmpeg-devel] [PATCH 1/2] lavd/fbdev_common: report error during probing fbdev device

2014-10-18 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavdevice/fbdev_common.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavdevice/fbdev_common.c b/libavdevice/fbdev_common.c index 634780d..713e4fd 100644 --- a/libavdevice/fbdev_common.c +++ b/libavdevice/fbdev_common.c @@ -84,8

[FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-18 Thread Lukasz Marek
Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek --- cmdutils.c | 191 + cmdutils.h | 12 cmdutils_common_opts.h | 6 ++ 3 files changed, 209 insertions

[FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-18 Thread Lukasz Marek
--- libavdevice/alsa-audio-common.c | 60 + libavdevice/alsa-audio-dec.c| 6 + libavdevice/alsa-audio-enc.c| 6 + libavdevice/alsa-audio.h| 2 ++ 4 files changed, 74 insertions(+) diff --git a/libavdevice/alsa-audio-common.c b/lib

Re: [FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-18 Thread Lukasz Marek
On 18.10.2014 20:36, Lukasz Marek wrote: --- libavdevice/alsa-audio-common.c | 60 + libavdevice/alsa-audio-dec.c| 6 + libavdevice/alsa-audio-enc.c| 6 + libavdevice/alsa-audio.h| 2 ++ 4 files changed, 74 insertions

[FFmpeg-devel] [PATCH] lavd: export all symbols with av prefix

2014-10-19 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavdevice/libavdevice.v | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/libavdevice.v b/libavdevice/libavdevice.v index 663af85..d7c86ba 100644 --- a/libavdevice/libavdevice.v +++ b/libavdevice/libavdevice.v @@ -1,4 +1,4

Re: [FFmpeg-devel] [PATCH] lavd: export all symbols with av prefix

2014-10-20 Thread Lukasz Marek
On 20 October 2014 08:47, Reimar Döffinger wrote: > On 19.10.2014, at 13:39, Lukasz Marek wrote: > > > Signed-off-by: Lukasz Marek > > --- > > libavdevice/libavdevice.v | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] lavd: export all symbols with av prefix

2014-10-20 Thread Lukasz Marek
On 20.10.2014 14:55, Michael Niedermayer wrote: On Mon, Oct 20, 2014 at 12:14:14PM +0200, Lukasz Marek wrote: On 20 October 2014 08:47, Reimar Döffinger wrote: On 19.10.2014, at 13:39, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavdevice/libavdevice.v | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] lavd: export all symbols with av prefix

2014-10-20 Thread Lukasz Marek
On 20.10.2014 21:29, James Almer wrote: On 20/10/14 7:14 AM, Lukasz Marek wrote: diff --git a/libavdevice/libavdevice.v b/libavdevice/libavdevice.v index 663af85..de7278c 100644 --- a/libavdevice/libavdevice.v +++ b/libavdevice/libavdevice.v @@ -1,4 +1,4 @@ LIBAVDEVICE_$MAJOR

[FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-20 Thread Lukasz Marek
This commit allows to run programs linked dynamically in build dir without installing. Signed-off-by: Lukasz Marek --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 3e181aa..5cef407 100755 --- a/configure +++ b/configure @@ -5076,6 +5076,7

[FFmpeg-devel] [PATCH 0/4] FFserver configuration

2014-10-20 Thread Lukasz Marek
ll after these changes streaming is working, but ffplay stops playing after few seconds. I noticed ffmpeg is working at 270fps which seems wrong. I guess this is different story anyway, because this also happen without patches and workaround described in ticket. Lukasz Marek (4): ffserver: move

[FFmpeg-devel] [PATCH 1/4] ffserver: move configuration code to separate file

2014-10-20 Thread Lukasz Marek
This commit doesn't change any existing logic. It moves ffserver configuration related code to separate file. It intends to make maintaining easier. Signed-off-by: Lukasz Marek --- Makefile |1 + ffserver.c|

[FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-20 Thread Lukasz Marek
So far AVCodecContext was created without codec specified. This causes internal data to not be initialized to defaults. This commit postpone context creation until all information are gathered. Partially fixes #1275 --- ffserver.c| 8 +- ffserver_config.c | 286

[FFmpeg-devel] [PATCH 2/4] ffserver_config: clean up variable initialization

2014-10-20 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffserver_config.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/ffserver_config.c b/ffserver_config.c index 927b6fe..351c4e9 100644 --- a/ffserver_config.c +++ b/ffserver_config.c @@ -341,11 +341,11 @@ int

[FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-20 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffserver.c|6 + ffserver_config.c | 1138 ++--- ffserver_config.h |7 + 3 files changed, 566 insertions(+), 585 deletions(-) diff --git a/ffserver.c b/ffserver.c index af6e8e1..22560ce 100644 --- a

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-20 Thread Lukasz Marek
On 20.10.2014 23:57, Lukasz Marek wrote: So far AVCodecContext was created without codec specified. This causes internal data to not be initialized to defaults. This commit postpone context creation until all information are gathered. Partially fixes #1275 --- ffserver.c| 8

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-20 Thread Lukasz Marek
W dniu wtorek, 21 października 2014 Carl Eugen Hoyos napisał(a): > Lukasz Marek gmail.com> writes: > > > This commit allows to run programs linked > > dynamically in build dir without installing. > > Sorry if I misunderstand: > Doesn't this patch chang

Re: [FFmpeg-devel] [PATCH 1/4] ffserver: move configuration code to separate file

2014-10-21 Thread Lukasz Marek
On 21 October 2014 12:08, Stefano Sabatini wrote: > On date Monday 2014-10-20 23:56:59 +0200, Lukasz Marek encoded: > > This commit doesn't change any existing logic. > > It moves ffserver configuration related code to separate file. > > It intends to make maintaining e

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-21 Thread Lukasz Marek
On 21 October 2014 12:01, Derek Buitenhuis wrote: > On 10/21/2014 8:21 AM, Carl Eugen Hoyos wrote: > > This sounds like a very bad idea to me > > I agree. It's not nice to have remnants of the build process in the > installed binaries. > > If you need to run them during development, use LD_LIBRAR

Re: [FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-21 Thread Lukasz Marek
On 19.10.2014 16:27, wm4 wrote: On Sat, 18 Oct 2014 20:36:22 +0200 Lukasz Marek wrote: --- libavdevice/alsa-audio-common.c | 60 + libavdevice/alsa-audio-dec.c| 6 + libavdevice/alsa-audio-enc.c| 6 + libavdevice/alsa-audio.h

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-21 Thread Lukasz Marek
On 21.10.2014 20:25, Reimar Döffinger wrote: On 21.10.2014, at 12:15, Stefano Sabatini wrote: On date Monday 2014-10-20 23:57:01 +0200, Lukasz Marek encoded: Signed-off-by: Lukasz Marek --- ffserver.c|6 + ffserver_config.c | 1138

Re: [FFmpeg-devel] [PATCH 1/2] lavd/fbdev_common: report error during probing fbdev device

2014-10-21 Thread Lukasz Marek
On 19.10.2014 00:28, Michael Niedermayer wrote: On Sat, Oct 18, 2014 at 08:25:29PM +0200, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavdevice/fbdev_common.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) LGTM Pushed

Re: [FFmpeg-devel] [PATCH] lavd/fbdev_dec: use default device when not provided

2014-10-21 Thread Lukasz Marek
On 19.10.2014 00:27, Michael Niedermayer wrote: On Sat, Oct 18, 2014 at 07:38:16PM +0200, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- libavdevice/fbdev_dec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) LGTM Pushed

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-21 Thread Lukasz Marek
On 19.10.2014 00:20, Michael Niedermayer wrote: On Sat, Oct 18, 2014 at 08:25:30PM +0200, Lukasz Marek wrote: Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek [...] +int show_sinks(void *optctx, const char *opt, const char *arg

Re: [FFmpeg-devel] [PATCH] lavd: export all symbols with av prefix

2014-10-21 Thread Lukasz Marek
On 21.10.2014 08:59, James Almer wrote: On 20/10/14 5:03 PM, Lukasz Marek wrote: On 20.10.2014 14:55, Michael Niedermayer wrote: On Mon, Oct 20, 2014 at 12:14:14PM +0200, Lukasz Marek wrote: On 20 October 2014 08:47, Reimar Döffinger wrote: On 19.10.2014, at 13:39, Lukasz Marek wrote

Re: [FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-22 Thread Lukasz Marek
On 22 October 2014 11:53, Nicolas George wrote: > Le septidi 27 vendémiaire, an CCXXIII, Lukasz Marek a écrit : > > --- > > libavdevice/alsa-audio-common.c | 60 > + > > libavdevice/alsa-audio-dec.c| 6 + > > libavd

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_conf: factorize parse function per config tag

2014-10-22 Thread Lukasz Marek
On 22.10.2014 21:51, Reynaldo H. Verdejo Pinochet wrote: Feel free to push after removing the explicit/redundant initialization of FFServerConfig config as Reimar suggested. Removed. While you are at this though, can you remove braces on single statement ifs? appreciated. Removed. At least

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-22 Thread Lukasz Marek
On 22.10.2014 22:05, Reynaldo H. Verdejo Pinochet wrote: Hi On 10/20/2014 06:57 PM, Lukasz Marek wrote: So far AVCodecContext was created without codec specified. This causes internal data to not be initialized to defaults. This commit postpone context creation until all information are

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-22 Thread Lukasz Marek
ream_config calls >From ca5e53e39254ce8ed205598b6ffc3ef0a3a41138 Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Sun, 19 Oct 2014 21:29:40 +0200 Subject: [PATCH] ffserver_config: postpone codec context creation So far AVCodecContext was created without codec specified. This causes internal da

Re: [FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-24 Thread Lukasz Marek
On 23.10.2014 14:28, Nicolas George wrote: Le primidi 1er brumaire, an CCXXIII, Lukasz Marek a écrit : It gives the same list as aplay -L (upper case). For example (ffmpeg will display it in different way, but the content is the same) I thought for a time that "dmix:CARD=PCH,DEV=0

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-24 Thread Lukasz Marek
rom 545cb5b81e9d4b8dee3d6e1e34f72cd165f336c8 Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Thu, 7 Aug 2014 00:45:26 +0200 Subject: [PATCH 1/2] opts: add list device sources/sinks options Allows to list sources/sinks of the devices that implement that functionality. Signed-off-by: Lukasz Marek --- cmdutil

[FFmpeg-devel] [PATCH] doc/fftools-common-opts: document -devices option

2014-10-24 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- doc/fftools-common-opts.texi | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 18027d2..c0bfb7e 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-25 Thread Lukasz Marek
lues stored in audio AVCodecContext.fields */ Would drop the repeated "Contains". Dropped. >From ab5395a62b60cedd47d9e6894b685c29a8c87f3d Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Sun, 19 Oct 2014 21:29:40 +0200 Subject: [PATCH] ffserver_config: postpone codec conte

Re: [FFmpeg-devel] [PATCH] doc/fftools-common-opts: document -devices option

2014-10-25 Thread Lukasz Marek
On 25.10.2014 11:56, Michael Niedermayer wrote: On Fri, Oct 24, 2014 at 11:31:14PM +0200, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- doc/fftools-common-opts.texi | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) LGTM Pushed

Re: [FFmpeg-devel] [PATCH 2/2] opts: add list device sources/sinks options

2014-10-25 Thread Lukasz Marek
On 24.10.2014 23:13, Michael Niedermayer wrote: +The returned list cannot be assumed to be always completed. complete +The returned list cannot be assumed to be always completed. complete Both changed i wonder if some of the code can be factorized/simplifed but either way it LGTM I know

Re: [FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-27 Thread Lukasz Marek
o fail; +} +free(tmp); doesnt mem leak in case of the goto fails ? i dont see where its freed I intended to free before ifs, but I'm a victim of routine... I noticed it can be done more clever anyway, so one more patch attached. >From 32d597cb057f7d45e3fcd794543b3ffc

Re: [FFmpeg-devel] FFserver bug?

2014-10-31 Thread Lukasz Marek
On 31 October 2014 03:19, Michael Niedermayer wrote: > On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: > > Hi, > > > > Two days ago i updated my linux system and also ffmpeg was updated. When > i > > started to stream it was not working anymore. I am using ffserver. i > > determined

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

2014-10-31 Thread Lukasz Marek
On 25.10.2014 19:53, Lukasz Marek wrote: On 24.10.2014 00:18, Reynaldo H. Verdejo Pinochet wrote: Hi Lukasz +static int ffserver_apply_stream_config(AVCodecContext *enc, const AVDictionary *conf, AVDictionary **opts) +{ +static const char *error_message = "Cannot parse '%s'

Re: [FFmpeg-devel] [PATCH] lavd/alsa: implement get_device_list callbacks

2014-10-31 Thread Lukasz Marek
On 27.10.2014 23:12, Lukasz Marek wrote: On 26.10.2014 23:27, Michael Niedermayer wrote: +/* ported from alsa-utils/aplay.c */ +int ff_alsa_get_device_list(AVDeviceInfoList *device_list, snd_pcm_stream_t stream_type) +{ +int ret = 0; +void **hints, **n; +char *name = NULL, *descr

[FFmpeg-devel] [PATCH] configure: add -Werror=declaration-after-statement for gcc

2014-10-31 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 40d1f07..3322779 100755 --- a/configure +++ b/configure @@ -5227,6 +5227,7 @@ elif enabled gcc; then check_cflags -Werror=missing-prototypes check_cflags -Werror

[FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

2014-10-31 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffserver_config.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ffserver_config.c b/ffserver_config.c index d589ff2..f11db03 100644 --- a/ffserver_config.c +++ b/ffserver_config.c @@ -819,8 +819,6 @@ static int ffserver_parse_config_stream(FFServerConfig

[FFmpeg-devel] [PATCH 2/4] ffserver_config: drop presets support

2014-10-31 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffserver_config.c | 80 +-- ffserver_config.h | 2 -- 2 files changed, 1 insertion(+), 81 deletions(-) diff --git a/ffserver_config.c b/ffserver_config.c index f11db03..6989bd8 100644 --- a/ffserver_config.c

[FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-10-31 Thread Lukasz Marek
Replace atoi with more advanced parsing routine. Set maximum port value to 65535 (not 65536). Other checks. Signed-off-by: Lukasz Marek --- ffserver_config.c | 48 +++- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/ffserver_config.c

[FFmpeg-devel] [PATCH 4/4] ffserver_config: dont pass pointer to enum as pointer to int

2014-10-31 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffserver_config.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ffserver_config.c b/ffserver_config.c index c694934..045b791 100644 --- a/ffserver_config.c +++ b/ffserver_config.c @@ -541,8 +541,11 @@ static int

Re: [FFmpeg-devel] [PATCH] configure: add -Werror=declaration-after-statement for gcc

2014-11-01 Thread Lukasz Marek
On 01.11.2014 09:48, Nicolas George wrote: Le primidi 11 brumaire, an CCXXIII, Lukasz Marek a écrit : Signed-off-by: Lukasz Marek --- configure | 1 + 1 file changed, 1 insertion(+) Did something change since 377dfa3d? Hmm, it can be annoying during debugging/development/tests... yes

Re: [FFmpeg-devel] "OPW Qualification Task: Enable daemon mode for FFserver"

2014-11-01 Thread Lukasz Marek
On 01.11.2014 17:20, Binathi Bingi wrote: +if (config.ffserver_daemon) { +int ffserver_id = 0; You may change int to pid_t too, which is actually returned by fork() +pid_t sid = 0; + +ffserver_id = fork(); ___ ffmpeg-de

[FFmpeg-devel] [PATCH] ffserver_config: improve AVOption handing

2014-11-01 Thread Lukasz Marek
AVOption are checked right after found in config file. It allows to report exact line in config file. Options provided more than once are threated as errors. It also fixes flag options handing. Flags may occur more than once in config file. Signed-off-by: Lukasz Marek --- ffserver_config.c

Re: [FFmpeg-devel] [PATCH 2/4] ffserver_config: drop presets support

2014-11-01 Thread Lukasz Marek
On 01.11.2014 22:27, Reynaldo H. Verdejo Pinochet wrote: Patch seems OK but I'm missing on the rationalle behind dropping the preset support. Can you elaborate? Patch 1 and 2 are just suggestion from previous reviews by Stefano. Regarding presents itself I have no pressure to remove it, but I a

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-01 Thread Lukasz Marek
On 01.11.2014 23:06, Reynaldo H. Verdejo Pinochet wrote: Hi On 10/31/2014 11:00 PM, Lukasz Marek wrote: [..] @@ -356,9 +356,7 @@ static int ffserver_parse_config_global(FFServerConfig *config, const char *cmd, if (!av_strcasecmp(cmd, "Port")) WARNING("

Re: [FFmpeg-devel] [PATCH 4/4] ffserver_config: dont pass pointer to enum as pointer to int

2014-11-01 Thread Lukasz Marek
On 1 November 2014 23:07, Reynaldo H. Verdejo Pinochet < reyna...@osg.samsung.com> wrote: > Looks OK. Feel free to push. > Pushed this one ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] ffserver_config: drop presets support

2014-11-01 Thread Lukasz Marek
On 2 November 2014 00:15, Reynaldo H. Verdejo Pinochet < reyna...@osg.samsung.com> wrote: > Hi > > On 11/01/2014 07:42 PM, Lukasz Marek wrote: > > [..] > > > > Patch 1 and 2 are just suggestion from previous reviews by Stefano. > > Regarding presents itself

[FFmpeg-devel] [PATCH 1/2] lavf/ffm: silent deprecated warnings

2014-11-02 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavformat/ffmdec.c | 11 +++ libavformat/ffmenc.c | 5 + 2 files changed, 16 insertions(+) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index 448762b..e95c139 100644 --- a/libavformat/ffmdec.c +++ b/libavformat/ffmdec.c @@ -23,6 +23,7

[FFmpeg-devel] [PATCH 2/2] [RFC]lavf/ffm: update with more options.

2014-11-02 Thread Lukasz Marek
TODO: bump micro Many common codec options are not via ffm protocol. This commit adds common A/V encoding options to protocol. Signed-off-by: Lukasz Marek --- libavformat/ffmdec.c | 78 libavformat/ffmenc.c | 60

Re: [FFmpeg-devel] FFserver bug?

2014-11-02 Thread Lukasz Marek
On 02.11.2014 23:34, Sevan Gelici wrote: I still don't have tested old gits. But i will try to expain. A half year ago i installed ffmpeg and i made a configuration file. When i start this bitrate was going up to 2000kbs max. I updated and now it will go higher like its sum up or something, in so

Re: [FFmpeg-devel] [PATCH] ffserver_config: improve AVOption handing

2014-11-02 Thread Lukasz Marek
On 02.11.2014 22:37, Reynaldo H. Verdejo Pinochet wrote: If you are always returning 0 then this func should probably be declared static void instead? I left it as int for future, but probably no reason for that, so changed. [..] diff --git a/ffserver_config.h b/ffserver_config.h index f29f07

Re: [FFmpeg-devel] [PATCH 3/4] ffserver_config: improve error handling

2014-11-02 Thread Lukasz Marek
On 2 November 2014 00:02, Reynaldo H. Verdejo Pinochet < reyna...@osg.samsung.com> wrote: > > > On 11/01/2014 07:59 PM, Lukasz Marek wrote: > > [..] > > > > I decreased it by 1 automatically rather than for any reason. I didn't > > want to change l

Re: [FFmpeg-devel] [PATCH 2/2] [RFC]lavf/ffm: update with more options.

2014-11-02 Thread Lukasz Marek
On 03.11.2014 00:40, Stefano Sabatini wrote: On date Sunday 2014-11-02 19:19:14 +0100, Lukasz Marek encoded: TODO: bump micro Many common codec options are not via ffm protocol. This commit adds common A/V encoding options to protocol. Signed-off-by: Lukasz Marek --- libavformat/ffmdec.c

Re: [FFmpeg-devel] [PATCH 2/2] [RFC]lavf/ffm: update with more options.

2014-11-03 Thread Lukasz Marek
On 3 November 2014 01:31, Michael Niedermayer wrote: > On Sun, Nov 02, 2014 at 07:19:14PM +0100, Lukasz Marek wrote: > > > shouldnt all these values be checked to be within the allowed ranges > for the corresponding AVOptions? > > being able to set so many field so arbitra

Re: [FFmpeg-devel] FFserver bug?

2014-11-04 Thread Lukasz Marek
On 31.10.2014 03:19, Michael Niedermayer wrote: On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: Hi, Two days ago i updated my linux system and also ffmpeg was updated. When i started to stream it was not working anymore. I am using ffserver. i determined the problem which causes t

Re: [FFmpeg-devel] FFserver bug?

2014-11-04 Thread Lukasz Marek
On 05.11.2014 00:07, Lukasz Marek wrote: Maybe worth to mention I recently created function to dump AvCodecContext, to test if ffm is transmitting context properly. And strange thing I noticed ffm demuxer's read_header callback is called only once, even though there are 2 streams. I gue

Re: [FFmpeg-devel] FFserver bug?

2014-11-04 Thread Lukasz Marek
later releases so cherry-pick would not be enough tho, to fix it on previous release Fix patches attached. >From 9c1455bd9e830aedba645451b7c0cb44831658e2 Mon Sep 17 00:00:00 2001 From: Lukasz Marek Date: Wed, 5 Nov 2014 02:10:24 +0100 Subject: [PATCH 1/2] lavc/options: don't free options w

Re: [FFmpeg-devel] FFserver bug?

2014-11-04 Thread Lukasz Marek
W dniu środa, 5 listopada 2014 Michael Niedermayer napisał(a): > On Wed, Nov 05, 2014 at 12:07:14AM +0100, Lukasz Marek wrote: > > On 31.10.2014 03:19, Michael Niedermayer wrote: > > >On Fri, Oct 31, 2014 at 02:14:29AM +0100, Sevan Gelici wrote: > > >>Hi, > >

Re: [FFmpeg-devel] [PATCH 2/2] [RFC]lavf/ffm: update with more options.

2014-11-05 Thread Lukasz Marek
On 5 November 2014 12:25, Stefano Sabatini wrote: > On date Monday 2014-11-03 00:54:01 +0100, Lukasz Marek encoded: > > On 03.11.2014 00:40, Stefano Sabatini wrote: > > >On date Sunday 2014-11-02 19:19:14 +0100, Lukasz Marek encoded: > > >>TODO: bump micro > >

[FFmpeg-devel] [PATCH] ffmpeg_opt: set correct priv_data for feed stream

2014-11-05 Thread Lukasz Marek
new_output_stream creates a codec context with arbitraty picked codec. Later data is updated, but priv_data are left alone. There is a bit chance there is a mismatch between codecs. Signed-off-by: Lukasz Marek --- ffmpeg_opt.c | 16 libavformat/ffmdec.c | 6 -- 2

Re: [FFmpeg-devel] FFserver bug?

2014-11-05 Thread Lukasz Marek
On 05.11.2014 02:15, Lukasz Marek wrote: On 31.10.2014 02:14, Sevan Gelici wrote: Hi, Two days ago i updated my linux system and also ffmpeg was updated. When i started to stream it was not working anymore. I am using ffserver. i determined the problem which causes the problem thats the

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: set correct priv_data for feed stream

2014-11-06 Thread Lukasz Marek
On 06.11.2014 01:32, Michael Niedermayer wrote: On Thu, Nov 06, 2014 at 12:59:45AM +0100, Lukasz Marek wrote: new_output_stream creates a codec context with arbitraty picked codec. Later data is updated, but priv_data are left alone. There is a bit chance there is a mismatch between codecs

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: set correct priv_data for feed stream

2014-11-07 Thread Lukasz Marek
On 6 November 2014 22:55, Michael Niedermayer wrote: > On Thu, Nov 06, 2014 at 09:27:45PM +0100, Lukasz Marek wrote: > > On 06.11.2014 01:32, Michael Niedermayer wrote: > > >On Thu, Nov 06, 2014 at 12:59:45AM +0100, Lukasz Marek wrote: > > >>new_output_strea

[FFmpeg-devel] [PATCH 2/4] lavu/opt: document av_opt_copy function

2014-11-08 Thread Lukasz Marek
--- libavutil/opt.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index b9ac932..b78810c 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -815,6 +815,16 @@ void av_opt_freep_ranges(AVOptionRanges **ranges); */ int av_opt_query_ranges(AVOp

[FFmpeg-devel] [PATCH 4/4] lavu/opt: copy dict in av_opt_copy

2014-11-08 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- libavutil/opt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index 0692393..86d3ddf 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1596,6 +1596,13 @@ int av_opt_copy(void *dst, void *src) *(int

[FFmpeg-devel] [PATCH 3/4] lavu/opt: explicity set NULL as dict/binary defaults

2014-11-08 Thread Lukasz Marek
Unless user clears context manually during creation, binary and dict pointer may contain random values. Signed-off-by: Lukasz Marek --- libavutil/opt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index 4116f96..0692393 100644 --- a/libavutil/opt.c +++ b

Re: [FFmpeg-devel] [PATCH 1/4] ffserver_config: drop requirement video size being multiple of 16

2014-11-08 Thread Lukasz Marek
On 1 November 2014 22:20, Reynaldo H. Verdejo Pinochet < reyna...@osg.samsung.com> wrote: > Hi > > On 10/31/2014 11:00 PM, Lukasz Marek wrote: > > [..] > > diff --git a/ffserver_config.c b/ffserver_config.c > > index d589ff2..f11db03 100644 > > --- a/ffserv

[FFmpeg-devel] [PATCH] ffserver_config: report not closed last tag

2014-11-08 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- ffserver_config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ffserver_config.c b/ffserver_config.c index c05c942..2ca484f 100644 --- a/ffserver_config.c +++ b/ffserver_config.c @@ -1303,6 +1303,8 @@ int ffserver_parse_ffconfig(const char *filename

Re: [FFmpeg-devel] [PATCH 3/4] lavu/opt: explicity set NULL as dict/binary defaults

2014-11-08 Thread Lukasz Marek
On 08.11.2014 19:18, Michael Niedermayer wrote: On Sat, Nov 08, 2014 at 06:13:52PM +0100, Lukasz Marek wrote: Unless user clears context manually during creation, binary and dict pointer may contain random values. wouldnt the string type in that case free random pointers ? Strings are set

  1   2   3   4   >