On 24.10.2014 23:13, Michael Niedermayer wrote:
+The returned list cannot be assumed to be always completed.
complete
+The returned list cannot be assumed to be always completed.
complete

Both changed

i wonder if some of the code can be factorized/simplifed but either
way it LGTM

I know the code looks similar, but these small differences make it hard to really simplify (making common function that is longer and more complex than 2 is not really an improvement imho)

@@ -2136,7 +2136,7 @@ static int print_device_sinks(AVOutputFormat *fmt, AVDictionary *opts)
   fail:
     av_dict_free(&tmp_opts);
     avdevice_free_list_devices(&device_list);
-    avformat_close_input(&dev);
+    avformat_free_context(dev);
     return ret;
 }

Pushed with this small local fix.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to