[FFmpeg-devel] [PATCH] avformat/hls: Fix twitter

2025-02-06 Thread Michael Niedermayer
Allow mp4 with all mpegts extensions Fixes: Ticket11435 Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 8eae64b787e..3bdc1bc8489 100644 --- a/libavformat/hls.c +++ b/liba

Re: [FFmpeg-devel] [PATCH v2] avfilter/xpsnr: avoid division by zero

2025-02-06 Thread Gyan Doshi
On 2025-02-05 12:09 pm, Gyan Doshi wrote: On 2025-02-02 11:27 pm, Gyan Doshi wrote: The ref input may have its frame rate unset, which would then lead to SIGFPE. So fall back to the main link frame rate. If that too is unset, default to 0. Related to #11428 Plan to push tomorrow. Pushe

Re: [FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true

2025-02-06 Thread Efrain T
That sounds perfectly fine with me. Thanks for the quick reply. On Thursday, February 6, 2025, Leo Izen wrote: > On 2/6/25 2:00 AM, dank074 wrote: > >> Currently when a Unix Domain Socket is used as input there is a loss of >> data when data is consumed from the stream. Setting is_streamed to tr

[FFmpeg-devel] Captions SCC

2025-02-06 Thread Devlist Archive
Greetings, I have been absent from the list for a few years, so I would appreciate it if someone could catch me up a bit. I am needing to extract and embed scc files with 608 captions. I am pleased to see that transcoding without frame rate changes now preserves 608 intact, and there appear to b

Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks

2025-02-06 Thread Nicolas Gaullier
>De : ffmpeg-devel de la part de Tomas Härdin > >Envoyé : mercredi 5 février 2025 15:47 >Objet : Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, >wav and mxf stereo tracks > >Looks OK > >Sorry for the late review > >/Tomas Thanks to you, good to know; nevertheless, the pat

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fix twitter

2025-02-06 Thread Steven Liu
Michael Niedermayer 于2025年2月6日周四 20:10写道: > > Allow mp4 with all mpegts extensions > > Fixes: Ticket11435 > > Signed-off-by: Michael Niedermayer > --- > libavformat/hls.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 8e

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-06 Thread Jerome Martinez
Le 06/02/2025 à 16:52, Michael Niedermayer a écrit : On Sun, Feb 02, 2025 at 11:16:03PM -0300, James Almer wrote: [...] +s->pict_type = AV_PICTURE_TYPE_I; //FIXME I vs. P, see ffv1dec.c id remove the comment, also in ffv1dec.c For your information this resolves the issue with non working

[FFmpeg-devel] [PATCH v2] avcodec/ac3dec: add a flush callback for the ac3 and eac3 decoders

2025-02-06 Thread James Almer
Fixes ticket #10732 Signed-off-by: James Almer --- libavcodec/ac3dec.c | 10 ++ libavcodec/ac3dec.h | 40 ++- libavcodec/ac3dec_fixed.c | 1 + libavcodec/ac3dec_float.c | 2 ++ 4 files changed, 36 insertions(+), 17 deletions(-) diff --gi

Re: [FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-06 Thread Devin Heitmueller
On Thu, Feb 6, 2025 at 3:16 PM Marton Balint wrote: > > Feel free to take a look. The last change to the decklink code in FFmpeg was > > authored last april (not counting minor one-line bugfixes and the like) and > > as far as I am aware nobody is currently working on that so you wouldn't be > > r

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

2025-02-06 Thread Michael Niedermayer
Hi On Wed, Feb 05, 2025 at 03:53:23PM +0100, Tomas Härdin wrote: > ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer: > > Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be > > represented in type 'long' > > Fixes: 392672068/clusterfuzz-testcase-minimized- > > ffmpeg_dem_

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: fix eof check in mov_read_iinf()

2025-02-06 Thread Michael Niedermayer
On Mon, Feb 03, 2025 at 06:25:53AM +0100, Kacper Michajłow wrote: > This fix ensures that the loop stops early on EOF. The issue occurs > because mov_read_infe() performs a version check and skips unsupported > versions. The problem is that seeking within the stream clears the EOF > flag, causing a

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fix twitter

2025-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2025 at 08:17:05PM +0800, Steven Liu wrote: > Michael Niedermayer 于2025年2月6日周四 20:10写道: > > > > Allow mp4 with all mpegts extensions > > > > Fixes: Ticket11435 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/hls.c | 4 ++-- > > 1 file changed, 2 insertions(+),

[FFmpeg-devel] [PATCH v3 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-06 Thread Martin Storsjö
On a Zen 5, on Ubuntu 24.04 (with CLOCKS_PER_SEC 100), the value of clock() in this loop increments by 0 most of the time, and when it does increment, it usually increments by 1 compared to the previous round. Due to the "last_t + 2*last_td + (CLOCKS_PER_SEC > 1000) >= t" expression, we only m

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/hevc: Add alpha layer support

2025-02-06 Thread Zhao Zhili
> On Feb 6, 2025, at 21:26, James Almer wrote: > > On 2/6/2025 12:50 AM, Zhao Zhili wrote: >> From: Zhao Zhili >> Signed-off-by: Zhao Zhili >> --- >> libavcodec/hevc/hevcdec.c | 72 ++- >> libavcodec/hevc/hevcdec.h | 2 ++ >> libavcodec/hevc/refs.c|

Re: [FFmpeg-devel] [PATCH 4/8] avformat/flacdec: Return correct error-codes on read-failure

2025-02-06 Thread Michael Niedermayer
On Wed, Feb 05, 2025 at 03:20:30PM +0100, Tomas Härdin wrote: > > flacdec.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > da53ae8bb59c5ee934cc7ba809955e0446168675 > 0004-avformat-flacdec-Return-correct-error-codes-on-read-.patch > From c81e350d5419cf02f029ce006d

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_amf: fix crash on uninit after init failed

2025-02-06 Thread Dmitrii Ovchinnikov
LGTM, Thanks. I will merge it soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Jack Lau
> I have been absent from the list for a few years, so I would appreciate it > if someone could catch me up a bit. I am needing to extract and embed scc > files with 608 captions. I am pleased to see that transcoding without > frame rate changes now preserves 608 intact, and there appear to be

Re: [FFmpeg-devel] [PATCH] fate/libswresample: add a test downmixing with a custom order layout

2025-02-06 Thread James Almer
On 2/6/2025 11:26 AM, Michael Niedermayer wrote: Hi James On Wed, Feb 05, 2025 at 11:46:32AM -0300, James Almer wrote: Signed-off-by: James Almer --- tests/fate/libswresample.mak | 8 tests/filtergraphs/custom_rematrix | 1 + 2 files changed, 9 insertions(+) create mode 10

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: add AV_CODEC_ID_IVTV_VBI

2025-02-06 Thread Marth64
Planning to push in 24-48 hours. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: log the readable error message on failure

2025-02-06 Thread Marth64
Planning to push in 24-48 hours. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-06 Thread James Almer
On 2/6/2025 4:25 PM, Jerome Martinez wrote: Le 06/02/2025 à 16:52, Michael Niedermayer a écrit : On Sun, Feb 02, 2025 at 11:16:03PM -0300, James Almer wrote: [...] +    s->pict_type = AV_PICTURE_TYPE_I; //FIXME I vs. P, see ffv1dec.c id remove the comment, also in ffv1dec.c For your informat

Re: [FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-06 Thread Marton Balint
On Wed, 5 Feb 2025, Leo Izen wrote: On 2/5/25 4:44 PM, ffm...@gallery.co.uk wrote: Hi Folks It seems like the current decklink code in FFMPEG is no longer fully compatible with the latest Decklink drivers The behaviour seen is that output via DeckLink starts OK but very quickly stalls.

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vvc/refs: Check content_ref in set_pict_type()

2025-02-06 Thread Frank Plowman
On 02/02/2025 21:17, Michael Niedermayer wrote: > Fixes: > 390565846/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4990028521996288 > Fixes: Null pointer dereference > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2025 at 02:38:48PM +0200, Martin Storsjö wrote: > On Thu, 6 Feb 2025, Michael Niedermayer wrote: > > > > +// If the timer resolution is high, and we get the same timer > > > +// value multiple times, use variances in the number of > > > repeats > > > +

[FFmpeg-devel] [PATCH] avcodec/ac3dec: add a flush callback for the eac3 decoder

2025-02-06 Thread James Almer
Fixes ticket #10732 Signed-off-by: James Almer --- libavcodec/ac3dec.c | 10 ++ libavcodec/ac3dec.h | 38 ++ libavcodec/ac3dec_fixed.c | 1 + libavcodec/ac3dec_float.c | 1 + 4 files changed, 34 insertions(+), 16 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-06 Thread Michael Niedermayer
Hi Tomas On Wed, Feb 05, 2025 at 03:24:24PM +0100, Tomas Härdin wrote: > Seems reasonable to me and passes FATE > > /Tomas > avformat.h |2 +- > format.c |8 > libopenmpt.c |2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > 01f04f79202640330d6be91b0215f92f14d

[FFmpeg-devel] [PATCH 1/3] doc/encoders: Document compression_level for PNG

2025-02-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/encoders.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index c0795fe5fd5..0005ade9c18 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -3395,6 +3395,13 @@ Default is 1 (on). PNG image en

[FFmpeg-devel] [PATCH 2/3] avcodec/pngenc: set default prediction method to PAETH

2025-02-06 Thread Michael Niedermayer
this is a good compromise between speed and compression -rw-r- 1 michael michael 180987 Feb 6 14:29 lena-def.png -rw-r- 1 michael michael 128430 Feb 6 14:36 lena-pavg.png -rw-r- 1 michael michael 126269 Feb 6 14:36 lena-pmixed.png -rw-r- 1 michael michael 180987 Feb 6 14:35 len

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/hevc: Add alpha layer support

2025-02-06 Thread James Almer
On 2/6/2025 11:32 AM, James Almer wrote: On 2/6/2025 11:06 AM, Zhao Zhili wrote: On Feb 6, 2025, at 21:26, James Almer wrote: On 2/6/2025 12:50 AM, Zhao Zhili wrote: From: Zhao Zhili Signed-off-by: Zhao Zhili ---   libavcodec/hevc/hevcdec.c | 72 +++ +++-

[FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-06 Thread Ronald S. Bultje
Fixes #11456. --- libavcodec/threadprogress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c index 62c4fd898b..aa72ff80e7 100644 --- a/libavcodec/threadprogress.c +++ b/libavcodec/threadprogress.c @@ -55,9 +55,8 @@ vo

Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread Marth64
> it would probably also be odd when there's a single white space in-between. Yes, it would look worse on white background. OK as is, then. > Why wouldn't it be machine-parsable without those letters? It is more about having timezone, etc. I actually think it is better for readability as is, but w

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-06 Thread Thinh Nguyen Huu
Hello. I discovered this issue while using the *release/6.1* branch. Could you try applying the patch on this branch? On Fri, Feb 7, 2025 at 11:10 AM Marth64 wrote: > Hello, > Patch fails to apply (looks like a rebase needed since I see the path > of hevcdec.c is older). > Also a sample or conte

Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread Marth64
I meant obscure in the context of running ffmpeg CLI in a short lived (<1 day) session for the average user. Nonetheless I am good. Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubsc

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-06 Thread Marth64
Hello, Yes I can, thanks for sharing that. Can you share a sample or steps to reproduce? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ..

[FFmpeg-devel] [PATCH v4 0/3] Add option to log timing

2025-02-06 Thread ffmpegagent
This pathcset adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Update V1 * Fix merge conflicts Update V2 * Rebased Update V3 * Fix print timing on exit (as reported by Michael Niedermayer) softworkz (3): avutil/log: s

[FFmpeg-devel] [PATCH v4 1/3] avutil/log: support logging of date and timing information

2025-02-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 32 +--- libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges

[FFmpeg-devel] [PATCH v4 2/3] fftools/opt_common: add timing and datetiming log flags

2025-02-06 Thread softworkz
From: softworkz This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents timing to be printed when exiting. Signed-off-by: softworkz --- fftools/ffmpeg.c

[FFmpeg-devel] [PATCH v4 3/3] doc/fftools-common-opts: document log timing flags

2025-02-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 8b0931a86d..f6d452c40e 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Devlist Archive > Sent: Friday, February 7, 2025 6:13 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > On Thu, Feb 6, 2025 at 4:57 AM Jack Lau > wrote: > > > > >

[FFmpeg-devel] [PATCH v5 1/3] avutil/log: support logging of date and time information

2025-02-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 32 +--- libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges

[FFmpeg-devel] [PATCH v5 0/3] Add option to log timing

2025-02-06 Thread ffmpegagent
This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Update V1 * Fix merge conflicts Update V2 * Rebased Update V3 * Fix print timing on exit (as reported by Michael Niedermayer) Update V4 * Rename variable * Rename

[FFmpeg-devel] [PATCH v5 3/3] doc/fftools-common-opts: document log timing flags

2025-02-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 8b0931a86d..f6d452c40e 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Jack Lau
> > > Hi Zack, > > that message from "Jack" had confused me for a moment, but on re-reading it > appears to be an AI response. > The content is total nonsense. There is no "SCC" encoder in ffmpeg, and if > there was one, it wouldn't help much because the CC data needs to get into > the video

[FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags

2025-02-06 Thread softworkz
From: softworkz This commit adds two logging flags: 'time' and 'datetime'. Usage: ffmpeg -loglevel +time or ffmpeg -loglevel +datetime Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents timing to be printed when exiting. Signed-off-by: softworkz --- fftools/ffmpeg.c | 1 +

Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce default max reload to 3"

2025-02-06 Thread Soft Works
> -Original Message- > From: softworkz > Sent: Sunday, January 19, 2025 9:53 AM > To: ffmpeg-devel@ffmpeg.org > Cc: softworkz ; softworkz > > Subject: [PATCH] avformat/hls: Revert "reduce default max reload to > 3" > > From: softworkz > > This change has caused regressions for many use

Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread Marth64
The example I was thinking of was if I wanted to look at the logs 2 years later, it would have time zone in case of DST or whatever. But it's a total obscure stretch case IMO. I'm not advocating for it, just sharing what I meant with my logic. (And if someone really needs it later they can make a +

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Devlist Archive
Hi Jack, Thanks for the suggestions. Could you please tell me where I can get a build of ffmpeg that will work with the -c:s scc command? That encoder doesn't seem to be in the release version I am working with. It is slightly unclear to me how your suggestion for the extract command suggestion

Re: [FFmpeg-devel] [PATCH] threadprogress: reorder instructions to silence tsan warning.

2025-02-06 Thread Zhao Zhili
> On Feb 7, 2025, at 05:42, Ronald S. Bultje wrote: > > Fixes #11456. > --- > libavcodec/threadprogress.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/threadprogress.c b/libavcodec/threadprogress.c > index 62c4fd898b..aa72ff80e7 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread Soft Works
> -Original Message- > From: Marth64 > Sent: Friday, February 7, 2025 5:47 AM > To: Soft Works > Cc: FFmpeg development discussions and patches de...@ffmpeg.org>; Michael Niedermayer ; Soft > Works > Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing > > > it would pr

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-06 Thread Marth64
Yes, confirmed Looks like its only present on 6.1. In 7.0+ it is fixed by d9f1b321cf58a85518d29c5a3d220d67b1a68b92 (which is the same change) If there is no objection I'll back port that commit in the next few days. Thanks Thinh. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH v4 2/3] fftools/opt_common: add timing and datetiming log flags

2025-02-06 Thread epirat07
On 7 Feb 2025, at 7:27, softworkz wrote: > From: softworkz > > This commit adds two logging flags: 'timing' and 'datetiming'. > > Usage: > > ffmpeg -loglevel +timing > > or > > ffmpeg -loglevel +datetiming This commit message seems out of date regarding the actual commit contents given the fl

Re: [FFmpeg-devel] [PATCH v4 2/3] fftools/opt_common: add timing and datetiming log flags

2025-02-06 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > epira...@gmail.com > Sent: Friday, February 7, 2025 7:46 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 2/3] fftools/opt_common: add > timing and datetiming log flags

Re: [FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-06 Thread Martin Storsjö
On Thu, 6 Feb 2025, Michael Niedermayer wrote: On Thu, Feb 06, 2025 at 02:38:48PM +0200, Martin Storsjö wrote: On Thu, 6 Feb 2025, Michael Niedermayer wrote: +// If the timer resolution is high, and we get the same timer +// value multiple times, use variances in the n

[FFmpeg-devel] [PATCH v3 1/3] avutil/log: support logging of date and timing information

2025-02-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 32 +--- libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 43 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges

[FFmpeg-devel] [PATCH v3 2/3] fftools/opt_common: add timing and datetiming log flags

2025-02-06 Thread softworkz
From: softworkz This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Setting av_log_set_flags(0) in term_exit in ffmpeg.c prevents timing to be printed when exiting. Signed-off-by: softworkz --- fftools/ffmpeg.c

[FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread ffmpegagent
This pathcset adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Update V1 * Fix merge conflicts Update V2 * Rebased Update V3 * Fix print timing on exit (as reported by Michael Niedermayer) softworkz (3): avutil/log: s

[FFmpeg-devel] [PATCH v3 3/3] doc/fftools-common-opts: document log timing flags

2025-02-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 8b0931a86d..37bed92864 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi

Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread Marth64
It works good. First pass thoughts: 1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case convention and conveys clearly that the parameter is an `AVBPrint` 2- Option switch: +datetime and +time feels lighter/easier (vs. -ing) 3- Term color: the space after the time keeps the backgr

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

2025-02-06 Thread Marth64
Hello, Patch fails to apply (looks like a rebase needed since I see the path of hevcdec.c is older). Also a sample or context to trigger the condition would be nice to validation. Thank you ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH] avfilter/scale*: add option reset_sar

2025-02-06 Thread Gyan Doshi
On 2025-01-31 06:30 pm, Gyan Doshi wrote: For anamorphic videos, enabling this option leads to adjustment of output dimensions to obtain square pixels when the user requests proportional scaling through either of the w/h expressions or force_original_aspect_ratio. Output SAR is always reset t

[FFmpeg-devel] [PATCH] swscale/graph: copy scaler_params to the legacy subpass context

2025-02-06 Thread James Almer
Fixes ticket #11448. Signed-off-by: James Almer --- libswscale/graph.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libswscale/graph.c b/libswscale/graph.c index 2337016111..ed5e8038b1 100644 --- a/libswscale/graph.c +++ b/libswscale/graph.c @@ -431,6 +431,9 @@ static int add_legacy_sw

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/delogo: add parameter to switch on circular delogo

2025-02-06 Thread Jörg Habenicht via ffmpeg-devel
Hi Am 06.02.25 um 18:12 schrieb Michael Niedermayer: > Hi Jörg > > On Tue, Feb 04, 2025 at 08:53:58PM +0100, Jörg Habenicht via ffmpeg-devel > wrote: >> Add a parameter (boolean) r to switch the area from >> rectangular (r=0) to circular(r=1) delogo. >> [...] >> @@ -209,6 +209,7 @@ static const

Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce default max reload to 3"

2025-02-06 Thread Steven Liu
softworkz 于2025年1月19日周日 16:52写道: > > From: softworkz > > This change has caused regressions for many users and consumers. > Playlist reloads only happen when a playlist doesn't indicate that it > has ended (via #EXT-X-ENDLIST), which means that the addition of future > segments is still expected.

Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce default max reload to 3"

2025-02-06 Thread Soft Works
> -Original Message- > From: Steven Liu > Sent: Friday, February 7, 2025 3:24 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce > default max reload to 3" > > softworkz 于2025年1月19日周

[FFmpeg-devel] [PATCH] avcodec/libtheora: fix setting keyframe_mask

2025-02-06 Thread James Almer
t_info.keyframe_granule_shift is set to the library default of 6, which is ok for gop sizes up to 63. Since there's apparently no way to query the updated value after having forced a gop value with TH_ENCCTL_SET_KEYFRAME_FREQUENCY_FORCE, calculate it manually instead. Fixes ticket #11454. Signed

Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing

2025-02-06 Thread Soft Works
> -Original Message- > From: Marth64 > Sent: Friday, February 7, 2025 4:58 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Michael Niedermayer ; softworkz > ; Soft Works hotmail@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log

Re: [FFmpeg-devel] [PATCH] ffv1dec: fix threaded decode failures

2025-02-06 Thread Michael Niedermayer
On Wed, Feb 05, 2025 at 03:47:19PM +0100, Lynne wrote: > Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5 > > The issue is that while avctx->pix_fmt is synchronized between > threads, f->pix_fmt was not. > > Fixes fate-vsynth1-ffv1-2pass10 with THREADS=2. > --- > libavcodec/ffv1dec.c | 1 + > 1 fi

[FFmpeg-devel] [PATCH 3/3] doc/encoders: Document png pred

2025-02-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/encoders.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 0005ade9c18..0bbdf5d6916 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -3409,6 +3409,8 @@ Sets the compression level, from 0 to 9(

Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-06 Thread Zhao Zhili
> On Feb 6, 2025, at 21:25, James Almer wrote: > > On 2/6/2025 12:49 AM, Zhao Zhili wrote: >> From: Zhao Zhili >> Only implementing what's needed for HEVC with alpha. >> Signed-off-by: Zhao Zhili >> --- >> libavcodec/hevc/hevc.h | 5 ++ >> libavcodec/hevc/ps.c | 126 +

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/hevc: Add alpha layer support

2025-02-06 Thread James Almer
On 2/6/2025 11:06 AM, Zhao Zhili wrote: On Feb 6, 2025, at 21:26, James Almer wrote: On 2/6/2025 12:50 AM, Zhao Zhili wrote: From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavc

Re: [FFmpeg-devel] [PATCH 1/2] swresample/rematrix: split filling the matrix array into its own function

2025-02-06 Thread Michael Niedermayer
On Sun, Feb 02, 2025 at 06:46:41PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswresample/rematrix.c | 202 --- > 1 file changed, 106 insertions(+), 96 deletions(-) > > diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c > in

Re: [FFmpeg-devel] [PATCH 2/2] swresample/rematrix: add support for custom order channel layouts

2025-02-06 Thread Michael Niedermayer
On Sun, Feb 02, 2025 at 06:46:42PM -0300, James Almer wrote: > Limited to the same channels as a native layout, but not constrained by > channel ordering. > > Signed-off-by: James Almer > --- > Untested, as i don't have a sample from which we export a custom layout (Like > PCM in mp4). > > li

Re: [FFmpeg-devel] [PATCH] fix pad artifacting

2025-02-06 Thread Michael Niedermayer
Hi Ben On Mon, Feb 03, 2025 at 04:02:15PM +, Ben Lu via ffmpeg-devel wrote: > Sure, looks like gmail is complying with a plaintext email RFC. Let me try > attaching to eml with: > `git format-patch -s -o "outputfolder" --add-header "X-Unsent: 1" --suffix > .eml --to ffmpeg-devel@ffmpeg.org -1

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-06 Thread James Almer
On 2/6/2025 12:52 PM, Michael Niedermayer wrote: On Sun, Feb 02, 2025 at 11:16:03PM -0300, James Almer wrote: Only setting frame and stream properties. No packetization is performed. Signed-off-by: James Almer --- configure| 1 + libavcodec/Makefile | 1 + libavcodec

Re: [FFmpeg-devel] [PATCH v3 2/2] Add stream dump test with test for ogg/flac.

2025-02-06 Thread Romain Beauxis
Le mer. 5 févr. 2025 à 21:03, Michael Niedermayer a écrit : > > On Tue, Feb 04, 2025 at 07:31:45AM -0500, Romain Beauxis wrote: > > This is the new FATE test. > > > > Test samples are available here: https://www.dropbox.com/scl/fo/fxt2edwkyj2mjc9qubku5/AICHxJyxMMAK8MIJqWLcvk4?rlkey=mlt12lsu741ejuk

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/delogo: add parameter to switch on circular delogo

2025-02-06 Thread Michael Niedermayer
Hi Jörg On Tue, Feb 04, 2025 at 08:53:58PM +0100, Jörg Habenicht via ffmpeg-devel wrote: > Add a parameter (boolean) r to switch the area from > rectangular (r=0) to circular(r=1) delogo. > > Signed-off-by: Jörg Habenicht > --- > libavfilter/vf_delogo.c | 7 --- > 1 file changed, 4 insertio

Re: [FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-06 Thread Martin Storsjö
On Thu, 6 Feb 2025, Michael Niedermayer wrote: +// If the timer resolution is high, and we get the same timer +// value multiple times, use variances in the number of repeats +// of each timer value as entropy. If the number of repeats changed, +/

Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-06 Thread James Almer
On 2/6/2025 12:49 AM, Zhao Zhili wrote: From: Zhao Zhili Only implementing what's needed for HEVC with alpha. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 5 ++ libavcodec/hevc/ps.c | 126 + libavcodec/hevc/ps.h | 4 ++ 3 files ch

Re: [FFmpeg-devel] [PATCH v4 3/3] avcodec/hevc: Add alpha layer support

2025-02-06 Thread James Almer
On 2/6/2025 12:50 AM, Zhao Zhili wrote: From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavcodec/hevc/refs.c| 11 +- 3 files changed, 83 insertions(+), 2 deletions(-) Can

Re: [FFmpeg-devel] [PATCH] fate/libswresample: add a test downmixing with a custom order layout

2025-02-06 Thread Michael Niedermayer
Hi James On Wed, Feb 05, 2025 at 11:46:32AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/libswresample.mak | 8 > tests/filtergraphs/custom_rematrix | 1 + > 2 files changed, 9 insertions(+) > create mode 100644 tests/filtergraphs/custom_rematrix > >

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-06 Thread Michael Niedermayer
Hi Tomas On Wed, Feb 05, 2025 at 03:20:09PM +0100, Tomas Härdin wrote: > > libavformat/flacdec.c |6 ++ > tests/ref/fate/cover-art-aiff-id3v2-remux |5 +++-- > tests/ref/fate/cover-art-flac-remux |1 + > tests/ref/fate/id3v2-utf16-bom|5

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: split off and share frame header parsing code

2025-02-06 Thread Michael Niedermayer
On Sun, Feb 02, 2025 at 11:16:02PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/Makefile | 4 +- > libavcodec/ffv1.c | 14 +- > libavcodec/ffv1.h | 35 ++- > libavcodec/ffv1_parse.c | 410 +++ > libavcodec/ffv1dec.c

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec: add a ffv1 parser

2025-02-06 Thread Michael Niedermayer
On Sun, Feb 02, 2025 at 11:16:03PM -0300, James Almer wrote: > Only setting frame and stream properties. No packetization is performed. > > Signed-off-by: James Almer > --- > configure| 1 + > libavcodec/Makefile | 1 + > libavcodec/ffv1_parser.c | 86 +

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2025-02-06 Thread Marth64
Leo: > If you do, you should consider not just -nostdin but also if reading > from stdin like a pipe, e.g. ffmpeg -i - foo.mkv > this will exit with success if foo.mkv exists without asking on stdin > (as you'd expect it to not, cause it's reading from stdin) Agreed, that sounds logical. I'll