That sounds perfectly fine with me. Thanks for the quick reply. On Thursday, February 6, 2025, Leo Izen <leo.i...@gmail.com> wrote:
> On 2/6/25 2:00 AM, dank074 wrote: > >> Currently when a Unix Domain Socket is used as input there is a loss of >> data when data is consumed from the stream. Setting is_streamed to true >> fixes this, since the unix domain socket is now treated like a consumable >> stream. >> >> Fixes: #9346 >> Signed-off-by: dank074 <torresefrai...@gmail.com> >> --- >> libavformat/unix.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/unix.c b/libavformat/unix.c >> index 5704155cf0..2de4023835 100644 >> --- a/libavformat/unix.c >> +++ b/libavformat/unix.c >> @@ -89,7 +89,7 @@ static int unix_open(URLContext *h, const char >> *filename, int flags) >> } >> s->fd = fd; >> - >> + h->is_streamed = 1; >> return 0; >> fail: >> > > The patch looks fine as-is but two style nitpicks: > > - we like to have a full blank line between the return statement and the > one before it, so you should add this line of code right after the line > s->fd = fd; but not remove the blank line that was there > - commit messages should be capped at 72 characters per line for > historical reasons, so please insert newline characters in the commit > message > > If there's no other objections I will push this patch and make both of > these changes on my end, preserving authorship before I do, if that is okay > with you. > > - Leo Izen (Traneptora) > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
