Le mer. 5 févr. 2025 à 21:03, Michael Niedermayer <mich...@niedermayer.cc> a écrit : > > On Tue, Feb 04, 2025 at 07:31:45AM -0500, Romain Beauxis wrote: > > This is the new FATE test. > > > > Test samples are available here: https://www.dropbox.com/scl/fo/fxt2edwkyj2mjc9qubku5/AICHxJyxMMAK8MIJqWLcvk4?rlkey=mlt12lsu741ejukz0p5qtn9rq&dl=0 > > > > Output prior to the changes is: > > Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, frame PTS: 0, metadata: > > Stream ID: 0, packet PTS: 4608, packet DTS: 4608 > > Stream ID: 0, frame PTS: 4608, metadata: > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, frame PTS: 0, metadata: > > Stream ID: 0, packet PTS: 4608, packet DTS: 4608 > > Stream ID: 0, frame PTS: 4608, metadata: > > > > Output after the changes: > > Stream ID: 0, codec name: flac, metadata: encoder=Lavc61.19.100 flac:title=First Stream > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, frame PTS: 0, metadata: > > Stream ID: 0, packet PTS: 4608, packet DTS: 4608 > > Stream ID: 0, frame PTS: 4608, metadata: > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, frame PTS: 0, metadata: encoder=Lavc61.19.100 flac:title=Second Stream > > Stream ID: 0, packet PTS: 4608, packet DTS: 4608 > > Stream ID: 0, frame PTS: 4608, metadata: > > > > --- > > tests/Makefile | 2 + > > tests/api/Makefile | 2 +- > > tests/api/api-dump-stream-meta-test.c | 169 ++++++++++++++++++++++++++ > > tests/fate/api.mak | 5 + > > tests/fate/ogg-flac.mak | 11 ++ > > This is missing: > ./tests/ref/fate/api-dump-stream-meta > > also make fate fails like this: > TEST api-dump-stream-meta > reference file './tests/ref/fate/api-dump-stream-meta' not found > ./tests/fate-run.sh: 705: cannot open tests/data/fate/api-dump-stream-meta.diff: No such file > Test api-dump-stream-meta failed. Look at tests/data/fate/api-dump-stream-meta.err for details. > make: *** [tests/Makefile:313: api-dump-stream-meta] Error 1 > > but the failed part cant be run > > make api-dump-stream-meta > make: *** No rule to make target 'api-dump-stream-meta'. Stop. > > also if i add a empty reference file > make fate passes > > so it seems there is some bug in this
Thanks for looking into this! It was a silly mistake: diff --git a/tests/fate/api.mak b/tests/fate/api.mak index a9872a5589..5a01a381c0 100644 --- a/tests/fate/api.mak +++ b/tests/fate/api.mak @@ -1,4 +1,4 @@ -FATE_API_LIBAVFORMAT-$(call ENCDEC, FLAC, FLAC) += api-dump-stream-meta +FATE_API_LIBAVFORMAT-$(call ENCDEC, FLAC, FLAC) += fate-api-ogg-flac-meta fate-api-ogg-flac-meta: $(APITESTSDIR)/api-dump-stream-meta-test$(EXESUF) fate-api-ogg-flac-meta: CMD = run $(APITESTSDIR)/api-flac-test$(EXESUF) fate-api-ogg-flac-meta: CMP = null Should I send an updated patch? Any other feedback before I do so? -- Romain _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
