It works good. First pass thoughts: 1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case convention and conveys clearly that the parameter is an `AVBPrint`
2- Option switch: +datetime and +time feels lighter/easier (vs. -ing) 3- Term color: the space after the time keeps the background of the time, which looks odd IMO with terminal emulator color schemes that show the background. Not sure if this is intentional. Let me know if you need a screenshot. 4- (Optional): how would you feel about RFC3339 representation? If machine parsing is a goal for this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
