Re: [FFmpeg-devel] [PATCH] doc/protocols: fix/improve RTP documentation

2025-01-17 Thread Michael Niedermayer
On Thu, Jan 16, 2025 at 09:07:56PM +0100, Stefan Pöschel via ffmpeg-devel wrote: > Sorry, I tried git send-email the first time and didn't check the > wrapping before sending. > Please find the patch attached as file. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF

Re: [FFmpeg-devel] [PATCH] avutil/avstring: dont mess with NULL pointers in av_match_list()

2025-01-17 Thread Michael Niedermayer
On Wed, Jan 15, 2025 at 04:30:47AM +0100, Michael Niedermayer wrote: > Fixes: applying zero offset to null pointer > > Signed-off-by: Michael Niedermayer > --- > libavutil/avstring.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprin

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix memory leak when using "reinit" runtime command

2025-01-17 Thread Steven Zhou
> Bump A quick way to demonstrate the memleak: ``` ./configure --enable-libfreetype --enable-libfribidi --enable-libfontconfig --enable-libharfbuzz make -j `nproc valgrind --leak-check=full ./ffmpeg -nostdin -y -f lavfi \ -i testsrc=size=640x360:rate=10 -filter_complex \ "[0:v]format=yuv420p,sen

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: Check whitelist

2025-01-17 Thread Michael Niedermayer
On Thu, Jan 16, 2025 at 04:39:49AM +0100, Michael Niedermayer wrote: > Fixes: CVE-2023-6602, V. DASH Playlist SSRF > > Found-by: Harvey Phillips of Amazon Element55 (element55) > Signed-off-by: Michael Niedermayer > --- > libavformat/dashdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 delet

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: Be more picky on extensions

2025-01-17 Thread James Almer
On 1/16/2025 12:39 AM, Michael Niedermayer wrote: This blocks disallowed extensions from probing It also requires segments to have matching extensions to the format It is recommended to set the whitelists correctly instead of depending on extensions, but this should help a bit, and this is easie

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
On Fri, 17 Jan 2025, 21:32 Romain Beauxis, wrote: > Le ven. 17 janv. 2025 à 08:32, Kieran Kunhya > a écrit : > > > > On Fri, Jan 17, 2025 at 2:24 PM Kieran Kunhya > wrote: > > > > > > On Fri, Jan 17, 2025 at 2:00 PM Romain Beauxis < > romain.beau...@gmail.com> wrote: > > > > > > > > Hi, > > > >

[FFmpeg-devel] [PATCH 2/4] avcodec/ffv1enc: dont reset version

2025-01-17 Thread Michael Niedermayer
resetting the version causes any previously set values to be disregarded Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index c6f450ae6c0..c952065e443 100644 --- a/libavcodec/ffv1enc.c +++

[FFmpeg-devel] [PATCH 3/4] avcodec/ffv1: Basic float16 support

2025-01-17 Thread Michael Niedermayer
This can be used as a reference for bitstream and compression improvements Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h| 2 ++ libavcodec/ffv1dec.c | 12 ++-- libavcodec/ffv1enc.c | 9 - 3 files changed, 20 insertions(+), 3 dele

[FFmpeg-devel] [PATCH 1/4] avcodec/ffv1: simplify version checks with combined_version

2025-01-17 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.c| 2 +- libavcodec/ffv1.h| 1 + libavcodec/ffv1dec.c | 9 ++--- libavcodec/ffv1enc.c | 2 ++ 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1.c b/libavcodec/ffv1.c

[FFmpeg-devel] [PATCH 4/4] avcodec/ffv1: NOT FOR GIT, experiment about float decorrelation

2025-01-17 Thread Michael Niedermayer
This performs a tiny bit better than not using it but it is incompatible with the RCT which gives a bigger gain Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h | 20 libavcodec/ffv1enc_template.c | 33 +++

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Frank Plowman
On 16/01/2025 19:12, Vitaly Buka via ffmpeg-devel wrote: > UBSAN by default is just prints a mesage and > moves on. This hides a few UBs in fate-suite. > > Signed-off-by: Vitaly Buka > --- > configure | 4 ++-- > libavcodec/aacenc_pred.c | 1 + > libavcodec/ffv1dec.c

Re: [FFmpeg-devel] [PATCH] avformat/avformat: also clear packet queues when closing a muxer

2025-01-17 Thread Michael Niedermayer
On Fri, Jan 17, 2025 at 12:05:41AM -0300, James Almer wrote: > FFFormatContext.packet_buffer is used in mux.c, and if a muxing process fails > at a > point where packets remained in said queue, they will leak. > > Fixes ticket #11419 > > Signed-off-by: James Almer > --- > libavformat/avformat.

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there are a bunch of unfixed reports. Maybe forcing no-recover by default will improve this situation? On Fri, Jan 17, 2025 at 11:57 AM Frank Plowman wrote: > On 16/01/2025 19:12

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread James Almer
On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there are a bunch of unfixed reports. Maybe forcing no-recover by default will improve this situation? It will not chang

[FFmpeg-devel] [PATCH] swscale/swscale: don't reject scaling when color parameters are not supported but conversion is not required

2025-01-17 Thread James Almer
Values in csp, prim, trc, etc, are irrelevant if there's no conversion needed. Signed-off-by: James Almer --- ./ffmpeg -i https://0x0.st/8Hr_.mp4 -vf "scale=1920:1080" -f null - Fails without this patch, because swscale lacks conversion for the signaled color primaries. libswscale/swscale.c |

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-17 Thread Michael Niedermayer
Hi On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote: > Sample files are available at https://archive.org/download/datstrue-read/ > > Makefile |1 > allformats.c |1 > dat.c| 159 > +++ > 3 files chang

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Romain Beauxis
Le ven. 17 janv. 2025 à 08:32, Kieran Kunhya a écrit : > > On Fri, Jan 17, 2025 at 2:24 PM Kieran Kunhya > wrote: > > > > On Fri, Jan 17, 2025 at 2:00 PM Romain Beauxis > > wrote: > > > > > > Hi, > > > > > > Le jeu. 16 janv. 2025 à 16:40, Kieran Kunhya > > > a écrit : > > > > > > > > On Thu,

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote: > On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: > > My confusion here is that it looks like ffmpeg developers care about UB, > I > > see from time to time large cleanups, but there are a bunch of unfixed > > reports. > > Maybe forcing

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread James Almer
On 1/17/2025 8:27 PM, Vitaly Buka via ffmpeg-devel wrote: On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote: On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: My confusion here is that it looks like ffmpeg developers care about UB, I see from time to time large cleanups, but there a

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: fix memory leak when using "reinit" runtime command

2025-01-17 Thread James Almer
On 11/22/2024 10:20 PM, Steven Zhou wrote: Free AVOption in drawtext private context when freeing old copy of drawtext private context during processing of "reinit" runtime command. Signed-off-by: Steven Zhou --- libavfilter/vf_drawtext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/l

[FFmpeg-devel] [PATCH v3] lavc/vvc: Stop c->pix_fmt and s->pix_fmt diverging

2025-01-17 Thread Frank Plowman
When the chroma format changes mid-sequence, c->pix_fmt and s->pix_fmt can get out-of-sync. More specifically, 1. export_frame_params is called. c->pix_fmt and s->pix_fmt are both set to their new values. 2. set_output_format is called. c->pix_fmt is set back to its old value. The two getti

Re: [FFmpeg-devel] [PATCH] avformat/avformat: also clear packet queues when closing a muxer

2025-01-17 Thread Andreas Rheinhardt
James Almer: > FFFormatContext.packet_buffer is used in mux.c, and if a muxing process fails > at a > point where packets remained in said queue, they will leak. > > Fixes ticket #11419 > > Signed-off-by: James Almer > --- > libavformat/avformat.c | 3 +-- > 1 file changed, 1 insertion(+), 2 d

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Romain Beauxis
Hi, Le jeu. 16 janv. 2025 à 16:40, Kieran Kunhya a écrit : > > On Thu, Jan 16, 2025 at 9:35 PM Romain Beauxis > wrote: > > > > Le jeu. 16 janv. 2025 à 14:48, Kieran Kunhya > > a écrit : > > > > > > On Thu, 16 Jan 2025, 20:15 Romain Beauxis, > > > wrote: > > >> > > >> This patch implements th

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Romain Beauxis
Le ven. 17 janv. 2025 à 00:40, Christophe Gisquet a écrit : > > Hello, > > Le jeu. 16 janv. 2025 à 21:15, Romain Beauxis > a écrit : > > --- a/libavformat/prompeg.c > > +++ b/libavformat/prompeg.c > > @@ -25,78 +25,16 @@ > > * @author Vlad Tarca > > */ > > [...] > > > --- /dev/null > > +++ b

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
On Fri, Jan 17, 2025 at 2:00 PM Romain Beauxis wrote: > > Hi, > > Le jeu. 16 janv. 2025 à 16:40, Kieran Kunhya > a écrit : > > > > On Thu, Jan 16, 2025 at 9:35 PM Romain Beauxis > > wrote: > > > > > > Le jeu. 16 janv. 2025 à 14:48, Kieran Kunhya > > > a écrit : > > > > > > > > On Thu, 16 Jan 2

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread James Almer
On 1/17/2025 11:24 AM, Kieran Kunhya via ffmpeg-devel wrote: On Fri, Jan 17, 2025 at 2:00 PM Romain Beauxis wrote: Hi, Le jeu. 16 janv. 2025 à 16:40, Kieran Kunhya a écrit : On Thu, Jan 16, 2025 at 9:35 PM Romain Beauxis wrote: Le jeu. 16 janv. 2025 à 14:48, Kieran Kunhya a écrit : O

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
On Fri, Jan 17, 2025 at 2:24 PM Kieran Kunhya wrote: > > On Fri, Jan 17, 2025 at 2:00 PM Romain Beauxis > wrote: > > > > Hi, > > > > Le jeu. 16 janv. 2025 à 16:40, Kieran Kunhya > > a écrit : > > > > > > On Thu, Jan 16, 2025 at 9:35 PM Romain Beauxis > > > wrote: > > > > > > > > Le jeu. 16 ja

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
> Don't assume he will not extend the implementation. Ask him instead what > he plans to do in the long term. > And this could also be marked as experimental, in which case if > abandoned or proven unstable for several real world cases, it can be > removed or disabled. "the most simple and elegant

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread James Almer
On 1/17/2025 11:42 AM, Nicolas George wrote: James Almer (12025-01-17): Don't assume he will not extend the implementation. Ask him instead what he plans to do in the long term. And this could also be marked as experimental, in which case if abandoned or proven unstable for several real world ca

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Nicolas George
James Almer (12025-01-17): > Don't assume he will not extend the implementation. Ask him instead what he > plans to do in the long term. > And this could also be marked as experimental, in which case if abandoned or > proven unstable for several real world cases, it can be removed or disabled. You

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
On Fri, Jan 17, 2025 at 2:48 PM James Almer wrote: > > On 1/17/2025 11:42 AM, Nicolas George wrote: > > James Almer (12025-01-17): > >> Don't assume he will not extend the implementation. Ask him instead what he > >> plans to do in the long term. > >> And this could also be marked as experimental,

[FFmpeg-devel] [PATCH] fate/tests/flvenc: add missing ffprobe dependency to fate-enhanced-flv-multitrack

2025-01-17 Thread James Almer
Signed-off-by: James Almer --- tests/fate/flvenc.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak index 7b656e944f..8ef6027a4d 100644 --- a/tests/fate/flvenc.mak +++ b/tests/fate/flvenc.mak @@ -13,10 +13,11 @@ FATE_ENHANCED

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Michael Niedermayer
Hi Kieran On Fri, Jan 17, 2025 at 02:44:03PM +, Kieran Kunhya via ffmpeg-devel wrote: > > Don't assume he will not extend the implementation. Ask him instead what > > he plans to do in the long term. > > And this could also be marked as experimental, in which case if > > abandoned or proven un

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Michael Niedermayer
Hi Kieran On Fri, Jan 17, 2025 at 04:05:09PM +, Kieran Kunhya via ffmpeg-devel wrote: > On Fri, Jan 17, 2025 at 2:48 PM James Almer wrote: > > > > On 1/17/2025 11:42 AM, Nicolas George wrote: > > > James Almer (12025-01-17): > > >> Don't assume he will not extend the implementation. Ask him i

Re: [FFmpeg-devel] Democratization

2025-01-17 Thread Michael Niedermayer
Hi On Tue, Jan 14, 2025 at 03:40:42PM -0300, James Almer wrote: > On 1/14/2025 2:06 PM, Michael Niedermayer wrote: > > Hi > > > > To come back to this, and iam not sure this is the best mail to reply > > to (i think there was a better one) > > but thres a glaring missconception, see below > > >

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Michael Niedermayer
Hi Kieran On Fri, Jan 17, 2025 at 02:32:05PM +, Kieran Kunhya via ffmpeg-devel wrote: > On Fri, Jan 17, 2025 at 2:24 PM Kieran Kunhya > wrote: > > > > On Fri, Jan 17, 2025 at 2:00 PM Romain Beauxis > > wrote: [...] > For an ancient protocol like FEC, nobody is going to work on it and so >

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
> A simple and clean mpeg FEC implementation will do no harm to FFmpeg, > instead it will improve FFmpegs capabilities. For the reasons I have described this is not possible. It's similar to the way the kernel hides all the idiosyncrasies of real world TCP. Kieran

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Devin Heitmueller
Hello all, I've got some experience in this particular area, so figured it might be helpful to offer another voice. Kieran makes a number of excellent points, and I largely agree with his discussion of the problem space. It's an intrinsically difficult problem. The data arrives on multiple sock

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Kieran Kunhya via ffmpeg-devel
> > FEC requires tons of heuristics to work in the real world. > > Besides your word, is there some evidence ? > > (and the question is not that YOUR implementation needs > "tons of heuristics to work in the real world." or the reference > does but that EVERY implementation does) > > You seem to

[FFmpeg-devel] [PATCH] libavcodec/hdrdec: accept "#?RGBE" header in addition to "#?RADIANCE"

2025-01-17 Thread Kirill Gavrilov
Some Radiance HDR image files in the wild have "#?RGBE" header, which other image readers accept. Signed-off-by: Kirill Gavrilov --- libavcodec/hdrdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hdrdec.c b/libavcodec/hdrdec.c index b7ade48e32..6e62e19dcd 100

Re: [FFmpeg-devel] [PATCH] avutil/vulkan_glslang: windows build improvements

2025-01-17 Thread Benjamin Cheng via ffmpeg-devel
On 2025-01-15 7:38 p.m., Koushik Dutta wrote: For my use case I ended up creating a custom pkgconfig file. My platform and compiler is windows and msvc. I was unable to get the existing configure to work correctly with this environment and opted for pkgconfig as the hook for my environment. Is t

Re: [FFmpeg-devel] Democratization

2025-01-17 Thread James Almer
On 1/17/2025 2:39 PM, Michael Niedermayer wrote: Hi On Tue, Jan 14, 2025 at 03:40:42PM -0300, James Almer wrote: On 1/14/2025 2:06 PM, Michael Niedermayer wrote: Hi To come back to this, and iam not sure this is the best mail to reply to (i think there was a better one) but thres a glaring mi

[FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-17 Thread Jerome Martinez
Sample files are available at https://archive.org/download/datstrue-read/ From 50c78a0ae2049e2dbd65e2c3d28f3d8abea1adfa Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 12 Sep 2024 20:34:22 +0200 Subject: [PATCH] avformat: add DAT demuxer --- libavformat/Makefile | 1 + libavformat