Le ven. 17 janv. 2025 à 00:40, Christophe Gisquet <christophe.gisq...@gmail.com> a écrit : > > Hello, > > Le jeu. 16 janv. 2025 à 21:15, Romain Beauxis > <romain.beau...@gmail.com> a écrit : > > --- a/libavformat/prompeg.c > > +++ b/libavformat/prompeg.c > > @@ -25,78 +25,16 @@ > > * @author Vlad Tarca <vlad.ta...@gmail.com> > > */ > > [...] > > > --- /dev/null > > +++ b/libavformat/prompeg_utils.c > > @@ -0,0 +1,226 @@ > > +/* > > + * Pro-MPEG Code of Practice #3 Release 2 FEC > > + * Copyright (c) 2025 Radio France (https://radiofrance.fr) > > If I'm not mistaken, you are copying around code here: > * Is it ok to remove the previous copyrights? > * Is it ok to add another copyright?
Thanks, that's a good point. Generally speaking, I have tried to keep the copyright from the original files and added a new one on the new files only. This file is the only one that contains both old and new code. I have done it to put all the bitwise operations together for easier proof-reading and also to make it possible to write unit tests on them, which I have written when working on the implementation but not submitted as this does not appear to be a common pattern in this code-base. I will consult about what's best to do or would love to hear from people here. I'm sure that this is a common situation in open-source projects. I imagine the best is probably to add the two copyright in files that contain some of the original code and some new code. Otherwise, I believe in the French and US legal system, which are the two that I am more familiar with, you have to consider whether the modified work is changed enough to be considered a derivative work. -- Romain _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
