Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Tom Butterworth
Hey Martin > +ctx->tex_fun = ctx->dxtc.rgtc1u_block; > +avctx->pix_fmt = AV_PIX_FMT_RGB0; The rgtc1u_block function places the single channel value in every channel except the alpha channel The pixel format you have chosen is one which disregards the alpha channel The output of

[FFmpeg-devel] cross compile on Ubuntu for Arm with --enable-omx meet "ERROR: OpenMAX IL headers not found"

2017-09-27 Thread chang jc
Dear all: I meet the problem "ERROR: OpenMAX IL headers not found" when I cross compile ffmpeg for Arm on Ubuntu with --enable-omx. How could I resolve this problem? I guess there should be something missed. Thanks in advance! ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-27 Thread Mateusz
W dniu 2017-09-26 o 13:31, Carl Eugen Hoyos pisze: > 2017-09-26 1:33 GMT+02:00 Mateusz : > >> I've sent C code patch 2017-09-06 (and nothing) so I thought that the >> problem is with speed. For simplicity I've attached this patch. > > You could (wait a day or two and) either add an option to > se

Re: [FFmpeg-devel] libavcodec/hapenc : add support for hap alpha only encoding

2017-09-27 Thread Tom Butterworth
Yo > Patch 1 : 0004-libavcodec-texturedspenc-add-rgtc1u-encoding > +/** > + * Compress one block of RGBA pixels in a RGTC1U texture and store the > + * resulting bytes in 'dst'. Alpha is preserved. > + * > + * @param dstoutput buffer. > + * @param stride scanline in bytes. > + * @param block

Re: [FFmpeg-devel] ffmpeg have program decoding ACC ltam audo stream

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 6:41 GMT+02:00 : > Seems ffmpeg had problem decoding the audio stream - ACC ltam 5.1 > > Appreciate your advise Please post your question on the user mailing list and provide a sample input file. See also http://ffmpeg.org/contact.html#MailingLists Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-27 Thread Hendrik Leppkes
On Wed, Sep 27, 2017 at 12:04 PM, Mateusz wrote: > > OK, so this fight with possible overflow is even more needed. > Luckily x86 SIMD has saturating instructions which don't overflow, so if we device a way to properly optimize this in yasm/nasm assembly, then this should be pretty simple to do.

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Martin Vignali
> > > +ctx->tex_fun = ctx->dxtc.rgtc1u_block; > > +avctx->pix_fmt = AV_PIX_FMT_RGB0; > > The rgtc1u_block function places the single channel value in every channel > except the alpha channel > The pixel format you have chosen is one which disregards the alpha channel > > The output

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Tom Butterworth
> On 27 Sep 2017, at 11:59, Martin Vignali wrote: > >> >>> +ctx->tex_fun = ctx->dxtc.rgtc1u_block; >>> +avctx->pix_fmt = AV_PIX_FMT_RGB0; >> >> The rgtc1u_block function places the single channel value in every channel >> except the alpha channel >> The pixel format you have c

[FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread Josh de Kock
Support for this device has been removed in kernel since v2.6.37. dv1394 has been superseded by libiec61883 which is functionally equivalent. Signed-off-by: Josh de Kock --- configure| 3 - doc/indevs.texi | 25 libavdevice/Makefile | 1 - libavdevice/allde

Re: [FFmpeg-devel] [PATCH v4] fate: add tests for psnr and ssim filter

2017-09-27 Thread Tobias Rapp
On 26.09.2017 09:54, Tobias Rapp wrote: On 20.09.2017 11:01, Tobias Rapp wrote: Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64). Signed-off-by: Tobi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread wm4
On Tue, 26 Sep 2017 19:49:34 -0700 Aman Gupta wrote: > On Tue, Sep 26, 2017 at 7:20 PM, James Almer wrote: > > > On 9/26/2017 10:08 PM, Aman Gupta wrote: > > > From: Aman Gupta > > > > > > --- > > > configure| 2 + > > > libavcodec/allcodecs.c | 1 + > > > liba

Re: [FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 13:09:02 +0100 Josh de Kock wrote: > Support for this device has been removed in kernel since v2.6.37. dv1394 > has been superseded by libiec61883 which is functionally equivalent. > > Signed-off-by: Josh de Kock > --- The API has been removed 7 years ago from the kernel. L

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread wm4
On Tue, 26 Sep 2017 18:08:10 -0700 Aman Gupta wrote: > From: Aman Gupta > > --- > configure| 2 + > libavcodec/allcodecs.c | 1 + > libavcodec/hevc_refs.c | 3 + > libavcodec/hevcdec.c | 12 ++- > libavcodec/vda_vt_internal.h | 1 + > libavcodec

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread wm4
On Tue, 26 Sep 2017 18:08:10 -0700 Aman Gupta wrote: > From: Aman Gupta > > --- > configure| 2 + > libavcodec/allcodecs.c | 1 + > libavcodec/hevc_refs.c | 3 + > libavcodec/hevcdec.c | 12 ++- > libavcodec/vda_vt_internal.h | 1 + > libavcodec

Re: [FFmpeg-devel] [PATCH v4] fate: add tests for psnr and ssim filter

2017-09-27 Thread Paul B Mahol
On 9/27/17, Tobias Rapp wrote: > On 26.09.2017 09:54, Tobias Rapp wrote: >> On 20.09.2017 11:01, Tobias Rapp wrote: >>> Metadata filter output is passed through an Awk script comparing floats >>> against reference values with specified "fuzz" tolerance to account for >>> architectural differences

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: fix draining process (dequeue without input)

2017-09-27 Thread wm4
On Tue, 26 Sep 2017 16:22:23 -0700 Jorge Ramirez-Ortiz wrote: > Stopping the codec when no more input is available causes captured > buffers that might be ready to be dequeued to be invalidated. > > This commit follows the V4L2 API more closely: > 1. on the last valid input buffer, it sets the V

[FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
Hi, There is no point of having these output devices as all the functionality is contained in the 'ffplay' tool. If people wanted to integrate these devices in their own programs instead of using the ffmpeg tool then they are far too constrained for proper control, not to mention output devices ha

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Martin Vignali
2017-09-27 13:25 GMT+02:00 Tom Butterworth : > > > > On 27 Sep 2017, at 11:59, Martin Vignali > wrote: > > > >> > >>> +ctx->tex_fun = ctx->dxtc.rgtc1u_block; > >>> +avctx->pix_fmt = AV_PIX_FMT_RGB0; > >> > >> The rgtc1u_block function places the single channel value in every > cha

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 14:18:13 +0100 Josh de Kock wrote: > Hi, > > There is no point of having these output devices as all the > functionality is contained in the 'ffplay' tool. If people wanted to > integrate these devices in their own programs instead of using the > ffmpeg tool then they are far

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Paul B Mahol
On 9/27/17, Josh de Kock wrote: > Hi, > > There is no point of having these output devices as all the > functionality is contained in the 'ffplay' tool. If people wanted to > integrate these devices in their own programs instead of using the > ffmpeg tool then they are far too constrained for prop

[FFmpeg-devel] [PATCH v5 1/2] avfilter/f_metadata: avoid trailing whitespace in filter output

2017-09-27 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- libavfilter/f_metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c index 23bc254..523a94d 100644 --- a/libavfilter/f_metadata.c +++ b/libavfilter/f_metadata.c @@ -314,14 +314,14 @@ sta

[FFmpeg-devel] [PATCH v5 2/2] fate: add tests for psnr and ssim filter

2017-09-27 Thread Tobias Rapp
Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64). Signed-off-by: Tobias Rapp --- tested on Linux x86-32/64 and Mips (Qemu) v5: - fixed trailing whit

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Nicolas George
Le sextidi 6 vendémiaire, an CCXXVI, Josh de Kock a écrit : > There is no point of having these output devices as all the > functionality is contained in the 'ffplay' tool. ffplay is not a library. > If people wanted to > integrate these devices in

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Tom Butterworth
> On 27 Sep 2017, at 14:20, Martin Vignali wrote: > > 2017-09-27 13:25 GMT+02:00 Tom Butterworth >: > >> >> >>> On 27 Sep 2017, at 11:59, Martin Vignali >> wrote: >>> > +ctx->tex_fun = ctx->dxtc.rgtc1u_block; > +avctx->pix_fmt = AV

Re: [FFmpeg-devel] [PATCH v5 1/2] avfilter/f_metadata: avoid trailing whitespace in filter output

2017-09-27 Thread Paul B Mahol
On 9/27/17, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > libavfilter/f_metadata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Martin Vignali
2017-09-27 15:33 GMT+02:00 Tom Butterworth : > > > > On 27 Sep 2017, at 14:20, Martin Vignali > wrote: > > > > 2017-09-27 13:25 GMT+02:00 Tom Butterworth bangno...@gmail.com>>: > > > >> > >> > >>> On 27 Sep 2017, at 11:59, Martin Vignali > >> wrote: > >>> > > > +ctx->tex_fun =

Re: [FFmpeg-devel] [PATCH v5 1/2] avfilter/f_metadata: avoid trailing whitespace in filter output

2017-09-27 Thread Tobias Rapp
On 27.09.2017 15:50, Paul B Mahol wrote: On 9/27/17, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- libavfilter/f_metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) lgtm Pushed both patches. Thanks, Tobias ___ ffmpeg-de

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Michael Niedermayer
On Wed, Sep 27, 2017 at 02:18:13PM +0100, Josh de Kock wrote: > Hi, > > There is no point of having these output devices as all the > functionality is contained in the 'ffplay' tool. If people wanted to > integrate these devices in their own programs instead of using the > ffmpeg tool then they ar

[FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Anonymous Maarten
Hey, Building the static ffmpeg library using vcpkg is currently broken [1][2]. This is mainly due to the fact that the built static libraries are .a files with lib prefixes. The attached patch sets the lib prefix to "" and the lib suffix to ".lib". Tested by building ffmpeg using vcpkg and Visu

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 16:34:49 +0200 Michael Niedermayer wrote: > On Wed, Sep 27, 2017 at 02:18:13PM +0100, Josh de Kock wrote: > > Hi, > > > > There is no point of having these output devices as all the > > functionality is contained in the 'ffplay' tool. If people wanted to > > integrate these d

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 16:43 GMT+02:00 Anonymous Maarten : > Building the static ffmpeg library using vcpkg is currently broken [1][2]. > This is mainly due to the fact that the built static libraries are .a files > with lib prefixes. Did this work with older versions of any of the involved tools (including

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 15:18 GMT+02:00 Josh de Kock : > There is no point of having these output devices as all the > functionality is contained in the 'ffplay' tool. I use at least sdl and opengl regularly for tests that cannot be done with ffplay. Carl Eugen ___

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread James Almer
On 9/27/2017 12:01 PM, wm4 wrote: > On Wed, 27 Sep 2017 16:34:49 +0200 > Michael Niedermayer wrote: > >> On Wed, Sep 27, 2017 at 02:18:13PM +0100, Josh de Kock wrote: >>> Hi, >>> >>> There is no point of having these output devices as all the >>> functionality is contained in the 'ffplay' tool. I

[FFmpeg-devel] [PATCH]fate: Add a test for latm-in-dvb autodetection

2017-09-27 Thread Carl Eugen Hoyos
Hi! Attached patch adds a test for ticket #6657. Please comment, Carl Eugen From bef8e7beff7a674180404aa70424f08c6a86a9cd Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Sep 2017 17:05:14 +0200 Subject: [PATCH] fate: Add a test for latm-in-dvb auto-detection, ticket #6657. --- t

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 17:08:06 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 15:18 GMT+02:00 Josh de Kock : > > > There is no point of having these output devices as all the > > functionality is contained in the 'ffplay' tool. > > I use at least sdl and opengl regularly for tests that cannot > be

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 17:15 GMT+02:00 wm4 : > On Wed, 27 Sep 2017 17:08:06 +0200 > Carl Eugen Hoyos wrote: > >> 2017-09-27 15:18 GMT+02:00 Josh de Kock : >> >> > There is no point of having these output devices as all the >> > functionality is contained in the 'ffplay' tool. >> >> I use at least sdl and open

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
On 27/09/2017 16:17, Carl Eugen Hoyos wrote: > 2017-09-27 17:15 GMT+02:00 wm4 : >> On Wed, 27 Sep 2017 17:08:06 +0200 >> Carl Eugen Hoyos wrote: >> >>> 2017-09-27 15:18 GMT+02:00 Josh de Kock : >>> There is no point of having these output devices as all the functionality is contained in

Re: [FFmpeg-devel] [PATCH v5 2/2] fate: add tests for psnr and ssim filter

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 15:30 GMT+02:00 Tobias Rapp : > Metadata filter output is passed through an Awk script comparing floats Is awk needed on the host or the target system? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Michael Niedermayer
On Wed, Sep 27, 2017 at 05:01:59PM +0200, wm4 wrote: > On Wed, 27 Sep 2017 16:34:49 +0200 > Michael Niedermayer wrote: > > > On Wed, Sep 27, 2017 at 02:18:13PM +0100, Josh de Kock wrote: > > > Hi, > > > > > > There is no point of having these output devices as all the > > > functionality is cont

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 17:17:37 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 17:15 GMT+02:00 wm4 : > > On Wed, 27 Sep 2017 17:08:06 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-09-27 15:18 GMT+02:00 Josh de Kock : > >> > >> > There is no point of having these output devices as all the > >> > f

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 17:21 GMT+02:00 Josh de Kock : > On 27/09/2017 16:17, Carl Eugen Hoyos wrote: >> 2017-09-27 17:15 GMT+02:00 wm4 : >>> On Wed, 27 Sep 2017 17:08:06 +0200 >>> Carl Eugen Hoyos wrote: >>> 2017-09-27 15:18 GMT+02:00 Josh de Kock : > There is no point of having these output dev

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Josh de Kock
On 27/09/2017 16:28, Carl Eugen Hoyos wrote: > 2017-09-27 17:21 GMT+02:00 Josh de Kock : >> On 27/09/2017 16:17, Carl Eugen Hoyos wrote: >>> 2017-09-27 17:15 GMT+02:00 wm4 : On Wed, 27 Sep 2017 17:08:06 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 15:18 GMT+02:00 Josh de Kock : >>

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Hendrik Leppkes
On Wed, Sep 27, 2017 at 4:43 PM, Anonymous Maarten wrote: > Hey, > > Building the static ffmpeg library using vcpkg is currently broken [1][2]. > This is mainly due to the fact that the built static libraries are .a files > with lib prefixes. > > The attached patch sets the lib prefix to "" and th

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 16:31:37 +0100 Josh de Kock wrote: > On 27/09/2017 16:28, Carl Eugen Hoyos wrote: > > 2017-09-27 17:21 GMT+02:00 Josh de Kock : > >> On 27/09/2017 16:17, Carl Eugen Hoyos wrote: > >>> 2017-09-27 17:15 GMT+02:00 wm4 : > On Wed, 27 Sep 2017 17:08:06 +0200 > Carl

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 15:20 GMT+02:00 Martin Vignali : > 2017-09-27 13:25 GMT+02:00 Tom Butterworth : > >> >> >> > On 27 Sep 2017, at 11:59, Martin Vignali >> wrote: >> > >> >> >> >>> +ctx->tex_fun = ctx->dxtc.rgtc1u_block; >> >>> +avctx->pix_fmt = AV_PIX_FMT_RGB0; >> >> >> >> The rgtc1u_bloc

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: fix draining process (dequeue without input)

2017-09-27 Thread Jorge Ramirez-Ortiz
On 09/27/2017 06:01 AM, wm4 wrote: On Tue, 26 Sep 2017 16:22:23 -0700 Jorge Ramirez-Ortiz wrote: Stopping the codec when no more input is available causes captured buffers that might be ready to be dequeued to be invalidated. This commit follows the V4L2 API more closely: 1. on the last valid

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: extract SPS fields required for hvcC construction

2017-09-27 Thread Michael Niedermayer
On Tue, Sep 26, 2017 at 06:08:09PM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/hevc_ps.c | 3 ++- > libavcodec/hevc_ps.h | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB F

[FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
Hi! The existing amr demuxer does not allow reading streams, it requires the 3GPP-conforming file header. Attached patch allows reading amrnb and amrwb from (live) streams, fixes ticket #6678. Please comment, Carl Eugen From 1b548fbd47f521d0c2a7b443ac2b1f2925e8bb41 Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] lavd: remove deprecated dv1394 device

2017-09-27 Thread Josh de Kock
On 27/09/2017 13:33, wm4 wrote: > On Wed, 27 Sep 2017 13:09:02 +0100 > Josh de Kock wrote: > >> Support for this device has been removed in kernel since v2.6.37. dv1394 >> has been superseded by libiec61883 which is functionally equivalent. >> >> Signed-off-by: Josh de Kock >> --- > > The API h

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread Aman Gupta
On Wed, Sep 27, 2017 at 5:51 AM, wm4 wrote: > On Tue, 26 Sep 2017 18:08:10 -0700 > Aman Gupta wrote: > > > From: Aman Gupta > > > > --- > > configure| 2 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/hevc_refs.c | 3 + > > libavcodec/hevcdec.c

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: fix draining process (dequeue without input)

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 09:03:58 -0700 Jorge Ramirez-Ortiz wrote: > On 09/27/2017 06:01 AM, wm4 wrote: > > On Tue, 26 Sep 2017 16:22:23 -0700 > > Jorge Ramirez-Ortiz wrote: > > > >> Stopping the codec when no more input is available causes captured > >> buffers that might be ready to be dequeued t

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 09:17:36 -0700 Aman Gupta wrote: > On Wed, Sep 27, 2017 at 5:51 AM, wm4 wrote: > > > On Tue, 26 Sep 2017 18:08:10 -0700 > > Aman Gupta wrote: > > > > > From: Aman Gupta > > > > > > --- > > > configure| 2 + > > > libavcodec/allcodecs.c | 1

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 18:08:19 +0200 Carl Eugen Hoyos wrote: > Hi! > > The existing amr demuxer does not allow reading streams, it requires > the 3GPP-conforming file header. > Attached patch allows reading amrnb and amrwb from (live) streams, > fixes ticket #6678. > > Please comment, Carl Eugen

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/h264, videotoolbox: return AVERROR_INVALIDDATA when no frames are produced

2017-09-27 Thread Michael Niedermayer
On Mon, Sep 25, 2017 at 05:36:28PM -0700, Aman Gupta wrote: > From: Aman Gupta > > The only reason videotoolbox wouldn't produce frames is if the data fed > to it was invalid, so returning AVERROR_INVALIDDATA makes sense here. > > Further, it means AVERROR_EXTERNAL can be used in further commits

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 18:40 GMT+02:00 wm4 : > On Wed, 27 Sep 2017 18:08:19 +0200 > Carl Eugen Hoyos wrote: > >> Hi! >> >> The existing amr demuxer does not allow reading streams, it requires >> the 3GPP-conforming file header. >> Attached patch allows reading amrnb and amrwb from (live) streams, >> fixes tic

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread James Almer
On 9/27/2017 1:37 PM, wm4 wrote: > On Wed, 27 Sep 2017 09:17:36 -0700 > Aman Gupta wrote: > >> On Wed, Sep 27, 2017 at 5:51 AM, wm4 wrote: >> >>> On Tue, 26 Sep 2017 18:08:10 -0700 >>> Aman Gupta wrote: >>> From: Aman Gupta --- configure| 2 +

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: add hevc support

2017-09-27 Thread Hendrik Leppkes
On Wed, Sep 27, 2017 at 6:37 PM, wm4 wrote: > On Wed, 27 Sep 2017 09:17:36 -0700 > Aman Gupta wrote: > >> On Wed, Sep 27, 2017 at 5:51 AM, wm4 wrote: >> >> > On Tue, 26 Sep 2017 18:08:10 -0700 >> > Aman Gupta wrote: >> > >> > > From: Aman Gupta >> > > >> > > --- >> > > configure

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 18:47:16 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 18:40 GMT+02:00 wm4 : > > On Wed, 27 Sep 2017 18:08:19 +0200 > > Carl Eugen Hoyos wrote: > > > >> Hi! > >> > >> The existing amr demuxer does not allow reading streams, it requires > >> the 3GPP-conforming file header. > >

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 18:58 GMT+02:00 wm4 : > It may be better for you not committing anything if you don't know what > commit messages are. I assume this is how you interpret our code-of-conduct to which you agreed? Watch your tongue, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 19:00:04 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 18:58 GMT+02:00 wm4 : > > > It may be better for you not committing anything if you don't know what > > commit messages are. > > I assume this is how you interpret our code-of-conduct > to which you agreed? > > Watch you

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: fix draining process (dequeue without input)

2017-09-27 Thread Jorge Ramirez-Ortiz
On 09/27/2017 09:31 AM, wm4 wrote: On Wed, 27 Sep 2017 09:03:58 -0700 Jorge Ramirez-Ortiz wrote: On 09/27/2017 06:01 AM, wm4 wrote: On Tue, 26 Sep 2017 16:22:23 -0700 Jorge Ramirez-Ortiz wrote: Stopping the codec when no more input is available causes captured buffers that might be ready

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 19:02 GMT+02:00 wm4 : > On Wed, 27 Sep 2017 19:00:04 +0200 > Carl Eugen Hoyos wrote: > >> 2017-09-27 18:58 GMT+02:00 wm4 : >> >> > It may be better for you not committing anything if you don't know what >> > commit messages are. >> >> I assume this is how you interpret our code-of-condu

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 19:04:26 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 19:02 GMT+02:00 wm4 : > > On Wed, 27 Sep 2017 19:00:04 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-09-27 18:58 GMT+02:00 wm4 : > >> > >> > It may be better for you not committing anything if you don't know what > >>

Re: [FFmpeg-devel] Deprecation of visual output devices

2017-09-27 Thread Nicolas George
Le sextidi 6 vendémiaire, an CCXXVI, Josh de Kock a écrit : > I see no reason to bring parity to ffplay then. Nobody asked you to do that. Why do you want to remove these devices in the first place? Regards, -- Nicolas George ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 19:08 GMT+02:00 wm4 : > Maybe you could get back to the technical discussion I wish this were so easy with you: You first wrote: > That seems particularly pointless, since the user has > to force the demuxers. If I understand this sentence correctly, you agree with me that it should

[FFmpeg-devel] [PATCHv2] avcodec/v4l2_m2m: fix draining process (dequeue without input)

2017-09-27 Thread Jorge Ramirez-Ortiz
Stopping the codec when no more input is available causes captured buffers that might be ready to be invalidated. This commit follows the V4L2 API more closely: 1. when ffmpeg indicates EOS (NULL frame or packet size), the v4l2_m2m codec will send a dummy buffer to the driver with the V4L2_BUF

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 19:22:37 +0200 Carl Eugen Hoyos wrote: > 2017-09-27 19:08 GMT+02:00 wm4 : > > Maybe you could get back to the technical discussion > > I wish this were so easy with you: Well, it certainly isn't with you. ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Ronald S. Bultje
Hi guys, On Wed, Sep 27, 2017 at 1:32 PM, wm4 wrote: > On Wed, 27 Sep 2017 19:22:37 +0200 > Carl Eugen Hoyos wrote: > > > 2017-09-27 19:08 GMT+02:00 wm4 : > > > Maybe you could get back to the technical discussion > > > > I wish this were so easy with you: > > Well, it certainly isn't with you

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 19:46 GMT+02:00 Ronald S. Bultje : > @Carl Eugen: I've read the bug report. Thank you; sorry that imo, this cannot help in this case;-( The relevant issue is that live streams or truncated amr files cannot be handled by the existing demuxer although they work if the properties are forc

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 20:09 GMT+02:00 Carl Eugen Hoyos : > 2017-09-27 19:46 GMT+02:00 Ronald S. Bultje : >> It's intruiging that the existing demuxer (as you mentioned, >> it expects a prefix) works with unicast but not >> multicast input. > > I don't think this is correct (as in: "This is impossible") but >

[FFmpeg-devel] [RFC]lavc/fdk-aacenc: Print an error if (e)ld was requested without signaling

2017-09-27 Thread Carl Eugen Hoyos
Hi! No opinion here, this was reported twice on trac this week, I don't know if there was really more than one user affected. Please comment, Carl Eugen From 256d46d2479b19103fab3f79f34f6ae597ae402c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Sep 2017 20:15:13 +0200 Subject: [P

[FFmpeg-devel] [PATCH 1/2] configure: disable libxcb dependent features if libxcb is not enabled

2017-09-27 Thread James Almer
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index a4baeb3b2a..1676215146 100755 --- a/configure +++ b/configure @@ -6186,7 +6186,7 @@ if enabled libcdio; then die "ERROR: No usable libcdio/cdparanoia found" fi -enabled libxcb && c

[FFmpeg-devel] [PATCH 2/2] configure: simplify checks for libxcb dependent features

2017-09-27 Thread James Almer
--- configure | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 1676215146..5b3e2ecdbf 100755 --- a/configure +++ b/configure @@ -6189,13 +6189,9 @@ fi enabled libxcb && check_pkg_config "xcb >= 1.4" xcb/xcb.h xcb_connect || disable libxcb

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-09-27 Thread Ronald S. Bultje
Hi, On Wed, Sep 27, 2017 at 2:10 PM, Carl Eugen Hoyos wrote: > 2017-09-27 20:09 GMT+02:00 Carl Eugen Hoyos : > > 2017-09-27 19:46 GMT+02:00 Ronald S. Bultje : > > >> It's intruiging that the existing demuxer (as you mentioned, > >> it expects a prefix) works with unicast but not > >> multicast i

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Anonymous Maarten
>>* Hey, ** Building the static ffmpeg library using vcpkg is currently broken [1][2]. *>>* This is mainly due to the fact that the built static libraries are .a files *>>* with lib prefixes. ** The attached patch sets the lib prefix to "" and the lib suffix to ".lib". ** Tested by buil

Re: [FFmpeg-devel] [PATCH] avcodec/mips: preload data in hevc sao edge 45 degree filter msa functions

2017-09-27 Thread Michael Niedermayer
On Tue, Sep 26, 2017 at 07:43:48AM +, Manojkumar Bhosale wrote: > LGTM applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Removed generic function call in avc intra msa functions

2017-09-27 Thread Michael Niedermayer
On Tue, Sep 26, 2017 at 07:48:51AM +, Manojkumar Bhosale wrote: > LGTM applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstand

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc weighted mc msa functions

2017-09-27 Thread Michael Niedermayer
On Tue, Sep 26, 2017 at 08:49:15AM +, Manojkumar Bhosale wrote: > LGTM applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to bec

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc chroma vert mc msa functions

2017-09-27 Thread Michael Niedermayer
On Tue, Sep 26, 2017 at 08:49:24AM +, Manojkumar Bhosale wrote: > LGTM applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates signature.asc Description: Dig

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve avc put mc 20, 01 and 03 msa functions

2017-09-27 Thread Michael Niedermayer
On Tue, Sep 26, 2017 at 11:56:20AM +, Manojkumar Bhosale wrote: > LGTM applied thx [..] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurit

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Mateusz
W dniu 2017-09-27 o 17:40, Hendrik Leppkes pisze: > On Wed, Sep 27, 2017 at 4:43 PM, Anonymous Maarten > wrote: >> Hey, >> >> Building the static ffmpeg library using vcpkg is currently broken [1][2]. >> This is mainly due to the fact that the built static libraries are .a files >> with lib prefix

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Hendrik Leppkes
On Wed, Sep 27, 2017 at 10:11 PM, Mateusz wrote: > W dniu 2017-09-27 o 17:40, Hendrik Leppkes pisze: >> On Wed, Sep 27, 2017 at 4:43 PM, Anonymous Maarten >> wrote: >>> Hey, >>> >>> Building the static ffmpeg library using vcpkg is currently broken [1][2]. >>> This is mainly due to the fact that

Re: [FFmpeg-devel] [RFC]lavc/fdk-aacenc: Print an error if (e)ld was requested without signaling

2017-09-27 Thread Hendrik Leppkes
On Wed, Sep 27, 2017 at 8:18 PM, Carl Eugen Hoyos wrote: > Hi! > > No opinion here, this was reported twice on trac this week, I don't > know if there was really more than one user affected. "Signaling" as a single word isn't very descriptive, and should probably be expanded. Additionally, if it

Re: [FFmpeg-devel] [RFC]lavc/fdk-aacenc: Print an error if (e)ld was requested without signaling

2017-09-27 Thread Carl Eugen Hoyos
2017-09-27 22:30 GMT+02:00 Hendrik Leppkes : > On Wed, Sep 27, 2017 at 8:18 PM, Carl Eugen Hoyos wrote: >> No opinion here, this was reported twice on trac this week, I don't >> know if there was really more than one user affected. > > "Signaling" as a single word isn't very descriptive, and shou

Re: [FFmpeg-devel] [RFC]lavc/fdk-aacenc: Print an error if (e)ld was requested without signaling

2017-09-27 Thread Hendrik Leppkes
On Wed, Sep 27, 2017 at 10:39 PM, Carl Eugen Hoyos wrote: > 2017-09-27 22:30 GMT+02:00 Hendrik Leppkes : >> On Wed, Sep 27, 2017 at 8:18 PM, Carl Eugen Hoyos wrote: > >>> No opinion here, this was reported twice on trac this week, I don't >>> know if there was really more than one user affected.

Re: [FFmpeg-devel] Create .lib static libraries on Windows instead of .a libraries (using MSVC compiler)

2017-09-27 Thread Anonymous Maarten
The current situation is inconsistent. It creates .lib/.dlls files for dynamic libraries and .a files for static libraries. This complicates e.g. detecting ffmpeg using cmake needlessly. Changing this behavior would be a net gain. I would also be happy if there would be a (configure) switch to man

[FFmpeg-devel] [PATCH] prores: Always assume limited range

2017-09-27 Thread Vittorio Giovara
As defined by the spcifications --- libavcodec/proresdec_lgpl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/proresdec_lgpl.c b/libavcodec/proresdec_lgpl.c index bc5bdb5a4d..c86d433f50 100644 --- a/libavcodec/proresdec_lgpl.c +++ b/libavcodec/proresdec_lgpl.c @@ -177,6 +177,7 @@

Re: [FFmpeg-devel] [PATCH] prores: Always assume limited range

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 17:28:12 -0400 Vittorio Giovara wrote: > As defined by the spcifications > --- > libavcodec/proresdec_lgpl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/proresdec_lgpl.c b/libavcodec/proresdec_lgpl.c > index bc5bdb5a4d..c86d433f50 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: fix profile search when disable exact profile match.

2017-09-27 Thread Mark Thompson
On 21/09/17 08:22, Jun Zhao wrote: > From d7dc5c00692302e810412dea44ae3d2f122fb9a4 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Thu, 21 Sep 2017 02:44:42 -0400 > Subject: [PATCH 2/2] lavc/vaapi_decode: fix profile search when disable exact > profile match. > > When disable exact profile mat

Re: [FFmpeg-devel] [PATCH] [PATCH v7] Add support for RockChip Media Process Platform

2017-09-27 Thread Mark Thompson
On 24/09/17 06:39, LongChair . wrote: > From: Lionel CHAZALLON > > This adds hardware decoding for h264 / HEVC / VP8 using MPP Rockchip API. > Will return frames holding an AVDRMFrameDescriptor struct in buf[0] that > allows drm / dmabuf usage. > Was tested on RK3288 (TinkerBoard) and RK3328. >

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-09-27 Thread Marton Balint
On Wed, 27 Sep 2017, Jeyapal, Karthick wrote: Sorry for the late reply, the last was busy week. Here are some more comments: Thanks for your comments. Please find the updated patch attached with your comments incorporated. Sorry, still not quite there... Here are some further comments: F

[FFmpeg-devel] [PATCH v2 1/2] avcodec/videotoolbox: use AV_WB16 where possible

2017-09-27 Thread Aman Gupta
From: Aman Gupta additional changes to hevc patchset, as suggested on-list if these look fine, I will squash into previous patchset and push it to master. --- libavcodec/videotoolbox.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/libavcodec/vi

[FFmpeg-devel] [PATCH v2 2/2] avcodec/videotoolbox: fix hevc hwaccel build on older macOS

2017-09-27 Thread Aman Gupta
From: Aman Gupta --- configure | 5 - libavcodec/videotoolbox.c | 4 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/configure b/configure index d353e9d824..aae23bf38f 100755 --- a/configure +++ b/configure @@ -2073,6 +2073,7 @@ TOOLCHAIN_FEATURES=" TYPE

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/videotoolbox: use AV_WB16 where possible

2017-09-27 Thread James Almer
On 9/27/2017 7:19 PM, Aman Gupta wrote: > From: Aman Gupta > > additional changes to hevc patchset, as suggested on-list > > if these look fine, I will squash into previous patchset and push it to > master. > --- > libavcodec/videotoolbox.c | 27 +-- > 1 file changed, 9

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/videotoolbox: fix hevc hwaccel build on older macOS

2017-09-27 Thread James Almer
On 9/27/2017 7:19 PM, Aman Gupta wrote: > From: Aman Gupta > > --- > configure | 5 - > libavcodec/videotoolbox.c | 4 > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index d353e9d824..aae23bf38f 100755 > --- a/configure > +++

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/videotoolbox: fix hevc hwaccel build on older macOS

2017-09-27 Thread Aman Gupta
On Wed, Sep 27, 2017 at 3:52 PM, James Almer wrote: > On 9/27/2017 7:19 PM, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > configure | 5 - > > libavcodec/videotoolbox.c | 4 > > 2 files changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/co

Re: [FFmpeg-devel] [PATCH] prores: Always assume limited range

2017-09-27 Thread Kieran O Leary
On Wed, Sep 27, 2017 at 10:28 PM, Vittorio Giovara wrote: > As defined by the spcifications Is this the paywalled SMPTE spec? I don't see any mention of it in the openly available whitepaper, https://images.apple.com/final-cut-pro/docs/Apple_ProRes_White_Paper.pdf

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/videotoolbox: fix hevc hwaccel build on older macOS

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 19:52:13 -0300 James Almer wrote: > > +#if !HAVE_KCMVIDEOCODECTYPE_HEVC > > +enum { kCMVideoCodecType_HEVC = 'hvc1' }; > > +#endif > > The correct thing to do is adding kCMVideoCodecType_HEVC to > hevc_videotoolbox_hwaccel_deps in configure, and not forcing it on SDKs > tha

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/videotoolbox: use AV_WB16 where possible

2017-09-27 Thread wm4
On Wed, 27 Sep 2017 19:45:23 -0300 James Almer wrote: > On 9/27/2017 7:19 PM, Aman Gupta wrote: > > From: Aman Gupta > > > > additional changes to hevc patchset, as suggested on-list > > > > if these look fine, I will squash into previous patchset and push it to > > master. > > --- > > libavc

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/videotoolbox: fix hevc hwaccel build on older macOS

2017-09-27 Thread James Almer
On 9/27/2017 8:11 PM, wm4 wrote: > On Wed, 27 Sep 2017 19:52:13 -0300 > James Almer wrote: > >>> +#if !HAVE_KCMVIDEOCODECTYPE_HEVC >>> +enum { kCMVideoCodecType_HEVC = 'hvc1' }; >>> +#endif >> >> The correct thing to do is adding kCMVideoCodecType_HEVC to >> hevc_videotoolbox_hwaccel_deps in co

  1   2   >