Re: [FFmpeg-devel] have some major changes for nvenc support

2016-01-08 Thread Roger Pack
On 11/5/15, wm4 wrote: > On Thu, 5 Nov 2015 16:23:04 +0800 > Agatha Hu wrote: > >> 2) We use AVFrame::opaque field to store a customized ffnvinfo struture >> to prevent expensive CPU<->GPU transferration. Without it, the workflow >> will be like CPU AVFrame input-->copy to GPU-->do CUDA resizing-

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread wm4
On Fri, 8 Jan 2016 17:55:38 +1100 Jean-Yves Avenard wrote: > One of the issues we've faced was with our reftest tests , with pages > creating hundreds of small video elements (the test change > orientation, sizes, transparency and the like and check that there's > no regression on how things are

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > On Fri, 8 Jan 2016 17:55:38 +1100 > Jean-Yves Avenard gmail.com> wrote: > > > One of the issues we've faced was with our reftest > > tests, with pages creating hundreds of small video > > elements (the test change orientation, sizes, > > transparency and the lik

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread wm4
On Fri, 8 Jan 2016 09:42:52 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > On Fri, 8 Jan 2016 17:55:38 +1100 > > Jean-Yves Avenard gmail.com> wrote: > > > > > One of the issues we've faced was with our reftest > > > tests, with pages creating hundreds of small vide

[FFmpeg-devel] [PATCH]lavc/libvpxenc: Improve documentation for cpu-used

2016-01-08 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #5140 here, seems to match: https://github.com/webmproject/libvpx/commit/a16f07537501ac96531577d5af004ad0b591a705 Please comment, Carl Eugen diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 9cf32bf..3740bdd 100644 --- a/libavcodec/libvpxenc.c +++

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-08 Thread wm4
On Thu, 7 Jan 2016 16:01:14 -0800 Ganesh Ajjanagadde wrote: > On Thu, Jan 7, 2016 at 3:57 PM, Ganesh Ajjanagadde wrote: > > On Thu, Jan 7, 2016 at 2:18 PM, Michael Niedermayer > > wrote: > >> On Thu, Jan 07, 2016 at 11:16:27PM +0100, Michael Niedermayer wrote: > >>> On Thu, Jan 07, 2016 at

Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

2016-01-08 Thread Anshul Maheshwari
On Thu, Jan 7, 2016 at 6:10 AM, Aman Gupta wrote: > > Aman Gupta wrote: > > > --- a/libavcodec/ccaption_dec.c > > > +++ b/libavcodec/ccaption_dec.c > > > @@ -150,6 +150,7 @@ struct Screen { > > > > > > typedef struct CCaptionSubContext { > > > AVClass *class; > > > +int calculate_durat

Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

2016-01-08 Thread Anshul Maheshwari
On Fri, Jan 8, 2016 at 3:51 PM, Anshul Maheshwari wrote: > > > On Thu, Jan 7, 2016 at 6:10 AM, Aman Gupta wrote: > > > Aman Gupta wrote: >> > > --- a/libavcodec/ccaption_dec.c >> > > +++ b/libavcodec/ccaption_dec.c >> > > @@ -150,6 +150,7 @@ struct Screen { >> > > >> > > typedef struct CCaptio

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Andrey Turkin
2016-01-08 12:42 GMT+03:00 Carl Eugen Hoyos : > > I may have misunderstood myself but I believe the > issue actually only happens on Windows XP;-) > > I've encountered this issue a while back when trying to do about 20 simultaneous transcodings with some video filters. It was on a high-end CPU wit

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

2016-01-08 Thread Anshul Maheshwari
On Thu, Jan 7, 2016 at 6:14 AM, Aman Gupta wrote: > Probably should have written a longer commit message here. The EOC command > stands for "end of caption" aka "display buffer". It's used with POPON > mode, where characters are written to an off-screen buffer and EOC flips > the buffers to displ

Re: [FFmpeg-devel] [PATCH v5] lavf/matroskadec: A_QUICKTIME and AV_CODEC_ID_NONE

2016-01-08 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 04:32:25AM +0100, Mats Peterson wrote: > In many older QuickTime files, the audio format, or "fourcc", is > 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification > states the following regarding this situation: > > "This format descriptor should not be used

Re: [FFmpeg-devel] [PATCH] x86/vf_w3fdif: 32-bit compatibility for w3fdif_simple_high

2016-01-08 Thread Hendrik Leppkes
On Thu, Jan 7, 2016 at 2:13 PM, Hendrik Leppkes wrote: > --- > libavfilter/x86/vf_w3fdif.asm| 35 +-- > libavfilter/x86/vf_w3fdif_init.c | 2 +- > 2 files changed, 34 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/x86/vf_w3fdif.asm b/libavfilter/x8

Re: [FFmpeg-devel] [PATCH v5] lavf/matroskadec: A_QUICKTIME and AV_CODEC_ID_NONE

2016-01-08 Thread Mats Peterson
On 01/08/2016 11:58 AM, Michael Niedermayer wrote: where can i find a file to test this and the mov patch ? also codec_id will be AV_CODEC_ID_NONE for any new fourcc that is not supported not just fourcc == 0 does it work to check fourcc or the place that fourcc is stored i addition or instead o

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Michael Niedermayer
On Fri, Jan 08, 2016 at 01:35:02PM +0300, Andrey Turkin wrote: > 2016-01-08 12:42 GMT+03:00 Carl Eugen Hoyos : > > > > > I may have misunderstood myself but I believe the > > issue actually only happens on Windows XP;-) > > > > > I've encountered this issue a while back when trying to do about 20

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

2016-01-08 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 05:20:55PM -0800, Ganesh Ajjanagadde wrote: > On Thu, Jan 7, 2016 at 4:48 PM, Michael Niedermayer > wrote: > > On Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde wrote: > >> This exploits an approach based on the sieve of Eratosthenes, a popular > >> method for ge

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-08 Thread Anshul
On 6 January 2016 1:55:27 am IST, "Clément Bœsch" wrote: >On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: >[...] >> This indeed LGTM, but I'm not the maintainer. >> > >OK I finally understood why it's done that way: validate_cc_data_pair() >alters the pkt data, but the decoder is

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-08 Thread Clément Bœsch
On Fri, Jan 08, 2016 at 05:24:15PM +0530, Anshul wrote: > > > On 6 January 2016 1:55:27 am IST, "Clément Bœsch" wrote: > >On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: > >[...] > >> This indeed LGTM, but I'm not the maintainer. > >> > > > >OK I finally understood why it's done

Re: [FFmpeg-devel] have some major changes for nvenc support

2016-01-08 Thread Andrey Turkin
In my opinion this proliferation of various filters which do the same thing in different way is a configuration headache. There's CPU filters: one for scaling/format conversion, one for padding, one for cropping, like 5 different filters for deinterlacing. And now there would be nvresize for scali

[FFmpeg-devel] [PATCH v6] lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

2016-01-08 Thread Mats Peterson
In many older QuickTime files, the audio format, or "fourcc", is 0x. The QuickTime File Format Specification states the following regarding this situation: "This format descriptor should not be used, but may be found in some files. Samples are assumed to be stored in either 'raw ' or 'two

[FFmpeg-devel] [PATCH v3] lavf/mov: Audio and fourcc 0x00000000

2016-01-08 Thread Mats Peterson
In many older QuickTime files, the audio format, or "fourcc", is 0x. The QuickTime File Format Specification states the following regarding this situation: "This format descriptor should not be used, but may be found in some files. Samples are assumed to be stored in either 'raw ' or 'two

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 20:28, wm4 wrote: > Do I understand right that only your tests do this? And that there are > no real world sites which do this? And that you want us to change our > architecture so that your tests actually run? I thought I had explained the problem in rather plain words easy

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 20:42, Carl Eugen Hoyos wrote: > I may have misunderstood myself but I believe the > issue actually only happens on Windows XP;-) > > Carl Eugen Well the issue is mostly important on 32 bits system, particularly on windows where a user process can only use up to 2GB of RAM.

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 20:51, wm4 wrote: > Anyway, as another point I would argue: > - discouraging web devs from creating too many video elements, and > introducing a static "reasonable" limit (maybe a dozen elements) You're kidding right? So what, you just don't display the video because really

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 21:35, Andrey Turkin wrote: > example. I ended up disabling MT everywhere I can to fix that (which was a > right thing to do anyway since my program was already multithreaded and it > could use all the cores anyway). This thread-pool idea sounds reasonable to > me; more reason

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread wm4
On Fri, 8 Jan 2016 23:15:11 +1100 Jean-Yves Avenard wrote: > On 8 January 2016 at 20:28, wm4 wrote: > > Do I understand right that only your tests do this? And that there are > > no real world sites which do this? And that you want us to change our > > architecture so that your tests actually ru

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-08 Thread Anshul
On 8 January 2016 5:27:37 pm IST, "Clément Bœsch" wrote: >On Fri, Jan 08, 2016 at 05:24:15PM +0530, Anshul wrote: >> >> >> On 6 January 2016 1:55:27 am IST, "Clément Bœsch" wrote: >> >On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: >> >[...] >> >> This indeed LGTM, but I'm not

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread wm4
On Fri, 8 Jan 2016 23:20:40 +1100 Jean-Yves Avenard wrote: > On 8 January 2016 at 20:51, wm4 wrote: > > Anyway, as another point I would argue: > > - discouraging web devs from creating too many video elements, and > > introducing a static "reasonable" limit (maybe a dozen elements) > > You

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 23:24, wm4 wrote: > > A global thread pool sounds like an extremely messy and unclean > solution. The state of a library is not supposed to affect anything > else in the same process. The point of my message was to start a discussion, not to receive immediate answer ridiculin

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 23:27, wm4 wrote: > Then don't create 30 threads. This was just a silly example... There are time when you do want to use multiple threads, because someone is playing a single high-def video and a single thread wouldn't cut it. The conditions could change dynamically too: Sa

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread wm4
On Fri, 8 Jan 2016 23:28:20 +1100 Jean-Yves Avenard wrote: > On 8 January 2016 at 23:24, wm4 wrote: > > > > A global thread pool sounds like an extremely messy and unclean > > solution. The state of a library is not supposed to affect anything > > else in the same process. > > The point of my

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Kieran Kunhya
On 8 January 2016 at 12:43, wm4 wrote: > On Fri, 8 Jan 2016 23:28:20 +1100 > Jean-Yves Avenard wrote: > >> On 8 January 2016 at 23:24, wm4 wrote: >> > >> > A global thread pool sounds like an extremely messy and unclean >> > solution. The state of a library is not supposed to affect anything >>

Re: [FFmpeg-devel] [PATCH v6] lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

2016-01-08 Thread Michael Niedermayer
On Fri, Jan 08, 2016 at 01:03:05PM +0100, Mats Peterson wrote: > In many older QuickTime files, the audio format, or "fourcc", is > 0x. The QuickTime File Format Specification states the following > regarding this situation: > > "This format descriptor should not be used, but may be found

Re: [FFmpeg-devel] [PATCH v3] lavf/mov: Audio and fourcc 0x00000000

2016-01-08 Thread Michael Niedermayer
On Fri, Jan 08, 2016 at 01:03:58PM +0100, Mats Peterson wrote: > In many older QuickTime files, the audio format, or "fourcc", is > 0x. The QuickTime File Format Specification states the following > regarding this situation: > > "This format descriptor should not be used, but may be found

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 8 January 2016 at 23:43, wm4 wrote: > Sorry, the problem you're trying to solve is just too ridiculous. Welcome to the world wide web ! :) > Threads might be the heaviest resource here, but no matter what you do, > having hundreds of objects active at the same time (bring back geocity > websi

Re: [FFmpeg-devel] [PATCH] -cmdline_from_file new paramter

2016-01-08 Thread Nicolas George
Le septidi 17 nivôse, an CCXXIV, Procontrol Robert Kovacs a écrit : > --- > cmdutils.c | 186 > +++ > doc/fftools-common-opts.texi | 41 ++ > 2 files changed, 227 insertions(+) I do not think that FFmpeg needs another shell-like

Re: [FFmpeg-devel] [PATCH 1/2] lavf/concatdec: do not access packet if av_read_frame returned error

2016-01-08 Thread Nicolas George
Le decadi 10 nivôse, an CCXXIV, Marton Balint a écrit : > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > LGTM, thanks, and sorry to have forgotten. Regards, -- Nicolas George signature.asc Description: Dig

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Derek Buitenhuis
On 1/8/2016 6:55 AM, Jean-Yves Avenard wrote: > We originally had configured AVCodecContext::thread_count to 0, which > on the machines running the tests would end up creating 8 threads per > decoder. > On windows 32 bits, that would amount in thousand of threads being > created for that particular

Re: [FFmpeg-devel] [PATCH 2/2] lavf/concatdec: add outpoint_interleave_delay option

2016-01-08 Thread Nicolas George
Le decadi 10 nivôse, an CCXXIV, Marton Balint a écrit : > Wait at most outpoint_interleave_delay at outpoint before considering it an > end of file condition. > > Signed-off-by: Marton Balint > --- > doc/demuxers.texi | 20 > libavformat/concatdec.c | 13 ++---

Re: [FFmpeg-devel] [PATCH v6] lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

2016-01-08 Thread Mats Peterson
On 01/08/2016 02:12 PM, Michael Niedermayer wrote: On Fri, Jan 08, 2016 at 01:03:05PM +0100, Mats Peterson wrote: In many older QuickTime files, the audio format, or "fourcc", is 0x. The QuickTime File Format Specification states the following regarding this situation: "This format desc

Re: [FFmpeg-devel] [PATCH v3] lavf/mov: Audio and fourcc 0x00000000

2016-01-08 Thread Mats Peterson
On 01/08/2016 02:24 PM, Michael Niedermayer wrote: applied simplified a bit thanks I missed the fact that sc->format is available to the function. I'll make another patch that removes the redundant stuff that I added. Mats ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH v3] lavf/mov: Audio and fourcc 0x00000000

2016-01-08 Thread Mats Peterson
On 01/08/2016 02:56 PM, Mats Peterson wrote: I missed the fact that sc->format is available to the function. I'll make another patch that removes the redundant stuff that I added. Ah sorry, it was already removed. Thanks for the edit, Michael. Mats -- Mats Peterson http://matsp888.no-ip.org/~

Re: [FFmpeg-devel] [PATCH v6] lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

2016-01-08 Thread Moritz Barsnick
On Fri, Jan 08, 2016 at 14:51:53 +0100, Mats Peterson wrote: > I can't see the applied patches at GitHub yet. Is a delay normal? Sorry > for a stupid question. Yes, that is normal. videolan.org hosts the "original". There was an explanation in this thread: http://lists.ffmpeg.org/pipermail/ffmpe

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 9 January 2016 at 00:39, Derek Buitenhuis wrote: > This seems to be a rather contentious subject. Would you be amenable to > perhaps joining #ffmpeg-devel to discuss in real time? In my experience, > stuff gets cleared up a lot faster, and with few misunderstandings / large > mailing list flame

Re: [FFmpeg-devel] [PATCH v6] lavf/matroskadec: A_QUICKTIME and fourcc 0x00000000

2016-01-08 Thread Mats Peterson
On 01/08/2016 03:07 PM, Moritz Barsnick wrote: On Fri, Jan 08, 2016 at 14:51:53 +0100, Mats Peterson wrote: I can't see the applied patches at GitHub yet. Is a delay normal? Sorry for a stupid question. Yes, that is normal. videolan.org hosts the "original". There was an explanation in this t

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread compn
On Fri, 8 Jan 2016 10:51:39 +0100 wm4 wrote: > On Fri, 8 Jan 2016 09:42:52 + (UTC) > Carl Eugen Hoyos wrote: > > > wm4 googlemail.com> writes: > > > > > On Fri, 8 Jan 2016 17:55:38 +1100 > > > Jean-Yves Avenard gmail.com> wrote: > > > > > > > One of the issues we've faced was with our

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-08 Thread foo86
On Thu, Jan 07, 2016 at 08:17:59PM +0100, Andreas Cadhalpun wrote: > On 03.01.2016 18:49, foo86 wrote: > > +for (i = 0; i < spkr_remap_nsets; i++) { > > +// Number of channels to be decoded for speaker remapping > > +int nch_for_remaps = get_bits(&s->gb,

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Derek Buitenhuis
On 1/8/2016 2:19 PM, Jean-Yves Avenard wrote: > I will come on Monday if that's okay... could setup a time that works > for you. I'm based in Melbourne Australia Most of the channel is usually around during daytime GMT/CET hours. - Derek ___ ffmpeg-deve

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-08 Thread foo86
On Thu, Jan 07, 2016 at 03:32:50PM +0100, Christophe Gisquet wrote: > One commit implements "sum/diff decoding", introducing sumdiff_X > functions, with X fixed or float. > > I think those are the corresponding butterflies_X functions in the > AV(Float|Fixed)DSPContext structures. But I haven't ve

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread James Almer
On 1/8/2016 11:22 AM, compn wrote: > does this also happen with webp ? e.g. if all images are vp8 webp and if > you used libavcodec to decode them? Firefox doesn't (yet) support webp. There's a very old bugzilla ticket about it. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Eli Kara
Web applications are fast becoming more and more complex, it's no surprise. I do mainly sever side work but a bit client side. The amount of data in a web page's DOM can be huge. Many applications use videos in several places, this isn't a theoretical problem. And with people having 30 tabs open

[FFmpeg-devel] [PATCH 1/3] x86/float_dsp: remove len check from ff_butterflies_float_sse

2016-01-08 Thread James Almer
The function documentation explicitly mentions it needs to be a multiple of 4. Signed-off-by: James Almer --- libavutil/x86/float_dsp.asm | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm index 87229d4..6ac2aa8 100644 --- a/libavutil/

[FFmpeg-devel] [PATCH 2/3] x86/float_dsp: zero extend len from ff_butterflies_float_sse implicitly

2016-01-08 Thread James Almer
Signed-off-by: James Almer --- libavutil/x86/float_dsp.asm | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm index 6ac2aa8..743e1c1 100644 --- a/libavutil/x86/float_dsp.asm +++ b/libavutil/x86/float_dsp.asm @@ -359,10

[FFmpeg-devel] [PATCH 3/3] x86/float_dsp: zero extend offset from ff_scalarproduct_float_sse

2016-01-08 Thread James Almer
Signed-off-by: James Almer --- libavutil/x86/float_dsp.asm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm index 743e1c1..021ff03 100644 --- a/libavutil/x86/float_dsp.asm +++ b/libavutil/x86/float_dsp.asm @@ -332,

[FFmpeg-devel] [PATCH] lavf/matroskadec: Normalize noncompliant, A_QUICKTIME/V_QUICKTIME private data

2016-01-08 Thread Mats Peterson
This patch adds a new static function get_qt_priv_data() that takes care of the initial retrieval of the fourcc and codec ID for A_QUICKTIME and V_QUICKTIME. It also normalizes noncompliant private data found in some older files that incorrectly starts with the fourcc by expanding/shifting the

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-08 Thread Ganesh Ajjanagadde
On Jan 8, 2016 1:59 AM, "wm4" wrote: > > On Thu, 7 Jan 2016 16:01:14 -0800 > Ganesh Ajjanagadde wrote: > > > On Thu, Jan 7, 2016 at 3:57 PM, Ganesh Ajjanagadde wrote: > > > On Thu, Jan 7, 2016 at 2:18 PM, Michael Niedermayer > > > wrote: > > >> On Thu, Jan 07, 2016 at 11:16:27PM +0100, Michael

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread Ricardo Constantino
Ping? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Jean-Yves Avenard
On 9 January 2016 at 01:22, compn wrote: > i think mozilla should share one test page with the hundred elements so > that we can see first hand the destruction. here is a simple one: http://people.mozilla.org/~cpearce/stress/ For our test page: http://hg.mozilla.org/mozilla-central/raw-file/tip

Re: [FFmpeg-devel] Discussion related to the use of a global thread pool rather than the current threading model

2016-01-08 Thread Michael Niedermayer
On Sat, Jan 09, 2016 at 03:10:48AM +1100, Jean-Yves Avenard wrote: > On 9 January 2016 at 01:22, compn wrote: > > > i think mozilla should share one test page with the hundred elements so > > that we can see first hand the destruction. > > here is a simple one: > http://people.mozilla.org/~cpear

[FFmpeg-devel] [PATCH v2] lavf/matroskadec: Normalize noncompliant A_QUICKTIME/V_QUICKTIME private data

2016-01-08 Thread Mats Peterson
Changed the name of get_qt_priv_data() to the more appropriate get_qt_codec(). Description follows: This patch adds a new static function get_qt_codec() that takes care of the initial retrieval of the fourcc and codec ID for A_QUICKTIME and V_QUICKTIME. It also normalizes noncompliant private d

Re: [FFmpeg-devel] [PATCH 1/3] x86/float_dsp: remove len check from ff_butterflies_float_sse

2016-01-08 Thread Christophe Gisquet
Hi, 2016-01-08 16:22 GMT+01:00 James Almer : > -test lenq, lenq > -jz .end > shl lenq, 2 > add src0q, lenq > add src1q, lenq > @@ -377,5 +375,4 @@ cglobal butterflies_float, 3,3,3, src0, src1, len > mova[src0q + lenq], m0 > add le

Re: [FFmpeg-devel] [PATCH 2/3] x86/float_dsp: zero extend len from ff_butterflies_float_sse implicitly

2016-01-08 Thread Christophe Gisquet
Hi, 2016-01-08 16:22 GMT+01:00 James Almer : > INIT_XMM sse > cglobal butterflies_float, 3,3,3, src0, src1, len > -%if ARCH_X86_64 > -movsxdlenq, lend > -%endif > -shl lenq, 2 > +shl lend, 2 All the more ok since, afaik, only WIN64 actually requires that. -- Christ

Re: [FFmpeg-devel] [PATCH 3/3] x86/float_dsp: zero extend offset from ff_scalarproduct_float_sse

2016-01-08 Thread Christophe Gisquet
Hi, 2016-01-08 16:22 GMT+01:00 James Almer : > +shl offsetd, 2 > +add v1q, offsetq > +add v2q, offsetq > neg offsetq > -shl offsetq, 2 > -sub v1q, offsetq > -sub v2q, offsetq Lucky that we never had any crash then. OK. -- Christophe __

[FFmpeg-devel] [PATCH v3] lavf/matroskadec: Normalize noncompliant A_QUICKTIME/V_QUICKTIME private data

2016-01-08 Thread Mats Peterson
Incorrectly used ff_codec_movvideo_tags instead of codec_tags. Description follows: This patch adds a new static function get_qt_codec() that takes care of the initial retrieval of the fourcc and codec ID for A_QUICKTIME and V_QUICKTIME. It also normalizes noncompliant private data found in som

Re: [FFmpeg-devel] have some major changes for nvenc support

2016-01-08 Thread Michael Niedermayer
On Fri, Jan 08, 2016 at 03:04:26PM +0300, Andrey Turkin wrote: > In my opinion this proliferation of various filters which do the same thing > in different way is a configuration headache. There's CPU filters: one for > scaling/format conversion, one for padding, one for cropping, like 5 > differe

Re: [FFmpeg-devel] [PATCH 1/3] x86/float_dsp: remove len check from ff_butterflies_float_sse

2016-01-08 Thread Christophe Gisquet
2016-01-08 17:41 GMT+01:00 Christophe Gisquet : > On a side note, do you intend to do an avx version? Just did that, need a tail processing, and no gain on a(n) Haswell over a 7 minute sample. The code for reference, over your set of patches. -- Christophe 0001-x86-float_dsp-avx-version-of-bu

Re: [FFmpeg-devel] [PATCH 1/3] x86/float_dsp: remove len check from ff_butterflies_float_sse

2016-01-08 Thread James Almer
On 1/8/2016 3:56 PM, Christophe Gisquet wrote: > 2016-01-08 17:41 GMT+01:00 Christophe Gisquet : >> > On a side note, do you intend to do an avx version? > Just did that, need a tail processing, and no gain on a(n) Haswell > over a 7 minute sample. Then honestly i don't think it's worth it. Maybe

Re: [FFmpeg-devel] [PATCH]lavc/libvpxenc: Improve documentation for cpu-used

2016-01-08 Thread James Zern
On Fri, Jan 8, 2016 at 1:58 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #5140 here, seems to match: > https://github.com/webmproject/libvpx/commit/a16f07537501ac96531577d5af004ad0b591a705 > > Please comment, Carl Eugen > lgtm. thanks.

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread Michael Niedermayer
On Tue, Dec 29, 2015 at 10:47:05PM +, Ricardo Constantino wrote: > Signed-off-by: Ricardo Constantino > --- > configure | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He

Re: [FFmpeg-devel] [PATCH 1/3] x86/float_dsp: remove len check from ff_butterflies_float_sse

2016-01-08 Thread Christophe Gisquet
Hi, 2016-01-08 20:16 GMT+01:00 James Almer : > Then honestly i don't think it's worth it. Maybe if we could change the > alignment to 32 bytes and making len multiple of 8 or 16, but not sure > how feasible is that. There could be a more specialized version, but of doubtful use (maybe dca2?) The

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

2016-01-08 Thread Aman Gupta
On Fri, Jan 8, 2016 at 2:50 AM, Anshul Maheshwari wrote: > > > On Thu, Jan 7, 2016 at 6:14 AM, Aman Gupta wrote: > >> Probably should have written a longer commit message here. The EOC >> command stands for "end of caption" aka "display buffer". It's used with >> POPON mode, where characters are

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread James Almer
On 12/29/2015 7:47 PM, Ricardo Constantino wrote: > Signed-off-by: Ricardo Constantino > --- > configure | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index c986aba..d639b8d 100755 > --- a/configure > +++ b/configure > @@ -5396,7 +5

[FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

2016-01-08 Thread Rodger Combs
--- ffprobe.c | 1 + libavformat/avformat.h | 12 +--- tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- tests/ref/fate/concat-demuxer-simple1-lav

[FFmpeg-devel] [PATCH 2/3] lavf/mov: improve `tref/chap` chapter handling

2016-01-08 Thread Rodger Combs
3 parts: - Supports multiple chapter streams - Exports regular text chapter streams as opaque data. This prevents consumers from showing chapters as if they were regular subtitle streams. - Exports video chapter streams as thumbnails, and provides the first one as an attached_pic. --- libavfor

[FFmpeg-devel] [PATCH 3/3] lavf/mov: reindent

2016-01-08 Thread Rodger Combs
--- libavformat/mov.c | 156 +++--- 1 file changed, 78 insertions(+), 78 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 4040cf7..42a232f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4428,94 +4428,94 @@ static voi

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread Ricardo Constantino
On 8 January 2016 at 20:40, James Almer wrote: > Shouldn't this also check libgcrypt-config --cflags? Assuming > the library is in an unusual path, the above will look for > the header in whatever include path configure was using by > then and either fail or include the wrong headers. The issue

Re: [FFmpeg-devel] have some major changes for nvenc support

2016-01-08 Thread Andrey Turkin
2016-01-08 20:25 GMT+03:00 Michael Niedermayer : > Also slightly orthogonal but if you have 4 filters each written for a > different hwaccel you can write a generic filter that passes its > stuff to the appropriate one > If theres not much shareale code between hw specific filters then this > migh

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread James Almer
On 1/8/2016 6:39 PM, Ricardo Constantino wrote: > On 8 January 2016 at 20:40, James Almer wrote: > >> Shouldn't this also check libgcrypt-config --cflags? Assuming >> the library is in an unusual path, the above will look for >> the header in whatever include path configure was using by >> then a

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread Ricardo Constantino
Like this? 0001-configure-Use-libgcrypt-config-s-cflags.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread James Almer
On 1/8/2016 8:41 PM, Ricardo Constantino wrote: > Like this? Yes, pushed. Thank you. > > > 0001-configure-Use-libgcrypt-config-s-cflags.patch > > > From f4e0c96e41da606a5d83ebff1dbad718c8fa2485 Mon Sep 17 00:00:00 2001 > From: Ricardo Constantino > Date: Fri, 8 Jan 2016 23:40:50 + > Subj

Re: [FFmpeg-devel] [PATCH] configure: Use libgcrypt-config if available

2016-01-08 Thread Michael Niedermayer
On Fri, Jan 08, 2016 at 09:02:34PM -0300, James Almer wrote: > On 1/8/2016 8:41 PM, Ricardo Constantino wrote: > > Like this? > > Yes, pushed. Thank you. thanks as well [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualitie

Re: [FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

2016-01-08 Thread Marton Balint
On Fri, 8 Jan 2016, Rodger Combs wrote: [...] diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 95a645b..eaf6270 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -824,11 +824,17 @@ typedef struct AVIndexEntry { #define AV_DISPOSITION_CLEAN_EFFECTS 0x0200

Re: [FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

2016-01-08 Thread Rodger Combs
> On Jan 8, 2016, at 18:30, Marton Balint wrote: > > On Fri, 8 Jan 2016, Rodger Combs wrote: > > [...] >> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >> index 95a645b..eaf6270 100644 >> --- a/libavformat/avformat.h >> +++ b/libavformat/avformat.h >> @@ -824,11 +824,17 @@ typede

[FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-08 Thread Sasi Inguva
Pass through color range to vp9 encoder. Parse color range in libvpxdec.c. Signed-off-by: Sasi Inguva --- libavcodec/libvpxdec.c | 6 ++ libavcodec/libvpxenc.c | 26 ++ 2 files changed, 32 insertions(+) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c in

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

2016-01-08 Thread Sasi Inguva
Sorry for the delay on this. Was waiting for https://chromium-review.googlesource.com/#/c/320116/ to be submitted. Sent the new patch with decoder changes. On Mon, Jan 4, 2016 at 12:26 PM, James Almer wrote: > On 1/4/2016 5:01 PM, Sasi Inguva wrote: > > Would it be a lot easier and correct if I