Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Steven Liu
Stephen Hutchinson 于2025年2月14日 周五05:44写道: > On 2/13/25 8:32 AM, Timo Rothenpieler wrote: > > If anyone wants to be allowed to fork, just let me know with an account > > name and I'll up the limit. > > Yes, in my case. Account name: qyot27 Yes too. account name:lq Thanks Steven > > > __

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tanay Manerikar
On Fri, Feb 14, 2025 at 7:44 AM Timo Rothenpieler wrote: > On 13.02.2025 22:44, Stephen Hutchinson wrote: > > On 2/13/25 8:32 AM, Timo Rothenpieler wrote: > >> If anyone wants to be allowed to fork, just let me know with an > >> account name and I'll up the limit. > > > > Yes, in my case. Accoun

Re: [FFmpeg-devel] [PATCH] avformat/mov: (v4) fix get_eia608_packet

2025-02-13 Thread Andreas Rheinhardt
Pavel Koshevoy: > The problem is reproducible with "Test for Quicktime 608 CC file.mov" > from https://samples.ffmpeg.org/MPEG2/subcc/ > > ffmpeg -i "Test for Quicktime 608 CC file.mov" -map 0 -c copy -y remuxed.mov > > Prior to the fix QuickTime Player playback of remuxed.mov would > render garb

[FFmpeg-devel] [PATCH] libavdevice/avfoundation.m: Fix potential format selection error in configure_video_device

2025-02-13 Thread infiniteice-at-foxmail . com
From: Hong Changbin The loop continues even if the correct format is selected, which may result in the selected_range is not in selected_format, finally failed to configure video device. --- libavdevice/avfoundation.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/avfoundat

[FFmpeg-devel] [PATCH v2 2/2] avformat/demux: don't discard empty Theora packets

2025-02-13 Thread James Almer
Theora signals "Output last frame again" with an empty packet. Finishes fixing ticket #11451. Signed-off-by: James Almer --- libavformat/demux.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index d8ab29431e..0e39346f62 1

[FFmpeg-devel] [PATCH] avformat/mov: further ensure mov_build_index isn't run twice

2025-02-13 Thread James Almer
If sc->tts_count is not 0, then the sample index has already been built. Fixes: Null-dereference READ Fixes: 396192874/clusterfuzz-testcase-minimized-audio_decoder_fuzzer-4589309789143040 Signed-off-by: James Almer --- Supersedes "avformat/mov: ensure no trun atoms are parsed as children of tra

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Timo Rothenpieler
On 13.02.2025 22:44, Stephen Hutchinson wrote: On 2/13/25 8:32 AM, Timo Rothenpieler wrote: If anyone wants to be allowed to fork, just let me know with an account name and I'll up the limit. Yes, in my case.  Account name: qyot27 Limit raised to 25 repos. ___

Re: [FFmpeg-devel] [PATCH v4 3/6] Pass secondary ogg/opus chained streams metadata.

2025-02-13 Thread Lynne
On 14/02/2025 00:27, Romain Beauxis wrote: Le jeu. 13 févr. 2025 à 15:53, Lynne a écrit : On 10/02/2025 20:25, Romain Beauxis wrote: These changes parse ogg/opus comment in secondary chained ogg/opus streams and attach them as extradata to the corresponding packet. They can then be decoded

Re: [FFmpeg-devel] [PATCH v4 3/6] Pass secondary ogg/opus chained streams metadata.

2025-02-13 Thread Romain Beauxis
Le jeu. 13 févr. 2025 à 15:53, Lynne a écrit : > > On 10/02/2025 20:25, Romain Beauxis wrote: > > These changes parse ogg/opus comment in secondary chained ogg/opus > > streams and attach them as extradata to the corresponding packet. > > > > They can then be decoded in the opus decoder and attach

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Pavel Koshevoy
On Thu, Feb 13, 2025 at 1:12 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > On Thu, Feb 13, 2025 at 3:00 PM Pavel Koshevoy > wrote: > > yes, that patch is better in that it doesn't over-allocate. > > I don't care much which fix gets merged, so long as the problem is fixed. > > O

[FFmpeg-devel] [PATCH 2/2] avformat/demux: don't discard empty Theora packets

2025-02-13 Thread James Almer
Theora signals "Output last frame again" with an empty packet. Finishes fixing ticket #11451. Signed-off-by: James Almer --- libavformat/demux.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index d8ab29431e..407e448252

[FFmpeg-devel] [PATCH 1/2] avformat/oggenc: don't discard empty packets with no side data

2025-02-13 Thread James Almer
Theora signals "Output last frame again" with an empty packet. To keep the behaviour of 18f24527eb of ignoring side data only packets, as generated by the FLAC encoder to propagate updated extradata, also check for pkt->side_data_size to choose wheter to mux the paket or not. Fixes part of ticket

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Pavel Koshevoy
On Thu, Feb 13, 2025 at 3:04 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > On Thu, Feb 13, 2025 at 4:06 PM Pavel Koshevoy > wrote: > > I've submitted a 3rd version of the patch that doesn't do as much > > over-allocation, similar to > > https://lists.ffmpeg.org/pipermail/ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Devin Heitmueller
On Thu, Feb 13, 2025 at 4:06 PM Pavel Koshevoy wrote: > I've submitted a 3rd version of the patch that doesn't do as much > over-allocation, similar to > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310456.html > My v3 patch works correctly with the 2 sample files I can test with. Yo

Re: [FFmpeg-devel] [PATCH v4 3/6] Pass secondary ogg/opus chained streams metadata.

2025-02-13 Thread Lynne
On 10/02/2025 20:25, Romain Beauxis wrote: These changes parse ogg/opus comment in secondary chained ogg/opus streams and attach them as extradata to the corresponding packet. They can then be decoded in the opus decoder and attached to the next decoded frame. libavformat/oggparseopus.c: Parse

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Stephen Hutchinson
On 2/13/25 8:32 AM, Timo Rothenpieler wrote: If anyone wants to be allowed to fork, just let me know with an account name and I'll up the limit. Yes, in my case. Account name: qyot27 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-13 Thread Tomas Härdin
tor 2025-02-13 klockan 13:03 +0100 skrev Michael Niedermayer: > On Thu, Feb 13, 2025 at 12:40:24PM +0100, Tomas Härdin wrote: > > ons 2025-02-12 klockan 23:03 +0100 skrev Michael Niedermayer: > > > On Wed, Feb 12, 2025 at 12:03:37PM +0100, Tomas Härdin wrote: > > > > tor 2025-02-06 klockan 15:58 +0

Re: [FFmpeg-devel] [PATCH] avformat/mov: (v3) fix get_eia608_packet

2025-02-13 Thread Pavel Koshevoy
please disregard v3 patch ... `if (size <= 10 || size % 2 != 0)` statement is wrong, I've submitted a v4 patch to correct it. Thank you, Pavel. On Thu, Feb 13, 2025 at 2:01 PM Pavel Koshevoy wrote: > The problem is reproducible with "Test for Quicktime 608 CC file.mov" > from https://samp

[FFmpeg-devel] [PATCH] avformat/mov: (v4) fix get_eia608_packet

2025-02-13 Thread Pavel Koshevoy
The problem is reproducible with "Test for Quicktime 608 CC file.mov" from https://samples.ffmpeg.org/MPEG2/subcc/ ffmpeg -i "Test for Quicktime 608 CC file.mov" -map 0 -c copy -y remuxed.mov Prior to the fix QuickTime Player playback of remuxed.mov would render garbage text for "English CC" subt

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Pavel Koshevoy
On Thu, Feb 13, 2025 at 1:12 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > On Thu, Feb 13, 2025 at 3:00 PM Pavel Koshevoy > wrote: > > yes, that patch is better in that it doesn't over-allocate. > > I don't care much which fix gets merged, so long as the problem is fixed. > > O

Re: [FFmpeg-devel] [PATCH] avformat/mov: (v2) fix get_eia608_packet

2025-02-13 Thread Pavel Koshevoy
I've submitted a v3 patch that doesn't do as much over-allocation, similar to https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310456.html On Thu, Feb 13, 2025 at 10:55 AM Pavel Koshevoy wrote: > The problem is reproducible with "Test for Quicktime 608 CC file.mov" > from https://sample

[FFmpeg-devel] [PATCH] avformat/mov: (v3) fix get_eia608_packet

2025-02-13 Thread Pavel Koshevoy
The problem is reproducible with "Test for Quicktime 608 CC file.mov" from https://samples.ffmpeg.org/MPEG2/subcc/ ffmpeg -i "Test for Quicktime 608 CC file.mov" -map 0 -c copy -y remuxed.mov Prior to the fix QuickTime Player playback of remuxed.mov would render garbage text for "English CC" subt

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Devin Heitmueller
On Thu, Feb 13, 2025 at 3:00 PM Pavel Koshevoy wrote: > yes, that patch is better in that it doesn't over-allocate. > I don't care much which fix gets merged, so long as the problem is fixed. Ok, if you could please try that patch and assuming it works for you reply to the list accordingly. I tr

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Pavel Koshevoy
On Thu, Feb 13, 2025 at 12:02 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > On Thu, Feb 13, 2025 at 12:57 PM Pavel Koshevoy > wrote: > > Thank you, I've submitted a 2nd version of the patch that performs more > > input validation. > > For what it's worth, a patch was submitted

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM '25 Expenses

2025-02-13 Thread Michael Niedermayer
Hi On Mon, Feb 10, 2025 at 05:29:49PM +0100, Lynne wrote: > Hi, > > I am requesting reimbursement for the following expenses made attending > FOSDEM 2025, where I attended the meeting and discussed development topics > with fellow developers. > > Eurostar tickets: 178.33 GBP > Hotel: 97.04 GBP

[FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb_neon: Implemented {yuyv, uyvy}toyuv{420, 422}

2025-02-13 Thread Krzysztof Pyrkosz via ffmpeg-devel
This patch succesfully passes the github pipeline. The previous one, which adds tests fails only the first check on linux x86, probably because of that mmx issue. The tiny patch in the second email chain (the one about right shift by 2) completes the checks chain as-is. Krzysztof --- libswscale

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Devin Heitmueller
On Thu, Feb 13, 2025 at 12:57 PM Pavel Koshevoy wrote: > Thank you, I've submitted a 2nd version of the patch that performs more > input validation. For what it's worth, a patch was submitted nearly two years ago which achieves the same goal (never upstreamed). You may wish to make sure it cover

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Pavel Koshevoy
On Wed, Feb 12, 2025 at 11:47 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Pavel Koshevoy: > > --- > > libavformat/mov.c | 40 +++- > > 1 file changed, 31 insertions(+), 9 deletions(-) > > > > diff --git a/libavformat/mov.c b/libavformat/mov

[FFmpeg-devel] [PATCH] avformat/mov: (v2) fix get_eia608_packet

2025-02-13 Thread Pavel Koshevoy
The problem is reproducible with "Test for Quicktime 608 CC file.mov" from https://samples.ffmpeg.org/MPEG2/subcc/ ffmpeg_g -i "Test for Quicktime 608 CC file.mov" -map 0 -c copy -y remuxed.mov Prior to the fix QuickTime Player playback of remuxed.mov would render cdt2 atom type tags as part of "

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Romain Beauxis
Le mer. 12 févr. 2025 à 16:12, Romain Beauxis a écrit : > > > > > Le mer. 12 févr. 2025 à 15:32, Timo Rothenpieler a > écrit : > > > > On 12.02.2025 22:22, Stephen Hutchinson wrote: > > > On 2/12/25 2:23 PM, Lynne wrote: > > >> > > >> > > >> On 12/02/2025 19:53, Romain Beauxis wrote: > > >>> Le

[FFmpeg-devel] [PATCH] avformat/mov: ensure no trun atoms are parsed as children of trak

2025-02-13 Thread James Almer
Fixes: Null-dereference READ Fixes: 396192874/clusterfuzz-testcase-minimized-audio_decoder_fuzzer-4589309789143040 Signed-off-by: James Almer --- libavformat/mov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 85aef33b19..f675929e57 100644

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Timo Rothenpieler
On 13/02/2025 13:07, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Tobias Rapp Sent: Donnerstag, 13. Februar 2025 12:05 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests On 13/02/2025 01:24, Romain Beauxis wro

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Timo Rothenpieler
On 13/02/2025 09:49, Leo Izen wrote: On 2/12/25 5:05 PM, Timo Rothenpieler wrote: I'm really not sure what you're asking. PRs are not restricted. Creating repos is. And there is no way to NOT restrict it, unless you want to pay several hundred Euros a month in hosting fees extra, and constant

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Timo Rothenpieler
On 13/02/2025 08:24, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Lynne Sent: Donnerstag, 13. Februar 2025 07:15 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests On 13/02/2025 03:59, Soft Works wrote:

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Leo Izen
On 2/13/25 4:27 AM, Tanay Manerikar wrote: On Thu, Feb 13, 2025 at 2:20 PM Leo Izen wrote: On 2/12/25 5:05 PM, Timo Rothenpieler wrote: My understanding as a Github and Gitlab user is the usual way to make a PR is to first fork the repository, then commit changes to a branch on your fork, and

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread martin schitter
On 2/13/25 13:10, Tomas Härdin wrote: More stuff should be done with git alone. This is one case where fossil shines, because it combines code, tickets and wiki into one single CLI tool. 'radicle' does the same with git! :) But it's still much to immature to use it as real alternative to the

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Leo Izen
On 2/13/25 4:49 AM, Gyan Doshi wrote: For some time, Github has allowed in-place editing. What that means is once you finished editing the file in the upstream repo, GH will fork the repo for you, or if already forked, create a new branch, with your changes incorporated, and give you an optio

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Soft > Works > Sent: Donnerstag, 13. Februar 2025 13:08 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests > Oh, just while writing this

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 23:07 + skrev Soft Works: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Timo > > Rothenpieler > > Sent: Mittwoch, 12. Februar 2025 22:33 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull > > r

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Donnerstag, 13. Februar 2025 12:05 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests > > On 13/02/2025 01:24, Romain Beauxis wrote: > > > Le mer. 12 févr

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 22:16 + skrev Soft Works: > > > I think people should be able to use a procedure they are > > > familiar with. > > > Is it possible to create PRs from a fork on GitHub? We explicitly don't want that. Also github doesn't federate. None of these git hosting sites do I thin

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-13 Thread Michael Niedermayer
On Thu, Feb 13, 2025 at 12:40:24PM +0100, Tomas Härdin wrote: > ons 2025-02-12 klockan 23:03 +0100 skrev Michael Niedermayer: > > On Wed, Feb 12, 2025 at 12:03:37PM +0100, Tomas Härdin wrote: > > > tor 2025-02-06 klockan 15:58 +0100 skrev Michael Niedermayer: > > > > Hi Tomas > > > > > > > > On We

[FFmpeg-devel] [RFC] Documenting metadata keys, informative (non-copied) metadata

2025-02-13 Thread Tomas Härdin
Hi In the samples_md5 patch discussion Michael wanted the proposed key to be documented. But it turns out we don't have any documentation for metadata keys! So I'm starting this thread to talk about it. I reckon we create a new file called doc/metadata_keys.texi with a table listing keys and where

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-13 Thread Gyan Doshi
On 2025-02-13 05:11 pm, Tomas Härdin wrote: ons 2025-02-12 klockan 22:55 +0100 skrev Michael Niedermayer: Hi On Wed, Feb 12, 2025 at 11:56:16AM +0100, Tomas Härdin wrote: tor 2025-02-06 klockan 16:07 +0100 skrev Michael Niedermayer: Hi Tomas On Wed, Feb 05, 2025 at 03:20:09PM +0100, Tomas H

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 22:55 +0100 skrev Michael Niedermayer: > Hi > On Wed, Feb 12, 2025 at 11:56:16AM +0100, Tomas Härdin wrote: > > tor 2025-02-06 klockan 16:07 +0100 skrev Michael Niedermayer: > > > Hi Tomas > > > > > > On Wed, Feb 05, 2025 at 03:20:09PM +0100, Tomas Härdin wrote: > [...] > >

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 23:03 +0100 skrev Michael Niedermayer: > On Wed, Feb 12, 2025 at 12:03:37PM +0100, Tomas Härdin wrote: > > tor 2025-02-06 klockan 15:58 +0100 skrev Michael Niedermayer: > > > Hi Tomas > > > > > > On Wed, Feb 05, 2025 at 03:24:24PM +0100, Tomas Härdin wrote: > > > > Seems rea

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tobias Rapp
On 13/02/2025 01:24, Romain Beauxis wrote: Le mer. 12 févr. 2025 à 18:17, Soft Works a écrit : Hm, please help me understand what kind of spam we're talking about here. I can't imagine somebody would take the effort for selling some pills to ffmpeg developers. When it's about advertising any

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Gyan > Doshi > Sent: Donnerstag, 13. Februar 2025 10:49 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests > > > > On 2025-02-13 02:19 pm, Leo Izen wrote: > > On 2/12/25 5:05

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Gyan Doshi
On 2025-02-13 02:19 pm, Leo Izen wrote: On 2/12/25 5:05 PM, Timo Rothenpieler wrote: I'm really not sure what you're asking. PRs are not restricted. Creating repos is. And there is no way to NOT restrict it, unless you want to pay several hundred Euros a month in hosting fees extra, and co

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tanay Manerikar
On Thu, Feb 13, 2025 at 2:20 PM Leo Izen wrote: > On 2/12/25 5:05 PM, Timo Rothenpieler wrote: > >> > > I'm really not sure what you're asking. > > PRs are not restricted. Creating repos is. > > And there is no way to NOT restrict it, unless you want to pay several > > hundred Euros a month in ho

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Leo Izen
On 2/12/25 5:05 PM, Timo Rothenpieler wrote: I'm really not sure what you're asking. PRs are not restricted. Creating repos is. And there is no way to NOT restrict it, unless you want to pay several hundred Euros a month in hosting fees extra, and constantly be on the lookout for hosting ille