On Thu, Feb 13, 2025 at 3:04 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote:
> On Thu, Feb 13, 2025 at 4:06 PM Pavel Koshevoy <pkoshe...@gmail.com> > wrote: > > I've submitted a 3rd version of the patch that doesn't do as much > > over-allocation, similar to > > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310456.html > > My v3 patch works correctly with the 2 sample files I can test with. > > Your patch looks substantially more complicated than the one from two > years ago. Does it address some edge case(s) that Sebastian's patch > didn't handle? > > If your patch is better in some way then so be it. But if it's > functionally equivalent I would suggest we merge Sebastian's patch as > it's simpler. > > It's on v4 now, BTW. I don't think my patch is any more complicated, it's just more explicit about what it's validating; I've included comments for most of the blocks, and used (hopefully) more meaningful variable names. I would hope my v4 patch should be easier to understand. Pavel. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
