[FFmpeg-devel] Install from Source on CentOS 7

2018-12-27 Thread Larry Apolonio
All, I am trying to compile ffmpeg with x265 libs Details of how I did it are here (without the x265 support) https://www.apolonio.com/node/138 but I get an error when I add x265. ERROR: x265 not found using pkg-config If you think configure made a mistake, make sure you are using the latest

[FFmpeg-devel] [PATCH V4 2/2] avcodec/libx264: add support for ROI-based encoding

2018-12-27 Thread Guo, Yejun
This patch just enables the path from ffmpeg to libx264, the more encoders can be added later. Signed-off-by: Guo, Yejun --- libavcodec/libx264.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index a68d0a7

[FFmpeg-devel] [PATCH V4 1/2] avutil: add ROI data struct and bump version

2018-12-27 Thread Guo, Yejun
The encoders such as libx264 support different QPs offset for different MBs, it makes possible for ROI-based encoding. It makes sense to add support within ffmpeg to generate/accept ROI infos and pass into encoders. Typical usage: After AVFrame is decoded, a ffmpeg filter or user's code generates

Re: [FFmpeg-devel] [PATCH V3 3/3] add an example to show how to fill the ROI info

2018-12-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Friday, December 28, 2018 12:47 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3 3/3] add an example to show how to > fill the ROI info > > O

Re: [FFmpeg-devel] [PATCH V3 1/3] avutil: add ROI data struct and bump version

2018-12-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Friday, December 28, 2018 12:42 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3 1/3] avutil: add ROI data struct and > bump version > > On 2

Re: [FFmpeg-devel] [PATCH V3 2/3] avcodec/libx264: add support for ROI-based encoding

2018-12-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Friday, December 28, 2018 12:45 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3 2/3] avcodec/libx264: add support > for ROI-based encoding >

Re: [FFmpeg-devel] [PATCH]lavf/vividas: Do not increase extradata_size after allocation

2018-12-27 Thread Carl Eugen Hoyos
2018-12-23 9:54 GMT+01:00, Paul B Mahol : > On 12/23/18, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch can avoid a crash in avcodec_parameters_from_context() >> if extradata_size was increased after allocation. >> >> Please comment, Carl Eugen >> > > OK Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/vividas: Support demuxing on big-endian hardware

2018-12-27 Thread Carl Eugen Hoyos
2018-12-23 9:52 GMT+01:00, Paul B Mahol : > On 12/23/18, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes demuxing vividas on big-endian hardware. >> >> Please comment, Carl Eugen >> > > OK, if tested and works. Patch applied. Thank you, Carl Eugen __

Re: [FFmpeg-devel] [PATCH]configure: Make sure libpostproc can be found if -rpath-link doesn't work

2018-12-27 Thread Carl Eugen Hoyos
2018-12-23 0:04 GMT+01:00, Carl Eugen Hoyos : > 2018-12-22 9:35 GMT+01:00, Michael Niedermayer : >> On Sat, Dec 22, 2018 at 12:08:19AM +0100, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes running fate with "--enable-shared --enable-gpl" on >>> Solaris, the linker searches "libpostpro

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Carl Eugen Hoyos
2018-12-27 22:02 GMT+01:00, Uwe Freese : > Am 27.12.18 um 20:25 schrieb Carl Eugen Hoyos: >> >>> I have now added as error handling: >>> >>> av_log(inlink->src, AV_LOG_ERROR, "More planes in frame than >>> expected.\n"); >>> return AVERROR(ENOMEM); >>> >>> Is this ok, or how should this be impleme

Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] optimize theora decoding in vp3dsp.

2018-12-27 Thread Michael Niedermayer
On Thu, Dec 27, 2018 at 02:16:22PM +0800, gxw wrote: > Optimize theora decoding with msa in functions: > 1. ff_vp3_idct_add_msa > 2. ff_vp3_idct_put_msa > 3. ff_vp3_idct_dc_add_msa > 4. ff_vp3_v_loop_filter_msa > 5. ff_vp3_h_loop_filter_msa > 6. ff_put_no_rnd_pixels_l2_msa > > Theora decoding spee

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Uwe Freese
Hello, Am 27.12.18 um 20:25 schrieb Carl Eugen Hoyos: I have now added as error handling: av_log(inlink->src, AV_LOG_ERROR, "More planes in frame than expected.\n"); return AVERROR(ENOMEM); Is this ok, or how should this be implemented instead? Not sure I understand: How can plane get >= MA

[FFmpeg-devel] [PATCH] fixed luma quantizing when q >= MAX_STORED_Q

2018-12-27 Thread Alex Mogurenko
--- libavcodec/proresenc_kostya.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 9a77d24fb6..e045a972f1 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c @@ -222,6 +222,7 @@

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Carl Eugen Hoyos
2018-12-27 13:00 GMT+01:00, Uwe Freese : > > The "10" should be a #define, [...] > > I have now added as error handling: > > av_log(inlink->src, AV_LOG_ERROR, "More planes in frame than expected.\n"); > return AVERROR(ENOMEM); > > Is this ok, or how should this be implemented instead? Not sure I

Re: [FFmpeg-devel] [PATCH] web/(old)download: Move 3.0 to olddownloads

2018-12-27 Thread Lou Logan
On Mon, Dec 3, 2018, at 10:19 AM, Lou Logan wrote: > No current downstream appears to be using 3.0: > https://trac.ffmpeg.org/wiki/Downstreams > > Signed-off-by: Lou Logan > --- > src/download| 39 --- > src/olddownload | 37 +++

Re: [FFmpeg-devel] [PATCH V3 3/3] add an example to show how to fill the ROI info

2018-12-27 Thread Derek Buitenhuis
On 27/12/2018 11:06, Guo, Yejun wrote: > This patch is just a quick example to show how to fill the ROI info, > it does not ask for upstreaming, just for your reference. > > to verify the ROI feature with this example, the command line looks like: > ./ffmpeg -i .../path_to_1920x1080_video_file -vf

Re: [FFmpeg-devel] [PATCH V3 1/3] avutil: add ROI data struct and bump version

2018-12-27 Thread Derek Buitenhuis
On 27/12/2018 11:05, Guo, Yejun wrote: > enum AVActiveFormatDescription { > @@ -200,6 +206,19 @@ typedef struct AVFrameSideData { > AVBufferRef *buf; > } AVFrameSideData; > > +typedef struct AVROI { > +/* coordinates at frame pixel level. > + * It will be extended internally if the

Re: [FFmpeg-devel] [PATCH V3 2/3] avcodec/libx264: add support for ROI-based encoding

2018-12-27 Thread Derek Buitenhuis
On 27/12/2018 11:06, Guo, Yejun wrote: > +AVFrameSideData *sd = av_frame_get_side_data(frame, > AV_FRAME_DATA_ROIS); > +if (sd != NULL) { Nit: `if (sd)` is convention. > +qoffsets = (float*)av_mallocz_array(mbx * mby, > sizeof(*qoffsets)); > +

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Moritz Barsnick
On Thu, Dec 27, 2018 at 13:00:29 +0100, Uwe Freese wrote: These were just some remarks from me, still pending other, better reviews. > > The "10" should be a #define, [...] > > I have now added as error handling: > > av_log(inlink->src, AV_LOG_ERROR, "More planes in frame than expected.\n"); >

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-27 Thread Steven Liu
> On Dec 27, 2018, at 21:30, Ronak Patel > wrote: > > > >> On Dec 17, 2018, at 9:58 AM, Steven Liu wrote: >> >> >> On Dec 17, 2018, at 21:07, Ronak Patel wrote: On Dec 13, 2018, at 9:15 PM, Ronak Patel wrote: > On Dec 12, 2018, at

Re: [FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

2018-12-27 Thread Ronak Patel
> On Dec 17, 2018, at 9:58 AM, Steven Liu wrote: > > > >>> On Dec 17, 2018, at 21:07, Ronak Patel >>> wrote: >>> >>> >>> On Dec 13, 2018, at 9:15 PM, Ronak Patel >>> wrote: >>> >>> >>> On Dec 12, 2018, at 2:46 AM, Liu Steven wrote: >> 在 2018年12月12日,上午5:08,

Re: [FFmpeg-devel] [PATCH V2] avfilter: Add tonemap vaapi filter

2018-12-27 Thread Michael Niedermayer
On Thu, Dec 27, 2018 at 04:55:17PM +0800, Zachary Zhou wrote: > It supports ICL platform. > H2H (HDR to HDR): P010 -> RGB10 > H2S (HDR to SDR): P010 -> RGB8 > > libva commit for HDR10 > https://github.com/intel/libva/commit/cf11abe5e1b9c93ee75cf974076957162c1605b9 > > Signed-off-by: Zachary Zhou

Re: [FFmpeg-devel] [PATCH V2] avfilter: Add tonemap vaapi filter

2018-12-27 Thread Moritz Barsnick
On Thu, Dec 27, 2018 at 16:55:17 +0800, Zachary Zhou wrote: > +typedef enum { > +HDR_VAAPI_H2H, > +HDR_VAAPI_H2S, > +} HDRType; > +static const AVOption tonemap_vaapi_options[] = { > +{ "type","hdr type",OFFSET(hdr_type), AV_OPT_TYPE_INT, { > .i64 = HDR_VAAPI_H2H }, 0,

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Uwe Freese
Hello, thanks for the comments. Most points were clear and I've changed the code accordingly (see attached new patch). Here are the remaining questions / points to discuss: You can start writing it now already, because it needs to go into doc/filters.texi. I've added the first version in t

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-27 Thread Michael Niedermayer
On Wed, Dec 26, 2018 at 12:30:05AM +, Kieran Kunhya wrote: > On Tue, 25 Dec 2018 at 22:17 Michael Niedermayer > wrote: > > > Fixes: Timeout > > Fixes: > > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > > Before: Executed > > clusterfuzz-testcase-minimiz

[FFmpeg-devel] [PATCH 1/3] avcodec/scpr: Use local variables in decode_run_i()

2018-12-27 Thread Michael Niedermayer
This improves the speed of decode_run_i() Before: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5656821117747200 in 17420 ms After: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5656821117747200 in 14018 ms Improves: 11270/clusterfuzz-testcase-minimized-ffmpe

[FFmpeg-devel] [PATCH 3/3] avcodec/scpr: Avoid per pixel y checks in decode_run_i

2018-12-27 Thread Michael Niedermayer
about 1% faster Signed-off-by: Michael Niedermayer --- libavcodec/scpr.h | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/libavcodec/scpr.h b/libavcodec/scpr.h index e22188ab3a..15cb87c464 100644 --- a/libavcodec/scpr.h +++ b/libavcode

[FFmpeg-devel] [PATCH 2/3] avcodec/scpr: Factor some indexes out in decode_run_i()

2018-12-27 Thread Michael Niedermayer
This improves the speed of decode_run_i() After: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5656821117747200 in 13516 ms Before: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5656821117747200 in 14018 ms Improves: 11270/clusterfuzz-testcase-minimized-ffmpe

[FFmpeg-devel] [PATCH V2] avfilter: Add tonemap vaapi filter

2018-12-27 Thread Zachary Zhou
It supports ICL platform. H2H (HDR to HDR): P010 -> RGB10 H2S (HDR to SDR): P010 -> RGB8 libva commit for HDR10 https://github.com/intel/libva/commit/cf11abe5e1b9c93ee75cf974076957162c1605b9 Signed-off-by: Zachary Zhou --- configure | 2 + libavfilter/Makefile |

Re: [FFmpeg-devel] [PATCH V1] avfilter: Add tonemap vaapi filter

2018-12-27 Thread Zhou, Zachary
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Moritz Barsnick > Sent: Tuesday, December 25, 2018 6:06 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V1] avfilter: Add tonemap vaapi filter > > O