On 27/12/2018 11:05, Guo, Yejun wrote:
> enum AVActiveFormatDescription {
> @@ -200,6 +206,19 @@ typedef struct AVFrameSideData {
> AVBufferRef *buf;
> } AVFrameSideData;
>
> +typedef struct AVROI {
> + /* coordinates at frame pixel level.
> + * It will be extended internally if the codec requires an alignment.
> + * If the regions overlap, the last value in the list will be used.
> + */
Should probaly be doxygen above the typedef, and mention the offset, too.
> + size_t top;
> + size_t bottom;
> + size_t left;
> + size_t right;
> + // quant offset is encoder dependent
> + int qoffset;
> +} AVROI;
Nit: Technically it could be a float, but I do't feel strongly about it
one way or another.
Cheers,
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
