> On Dec 17, 2018, at 9:58 AM, Steven Liu <l...@chinaffmpeg.org> wrote: > > > >>> On Dec 17, 2018, at 21:07, Ronak Patel <ronak2121-at-yahoo....@ffmpeg.org> >>> wrote: >>> >>> >>> On Dec 13, 2018, at 9:15 PM, Ronak Patel >>> <ronak2121-at-yahoo....@ffmpeg.org> wrote: >>> >>> >>> >>>> On Dec 12, 2018, at 2:46 AM, Liu Steven <l...@chinaffmpeg.org> wrote: >>>> >>>> >>>> >>>>>> 在 2018年12月12日，上午5:08，Ronak <ronak2121-at-yahoo....@ffmpeg.org> 写道： >>>>>> >>>>>> >>>>>> On Dec 11, 2018, at 3:28 PM, Gyan <ffm...@gyani.pro> wrote: >>>>>> >>>>>> >>>>>>> On 12-12-2018 01:13 AM, Ronak wrote: >>>>>>> >>>>>>> Looks like I found out why: >>>>>>> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/hlsenc.c#L790. >>>>>>> The hlsenc.c file overwrites whatever I pass in the command line... >>>>>> >>>>>> That is a bug but there's still an error in your command. It should be, >>>>>> >>>>>> >>>>>> -hls_ts_options movflags=+skip_sidx >>>>>> >>>>>> This is because mp4 is a child muxer in this context. That hls option >>>>>> should be renamed. >>>>>> >>>>>> Line 790 should be patched by adding + before frag_custom >>>>> >>>>> That doesn't work. >>>>> >>>>> ffmpeg -i input.mp4 -hls_ts_options movflags=+skip_sidx -codec copy >>>>> -hls_time 0.97523809523809 -hls_segment_type fmp4 -hls_flags single_file >>>>> -hls_playlist_type vod output.m3u8 >>>>> ffmpeg version N-92677-gdd7d6034f1 Copyright (c) 2000-2018 the FFmpeg >>>>> developers >>>>> built with gcc 4.4.6 (GCC) 20110731 (Red Hat 4.4.6-3) >>>>> configuration: --prefix=/home/ronakp/ffmpeg_build >>>>> --pkg-config-flags=--static >>>>> --extra-cflags=-I/home/ronakp/ffmpeg_build/include >>>>> --extra-ldflags=-L/home/ronakp/ffmpeg_build/lib --extra-libs=-lpthread >>>>> --extra-libs=-lm --bindir=/home/ronakp/bin --enable-gpl >>>>> --enable-libfdk_aac --enable-libmp3lame --enable-libopus --enable-nonfree >>>>> libavutil 56. 24.101 / 56. 24.101 >>>>> libavcodec 58. 42.100 / 58. 42.100 >>>>> libavformat 58. 24.100 / 58. 24.100 >>>>> libavdevice 58. 6.101 / 58. 6.101 >>>>> libavfilter 7. 46.101 / 7. 46.101 >>>>> libswscale 5. 4.100 / 5. 4.100 >>>>> libswresample 3. 4.100 / 3. 4.100 >>>>> libpostproc 55. 4.100 / 55. 4.100 >>>>> Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'input.mp4': >>>>> Metadata: >>>>> major_brand : isom >>>>> minor_version : 1 >>>>> compatible_brands: isom >>>>> creation_time : 2013-11-14T18:23:26.000000Z >>>>> Duration: 02:39:09.39, start: 0.000000, bitrate: 31 kb/s >>>>> Stream #0:0(und): Audio: aac (LC) (mp4a / 0x6134706D), 22050 Hz, mono, >>>>> fltp, 30 kb/s (default) >>>>> Metadata: >>>>> creation_time : 2013-11-14T18:23:26.000000Z >>>>> handler_name : GPAC ISO Audio Handler >>>>> [hls @ 0x23e1b00] Opening 'output.m4s' for writing >>>>> [hls @ 0x23e1b00] Some of provided format options in >>>>> 'movflags=+skip_sidx' are not recognized >>>>> Could not write header for output file #0 (incorrect codec parameters ?): >>>>> Invalid argument >>>>> Stream mapping: >>>>> Stream #0:0 -> #0:0 (copy) >>>>> Last message repeated 1 times >>>>> >>>>> Also, I think whatever options I set on the command line are going to be >>>>> overwritten by line 790 in hlsenc.c anyway no? >>>> https://patchwork.ffmpeg.org/patch/11378/ >>>> >>>> Try this patch please :D >>> >>> Thanks that works. >>> >>> Let’s merge it! >> >> Were you able to merge this patch? > No, i need more time to check that. > and look at this mail please, > i need check this patch first, [PATCH] Fix usage of temp_file flag in > hls_flags option >
Hi Steven, Would we be able to merge this now? Ronak >> >>> >>> >>>>> >>>>>> >>>>>> Gyan >>>>>> >>>>>> _______________________________________________ >>>>>> ffmpeg-devel mailing list >>>>>> ffmpeg-devel@ffmpeg.org >>>>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>> >>>>> _______________________________________________ >>>>> ffmpeg-devel mailing list >>>>> ffmpeg-devel@ffmpeg.org >>>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>> >>>> >>>> >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > Thanks > Steven > > > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
