> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Friday, December 28, 2018 12:42 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3 1/3] avutil: add ROI data struct and > bump version > > On 27/12/2018 11:05, Guo, Yejun wrote: > > enum AVActiveFormatDescription { > > @@ -200,6 +206,19 @@ typedef struct AVFrameSideData { > > AVBufferRef *buf; > > } AVFrameSideData; > > > > +typedef struct AVROI { > > + /* coordinates at frame pixel level. > > + * It will be extended internally if the codec requires an alignment. > > + * If the regions overlap, the last value in the list will be used. > > + */ > > Should probaly be doxygen above the typedef, and mention the offset, too. >
thanks, will fix it, together with the comment for qoffset. > > + size_t top; > > + size_t bottom; > > + size_t left; > > + size_t right; > > + // quant offset is encoder dependent > > + int qoffset; > > +} AVROI; > > Nit: Technically it could be a float, but I do't feel strongly about it one > way or > another. int is from an early comment, I'm open to both, so just keep it if no more objects. > > Cheers, > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
