> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Friday, December 28, 2018 12:45 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V3 2/3] avcodec/libx264: add support > for ROI-based encoding > > On 27/12/2018 11:06, Guo, Yejun wrote: > > + AVFrameSideData *sd = av_frame_get_side_data(frame, > AV_FRAME_DATA_ROIS); > > + if (sd != NULL) { > > Nit: `if (sd)` is convention. > > > + qoffsets = (float*)av_mallocz_array(mbx * mby, > sizeof(*qoffsets)); > > + if (qoffsets == NULL) > > Nit: `if (!qoffsets)` is convention. > > Rest is OK, I think. > > Whoever pushes the patch (or me, whatever) can fix the few style nits > above.
looks that I still have time for the change, will fix the two issues and send out a new version. > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
