Hi Achim,
Achim Gratz writes:
> Bastien writes:
>> Okay, so I committed a different fix in maint and master.
>
> That fix (and the explanation) makes much more sense… I'll have to see
> that this also gets tested, but I won't get to it for some time,
> unfortunately.
I'll first fix the document
Bastien writes:
> Okay, so I committed a different fix in maint and master.
That fix (and the explanation) makes much more sense… I'll have to see
that this also gets tested, but I won't get to it for some time,
unfortunately.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andro
Thanks Bastien.
Property API documentation could be made more precise in some places.
>From the documentation of org-entry-get (both the docstring and the
Org manual), it would seem that unless the inherit argument is
non-nil, file-wide and system-wide property settings should not be
checked at al
Bastien writes:
> Ilya Shlyakhter writes:
>
>> When I open emacs with this file, move to the emacs-lisp block, and
>> evaluate it, I get "aaa".
>
> I can reproduce your problem now, I'm on it, and the problem is real,
> but I need to make sure all tests pass fine before fixing this.
Okay, so I
Hi Ilya,
Bastien writes:
> I can reproduce your problem now, I'm on it, and the problem is real,
> but I need to make sure all tests pass fine before fixing this.
Don't expect a fix anytime soon -- things are complex here and I need
a few hours in a raw to fix this.
--
Bastien
Ilya Shlyakhter writes:
> When I open emacs with this file, move to the emacs-lisp block, and
> evaluate it, I get "aaa".
I can reproduce your problem now, I'm on it, and the problem is real,
but I need to make sure all tests pass fine before fixing this.
Thanks,
--
Bastien
On 3/17/14 5:43 PM, Achim Gratz wrote:
The test case doesn't work as posted. A working test case produces the
Try http://ilya.cc/testcase.org
When I open emacs with this file, move to the emacs-lisp block, and
evaluate it, I get "aaa".
I could easily be wrong re: the logic of the code, but
In the current master branch, doing the example from the patch
(reproduced below again) gives "aaa", because the line
(let (org-file-properties org-global-properties
org-global-properties-fixed)
has been removed from org-entry-get-with-inheritance .
I agree that patching a function as cor
Ilya Shlyakhter writes:
> Here is the test case again:
The test case doesn't work as posted. A working test case produces the
result shown below (with and without your patch reverted) on current
master (tested again via make vanilla just to be sure).
--8<---cut here---sta
Achim Gratz writes:
> Bastien writes:
>> What I meant is this: broken tests are not a sufficient reason to
>> revert a commit. You need to show the commit is wrong and the tests
>> are not outdated.
>
> No code breaking a test should have been committed in the first place,
> then we wouldn't nee
Bastien writes:
> What I meant is this: broken tests are not a sufficient reason to
> revert a commit. You need to show the commit is wrong and the tests
> are not outdated.
No code breaking a test should have been committed in the first place,
then we wouldn't need to have this discussion. If t
Achim Gratz writes:
>> I meant: can you tell me how the tests fail?
>
> They don't produce the result they are supposed to produce.
Thanks for this explanation.
>> I'm interested in the answer.
>
> make BTEST_RE='\\(header-arg-defaults\\|property-accumulation\\)'
> test-dirty
Thanks!
If
Bastien writes:
> Achim Gratz writes:
>
>>> Can you tell a bit more about what's wrong with the test?
>>
>> There is nothing wrong with those tests.
>
> I meant: can you tell me how the tests fail?
They don't produce the result they are supposed to produce.
> I'm interested in the answer.
make
Achim Gratz writes:
>> Can you tell a bit more about what's wrong with the test?
>
> There is nothing wrong with those tests.
I meant: can you tell me how the tests fail?
I'm interested in the answer.
>> If the patch is good and the tests are outdated, I'd rather
>> fix the tests than revert t
Bastien writes:
> Can you tell a bit more about what's wrong with the test?
There is nothing wrong with those tests.
> If the patch is good and the tests are outdated, I'd rather
> fix the tests than revert the patch to re-revert it again.
No, the patch is bad, otherwise it wouldn't break the te
Achim Gratz writes:
> Bastien writes:
>> Applied, thanks!
>
> That badly breaks the following tests:
>
>FAILED test-ob-header-arg-defaults/tree/accumulate/call
>FAILED test-ob-header-arg-defaults/tree/accumulate/noweb
>FAILED test-ob-header-arg-defaults/tree/complex/call
>FAILE
Bastien writes:
> Applied, thanks!
That badly breaks the following tests:
FAILED test-ob-header-arg-defaults/tree/accumulate/call
FAILED test-ob-header-arg-defaults/tree/accumulate/noweb
FAILED test-ob-header-arg-defaults/tree/complex/call
FAILED test-ob-header-arg-defaults/tree/c
Applied, thanks!
--
Bastien
>From bea0daf422e9ab8f27addb412aa03456c89d5844 Mon Sep 17 00:00:00 2001
From: Ilya Shlyakhter
Date: Fri, 7 Mar 2014 01:09:13 -0500
Subject: [PATCH] Properties: Fix property-getting with inheritance
* lisp/org.el (org-entry-get-with-inheritance): Temporarily clear
org-file-properties, org-global-
19 matches
Mail list logo
