Bastien writes: > What I meant is this: broken tests are not a sufficient reason to > revert a commit. You need to show the commit is wrong and the tests > are not outdated.
No code breaking a test should have been committed in the first place, then we wouldn't need to have this discussion. If the "tests are outdated" (in this case they ensure that the documentation and implementation are matching up which is difficult to ascertain by just playing with a single example, so that shouldn't ever happen), the onus is on the committer to explain why and change the tests and documentation accordingly (either as a preparation for that commit or in the same commit). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf Blofeld V1.15B11: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
