Achim Gratz <strom...@nexgo.de> writes: >> I meant: can you tell me how the tests fail? > > They don't produce the result they are supposed to produce.
Thanks for this explanation. >> I'm interested in the answer. > > make BTEST_RE='\\(header-arg-defaults\\|property-accumulation\\)' > test-dirty Thanks! >>>> If the patch is good and the tests are outdated, I'd rather >>>> fix the tests than revert the patch to re-revert it again. >>> >>> No, the patch is bad, otherwise it wouldn't break the tests. >> >> Sorry, I don't buy this. > > I'm not selling anything. What I meant is this: broken tests are not a sufficient reason to revert a commit. You need to show the commit is wrong and the tests are not outdated. In this case, I made the error of reproduce Ilya's solution, not Ilya's problem, so I wrong assumed his patch was the problem to his problem. Ilya: from the maint and master branch, I get "bbb" as a result for the example you placed in your commit message. Do you have "aaa" as a result with Org from maint or master? If so, can you provide a recipe? Thanks, -- Bastien
