Bastien writes:
> Achim Gratz <strom...@nexgo.de> writes:
>
>>> Can you tell a bit more about what's wrong with the test?
>>
>> There is nothing wrong with those tests.
>
> I meant: can you tell me how the tests fail?

They don't produce the result they are supposed to produce.

> I'm interested in the answer.

make BTEST_RE='\\(header-arg-defaults\\|property-accumulation\\)' test-dirty

>>> If the patch is good and the tests are outdated, I'd rather
>>> fix the tests than revert the patch to re-revert it again.
>>
>> No, the patch is bad, otherwise it wouldn't break the tests.
>
> Sorry, I don't buy this.

I'm not selling anything.

> Or maybe explain me why the patch is wrong.

It breaks property inheritance and accumulation.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada


Reply via email to