Re: [PATCH 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-18 Thread Thomas Zimmermann
Hi Am 18.02.25 um 21:12 schrieb Aditya Garg: Hi In continuation to my previous mail. + +static int appletbdrm_send_msg(struct appletbdrm_device *adev, u32 msg) +{ + struct appletbdrm_msg_simple_request *request; + int ret; + + request = kzalloc(sizeof(*request), GFP_KERNEL); + if (!request) +

Re: [PATCH] vgaarbiter: documentation grammar correction

2025-02-18 Thread Bagas Sanjaya
On Thu, Feb 13, 2025 at 11:05:39PM +0530, Pranav Tyagi wrote: > Hi, > > Just a gentle follow-up on this patch. It has been reviewed but hasn't > been applied yet. You may need to resend the patch, but with scripts/get_maintainer.pl output Cc'ed so that DRM maintainers can be notified on the patch

Re: [PATCH 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-18 Thread Thomas Zimmermann
Hi Am 18.02.25 um 14:49 schrieb Aditya Garg: [...] This code runs in the middle of the atomic update. It's then too late to do error handling. If these allocs fail, the display hardware will remain in undefined state. It is much preferable to allocate this memory in the atomic_check. To do so

Re: [PATCH v5 1/6] drm/sched: Add internal job peek/pop API

2025-02-18 Thread Philipp Stanner
On Tue, 2025-02-18 at 14:17 -0800, Matthew Brost wrote: > On Tue, Feb 18, 2025 at 06:26:15PM +, Tvrtko Ursulin wrote: > > > > On 18/02/2025 12:26, Philipp Stanner wrote: > > > Thx for the updated version. Overlooked it, I was out on Friday. > > > See > > > below > > > > > > On Fri, 2025-02-14

Re: [PATCH v2 drm-dp 6/7] drm/hisilicon/hibmc: Add drm debugfs functions

2025-02-18 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:58PM +0800, Yongbang Shi wrote: From: Baihan Li We use the previous two patches as our debug functions and generate two files. "hibmc-dp" and "color-bar". hibmc-dp: read only, print the dp link status and dpcd version Please define a generic DP attribute for this,

Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread Shixiong Ou
在 2025/2/19 14:47, Arnd Bergmann 写道: On Sat, Feb 8, 2025, at 10:29, oushixiong1...@163.com wrote: From: Shixiong Ou 1. The device_remove_file() need to be called when driver is removing. 2. The device_remove_file() need to be called if the call to device_create_file() fails. This should

Re: [PATCH v2 drm-dp 4/7] drm/hisilicon/hibmc: Add colorbar-cfg: set color bar cfg

2025-02-18 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:56PM +0800, Yongbang Shi wrote: From: Baihan Li This is a DP IP controller's feature. It can be used as a debug method which can check DP controller is working good. The colorbar displaying doesn't rely on other IPs work in the chip, like: GPU or DDR (vram) and so

Re: [PATCH v1] perf drm_pmu: Add a tool like PMU to expose DRM information

2025-02-18 Thread Namhyung Kim
Hi Ian, On Mon, Feb 10, 2025 at 11:17:27PM -0800, Ian Rogers wrote: > DRM clients expose information through usage stats as documented in > Documentation/gpu/drm-usage-stats.rst (available online at > https://docs.kernel.org/gpu/drm-usage-stats.html). Add a tool like > PMU, similar to the hwmon PM

Re: [PATCH v2 drm-dp 2/7] drm/hisilicon/hibmc: Add dp serdes cfg in dp process

2025-02-18 Thread Yongbang Shi
On Mon, Feb 10, 2025 at 10:49:54PM +0800, Yongbang Shi wrote: From: Baihan Li Add dp serdes cfg in link training process, and related adapting and modificating. We change some init values about training, Imperative language, please. Use 'change', not 'we change'. because we want completely t

[PATCH v3] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread oushixiong1025
From: Shixiong Ou 1. The device_remove_file() need to be called when driver is removing. 2. The device_remove_file() need to be called if the call to device_create_file() fails. Signed-off-by: Shixiong Ou --- v1->v2: add missing 'return error'. call device_remove_file() in sh

Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread Arnd Bergmann
On Sat, Feb 8, 2025, at 10:29, oushixiong1...@163.com wrote: > From: Shixiong Ou > > 1. The device_remove_file() need to be called when driver is removing. > 2. The device_remove_file() need to be called if the call to >device_create_file() fails. This should probably use device_add_group() i

Re: [PATCH v5 03/32] mm/migrate: Trylock device page in do_swap_page

2025-02-18 Thread Alistair Popple
On Tue, Feb 18, 2025 at 10:08:31PM -0800, Matthew Brost wrote: > On Wed, Feb 19, 2025 at 04:36:54PM +1100, Alistair Popple wrote: > > On Wed, Feb 12, 2025 at 06:10:43PM -0800, Matthew Brost wrote: > > > Avoid multiple CPU page faults to the same device page racing by trying > > > to lock the page i

Re: [PATCH v5 03/32] mm/migrate: Trylock device page in do_swap_page

2025-02-18 Thread Matthew Brost
On Wed, Feb 19, 2025 at 04:36:54PM +1100, Alistair Popple wrote: > On Wed, Feb 12, 2025 at 06:10:43PM -0800, Matthew Brost wrote: > > Avoid multiple CPU page faults to the same device page racing by trying > > to lock the page in do_swap_page before taking an extra reference to the > > page. This p

Re: [PATCH v5 03/32] mm/migrate: Trylock device page in do_swap_page

2025-02-18 Thread Alistair Popple
On Wed, Feb 12, 2025 at 06:10:43PM -0800, Matthew Brost wrote: > Avoid multiple CPU page faults to the same device page racing by trying > to lock the page in do_swap_page before taking an extra reference to the > page. This prevents scenarios where multiple CPU page faults each take > an extra ref

Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

2025-02-18 Thread kernel test robot
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on lee-leds/for-leds-next] [also build test WARNING on linus/master v6.14-rc3 next-20250218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

RE: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-18 Thread Michael Kelley
From: Saurabh Sengar Sent: Saturday, February 15, 2025 1:21 AM > > When a Hyper-V framebuffer device is unbind, hyperv_fb driver tries to > release the framebuffer forcefully. If this framebuffer is in use it > produce the following WARN and hence this framebuffer is never released. > > [ 44.

Re: [PATCH v2 6/6] drm/xe/xe_query: Add support for per-drm-client reset stat querying

2025-02-18 Thread kernel test robot
Hi Jonathan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-xe/drm-xe-next] [also build test ERROR on next-20250218] [cannot apply to linus/master v6.14-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v8 01/14] drm: Define histogram structures exposed to user

2025-02-18 Thread Murthy, Arun R
On 18-02-2025 21:48, Pekka Paalanen wrote: On Tue, 18 Feb 2025 11:13:39 +0530 "Murthy, Arun R" wrote: On 17-02-2025 15:38, Pekka Paalanen wrote: Hi Arun, this whole series seems to be missing all the UAPI docs for the DRM ReST files, e.g. drm-kms.rst. The UAPI header doc comments are not a r

Re: [PATCH v5 27/32] drm/xe: Add SVM VRAM migration

2025-02-18 Thread Ghimiray, Himal Prasad
On 19-02-2025 08:35, Matthew Brost wrote: On Wed, Feb 19, 2025 at 08:29:53AM +0530, Ghimiray, Himal Prasad wrote: On 19-02-2025 03:24, Matthew Brost wrote: On Thu, Feb 13, 2025 at 11:58:27PM +0530, Ghimiray, Himal Prasad wrote: On 13-02-2025 07:41, Matthew Brost wrote: Migration is imp

Re: [PATCH] drm/xe: Fix exporting xe buffers multiple times

2025-02-18 Thread Matthew Brost
On Tue, Feb 18, 2025 at 11:03:53AM +0100, Jacek Lawrynowicz wrote: > From: Tomasz Rusinowicz > > The `struct ttm_resource->placement` contains TTM_PL_FLAG_* flags, but > it was incorrectly tested for XE_PL_* flags. > This caused xe_dma_buf_pin() to always fail when invoked for > the second time.

Re: [PATCH RFC 1/3] rust: add useful ops for u64

2025-02-18 Thread John Hubbard
On 2/18/25 5:21 PM, Alexandre Courbot wrote: On Wed Feb 19, 2025 at 5:51 AM JST, Timur Tabi wrote: On Tue, 2025-02-18 at 22:16 +0900, Alexandre Courbot wrote: ... More likely this would be something like: let SplitU64 { high: some_u32, .. } = some_u64; Which is still a bit verbose, but a

Re: [PATCH v5 27/32] drm/xe: Add SVM VRAM migration

2025-02-18 Thread Matthew Brost
On Wed, Feb 19, 2025 at 08:29:53AM +0530, Ghimiray, Himal Prasad wrote: > > > On 19-02-2025 03:24, Matthew Brost wrote: > > On Thu, Feb 13, 2025 at 11:58:27PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > > > > On 13-02-2025 07:41, Matthew Brost wrote: > > > > Migration is implemented with r

Re: [PATCH v5 27/32] drm/xe: Add SVM VRAM migration

2025-02-18 Thread Ghimiray, Himal Prasad
On 19-02-2025 03:24, Matthew Brost wrote: On Thu, Feb 13, 2025 at 11:58:27PM +0530, Ghimiray, Himal Prasad wrote: On 13-02-2025 07:41, Matthew Brost wrote: Migration is implemented with range granularity, with VRAM backing being a VM private TTM BO (i.e., shares dma-resv with VM). The life

Re: [PATCH] drm/nouveau: select FW caching

2025-02-18 Thread Dave Airlie
On Wed, 19 Feb 2025 at 07:39, Luis Chamberlain wrote: > > On Tue, Feb 18, 2025 at 06:24:43PM +0100, Danilo Krummrich wrote: > > On Tue, Feb 18, 2025 at 06:28:53AM -0800, Luis Chamberlain wrote: > > > > > > What I recommend is to look into why we disable it by default, I think > > > > I think FW_CA

Re: [PATCH RFC 1/3] rust: add useful ops for u64

2025-02-18 Thread Alexandre Courbot
On Wed Feb 19, 2025 at 5:51 AM JST, Timur Tabi wrote: > On Tue, 2025-02-18 at 22:16 +0900, Alexandre Courbot wrote: >> > A proper struct with `high` and `low` might be more verbose, but >> > it rules out this issue. >> >> Mmm indeed, so we would have client code looking like: >> >>   let SplitU64

Re: [PATCH 0/5] EDITME: Support for Adreno 623 GPU

2025-02-18 Thread Rob Herring (Arm)
On Thu, 13 Feb 2025 21:40:05 +0530, Akhil P Oommen wrote: > This series adds support for A623 GPU found in QCS8300 chipsets. This > GPU IP is very similar to A621 GPU, except for the UBWC configuration > and the GMU firmware. > > Both DT patches are for Bjorn and rest of the patches for Rob Clar

Re: [PATCH] ntsync: Set the permissions to be 0666

2025-02-18 Thread Elizabeth Figura
On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote: > This allows ntsync to be usuable by non-root processes out of the box > > Signed-off-by: Mike Lothian > --- > drivers/misc/ntsync.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync

Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

2025-02-18 Thread Cristian Ciocaltea
Hi, On 2/18/25 6:05 PM, Sebastian Reichel wrote: > Hi, > > On Tue, Feb 18, 2025 at 03:53:06PM +0100, Heiko Stübner wrote: >> Am Dienstag, 18. Februar 2025, 15:13:07 MEZ schrieb Sebastian Reichel: >>> On Tue, Feb 18, 2025 at 08:17:46PM +0800, Jianfeng Liu wrote: On Tue, 18 Feb 2025 11:00:57 +

[RFC PATCH 7/7] drm/panfrost/panthor: Take sparse objects into account for fdinfo

2025-02-18 Thread Adrián Larumbe
Because of the alternative definition of the 'pages' field in shmem after adding support for sparse allocations, the logic for deciding whether pages are available must be expanded. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_gem.c | 4 +++- drivers/gpu/drm/panthor/pantho

[RFC PATCH 6/7] drm/panfrost: Use shmem sparse allocation for heap BOs

2025-02-18 Thread Adrián Larumbe
Panfrost heap BOs grow on demand when the GPU triggers a page fault after accessing an address within the BO's virtual range. We still store the sgts we get back from the shmem sparse allocation function, since it was decided management of sparse memory SGTs should be done by client drivers rather

[RFC PATCH 5/7] drm/shmem: Implement sparse allocation of pages for shmem objects

2025-02-18 Thread Adrián Larumbe
Add a new function that lets drivers allocate pages for a subset of the shmem object's virtual address range. Expand the shmem object's definition to include an RSS field, since it's different from the base GEM object's virtual size. Add also new function for putting the pages of a sparse page arr

[RFC PATCH 3/7] drm/prime: Let drm_prime_pages_to_sg use the page_array interface

2025-02-18 Thread Adrián Larumbe
Switch to sg_alloc_table_from_page_array_segment() when generating an sgtable from an array of pages. This is functionally equivalent, but a future commit will also let us do the same from a memory page xarray. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/drm_prime.c | 7 --- 1 file cha

[RFC PATCH 0/7] Introduce sparse DRM shmem object allocations

2025-02-18 Thread Adrián Larumbe
This patch series is a proposal for implementing sparse page allocations for shmem objects. It was initially motivated by a kind of BO managed by the Panfrost driver, the tiler heap, which grows on demand every time the GPU faults on a virtual address within its drm_mm-managed ranged. Because keep

[RFC PATCH 4/7] drm/shmem: Introduce the notion of sparse objects

2025-02-18 Thread Adrián Larumbe
Sparse DRM objects will store their backing pages in an xarray, to avoid the overhead of preallocating a huge struct page pointer array when only a very small range of indices might be assigned. For now, only the definition of a sparse object as a union alternative to a 'dense' object is provided,

[RFC PATCH 1/7] shmem: Introduce non-blocking allocation of shmem pages

2025-02-18 Thread Adrián Larumbe
With the future goal of preventing deadlocks with the shrinker when reclaiming GEM-allocated memory, a variant of shmem_read_mapping_page_gfp() that does not sleep when enough memory isn't available, therefore potentially triggering the shrinker on same driver, is introduced. Signed-off-by: Adrián

[RFC PATCH 2/7] lib/scatterlist.c: Support constructing sgt from page xarray

2025-02-18 Thread Adrián Larumbe
In preparation for a future commit that will introduce sparse allocation of pages in DRM shmem, a scatterlist function that knows how to deal with an xarray collection of memory pages had to be introduced. Because the new function is identical to the existing one that deals with a page array, the

[PATCH 1/1] fbdev: hyperv_fb: Fix hang in kdump kernel when on Hyper-V Gen 2 VMs

2025-02-18 Thread mhkelley58
From: Michael Kelley Gen 2 Hyper-V VMs boot via EFI and have a standard EFI framebuffer device. When the kdump kernel runs in such a VM, loading the efifb driver may hang because of accessing the framebuffer at the wrong memory address. The scenario occurs when the hyperv_fb driver in the origin

[RFC PATCH] drm/amd/display: fix page fault on dpms off with MST

2025-02-18 Thread Melissa Wen
A page fault occurs when running the IGT test: amdgpu@amd_vrr_range@freesync-parsing-suspend with MST. Fix that by skipping handling a stream state when stream is NULL when setting DPMS off. [ +7.435304] [drm] DM_MST: stopping TM on aconnector: 951db0f4 [id: 101] [ +0.535828] BUG: unabl

Re: [PATCH v5 1/6] drm/sched: Add internal job peek/pop API

2025-02-18 Thread Matthew Brost
On Tue, Feb 18, 2025 at 06:26:15PM +, Tvrtko Ursulin wrote: > > On 18/02/2025 12:26, Philipp Stanner wrote: > > Thx for the updated version. Overlooked it, I was out on Friday. See > > below > > > > On Fri, 2025-02-14 at 10:19 +, Tvrtko Ursulin wrote: > > > Idea is to add helpers for peek

Re: [PATCH v5 27/32] drm/xe: Add SVM VRAM migration

2025-02-18 Thread Matthew Brost
On Thu, Feb 13, 2025 at 11:58:27PM +0530, Ghimiray, Himal Prasad wrote: > > > On 13-02-2025 07:41, Matthew Brost wrote: > > Migration is implemented with range granularity, with VRAM backing being > > a VM private TTM BO (i.e., shares dma-resv with VM). The lifetime of the > > TTM BO is limited t

Re: [PATCH RFC 7/7] drm/display: dp-tunnel: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_tunnel.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_tunnel.c | 20 ++-- > 1 file changed, 10 insertion

Re: [PATCH RFC 3/7] drm/display: dp: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_helper.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_helper.c | 309 > > 1 file chang

Re: [PATCH RFC 6/7] drm/display: dp-mst-topology: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_mst_topology.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 > +- > 1 file

Re: [PATCH] drm/nouveau: select FW caching

2025-02-18 Thread Luis Chamberlain
On Tue, Feb 18, 2025 at 06:24:43PM +0100, Danilo Krummrich wrote: > On Tue, Feb 18, 2025 at 06:28:53AM -0800, Luis Chamberlain wrote: > > > > What I recommend is to look into why we disable it by default, I think > > I think FW_CACHE is enabled by default, no? > > > its sold old obscure reasonin

Re: [PATCH RFC 5/7] drm/display: dp-cec: use new DCPD access helpers

2025-02-18 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2025-01-17 at 10:56 +0200, Dmitry Baryshkov wrote: > Switch drm_dp_cec.c to use new set of DPCD read / write helpers. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dp_cec.c | 37 > ++-- > 1 file changed,

Re: [PATCH RFC 1/7] drm/display: dp: change drm_dp_dpcd_read_link_status() return

2025-02-18 Thread Lyude Paul
I've been wanting to do this for ages and just never got the time, thank you for getting to this ♥ So this patch looks good to me, but msm isn't the only user of drm_dp_dpcd_read_link_status() - so we would need to convert other drivers using coccinelle or similar as well for this to not break dri

Re: [PATCH RFC 2/7] drm/display: dp: implement new access helpers

2025-02-18 Thread Lyude Paul
On Thu, 2025-01-23 at 13:04 +0200, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 12:26:25PM +0200, Jani Nikula wrote: > > On Fri, 17 Jan 2025, Dmitry Baryshkov wrote: > > > Existing DPCD access functions return an error code or the number of > > > bytes being read / write in case of partial ac

Re: [PATCH RFC 1/3] rust: add useful ops for u64

2025-02-18 Thread Timur Tabi
On Tue, 2025-02-18 at 22:16 +0900, Alexandre Courbot wrote: > > A proper struct with `high` and `low` might be more verbose, but > > it rules out this issue. > > Mmm indeed, so we would have client code looking like: > >   let SplitU64 { high, low } = some_u64.into_u32(); > > instead of > >  

RE: [PATCH 3/4] FIXME: drm/xe/xe_drm_client: Add per drm client pagefault info

2025-02-18 Thread Cavitt, Jonathan
-Original Message- From: Tvrtko Ursulin Sent: Tuesday, February 18, 2025 10:39 AM To: Simona Vetter ; Cavitt, Jonathan Cc: intel...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Gupta, saurabhg ; Zuo, Alex ; Lahtinen, Joonas ; De Marchi, Lucas ; Brost, Matthew Subject: Re:

[PATCH v2 1/6] drm/xe/xe_exec_queue: Add ID param to exec queue struct

2025-02-18 Thread Jonathan Cavitt
Add the exec queue id to the exec queue struct. This is useful for performing a reverse lookup into the xef->exec_queue xarray. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_exec_queue.c | 1 + drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++ 2 files changed, 3 insertions(+) d

[PATCH AUTOSEL 6.12 31/31] drm/tests: hdmi: Fix recursive locking

2025-02-18 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 5d14c08a47460e8eedf0185a28b116420ea7f29d ] The find_preferred_mode() functions takes the mode_config mutex, but due to the order most tests have, is called with the crtc_ww_class_mutex taken. This raises a warning for a circular dependency when running the t

[PATCH AUTOSEL 6.12 30/31] drm/tests: hdmi: Reorder DRM entities variables assignment

2025-02-18 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 6b6bfd63e1626ceedc738b2a06505aa5b46c1481 ] The tests all deviate slightly in how they assign their local pointers to DRM entities. This makes refactoring pretty difficult, so let's just move the assignment as soon as the entities are allocated. Reviewed-by:

[PATCH AUTOSEL 6.12 29/31] drm/tests: hdmi: Remove redundant assignments

2025-02-18 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit bb4f929a8875b4801db95b8cf3b2c527c1e475e0 ] Some tests have the drm pointer assigned multiple times to the same value. Drop the redundant assignments. Reviewed-by: Simona Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20250129-test-kunit-v2-2-f

[PATCH AUTOSEL 6.13 31/31] drm/tests: hdmi: Fix recursive locking

2025-02-18 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 5d14c08a47460e8eedf0185a28b116420ea7f29d ] The find_preferred_mode() functions takes the mode_config mutex, but due to the order most tests have, is called with the crtc_ww_class_mutex taken. This raises a warning for a circular dependency when running the t

[PATCH AUTOSEL 6.13 29/31] drm/tests: hdmi: Remove redundant assignments

2025-02-18 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit bb4f929a8875b4801db95b8cf3b2c527c1e475e0 ] Some tests have the drm pointer assigned multiple times to the same value. Drop the redundant assignments. Reviewed-by: Simona Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20250129-test-kunit-v2-2-f

[PATCH AUTOSEL 6.13 30/31] drm/tests: hdmi: Reorder DRM entities variables assignment

2025-02-18 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 6b6bfd63e1626ceedc738b2a06505aa5b46c1481 ] The tests all deviate slightly in how they assign their local pointers to DRM entities. This makes refactoring pretty difficult, so let's just move the assignment as soon as the entities are allocated. Reviewed-by:

[PATCH v2 3/6] drm/xe/xe_drm_client: Add per drm client pagefault info

2025-02-18 Thread Jonathan Cavitt
Add additional information to drm client so it can report up to the last 50 exec queues to have been banned on it, as well as the last pagefault seen when said exec queues were banned. Since we cannot reasonably associate a pagefault to a specific exec queue, we currently report the last seen page

[PATCH v2 6/6] drm/xe/xe_query: Add support for per-drm-client reset stat querying

2025-02-18 Thread Jonathan Cavitt
Add support for userspace to query per drm client reset stats via the query ioctl. This includes the number of engine resets the drm client has observed, as well as a list of up to the last 50 relevant exec queue bans and their associated causal pagefaults (if they exists). Signed-off-by: Jonatha

[PATCH v2 5/6] drm/xe/xe_query: Pass drm file to query funcs

2025-02-18 Thread Jonathan Cavitt
Pass the drm file to the query funcs in xe_query.c. This will be necessary for a future query. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_query.c | 39 --- 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_query.c

[PATCH v2 0/6] drm/xe/xe_drm_client: Add per drm client reset stats

2025-02-18 Thread Jonathan Cavitt
Add additional information to drm client so it can report the last 50 exec queues to have been banned on it, as well as the last pagefault seen when said exec queues were banned. Since we cannot reasonably associate a pagefault to a specific exec queue, we currently report the last seen pagefault o

[PATCH v2 4/6] drm/xe/xe_drm_client: Add per drm client reset stats

2025-02-18 Thread Jonathan Cavitt
Add a counter to xe_drm_client that tracks the number of times the engine has been reset since the drm client was created. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_drm_client.h | 2 ++ drivers/gpu/drm/xe/xe_guc_submit.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) d

[PATCH v2 2/6] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header

2025-02-18 Thread Jonathan Cavitt
Migrate the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault.h header file, along with the associated enum values. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 27 --- drivers/gpu/drm/xe/xe_gt_pagefault.h | 28 +++

[PATCH 02/16] drm/vkms: Add and remove VKMS instances via configfs

2025-02-18 Thread José Expósito
Allow to create, enable, disable and destroy VKMS instances using configfs. For the moment, it is not possible to add pipeline items, so trying to enable the device will fail printing an informative error to the log. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: Jos

Re: [PATCH 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-18 Thread Aditya Garg
Hi In continuation to my previous mail. >> + >> +static int appletbdrm_send_msg(struct appletbdrm_device *adev, u32 msg) >> +{ >> + struct appletbdrm_msg_simple_request *request; >> + int ret; >> + >> + request = kzalloc(sizeof(*request), GFP_KERNEL); >> + if (!request) >> + return -ENOMEM; >> +

Re: [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-02-18 Thread Geert Uytterhoeven
Hi Thomas, On Tue, 18 Feb 2025 at 15:26, Thomas Zimmermann wrote: > Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer > scanline pitch and allocation size. Implementations of struct > drm_driver.dumb_create can call the new helper for their size > computations. > > There is current

[PATCH v4 3/8] drm/bridge: ti-sn65dsi86: use the auxiliary device

2025-02-18 Thread Jerome Brunet
The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Signed-off-by: Jerome Brunet --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 49 +-- 1 file changed, 7 insert

[PATCH v4 8/8] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2

2025-02-18 Thread Jerome Brunet
Remove the implementation of the reset driver in axg audio clock driver and migrate to the one provided by reset framework on the auxiliary bus. Signed-off-by: Jerome Brunet --- drivers/clk/meson/Kconfig | 2 +- drivers/clk/meson/axg-audio.c | 114 +-

[PATCH v4 7/8] clk: clk-imx8mp-audiomix: use the auxiliary device creation helper

2025-02-18 Thread Jerome Brunet
The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Signed-off-by: Jerome Brunet --- drivers/clk/imx/clk-imx8mp-audiomix.c | 49 ++- 1 file changed, 8 insert

[PATCH v4 6/8] reset: eyeq: drop device_set_of_node_from_dev() done by parent

2025-02-18 Thread Jerome Brunet
From: Théo Lebrun Our parent driver (clk-eyeq) now does the device_set_of_node_from_dev(dev, dev->parent) call through the newly introduced devm_auxiliary_device_create() helper. Doing it again in the reset-eyeq probe would be redundant. Drop both the WARN_ON() and the device_set_of_node

[PATCH v4 2/8] reset: mpfs: use the auxiliary device creation

2025-02-18 Thread Jerome Brunet
The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Acked-by: Conor Dooley Signed-off-by: Jerome Brunet --- drivers/reset/reset-mpfs.c | 56 +-

[PATCH v4 5/8] clk: eyeq: use the auxiliary device creation helper

2025-02-18 Thread Jerome Brunet
The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Tested-by: Théo Lebrun # On Mobileye EyeQ5 Signed-off-by: Jerome Brunet --- drivers/clk/clk-eyeq.c | 57 +++

[PATCH v4 4/8] platform: arm64: lenovo-yoga-c630: use the auxiliary device creation helper

2025-02-18 Thread Jerome Brunet
The auxiliary device creation of this driver is simple enough to use the available auxiliary device creation helper. Use it and remove some boilerplate code. Signed-off-by: Jerome Brunet --- drivers/platform/arm64/lenovo-yoga-c630.c | 40 +++ 1 file changed, 3 insert

[PATCH v4 1/8] driver core: auxiliary bus: add device creation helpers

2025-02-18 Thread Jerome Brunet
Add helper functions to create a device on the auxiliary bus. This is meant for fairly simple usage of the auxiliary bus, to avoid having the same code repeated in the different drivers. Suggested-by: Stephen Boyd Cc: Arnd Bergmann Signed-off-by: Jerome Brunet --- drivers/base/auxiliary.c

[PATCH v4 0/8] driver core: auxiliary bus: add device creation helper

2025-02-18 Thread Jerome Brunet
The suggestion for this change was initially discussed here: [1] This patchset adds and use a helper to create a simple auxiliary device. The goal is to remove boilerplate code that tends to get repeated for simple cases. Only the last change was tested on actual HW. The other usage of the helper

Re: [PATCH 0/4] drm/xe/xe_drm_client: Add per drm client reset stats

2025-02-18 Thread André Almeida
Hi Jonathan, Em 14/02/2025 17:37, Jonathan Cavitt escreveu: Add additional information to drm client so it can report the last 50 exec queues to have been banned on it, as well as the last pagefault seen when said exec queues were banned. Since we cannot reasonably associate a pagefault to a spe

Re: [PATCH 4/4] drm/xe/xe_drm_client: Add per drm client reset stats

2025-02-18 Thread Tvrtko Ursulin
On 14/02/2025 20:37, Jonathan Cavitt wrote: Add a counter to xe_drm_client that tracks the number of times the engine has been reset since the drm client was created. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/xe/xe_drm_client.c | 2 ++ drivers/gpu/drm/xe/xe_drm_client.h | 2 ++ d

Re: [PATCH v2] cgroup/dmem: Don't open-code css_for_each_descendant_pre

2025-02-18 Thread Tejun Heo
Hello, On Tue, Feb 18, 2025 at 03:55:43PM +0100, Maarten Lankhorst wrote: > Should this fix go through the cgroup tree? I haven't been routing any dmem patches. Might as well stick to drm tree? Thanks. -- tejun

Re: [PATCH 3/4] FIXME: drm/xe/xe_drm_client: Add per drm client pagefault info

2025-02-18 Thread Tvrtko Ursulin
On 17/02/2025 17:01, Simona Vetter wrote: On Fri, Feb 14, 2025 at 08:37:56PM +, Jonathan Cavitt wrote: Add additional information to drm client so it can report the last 50 exec queues to have been banned on it, as well as the last pagefault seen when said exec queues were banned. Since w

Re: [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621

2025-02-18 Thread Rob Clark
On Thu, Feb 13, 2025 at 8:10 AM Akhil P Oommen wrote: > > From: Jie Zhang > > Adreno 621 has a different memory map for GPUCC block. So update > a6xx_gpu_state code to dump the correct set of gpucc registers. > > Signed-off-by: Jie Zhang > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/

Re: [PATCH v5 1/6] drm/sched: Add internal job peek/pop API

2025-02-18 Thread Tvrtko Ursulin
On 18/02/2025 12:26, Philipp Stanner wrote: Thx for the updated version. Overlooked it, I was out on Friday. See below On Fri, 2025-02-14 at 10:19 +, Tvrtko Ursulin wrote: Idea is to add helpers for peeking and popping jobs from entities with the goal of decoupling the hidden assumption i

Re: [RFC PATCH] drm/sched: Fix preprocessor guard

2025-02-18 Thread Tvrtko Ursulin
On 18/02/2025 12:41, Philipp Stanner wrote: When writing the header guard for gpu_scheduler_trace.h, a typo, apparently, occurred. Fix the typo and document the scope of the guard. Fixes: 353da3c520b4 ("drm/amdgpu: add tracepoint for scheduler (v2)") Signed-off-by: Philipp Stanner --- I just

Re: [PATCH] drm/nouveau: select FW caching

2025-02-18 Thread Danilo Krummrich
On Tue, Feb 18, 2025 at 06:28:53AM -0800, Luis Chamberlain wrote: > > What I recommend is to look into why we disable it by default, I think I think FW_CACHE is enabled by default, no? > its sold old obscure reasoning but now suspect it was udev being dumb, > in line with why we also try to defe

[PATCH 05/16] drm/vkms: Allow to configure multiple CRTCs via configfs

2025-02-18 Thread José Expósito
Create a default subgroup at /config/vkms/crtcs to allow to create as many CRTCs as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 6 ++ drivers/gpu/drm/vkms/vkms_configfs.c | 98 +++

[PATCH 15/16] drm/vkms: Allow to configure the default device creation

2025-02-18 Thread José Expósito
Add a new module param to allow to create or not the default VKMS instance. Useful when combined with configfs to avoid having additional VKMS instances. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_drv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/vk

Re: [PATCH v1 1/2] dt-bindings: display: bridge: Document Solomon SSD2825

2025-02-18 Thread Conor Dooley
On Fri, Feb 14, 2025 at 08:29:22AM +0200, Svyatoslav Ryhel wrote: > чт, 13 лют. 2025 р. о 22:34 Conor Dooley пише: > > > > On Thu, Feb 13, 2025 at 03:56:04PM +0200, Svyatoslav Ryhel wrote: > > > Add bindings for Solomon SSD2825 MIPI master bridge chip that connects an > > > application processor w

[PATCH 06/16] drm/vkms: Allow to configure CRTC writeback support via configfs

2025-02-18 Thread José Expósito
When a CRTC is created, add a `writeback` file to allow to enable or disable writeback connector support Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 4 +++ drivers/gpu/drm/vkms/vkms_configfs.c | 47 +++

[PATCH 12/16] drm/vkms: Allow to configure connector status

2025-02-18 Thread José Expósito
Allow to store the connector status in vkms_config_connector and add a getter and a setter functions as well a KUnit test. This change only adds the configuration, the connector status is not used yet. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/tests/vkms_config_test.c | 24 +

[PATCH 08/16] drm/vkms: Allow to configure multiple encoders via configfs

2025-02-18 Thread José Expósito
Create a default subgroup at /config/vkms/encoders to allow to create as many encoders as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 6 ++ drivers/gpu/drm/vkms/vkms_configfs.c | 99 +

[PATCH 16/16] drm/vkms: Remove completed task from the TODO list

2025-02-18 Thread José Expósito
Remove the configfs related TODO items from the "Runtime Configuration" section. Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 3068879ce1fc..0a5

[PATCH 09/16] drm/vkms: Allow to attach encoders and CRTCs via configfs

2025-02-18 Thread José Expósito
Create a default subgroup at /config/vkms/encoders/encoder/possible_crtcs that will contain symbolic links to the possible CRTCs for the encoder. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 2 + drivers/gp

[PATCH 14/16] drm/vkms: Allow to configure connector status via configfs

2025-02-18 Thread José Expósito
When a connector is created, add a `status` file to allow to update the connector status to: - 1 connector_status_connected - 2 connector_status_disconnected - 3 connector_status_unknown If the device is enabled, updating the status hot-plug or unplugs the connector. Signed-off-by: José Expós

[PATCH 13/16] drm/vkms: Allow to update the connector status

2025-02-18 Thread José Expósito
Implement the drm_connector_funcs.detect() callback to update the connector status by returning the status stored in the configuration. Signed-off-by: José Expósito --- drivers/gpu/drm/vkms/vkms_connector.c | 19 ++- drivers/gpu/drm/vkms/vkms_connector.h | 12 +++- driver

[PATCH 10/16] drm/vkms: Allow to configure multiple connectors via configfs

2025-02-18 Thread José Expósito
Create a default subgroup at /config/vkms/connectors to allow to create as many connectors as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 6 ++ drivers/gpu/drm/vkms/vkms_configfs.c | 100 +++

[PATCH 04/16] drm/vkms: Allow to configure the plane type via configfs

2025-02-18 Thread José Expósito
When a plane is created, add a `type` file to allow to set the type: - 0 overlay - 1 primary - 2 cursor Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 4 +++ drivers/gpu/drm/vkms/vkms_configfs.c | 51

[PATCH 07/16] drm/vkms: Allow to attach planes and CRTCs via configfs

2025-02-18 Thread José Expósito
Create a default subgroup at /config/vkms/planes/plane/possible_crtcs that will contain symbolic links to the possible CRTCs for the plane. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 9 drivers/gpu/d

[PATCH 03/16] drm/vkms: Allow to configure multiple planes via configfs

2025-02-18 Thread José Expósito
Create a default subgroup at /config/vkms/planes to allow to create as many planes as required. Co-developed-by: Louis Chauvet Signed-off-by: Louis Chauvet Signed-off-by: José Expósito --- Documentation/gpu/vkms.rst | 16 - drivers/gpu/drm/vkms/vkms_configfs.c | 101

[PATCH 00/16] drm/vkms: Add configfs support

2025-02-18 Thread José Expósito
Hi everyone, This series, to be applied on top of [1], allow to configure one or more VKMS instances without having to reload the driver using configfs. The series is structured in 3 blocks: - Patches 1..11: Basic device configuration. For simplicity, I kept the available options as minima

Re: [PATCH v5 0/7] TEE subsystem for restricted dma-buf allocations

2025-02-18 Thread Daniel Stone
On Tue, 18 Feb 2025 at 14:35, Jens Wiklander wrote: > This can be tested on a RockPi 4B+ with the following steps: > repo init -u https://github.com/jenswi-linaro/manifest.git -m rockpi4.xml \ > -b prototype/sdp-v5 > repo sync -j8 > cd build > make toolchains -j$(nproc) > make all -j$(npro

Re: [PATCH v2] drm/msm/dpu: Fall back to a single DSC encoder (1:1:1) on small SoCs

2025-02-18 Thread Danila Tikhonov
On 1/22/25 19:23, Marijn Suijten wrote: Some SoCs such as SC7280 (used in the Fairphone 5) have only a single DSC "hard slice" encoder. The current hardcoded use of 2:2:1 topology (2 LM and 2 DSC for a single interface) make it impossible to use Display Stream Compression panels with mainline, w

[PATCH] drm: add modifiers for Apple twiddled layouts

2025-02-18 Thread Alyssa Rosenzweig
ows the + * body, after padding to 128-bytes. + * + * Images must be 16-byte aligned. + */ +#define DRM_FORMAT_MOD_APPLE_TWIDDLED_COMPRESSED fourcc_mod_code(APPLE, 2) + /* * AMD modifiers * --- base-commit: 0ed1356af8f629ae807963b7db4e501e3b580bc2 change-id: 20250218-apple-twiddled-modifiers-fde1a6f4300c Best regards, -- Alyssa Rosenzweig

  1   2   3   >