The auxiliary device creation of this driver is simple enough to
use the available auxiliary device creation helper.

Use it and remove some boilerplate code.

Signed-off-by: Jerome Brunet <jbru...@baylibre.com>
---
 drivers/platform/arm64/lenovo-yoga-c630.c | 40 +++----------------------------
 1 file changed, 3 insertions(+), 37 deletions(-)

diff --git a/drivers/platform/arm64/lenovo-yoga-c630.c 
b/drivers/platform/arm64/lenovo-yoga-c630.c
index 
1f05c9a6a89d5ee146144062f5d2e36795c56639..75060c842b249c1b4cab21fef943266ae0b31d32
 100644
--- a/drivers/platform/arm64/lenovo-yoga-c630.c
+++ b/drivers/platform/arm64/lenovo-yoga-c630.c
@@ -191,50 +191,16 @@ void yoga_c630_ec_unregister_notify(struct yoga_c630_ec 
*ec, struct notifier_blo
 }
 EXPORT_SYMBOL_GPL(yoga_c630_ec_unregister_notify);
 
-static void yoga_c630_aux_release(struct device *dev)
-{
-       struct auxiliary_device *adev = to_auxiliary_dev(dev);
-
-       kfree(adev);
-}
-
-static void yoga_c630_aux_remove(void *data)
-{
-       struct auxiliary_device *adev = data;
-
-       auxiliary_device_delete(adev);
-       auxiliary_device_uninit(adev);
-}
-
 static int yoga_c630_aux_init(struct device *parent, const char *name,
                              struct yoga_c630_ec *ec)
 {
        struct auxiliary_device *adev;
-       int ret;
 
-       adev = kzalloc(sizeof(*adev), GFP_KERNEL);
+       adev = devm_auxiliary_device_create(parent, name, ec);
        if (!adev)
-               return -ENOMEM;
-
-       adev->name = name;
-       adev->id = 0;
-       adev->dev.parent = parent;
-       adev->dev.release = yoga_c630_aux_release;
-       adev->dev.platform_data = ec;
-
-       ret = auxiliary_device_init(adev);
-       if (ret) {
-               kfree(adev);
-               return ret;
-       }
-
-       ret = auxiliary_device_add(adev);
-       if (ret) {
-               auxiliary_device_uninit(adev);
-               return ret;
-       }
+               return -ENODEV;
 
-       return devm_add_action_or_reset(parent, yoga_c630_aux_remove, adev);
+       return 0;
 }
 
 static int yoga_c630_ec_probe(struct i2c_client *client)

-- 
2.47.2

Reply via email to