From: Théo Lebrun <theo.leb...@bootlin.com>

Our parent driver (clk-eyeq) now does the
        device_set_of_node_from_dev(dev, dev->parent)
call through the newly introduced devm_auxiliary_device_create() helper.

Doing it again in the reset-eyeq probe would be redundant.
Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
Also fix the following comment that talks about "our newfound OF node".

Signed-off-by: Théo Lebrun <theo.leb...@bootlin.com>
Signed-off-by: Jerome Brunet <jbru...@baylibre.com>
---
 drivers/reset/reset-eyeq.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/reset/reset-eyeq.c b/drivers/reset/reset-eyeq.c
index 
02d50041048b42921e3e511148cd29f215b5fc5e..8018fa895427bb1e51ea23b99803dc7fe6108421
 100644
--- a/drivers/reset/reset-eyeq.c
+++ b/drivers/reset/reset-eyeq.c
@@ -420,17 +420,8 @@ static int eqr_probe(struct auxiliary_device *adev,
        int ret;
 
        /*
-        * We are an auxiliary device of clk-eyeq. We do not have an OF node by
-        * default; let's reuse our parent's OF node.
-        */
-       WARN_ON(dev->of_node);
-       device_set_of_node_from_dev(dev, dev->parent);
-       if (!dev->of_node)
-               return -ENODEV;
-
-       /*
-        * Using our newfound OF node, we can get match data. We cannot use
-        * device_get_match_data() because it does not match reused OF nodes.
+        * Get match data. We cannot use device_get_match_data() because it does
+        * not accept reused OF nodes; see device_set_of_node_from_dev().
         */
        match = of_match_node(dev->driver->of_match_table, dev->of_node);
        if (!match || !match->data)

-- 
2.47.2

Reply via email to