The auxiliary device creation of this driver is simple enough to
use the available auxiliary device creation helper.

Use it and remove some boilerplate code.

Signed-off-by: Jerome Brunet <jbru...@baylibre.com>
---
 drivers/clk/imx/clk-imx8mp-audiomix.c | 49 ++++++-----------------------------
 1 file changed, 8 insertions(+), 41 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c 
b/drivers/clk/imx/clk-imx8mp-audiomix.c
index 
c409fc7e061869988f83c7df3ef7860500426323..fa15a5ed59e304687317b5a23c845a0588890bee
 100644
--- a/drivers/clk/imx/clk-imx8mp-audiomix.c
+++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
@@ -230,61 +230,28 @@ struct clk_imx8mp_audiomix_priv {
 
 #if IS_ENABLED(CONFIG_RESET_CONTROLLER)
 
-static void clk_imx8mp_audiomix_reset_unregister_adev(void *_adev)
+static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev)
 {
-       struct auxiliary_device *adev = _adev;
-
-       auxiliary_device_delete(adev);
-       auxiliary_device_uninit(adev);
-}
-
-static void clk_imx8mp_audiomix_reset_adev_release(struct device *dev)
-{
-       struct auxiliary_device *adev = to_auxiliary_dev(dev);
-
-       kfree(adev);
-}
-
-static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
-                                                        struct 
clk_imx8mp_audiomix_priv *priv)
-{
-       struct auxiliary_device *adev __free(kfree) = NULL;
-       int ret;
+       struct auxiliary_device *adev;
 
        if (!of_property_present(dev->of_node, "#reset-cells"))
                return 0;
 
-       adev = kzalloc(sizeof(*adev), GFP_KERNEL);
+       adev = devm_auxiliary_device_create(dev, "reset", NULL);
        if (!adev)
-               return -ENOMEM;
-
-       adev->name = "reset";
-       adev->dev.parent = dev;
-       adev->dev.release = clk_imx8mp_audiomix_reset_adev_release;
-
-       ret = auxiliary_device_init(adev);
-       if (ret)
-               return ret;
+               return -ENODEV;
 
-       ret = auxiliary_device_add(adev);
-       if (ret) {
-               auxiliary_device_uninit(adev);
-               return ret;
-       }
-
-       return devm_add_action_or_reset(dev, 
clk_imx8mp_audiomix_reset_unregister_adev,
-                                       no_free_ptr(adev));
+       return 0;
 }
 
 #else /* !CONFIG_RESET_CONTROLLER */
 
-static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
-                                                        struct 
clk_imx8mp_audiomix_priv *priv)
+static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev)
 {
        return 0;
 }
 
-#endif /* !CONFIG_RESET_CONTROLLER */
+#endif
 
 static void clk_imx8mp_audiomix_save_restore(struct device *dev, bool save)
 {
@@ -408,7 +375,7 @@ static int clk_imx8mp_audiomix_probe(struct platform_device 
*pdev)
        if (ret)
                goto err_clk_register;
 
-       ret = clk_imx8mp_audiomix_reset_controller_register(dev, priv);
+       ret = clk_imx8mp_audiomix_reset_controller_register(dev);
        if (ret)
                goto err_clk_register;
 

-- 
2.47.2

Reply via email to