A page fault occurs when running the IGT test:
amdgpu@amd_vrr_range@freesync-parsing-suspend with MST. Fix that by
skipping handling a stream state when stream is NULL when setting DPMS
off.
[ +7.435304] [drm] DM_MST: stopping TM on aconnector: 00000000951db0f4 [id:
101]
[ +0.535828] BUG: unable to handle page fault for address: 0000000000006458
[ +0.000017] #PF: supervisor read access in kernel mode
[ +0.000007] #PF: error_code(0x0000) - not-present page
[ +0.000007] PGD 0 P4D 0
[ +0.000011] Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI
[ +0.000011] CPU: 6 UID: 0 PID: 365 Comm: kworker/6:1H Not tainted
6.12.12-amd64 #1 Debian 6.12.12-1
[ +0.000010] Hardware name: HP HP ENVY x360 Convertible 13-ay1xxx/8929, BIOS
F.01 07/14/2021
[ +0.000006] Workqueue: events_highpri dm_irq_work_func [amdgpu]
[ +0.000379] RIP: 0010:dc_stream_get_status+0x9/0x30 [amdgpu]
[ +0.000258] Code: 00 00 01 00 00 00 48 89 d8 5b e9 2d 5a ac ca 66 90 90 90 90
90 90 90 90 90 90 90 90 90 90 90 90 90 66 0f 1f 00 0f 1f 44 00 00 <48> 8b 87 58
64 00 00 48 89 fe 48 8b 00 48 8b b8 78 05 00 00 e9 0e
[ +0.000003] RSP: 0018:ffffbb7f40853a68 EFLAGS: 00010246
[ +0.000005] RAX: 0000000000000000 RBX: ffff91c08e9c0000 RCX: 0000000000000000
[ +0.000002] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ +0.000003] RBP: 0000000000000000 R08: ffffbb7f40853c28 R09: ffff91c08e9c0000
[ +0.000002] R10: 0000000000000004 R11: 0000000000000000 R12: 0000000000000000
[ +0.000003] R13: 0000000000000000 R14: ffff91c05cc00000 R15: ffffbb7f40853c28
[ +0.000003] FS: 0000000000000000(0000) GS:ffff91c33e500000(0000)
knlGS:0000000000000000
[ +0.000003] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ +0.000002] CR2: 0000000000006458 CR3: 000000012e622000 CR4: 0000000000f50ef0
[ +0.000003] PKRU: 55555554
[ +0.000003] Call Trace:
[ +0.000005] <TASK>
[ +0.000006] ? __die_body.cold+0x19/0x27
[ +0.000007] ? page_fault_oops+0x15a/0x2d0
[ +0.000009] ? exc_page_fault+0x7e/0x180
[ +0.000006] ? asm_exc_page_fault+0x26/0x30
[ +0.000010] ? dc_stream_get_status+0x9/0x30 [amdgpu]
[ +0.000243] ? srso_alias_return_thunk+0x5/0xfbef5
[ +0.000004] update_planes_and_stream_v1+0x9f/0x4c0 [amdgpu]
[ +0.000254] dc_commit_updates_for_stream+0x7a/0x100 [amdgpu]
[ +0.000242] ? link_get_master_pipes_with_dpms_on+0x38/0x80 [amdgpu]
[ +0.000297] link_set_all_streams_dpms_off_for_link+0xc5/0x110 [amdgpu]
[ +0.000304] link_detect+0x3f9/0x4e0 [amdgpu]
[ +0.000296] handle_hpd_rx_irq+0x1c0/0x2e0 [amdgpu]
[ +0.000292] process_one_work+0x177/0x330
[ +0.000007] worker_thread+0x252/0x390
[ +0.000005] ? __pfx_worker_thread+0x10/0x10
[ +0.000004] kthread+0xd2/0x100
[ +0.000004] ? __pfx_kthread+0x10/0x10
[ +0.000004] ret_from_fork+0x34/0x50
[ +0.000006] ? __pfx_kthread+0x10/0x10
[ +0.000003] ret_from_fork_asm+0x1a/0x30
[ +0.000009] </TASK>
Signed-off-by: Melissa Wen <m...@igalia.com>
---
Hi,
I found this issue by accident when testing some changes to improve
`drm_edid` usage in the driver. It's not related to any `drm_edid` code
because it happens in kernel 6.12.12 that doesn't have any `drm_edid`
code, and current asdn. I'm running the
amdgpu@amd_vrr_range@freesync-parsing-suspend in a Cezanne laptop with a
dock station where HDMI and DP cables are plugged and active. I'm not
sure if it's expected that stream is NULL at this point or something is
missing in the MST code. The page fault doesn't happen when MST isn't
enabled.
Any thoughts?
Melissa
drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
index ec7de9c01fab..98644e86275c 100644
--- a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c
@@ -161,6 +161,9 @@ void link_set_all_streams_dpms_off_for_link(struct dc_link
*link)
link_get_master_pipes_with_dpms_on(link, state, &count, pipes);
for (i = 0; i < count; i++) {
+ if (!pipes[i]->stream)
+ continue;
+
stream_update.stream = pipes[i]->stream;
dc_commit_updates_for_stream(link->ctx->dc, NULL, 0,
pipes[i]->stream, &stream_update,
--
2.47.2
