Hello Ben,
sorry I was away for some time and could not follow up -
Testing the 2.5 branch I'm still getting one fail:
## - ##
## Test results. ##
## - ##
ERROR: 1735 tests were run,
1 failed unexpectedly.
1 test was skipped.
## -- ##
## testsuit
On 05/27/2016 02:18 AM, Ben Pfaff wrote:
On Tue, May 24, 2016 at 12:24:31PM +0200, Gerhard Stenzel wrote:
On 05/02/2016 10:36 PM, Ben Pfaff wrote:
What if we just make ofp_port_t 32 bits? That has to be the long-term
trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
followin
On Tue, May 24, 2016 at 12:24:31PM +0200, Gerhard Stenzel wrote:
> On 05/02/2016 10:36 PM, Ben Pfaff wrote:
> >What if we just make ofp_port_t 32 bits? That has to be the long-term
> >trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
> >following passes all the unit tests on i386
On 05/02/2016 10:36 PM, Ben Pfaff wrote:
What if we just make ofp_port_t 32 bits? That has to be the long-term
trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
following passes all the unit tests on i386 (though I haven't carefully
looked at all the uses of ofp_port_t), what ab
On Thu, May 12, 2016 at 04:53:39PM +0200, Gerhard Stenzel wrote:
> On 05/04/2016 04:54 PM, Ben Pfaff wrote:
> ...
>
> >
> >Thanks, I received it. I don't think it's necessary to copy the list;
> >probably I'm the only one who will look at it.
> >
> >It will probably be a day or two before I can l
On 05/04/2016 04:54 PM, Ben Pfaff wrote:
...
Thanks, I received it. I don't think it's necessary to copy the list;
probably I'm the only one who will look at it.
It will probably be a day or two before I can look at this properly.
Hi Ben, did you have a chance to look at it? Let me know if
On Wed, May 04, 2016 at 02:44:38PM +0200, Gerhard Stenzel wrote:
>
>
> On 05/03/2016 05:25 PM, Ben Pfaff wrote:
> >On Tue, May 03, 2016 at 01:53:42PM +0200, Gerhard Stenzel wrote:
> ...
> >>[openvswitch 2.5.90] testsuite: 744 745 818 949 980 1026 1087 failed
> >
> >Would you mind passing along th
On 05/03/2016 05:25 PM, Ben Pfaff wrote:
On Tue, May 03, 2016 at 01:53:42PM +0200, Gerhard Stenzel wrote:
...
[openvswitch 2.5.90] testsuite: 744 745 818 949 980 1026 1087 failed
Would you mind passing along the full testsuite.log?
Sent via private mail. Do you want me to add it here as w
On Tue, May 03, 2016 at 01:53:42PM +0200, Gerhard Stenzel wrote:
>
> On 05/02/2016 10:36 PM, Ben Pfaff wrote:
> >What if we just make ofp_port_t 32 bits? That has to be the long-term
> >trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
> >following passes all the unit tests on i3
On 05/02/2016 10:36 PM, Ben Pfaff wrote:
What if we just make ofp_port_t 32 bits? That has to be the long-term
trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
following passes all the unit tests on i386 (though I haven't carefully
looked at all the uses of ofp_port_t), what a
Ben,
I modified this to apply to the 2.5 LTS tree head, and I get:
## - ##
## Test results. ##
## - ##
ERROR: 1733 tests were run,
6 failed unexpectedly.
1 test was skipped.
## -- ##
## testsuite.log was created. ##
## -- #
What if we just make ofp_port_t 32 bits? That has to be the long-term
trend anyway because OpenFlow 1.1+ uses a 32-bit port number. The
following passes all the unit tests on i386 (though I haven't carefully
looked at all the uses of ofp_port_t), what about big-endian systems?
diff --git a/inclu
Applying this to the master branch improves the situation quite a bit.
From 39 down to 7:
ERROR: 1753 tests were run,
7 failed unexpectedly.
286 tests were skipped.
## -- ##
## testsuite.log was created. ##
## -- ##
Please send `tests/testsuite.lo
I suppose the most elegant fix is to turn
union flow_in_port {
odp_port_t odp_port;
ofp_port_t ofp_port;
};
in lib/packet.h into:
union flow_in_port {
odp_port_t odp_port;
#ifdef WORDS_BIGENDIAN
struct __attribute__((__packed__)) {
ofp_port_t padding;
ofp_port_t
Hello,
I took the odd hour to look into this, and in big-endian this is broken:
lib/packet.h:
union flow_in_port {
odp_port_t odp_port;
ofp_port_t ofp_port;
};
I would propose to change this to something like:
#ifdef WORDS_BIGENDIAN
#define LVALUE 1
#else
#define LVALUE 0
#endi
Hi,
on System Z, this looks similar with current master branch:
ERROR: 1754 tests were run,
39 failed unexpectedly.
286 tests were skipped.
## -- ##
## testsuite.log was created. ##
## -- ##
Please send `tests/testsuite.log' and all information yo
16 matches
Mail list logo
